Re: Review Request 52137: GEODE-1925 : Copy the resources directory inside build directory

2016-09-22 Thread Jason Huynh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52137/#review150075
---


Ship it!




Ship It!

- Jason Huynh


On Sept. 21, 2016, 9:56 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52137/
> ---
> 
> (Updated Sept. 21, 2016, 9:56 p.m.)
> 
> 
> Review request for geode, Jason Huynh and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * Tests use the resources folder for its execution, hence it needs to be in 
> the build directory.
> * This was initially handled by gradle, but caused issues when test catagory 
> tags were changed.
> * This action is now handled by the test code.
> 
> 
> Diffs
> -
> 
>   extensions/geode-modules-tomcat7/build.gradle 3c75e56 
>   
> extensions/geode-modules-tomcat7/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession7.java
>  c9be3fe 
>   extensions/geode-modules-tomcat8/build.gradle dfa86cf 
>   extensions/geode-modules/build.gradle 81a926c 
>   
> extensions/geode-modules/src/test/java/org/apache/geode/modules/session/EmbeddedTomcat.java
>  1d97149 
>   
> extensions/geode-modules/src/test/java/org/apache/geode/modules/session/TestSessionsBase.java
>  a680d9e 
> 
> Diff: https://reviews.apache.org/r/52137/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> nabarun nag
> 
>



Review Request 52137: GEODE-1925 : Copy the resources directory inside build directory

2016-09-21 Thread nabarun nag

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52137/
---

Review request for geode, Jason Huynh and Dan Smith.


Repository: geode


Description
---

* Tests use the resources folder for its execution, hence it needs to be in the 
build directory.
* This was initially handled by gradle, but caused issues when test catagory 
tags were changed.
* This action is now handled by the test code.


Diffs
-

  extensions/geode-modules-tomcat7/build.gradle 3c75e56 
  
extensions/geode-modules-tomcat7/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession7.java
 c9be3fe 
  extensions/geode-modules-tomcat8/build.gradle dfa86cf 
  extensions/geode-modules/build.gradle 81a926c 
  
extensions/geode-modules/src/test/java/org/apache/geode/modules/session/EmbeddedTomcat.java
 1d97149 
  
extensions/geode-modules/src/test/java/org/apache/geode/modules/session/TestSessionsBase.java
 a680d9e 

Diff: https://reviews.apache.org/r/52137/diff/


Testing
---


Thanks,

nabarun nag