Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
On Jul 6, 2006, at 12:36 PM, Jacek Laskowski wrote: On 7/6/06, Jason Dillon <[EMAIL PROTECTED]> wrote: The exact command used to make the v5 patch was (from trunk): svn diff > GERONIMO-2161.patch And, as I thought I explained to you before, the same changes are applied to this branch: https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/ m2migration/ You can just use the branch to test the changes, or merge those changes into your branch, which should have the same results at the cost of additional merging. You've been working on the patch in your local copy of Geronimo trunk. You did svn co ...trunk. Correct? When you finished your work, you executed 'svn diff' to cut the patch. Correct? The patch turned out to be 'broken' or 'incompatible' for unix patch command and thus noone could test it out extensively, but look at it and verify reading. Correct? Mostly correct. You could apply the patch and examine the failed chunks and notice the trivial changes and how they would not alter the change and test w/a high degree of certainty that the changes in the patch were and are valid. But... due to the problem with svn diff+patch it made it much harder for folks to review and produce positive votes, due to the added overhead of the work and understanding of the failed patch chunks. 1/ You're working alone with no help from anyone. No, I don't mind your working alone and show changes when they're ready. The point is that I don't foster an interest of others to be involved and possibly contribute/help you. Again mostly correct. I had been working with David, Prasad and others as they applied the patch and then took feedback, fixed issues and then re-crafted patches. So, I was not working alone in that sense. But others could not directly help me work by submitting code to the codebase as would have been the case if we were all working and committing to SVN. For me this was a stretch, because I generally like to commit as often as possible when new features or fixes are introduced that are compatible with the build. I like to use source control to help me manage what changes I am making. 2/ As we have already found out, unix patch is not reliable and thus is not an option in a long turn. We need to figure out a way to work in a collaborative manner without the overhead of unix patch that makes the process of applying changes more complicated than it really needs to be. If your changes are between some revisions (e.g. initial branch creation revision and HEAD) anyone can use the branch and apply the change with svn merge command to his/her local Geronimo sources copy and test it out. Once an issue is found, the one who spot it could fix it in your branch and again call a vote. We MUST understand and resolve why svn diff + patch is broken, or why it could break. We MUST figure this out... regardless of whether the ongoing RTC work is done on a branch. But, we also need to find a way to allow more collaborative work to be done while following the RTC rules for commits to trunk. I believe that using branches works for this... in theory... BUT since merging in SVN is not as automated as it could be (or should be), that we must be-careful not introduce more overhead from merging and conflict resolution, which if not done carefully could be more harmful than good. This is why I was looking into SVK, since it provides another level on top of SVN with a more intelligent merging algorithm and integrated conflict resolution in a very Perforce-style (which IMO is highly effective). There're some other benefits, but these should be enough for now (unless you're not convinced and I'll have to write them down ;-)) Don't get me wrong... I think that using branches is a good idea. I just wish that SVN was better at facilitating the merge back. And since it is not, we must be very careful not to over-branch in set ourselves up for insane merges. * * * I still do believe that for the m2 build system implementation, that a branch is not needed, the work could (and should) be done on the trunk. Once finished, we can call a RTC vote on if the m2 build should be the default and at that time begin the work to remove the trails left over to support the m1 build. There is still a bunch of work left, and some of it will involve moving modules around into more sensible hierarchies. We are going to want to make these changes on the trunk... the added overhead of managing a merge from branches post-reorg w/SVN is going to be way, way to high. But, just to note... before any such work is done the general ideas will be presented for the community to vote upon. This is what I had intended the initial GERONIMO-2161 RTC to be used for. To vote on the concept and then implement on trunk. but, due to the slowness of the RTC process the work progressed faster than people could react to the RTC and
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
On 7/6/06, Jason Dillon <[EMAIL PROTECTED]> wrote: The exact command used to make the v5 patch was (from trunk): svn diff > GERONIMO-2161.patch And, as I thought I explained to you before, the same changes are applied to this branch: https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/ m2migration/ You can just use the branch to test the changes, or merge those changes into your branch, which should have the same results at the cost of additional merging. Understood. Would you consider a small improvement in the process (let me call it this way before we'll find a better name for it ;-))? You've been working on the patch in your local copy of Geronimo trunk. You did svn co ...trunk. Correct? When you finished your work, you executed 'svn diff' to cut the patch. Correct? The patch turned out to be 'broken' or 'incompatible' for unix patch command and thus noone could test it out extensively, but look at it and verify reading. Correct? I can see a few issues with that approach: 1/ You're working alone with no help from anyone. No, I don't mind your working alone and show changes when they're ready. The point is that I don't foster an interest of others to be involved and possibly contribute/help you. 2/ As we have already found out, unix patch is not reliable and thus is not an option in a long turn. We need to figure out a way to work in a collaborative manner without the overhead of unix patch that makes the process of applying changes more complicated than it really needs to be. If your changes are between some revisions (e.g. initial branch creation revision and HEAD) anyone can use the branch and apply the change with svn merge command to his/her local Geronimo sources copy and test it out. Once an issue is found, the one who spot it could fix it in your branch and again call a vote. There're some other benefits, but these should be enough for now (unless you're not convinced and I'll have to write them down ;-)) WDYT? --jason Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
The exact command used to make the v5 patch was (from trunk): svn diff > GERONIMO-2161.patch And, as I thought I explained to you before, the same changes are applied to this branch: https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/ m2migration/ You can just use the branch to test the changes, or merge those changes into your branch, which should have the same results at the cost of additional merging. --jason On Jul 6, 2006, at 4:09 AM, Jacek Laskowski wrote: On 7/6/06, Jason Dillon <[EMAIL PROTECTED]> wrote: I'm sorry... but I do not understand what you are asking Jacek. Could you please rephrase your question/request? How did you cut the latest patch v5? What commands did you use? I guess it was something like 'svn diff ... > GERONIMO-2161-v5.patch', wasn't it? If so and the changes are part of a branch (e.g. svkmerge/m2migration), we (testers) could apply it to our local Geronimo srcs using 'svn merge' nor 'patch' that we've just found is incompatible. This way we will use svn commands only and be able to apply and test it. --jason Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
On 7/6/06, Jason Dillon <[EMAIL PROTECTED]> wrote: I'm sorry... but I do not understand what you are asking Jacek. Could you please rephrase your question/request? How did you cut the latest patch v5? What commands did you use? I guess it was something like 'svn diff ... > GERONIMO-2161-v5.patch', wasn't it? If so and the changes are part of a branch (e.g. svkmerge/m2migration), we (testers) could apply it to our local Geronimo srcs using 'svn merge' nor 'patch' that we've just found is incompatible. This way we will use svn commands only and be able to apply and test it. --jason Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
I'm sorry... but I do not understand what you are asking Jacek.
Could you please rephrase your question/request?
Thanks,
--jason
On Jul 6, 2006, at 12:22 AM, Jacek Laskowski (JIRA) wrote:
[ http://issues.apache.org/jira/browse/GERONIMO-2161?
page=comments#action_12419429 ]
Jacek Laskowski commented on GERONIMO-2161:
---
After some thinking...may I find out how the patch was cut? I mean
what revisions it holds of svkmerge/m2migration? I'd like to apply
the patch to my local copy of a fresh Geronimo srcs check-out with
svn merge and give it a shot rather than relying on the
incompatible patch.
[RTC] Remove Geronimo modules from dependencyManagement in root
pom.xml
-
--
Key: GERONIMO-2161
URL: http://issues.apache.org/jira/browse/GERONIMO-2161
Project: Geronimo
Type: Task
Security: public(Regular issues)
Components: buildsystem
Reporter: Jason Dillon
Assignee: Jason Dillon
Fix For: 1.2
Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-
v1.patch, GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch,
GERONIMO-2161-v4.patch, GERONIMO-2161-v5.patch
As I have mentioned before, I believe we should remove the
Geronimo modules that are currently listed in the root pom.xml:
This reduces the configuration of the pom by *~500 lines*.
Modules that reference these as dependencies will need their pom's
adjusted to include ${pom.version} and
car for the configs. But in many places version
already exists with the ${geronimoVersion} property... which kinda
negates the purpose of the dependencyManagement section anyways.
I believe that it is more work to keep track of every module in
the root pom than it is to specify the additonal elements (mostly
just ${pom.version}) in child poms. There is
no additional maintenance, as the new elements never need to be
changed.
Net effect if this change is less configuration to maintain and
thus a less brittle build that can adapt to change easier.
Specifically these should be removed:
{code:xml}
org.apache.geronimo.modules
ge-activemq-rar
${geronimoVersion}
rar
org.apache.geronimo.modules
geronimo-activation
${geronimoVersion}
org.apache.geronimo.modules
geronimo-client
${geronimoVersion}
org.apache.geronimo.modules
geronimo-client-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-common
${geronimoVersion}
org.apache.geronimo.modules
geronimo-connector
${geronimoVersion}
org.apache.geronimo.modules
geronimo-connector-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-converter
${geronimoVersion}
org.apache.geronimo.modules
geronimo-core
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-config
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-jsr88
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-tool
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deployment
${geronimoVersion}
org.apache.geronimo.modules
geronimo-derby
${geronimoVersion}
org.apache.geronimo.modules
geronimo-directory
${geronimoVersion}
org.apache.geronimo.modules
geronimo-javamail-transport
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee-schema
${geronimoVersion}
org.apache.geronimo.modules
geronimo-kernel
${geronimoVersion}
org.apache.geronimo.modules
geronimo-jetty
${geronimoVersion}
org.apache.geronimo.modules
geronimo-jetty-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-jmx-remoting
${geronimoVersion}
org.apache.geronimo.modules
geronimo-mail
${geronimoVersion}
org.apache.geronimo.modules
geronimo-management
${geronimoVersion}
org.apache.geronimo.modules
geronimo-naming
${geronimoVersion}
org.apache.geronimo.modules
geronimo-naming-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-security
${geronimoVersion}
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419429
]
Jacek Laskowski commented on GERONIMO-2161:
---
After some thinking...may I find out how the patch was cut? I mean what
revisions it holds of svkmerge/m2migration? I'd like to apply the patch to my
local copy of a fresh Geronimo srcs check-out with svn merge and give it a shot
rather than relying on the incompatible patch.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch, GERONIMO-2161-v4.patch,
> GERONIMO-2161-v5.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419427
]
Jacek Laskowski commented on GERONIMO-2161:
---
What will happen after I've tested it out? How will we proceed? How do you want
the changes to be applied to trunk? svn merge?
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch, GERONIMO-2161-v4.patch,
> GERONIMO-2161-v5.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419375
]
Jason Dillon commented on GERONIMO-2161:
To test, you can use this branch, which has the same changes:
https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/m2migration/
This branch has v5 applied, as well as the chunks that fail to patch applied.
{noformat}
svn co https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/m2migration
m2migration
cd m2migration
./bootstrap
{noformat}
This will:
* clean everything (including the m2 repo cache)
* build the first stage
* checkout openejb2 and tranql and build them
* build the second (final) stage.
It will take some time... but should produce the same successful build
every-time.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch, GERONIMO-2161-v4.patch,
> GERONIMO-2161-v5.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
Please mail the output of `patch -sp0 < GERONIMO-2161-v4.patch`.
Yes, my workspace is clean. As I have noted before in previous
emails... svn diff is producing output that can not be reapplied with
patch. David J has seen this happen too IIRC.
--jason
On Jul 5, 2006, at 2:52 PM, Jacek Laskowski (JIRA) wrote:
[ http://issues.apache.org/jira/browse/GERONIMO-2161?
page=comments#action_12419339 ]
Jacek Laskowski commented on GERONIMO-2161:
---
Jason, I can't apply the v4 patch. It ends with errors. Have you
checked out clean Geronimo sources and apply it? Did it finish
properly? I'm concerned as others have reported it worked fine.
[RTC] Remove Geronimo modules from dependencyManagement in root
pom.xml
-
--
Key: GERONIMO-2161
URL: http://issues.apache.org/jira/browse/GERONIMO-2161
Project: Geronimo
Type: Task
Security: public(Regular issues)
Components: buildsystem
Reporter: Jason Dillon
Assignee: Jason Dillon
Fix For: 1.2
Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-
v1.patch, GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch,
GERONIMO-2161-v4.patch
As I have mentioned before, I believe we should remove the
Geronimo modules that are currently listed in the root pom.xml:
This reduces the configuration of the pom by *~500 lines*.
Modules that reference these as dependencies will need their pom's
adjusted to include ${pom.version} and
car for the configs. But in many places version
already exists with the ${geronimoVersion} property... which kinda
negates the purpose of the dependencyManagement section anyways.
I believe that it is more work to keep track of every module in
the root pom than it is to specify the additonal elements (mostly
just ${pom.version}) in child poms. There is
no additional maintenance, as the new elements never need to be
changed.
Net effect if this change is less configuration to maintain and
thus a less brittle build that can adapt to change easier.
Specifically these should be removed:
{code:xml}
org.apache.geronimo.modules
ge-activemq-rar
${geronimoVersion}
rar
org.apache.geronimo.modules
geronimo-activation
${geronimoVersion}
org.apache.geronimo.modules
geronimo-client
${geronimoVersion}
org.apache.geronimo.modules
geronimo-client-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-common
${geronimoVersion}
org.apache.geronimo.modules
geronimo-connector
${geronimoVersion}
org.apache.geronimo.modules
geronimo-connector-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-converter
${geronimoVersion}
org.apache.geronimo.modules
geronimo-core
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-config
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-jsr88
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-tool
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deployment
${geronimoVersion}
org.apache.geronimo.modules
geronimo-derby
${geronimoVersion}
org.apache.geronimo.modules
geronimo-directory
${geronimoVersion}
org.apache.geronimo.modules
geronimo-javamail-transport
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee-schema
${geronimoVersion}
org.apache.geronimo.modules
geronimo-kernel
${geronimoVersion}
org.apache.geronimo.modules
geronimo-jetty
${geronimoVersion}
org.apache.geronimo.modules
geronimo-jetty-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-jmx-remoting
${geronimoVersion}
org.apache.geronimo.modules
geronimo-mail
${geronimoVersion}
org.apache.geronimo.modules
geronimo-management
${geronimoVersion}
org.apache.geronimo.modules
geronimo-naming
${geronimoVersion}
org.apache.geronimo.modules
geronimo-naming-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-security
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419339
]
Jacek Laskowski commented on GERONIMO-2161:
---
Jason, I can't apply the v4 patch. It ends with errors. Have you checked out
clean Geronimo sources and apply it? Did it finish properly? I'm concerned as
others have reported it worked fine.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch, GERONIMO-2161-v4.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419287
]
Gianny Damour commented on GERONIMO-2161:
-
I've reviewed this patch and it is fine by me +1.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch, GERONIMO-2161-v4.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security-builder
> ${geronimoVersion}
>
>
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419266
]
Prasad Kashyap commented on GERONIMO-2161:
--
Jason, can we please make this a subtask of G-2071 ? Keeping all m2 related
work under 1 uber-JIRA will help us find them faster.
Thanx
Prasad
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch, GERONIMO-2161-v4.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419034
]
David Jencks commented on GERONIMO-2161:
I've applied the v4 patch and aside from the combination of svn diff and patch
not being compatible the result of applying the patch works and looks good to
me. If I had a vote I'd vote +1
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch, GERONIMO-2161-v4.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419022
]
Jason Dillon commented on GERONIMO-2161:
Looks like the latest 2.0.1-SNAPSHOT of the xmlbeans plugin removes the need
for the insaino 13 time build. I'm validating now. There are still issues of
removal of extraneous stax depends in our build, but we have a bunch of
dependency pruning to do and that can wait. Simply using 2.0.1-SNAPSHOT for
the plugin (which is deployed at snapshots.repository.codehaus.org) appears to
work much much better.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12419012
]
Jason Dillon commented on GERONIMO-2161:
13 times is *definitely* not due to this patch or any work I have done. Its is
a ugly hack work-around to a broken xmlbeans plugin. This crappy rebuild muck
will go away soon... but I am weary about making more changes with out first
getting this lot committed.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418994
]
Alan Cabrera commented on GERONIMO-2161:
+1 w/ comments
I find it odd that we have to build geronimo 13 times but, this is an artifact
of our circular depdendencies rather than a difficiency of this patch.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch, GERONIMO-2161-v3.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418922
]
Jason Dillon commented on GERONIMO-2161:
*NOTE:* The changes to the packaging plugin are mostly formatting related
(cleaned up tabs) etc. I did change some of the output to using logging too
instead of System.out.
I'm still really concerned than svn diff + patch is not working. I tried
several times and also tried a simple check to see if my workspace was corrupt
by checking out the packaging dir again and then copying over the changed
files. Still patch shows failures.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
>
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
Hrm... so I tried something else... I just svn up'd to get my working copy to revision 418706. Then svn status to make sure there are no conflicts... I've only got M and A indicators. Then `svn diff > test.patch` from trunk, and then in a clean checkout `patch -p0 --dry-run < ../../trunk/test.patch`. Below is the output... notice that it fails on packaging bits too. Why on earth would this happen? Either... I have made/applied the patches incorrectly, or svn diff is busted, or patch is busted, or somehow my workspace is now corrupt... how?!?! I hope it is not the latter else I just wasted several days worth of work to get this patch put together. WTF is going on?! I checked some of the rejects and most are harmless... but regardless of that I am really concerned about the reliability of patches. :-( patching file applications/ldap-realm-demo/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/console-standard/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/console-ear/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/console-core/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/console-framework/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/magicGball-ejb/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/magicGball-ear/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/magicGball-web/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/magicGball-client/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/demo/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/remote-deploy/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/uddi-db/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/uddi-server/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/welcome/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file configs/unavailable-client-deployer/pom.xml patching file configs/welcome-tomcat/pom.xml patching file configs/client-security/pom.xml patching file configs/javamail/pom.xml patching file configs/console-tomcat/pom.xml patching file configs/tomcat/pom.xml patching file configs/j2ee-server/pom.xml patching file configs/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file configs/activemq-broker/pom.xml patching file configs/jsp-examples-tomcat/pom.xml patching file configs/sharedlib/pom.xml patching file configs/jetty/pom.xml patching file configs/console-jetty/pom.xml patching file configs/client-system/pom.xml patching file configs/unavailable-ejb-deployer/pom.xml patching file configs/openejb-deployer/pom.xml patching file configs/directory/pom.xml patching file configs/online-deployer/pom.xml patching file configs/jsp-examples-jetty/pom.xml patching file configs/j2ee-deployer/pom.xml patching file configs/tomcat-deployer/pom.xml patching file configs/activemq/pom.xml patching file configs/geronimo-gbean-deployer/pom.xml patching file configs/hot-deployer/pom.xml patching file configs/shutdown/pom.xml patching file configs/jetty-deployer/pom.xml patching file configs/servlets-examples-jetty/pom.xml patching file configs/openejb/pom.xml patching file configs/unavailable-webservices-deployer/pom.xml patching file configs/axis-deployer/pom.xml patching file configs/system-database/pom.xml patching file configs/ldap-demo-tomcat/pom.xml patching file configs/upgrade/pom.xml patching file configs/welcome-jetty/pom.xml patching file configs/j2ee-security/pom.xml patching file configs/upgrade-cli/pom.xml patching file configs/rmi-naming/pom.xml patching file configs/ldap-demo-jetty/pom.xml patching file configs/client-deployer/pom.xml patching file configs/client-corba/pom.xml patching file configs/axis/pom.xml patching file configs/j2ee-system/pom.xml patching file configs/servlets-examples-tomcat/pom.xml patching file configs/j2ee-corba/pom.xml patching file configs/ldap-realm/pom.xml patching file configs/client/pom.xml patching file pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file m2-plugins/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file m2-plugins/geronimo-packaging-plugin/src/java/org/ apache/geronimo/plugin/packaging/PackageBuilderShellMojo.java Hunk #1 FAILED at 14. 1 out of 1 hunk FAILED -- saving rejects to file m2-plugins/geronimo- packaging-plugin/src/java/org/apache/geronimo/plugin/packaging/ PackageBuilderShellMojo.java.rej patching file m2-plugins/geronimo-packaging-plugin/src/java/org/ apache/geronimo/plugin/packaging/PlanProcessorMojo.java Hunk
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
Odd... I generated the patch in the same way I did for v1. I just tried: svn co https://svn.apache.org/repos/asf/geronimo/trunk cd trunk patch -p0 < ~/Downloads/GERONIMO-2161-v2.patch.txt Below is the output of patch... and I'm a touch concerned since I don't get why it would fail to apply this patch. I generated the file with: svn diff > GERONIMO-2161-v2.patch.txt Is that not the correct method to generate the patch file? Or is svn diff + patch not reliable? I don't get it. --jason patching file pom.xml Hunk #1 succeeded at 17 with fuzz 2. Hunk #2 FAILED at 33. 1 out of 2 hunks FAILED -- saving rejects to file pom.xml.rej patching file pom.xml Reversed (or previously applied) patch detected! Assume -R? [n] ^C Bliss:~/ws/apache/geronimo/tmp/trunk jason$ patch -p0 < ~/Downloads/ GERONIMO-2161-v2.patch.txt patching file applications/ldap-realm-demo/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/console-standard/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/console-ear/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/console-core/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/console/console-framework/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/magicGball-ejb/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/magicGball-ear/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/magicGball-web/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/magicGball/magicGball-client/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/demo/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/remote-deploy/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/uddi-db/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/uddi-server/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file applications/welcome/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file configs/unavailable-client-deployer/pom.xml patching file configs/welcome-tomcat/pom.xml patching file configs/client-security/pom.xml patching file configs/javamail/pom.xml patching file configs/console-tomcat/pom.xml patching file configs/tomcat/pom.xml patching file configs/j2ee-server/pom.xml patching file configs/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file configs/activemq-broker/pom.xml patching file configs/jsp-examples-tomcat/pom.xml patching file configs/sharedlib/pom.xml patching file configs/jetty/pom.xml patching file configs/console-jetty/pom.xml patching file configs/client-system/pom.xml patching file configs/unavailable-ejb-deployer/pom.xml patching file configs/openejb-deployer/pom.xml patching file configs/directory/pom.xml patching file configs/online-deployer/pom.xml patching file configs/jsp-examples-jetty/pom.xml patching file configs/j2ee-deployer/pom.xml patching file configs/tomcat-deployer/pom.xml patching file configs/activemq/pom.xml patching file configs/geronimo-gbean-deployer/pom.xml patching file configs/hot-deployer/pom.xml patching file configs/shutdown/pom.xml patching file configs/jetty-deployer/pom.xml patching file configs/servlets-examples-jetty/pom.xml patching file configs/openejb/pom.xml patching file configs/unavailable-webservices-deployer/pom.xml patching file configs/axis-deployer/pom.xml patching file configs/system-database/pom.xml patching file configs/ldap-demo-tomcat/pom.xml patching file configs/upgrade/pom.xml patching file configs/welcome-jetty/pom.xml patching file configs/j2ee-security/pom.xml patching file configs/upgrade-cli/pom.xml patching file configs/rmi-naming/pom.xml patching file configs/ldap-demo-jetty/pom.xml patching file configs/client-deployer/pom.xml patching file configs/client-corba/pom.xml patching file configs/axis/pom.xml patching file configs/j2ee-system/pom.xml patching file configs/servlets-examples-tomcat/pom.xml patching file configs/j2ee-corba/pom.xml patching file configs/ldap-realm/pom.xml patching file configs/client/pom.xml patching file pom.xml Hunk #1 FAILED at 17. Hunk #2 succeeded at 49 (offset 4 lines). Hunk #3 succeeded at 537 (offset 4 lines). Hunk #4 succeeded at 551 (offset 4 lines). Hunk #5 succeeded at 576 (offset 4 lines). Hunk #6 succeeded at 596 (offset 4 lines). Hunk #7 succeeded at 689 (offset 4 lines). Hunk #8 succeeded at 874 (offset 4 lines). 1 out of 8 hunks FAILED -- saving rejects to file pom.xml.rej patching file m2-plugins/pom.xml Hunk #1 succeeded at 17 with fuzz 2. patching file m2-plugins/geronimo-packaging-plugin/src/java/org/
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418915
]
David Jencks commented on GERONIMO-2161:
The v2 patch does not apply cleanly to my clean tree. Will try to investigate
further tomorrow. All problems are in the packaging plugin.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security-builder
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418909
]
John Sisson commented on GERONIMO-2161:
---
My +1 above is for the GERONIMO-2161-v2.patch.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418906
]
John Sisson commented on GERONIMO-2161:
---
+1 : applied patch and tested build. Due to xmlbeans issue (which is a
separate problem not caused by this patch) It took a number of build attempts
using Jason's script he shared with me on IRC:
{noformat}
#!/bin/sh
# Drop all existing repo state
rm -rf ~/.m2/repository
# Clean, since mvn clean won't work everytime because of chicken-egg plugins
find . -name target -type d -exec rm -rf \{\} \;
# Build the G modules - 13 times to get around xmlbeans crap
for x in 1 2 3 4 5 6 7 8 9 10 11 12 13; do
mvn -Dstage=bootstrap -Dmaven.test.skip=true
done
# Build OpenEJB - 3 times to get around xmlbeans crap
( cd openejb2/modules; mvn clean; mvn install; mvn install; mvn install )
# Build G apps, config and assembly
mvn -Dstage=assemble -Dmaven.test.skip=true
{noformat}
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418883
]
Jason Dillon commented on GERONIMO-2161:
#&@%, this won't work exactly asis, because openejb depends on G and G depends
on openejb.
This build is so convoluted.
And it also appears that the xmlbeans issue is still intermittent.
The latest magical elixir:
{noformat}
rm -rf ~/.m2/repository
find . -name target -type d -exec rm -rf \{\} \;
mvn -Dstage=bootstrap -Dmaven.test.skip=true
( cd openejb2/modules/ && mvn clean install )
mvn -Dstage=assemble -Dmaven.test.skip=true
{noformat}
Ends up spitting the same junk out:
{noformat}
Missing:
--
1) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=xmlbeans
-DartifactId=xmlbeans-jsr173-api \
-Dversion=2.0-dev -Dpackaging=jar -Dfile=/path/to/file
Path to dependency:
1) org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
2) stax:stax:jar:1.1.1-dev
3) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
{noformat}
FYI, with the build generating plugins that are expected to be in the main
build, after nuking your repository a `mvn clean` will not function.
I believe this is a good indication that the usage of the plugins asis is not
inline with how Maven 2 was intended to function.
I still believe it is in our best interest to get rid of this... or at least
refactor how it is applied to allow normal things like `mvn clean` to function
w/o errors.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418877
]
Jason Dillon commented on GERONIMO-2161:
Here is the latest patch... which includes several other fixes.
{noformat}
rm -rf ~/.m2/repository
{noformat}
Build openejb2 module with m2:
{noformat}
svn co http://svn.codehaus.org/openejb/trunk/openejb2
cd openejb2/modules
mvn install
{noformat}
Build G (from trunk dir), using build script that implements stages:
{noformat}
mvn clean
./build -Dmaven.test.skip=true
{noformat}
This fixes:
* openejb groupId's (dave j's patch)
* xmlbeans plugin problems (latest snap works)
* webapp war'ing + jspc
* uddi-db fixes to execute sql bits
Also a few changes to the packaging plugin to fix the formatting and the output
logging.
Plus all of the stuff from v1.
Please give it a whirl and let me know what issues you run into.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch,
> GERONIMO-2161-v2.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418867
]
Jason Dillon commented on GERONIMO-2161:
The war/jspc bits were fixed in my workspace yesterday, as well as several
other issues.
Its not easy to fix and the repost so many patches so that I can wait several
days to get someone to notice more issues that I fixed in those few days while
waiting.
IMO, we need to get a faster turn around from conceptual change to commit.
Right now it is very impractical for me to apply any other patches as my
workspace is already highly modified for the changes that are noted in this
issue.
I can put up an updated patch to the original that fixes many of the issues
(not the xmlbeans one yet).
But, if I need to keep making new revisions of the same patch over and over...
well, then I am much more likely to branch and then just fix the stupid m2
build and get it over with.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418864
]
David Jencks commented on GERONIMO-2161:
Patch applies fine for me.
mvn -Dstage=bootstrap && mvn, the bootstrap works but the mvn fails due to the
using plugin in same build problem
The first few applications builds fail with messages like:
Error assembling WAR: Deployment descriptor:
/Users/david/geronimo/svn/geronimo-patch/applications/ldap-realm-demo/target/geronimo-ldap-demo-1.2-SNAPSHOT/WEB-INF/web.xml
does not exist.
I gave up on applications after 2 of these. This might be related to removing
the war and jspc plugins from applications/pom.xml, which I don't understand,
as these plugins are needed.
I believe the packaging plugin version in root pom.xml needs to be
1.2-SNAPSHOT, or better pom.version
The openejb groupIds need to be updated to org.openejb. I'm attaching a patch
that works for me that fixes the openejb groupId and removes some unneeded
dependencies from a couple configs.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418841
]
Jacek Laskowski commented on GERONIMO-2161:
---
Once I applied GERONIMO-2082, too the build went a little further up to the
following error. Without the two fixes (GERONIMO-2082 and GERONIMO-2161) it's
impossible to move on.
[EMAIL PROTECTED] /cygdrive/c/oss/GERONIMO-2082-2161
$ mvn -Dstage=bootstrap && mvn
...
[INFO]
[INFO] Building Geronimo :: Applications
[INFO]task-segment: [install]
[INFO]
[INFO] [site:attach-descriptor]
[INFO] [install:install]
[INFO] Installing c:\oss\GERONIMO-2082-2161\applications\pom.xml to
C:\Documents and
Settings\jlaskowski\.m2\repository\org\apache\geronimo\applications\applications-parent\1.2-SNA
PSHOT\applications-parent-1.2-SNAPSHOT.pom
[INFO]
[INFO] Building Geronimo Applications :: Demo
[INFO]task-segment: [install]
[INFO]
Downloading:
http://repo.mergere.com/maven2/org/apache/maven/plugins/maven-war-plugin/2.0/maven-war-plugin-2.0.pom
1K downloaded
Downloading:
http://repo.mergere.com/maven2/org/apache/maven/plugins/maven-war-plugin/2.0/maven-war-plugin-2.0.jar
21K downloaded
[INFO] [resources:resources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:compile]
[INFO] No sources to compile
[INFO] [resources:testResources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:testCompile]
[INFO] No sources to compile
[INFO] [surefire:test]
[INFO] No tests to run.
[INFO] [war:war]
[INFO] Exploding webapp...
[INFO] Copy webapp webResources to
c:\oss\GERONIMO-2082-2161\applications\demo\target\demo-1.2-SNAPSHOT
[INFO] Assembling webapp demo in
c:\oss\GERONIMO-2082-2161\applications\demo\target\demo-1.2-SNAPSHOT
[INFO] Generating war
c:\oss\GERONIMO-2082-2161\applications\demo\target\demo-1.2-SNAPSHOT.war
[INFO]
[ERROR] BUILD ERROR
[INFO]
[INFO] Error assembling WAR: Deployment descriptor:
c:\oss\GERONIMO-2082-2161\applications\demo\target\demo-1.2-SNAPSHOT\WEB-INF\web.xml
does not exist.
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[INFO] Total time: 3 minutes 36 seconds
[INFO] Finished at: Sun Jul 02 12:12:54 CEST 2006
[INFO] Final Memory: 22M/254M
[INFO]
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418839
]
Jason Dillon commented on GERONIMO-2161:
I think if you run the build from the module that freaks out with xmlbeans then
it will pass, then you can try again from the root.
so, in the case you mentioned:
{noformat}
cd modules/j2ee-schema
mvn
{noformat}
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security-builder
>
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
I did not fix it... but it has started to go away... not sure why yet.
I think we need to get a common repo withy these new changes to
resync and move on to the next hurdle.
--jason
On Jul 2, 2006, at 12:57 AM, David Jencks wrote:
This is the xmlbeans/stax problem. It might be that either you or
jason has a fixed xmlbeans plugin.
david jencks
On Jul 2, 2006, at 12:46 AM, Jacek Laskowski (JIRA) wrote:
[ http://issues.apache.org/jira/browse/GERONIMO-2161?
page=comments#action_12418829 ]
Jacek Laskowski commented on GERONIMO-2161:
---
Tested and got the following build error. I'll give it a shot
again with no ~/.m2 local repo.
{noformat}
[EMAIL PROTECTED] /cygdrive/c/oss/GERONIMO-2161-testing
$ mvn -Dstage=bootstrap && mvn
...
[INFO]
-
---
[ERROR] BUILD ERROR
[INFO]
-
---
[INFO] Failed to resolve artifact.
Missing:
--
1) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=xmlbeans -
DartifactId=xmlbeans-jsr173-api \
-Dversion=2.0-dev -Dpackaging=jar -Dfile=/path/to/file
Path to dependency:
1) org.apache.geronimo.modules:geronimo-j2ee-schema:jar:
1.2-SNAPSHOT
2) stax:stax:jar:1.1.1-dev
3) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
--
1 required artifact is missing.
for artifact:
org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
{noformat}
[RTC] Remove Geronimo modules from dependencyManagement in root
pom.xml
---
Key: GERONIMO-2161
URL: http://issues.apache.org/jira/browse/GERONIMO-2161
Project: Geronimo
Type: Task
Security: public(Regular issues)
Components: buildsystem
Reporter: Jason Dillon
Assignee: Jason Dillon
Fix For: 1.2
Attachments: GERONIMO-2161-v1.patch
As I have mentioned before, I believe we should remove the
Geronimo modules that are currently listed in the root pom.xml:
This reduces the configuration of the pom by *~500 lines*.
Modules that reference these as dependencies will need their
pom's adjusted to include ${pom.version} and
car for the configs. But in many places version
already exists with the ${geronimoVersion} property... which
kinda negates the purpose of the dependencyManagement section
anyways.
I believe that it is more work to keep track of every module in
the root pom than it is to specify the additonal elements (mostly
just ${pom.version}) in child poms. There is
no additional maintenance, as the new elements never need to be
changed.
Net effect if this change is less configuration to maintain and
thus a less brittle build that can adapt to change easier.
Specifically these should be removed:
{code:xml}
org.apache.geronimo.modules
ge-activemq-rar
${geronimoVersion}
rar
org.apache.geronimo.modules
geronimo-activation
${geronimoVersion}
org.apache.geronimo.modules
geronimo-client
${geronimoVersion}
org.apache.geronimo.modules
geronimo-client-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-common
${geronimoVersion}
org.apache.geronimo.modules
geronimo-connector
${geronimoVersion}
org.apache.geronimo.modules
geronimo-connector-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-converter
${geronimoVersion}
org.apache.geronimo.modules
geronimo-core
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-config
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-jsr88
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-tool
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deployment
${geronimoVersion}
org.apache.geronimo.modules
geronimo-derby
${geronimoVersion}
org.apache.geronimo.modules
geronimo-directory
${geronimoVersion}
org.apache.geronimo.modules
geronimo-javamail-transport
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee-schema
${geronimoVersion}
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418834
]
Jason Dillon commented on GERONIMO-2161:
Baby steps...
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-service-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
>
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
1/ Why has the version tag been added? Doesn't M2 take care of it?
org.apache.geronimo.modules
geronimo-security-builder
+${pom.version}
m2 dose not take care of this.
internal modules IMO should be defined with this additional version
element to avoid needing to insert a dependencyManagement element in
the root pom.
IMO putting it here is easier to maintain and manage than to force
more than one file to be used to control the version.
This is only for internal dependencies that share the same $
{pom.version}.
NOTE: Before I even started working on this the m2 configuration was
already misusing the dependencyManagement section, but having all
issues redefine the same property-based version.
2/ Could the syntax of application names be changed to
Geronimo Applications :: The Magic G Ball :: WAR
rather than
Geronimo Applications, The Magic G Ball :: WAR
to be aligned with
Geronimo Applications :: The Magic G Ball
Yes that could be the syntax, but, once restart the restructure to
better organize modules for the m2 build, the use of the ' :: '
separator gets quite out of hand. There will be several layers of
nesting. To help this naming system scale only one (max two ::
should be used), otherwise the names get quite out of hand.
They were already out of hand and so I re-applied to original naming
scheme that I setup for the m1 modules way way back.
3/ Why has this been excluded?
+++ modules/directory/pom.xml (working copy)
...
+
+
+commons-test
+commons-test
+
+
As a measure to get this puppy to build ;-)
Where is this dependency? Where is its project? Where is the
version to be used?
If it is actually needed then we need an official build for it... and
a version in a well know repository.
FYI, there are a bunch of whacked dependencies throughout the build.
It is going to take many more RTC to get all of that resolved.
--jason
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418833
]
Jacek Laskowski commented on GERONIMO-2161:
---
Yes, we will, but if it's RTCed, shouldn't it depend on another RTCed patch? It
would be much clearer.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418831
]
Jason Dillon commented on GERONIMO-2161:
This is the xmlbeans issue that was talked about before. Waiting for David J
to get the poms updated.
Nothing I can do about it now unfortunately.
We will need to resolve this post several other changes for m2 support.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security-builder
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
On Jul 2, 2006, at 12:24 AM, Jacek Laskowski wrote:
On 7/2/06, Jason Dillon (JIRA) wrote:
> [RTC] Remove Geronimo modules from dependencyManagement in root
pom.xml
>
-
--
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
I've got questions about the patch. Appreciate comments.
1/ Why has the version tag been added? Doesn't M2 take care of it?
org.apache.geronimo.modules
geronimo-security-builder
+${pom.version}
This was the main point of the patch, as discussed on the dev list
and in the patch description: to remove geronimo dependencies from
dependencyManagement and instead include this version tag wherever
they are used. I'm a bit surprised by this idea but jason has worked
on many more m2 projects than I and I'm happy to believe him that
this will make our life easier.
thanks
david jencks
2/ Could the syntax of application names be changed to
Geronimo Applications :: The Magic G Ball :: WAR
rather than
Geronimo Applications, The Magic G Ball :: WAR
to be aligned with
Geronimo Applications :: The Magic G Ball
3/ Why has this been excluded?
+++ modules/directory/pom.xml (working copy)
...
+
+
+commons-test
+commons-test
+
+
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
This is the xmlbeans/stax problem. It might be that either you or
jason has a fixed xmlbeans plugin.
david jencks
On Jul 2, 2006, at 12:46 AM, Jacek Laskowski (JIRA) wrote:
[ http://issues.apache.org/jira/browse/GERONIMO-2161?
page=comments#action_12418829 ]
Jacek Laskowski commented on GERONIMO-2161:
---
Tested and got the following build error. I'll give it a shot again
with no ~/.m2 local repo.
{noformat}
[EMAIL PROTECTED] /cygdrive/c/oss/GERONIMO-2161-testing
$ mvn -Dstage=bootstrap && mvn
...
[INFO]
--
--
[ERROR] BUILD ERROR
[INFO]
--
--
[INFO] Failed to resolve artifact.
Missing:
--
1) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=xmlbeans -
DartifactId=xmlbeans-jsr173-api \
-Dversion=2.0-dev -Dpackaging=jar -Dfile=/path/to/file
Path to dependency:
1) org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-
SNAPSHOT
2) stax:stax:jar:1.1.1-dev
3) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
--
1 required artifact is missing.
for artifact:
org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
{noformat}
[RTC] Remove Geronimo modules from dependencyManagement in root
pom.xml
-
--
Key: GERONIMO-2161
URL: http://issues.apache.org/jira/browse/GERONIMO-2161
Project: Geronimo
Type: Task
Security: public(Regular issues)
Components: buildsystem
Reporter: Jason Dillon
Assignee: Jason Dillon
Fix For: 1.2
Attachments: GERONIMO-2161-v1.patch
As I have mentioned before, I believe we should remove the
Geronimo modules that are currently listed in the root pom.xml:
This reduces the configuration of the pom by *~500 lines*.
Modules that reference these as dependencies will need their pom's
adjusted to include ${pom.version} and
car for the configs. But in many places version
already exists with the ${geronimoVersion} property... which kinda
negates the purpose of the dependencyManagement section anyways.
I believe that it is more work to keep track of every module in
the root pom than it is to specify the additonal elements (mostly
just ${pom.version}) in child poms. There is
no additional maintenance, as the new elements never need to be
changed.
Net effect if this change is less configuration to maintain and
thus a less brittle build that can adapt to change easier.
Specifically these should be removed:
{code:xml}
org.apache.geronimo.modules
ge-activemq-rar
${geronimoVersion}
rar
org.apache.geronimo.modules
geronimo-activation
${geronimoVersion}
org.apache.geronimo.modules
geronimo-client
${geronimoVersion}
org.apache.geronimo.modules
geronimo-client-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-common
${geronimoVersion}
org.apache.geronimo.modules
geronimo-connector
${geronimoVersion}
org.apache.geronimo.modules
geronimo-connector-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-converter
${geronimoVersion}
org.apache.geronimo.modules
geronimo-core
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-config
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-jsr88
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deploy-tool
${geronimoVersion}
org.apache.geronimo.modules
geronimo-deployment
${geronimoVersion}
org.apache.geronimo.modules
geronimo-derby
${geronimoVersion}
org.apache.geronimo.modules
geronimo-directory
${geronimoVersion}
org.apache.geronimo.modules
geronimo-javamail-transport
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee-builder
${geronimoVersion}
org.apache.geronimo.modules
geronimo-j2ee-schema
${geronimoVersion}
org.apache.geronimo.modules
geronimo-kernel
${geronimoVersion}
org.apache.geronimo.modules
geronimo-jetty
${geronimoVersion}
org.apache.geronimo.modules
geronimo-jetty-builder
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418829
]
Jacek Laskowski commented on GERONIMO-2161:
---
Tested and got the following build error. I'll give it a shot again with no
~/.m2 local repo.
{noformat}
[EMAIL PROTECTED] /cygdrive/c/oss/GERONIMO-2161-testing
$ mvn -Dstage=bootstrap && mvn
...
[INFO]
[ERROR] BUILD ERROR
[INFO]
[INFO] Failed to resolve artifact.
Missing:
--
1) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=xmlbeans
-DartifactId=xmlbeans-jsr173-api \
-Dversion=2.0-dev -Dpackaging=jar -Dfile=/path/to/file
Path to dependency:
1) org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
2) stax:stax:jar:1.1.1-dev
3) xmlbeans:xmlbeans-jsr173-api:jar:2.0-dev
--
1 required artifact is missing.
for artifact:
org.apache.geronimo.modules:geronimo-j2ee-schema:jar:1.2-SNAPSHOT
{noformat}
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
>
Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
On 7/2/06, Jason Dillon (JIRA) wrote:
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
I've got questions about the patch. Appreciate comments.
1/ Why has the version tag been added? Doesn't M2 take care of it?
org.apache.geronimo.modules
geronimo-security-builder
+${pom.version}
2/ Could the syntax of application names be changed to
Geronimo Applications :: The Magic G Ball :: WAR
rather than
Geronimo Applications, The Magic G Ball :: WAR
to be aligned with
Geronimo Applications :: The Magic G Ball
3/ Why has this been excluded?
+++ modules/directory/pom.xml (working copy)
...
+
+
+commons-test
+commons-test
+
+
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418816
]
Jason Dillon commented on GERONIMO-2161:
FYI, this should be relatively easy to validate.
Setup a workspace and apply the patch:
{noformat}
wget
http://issues.apache.org/jira/secure/attachment/12336226/GERONIMO-2161-v1.patch
svn co svn.apache.org/repos/asf/geronimo/trunk GERONIMO-2161-testing
cd GERONIMO-2161-testing
patch -p0 < ../GERONIMO-2161-v1.patch
{noformat}
Run a build:
{noformat}
mvn -Dstage=bootstrap && mvn
{noformat}
Should complete w/o errors.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418806
]
Jason Dillon commented on GERONIMO-2161:
Forgot, also adds configuration to build module-linked project for IDEA using
the correct JDK.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
> Attachments: GERONIMO-2161-v1.patch
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-service-builder
>
[jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
[
http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418775
]
Jason Dillon commented on GERONIMO-2161:
FYI, there is also related work to clean up dependency configuration in all
modules. In many places modules re-specify the version (using a property as
the value) when the dependency with the same version was already defined in the
dependencyManagement section.
So, in general there is need to clean up the pom's to properly and effectively
use m2.
> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> ---
>
> Key: GERONIMO-2161
> URL: http://issues.apache.org/jira/browse/GERONIMO-2161
> Project: Geronimo
> Type: Task
> Security: public(Regular issues)
> Components: buildsystem
> Reporter: Jason Dillon
> Assignee: Jason Dillon
> Fix For: 1.2
>
> As I have mentioned before, I believe we should remove the Geronimo modules
> that are currently listed in the root pom.xml:
> This reduces the configuration of the pom by *~500 lines*.
> Modules that reference these as dependencies will need their pom's adjusted
> to include ${pom.version} and car for the
> configs. But in many places version already exists with the
> ${geronimoVersion} property... which kinda negates the purpose of the
> dependencyManagement section anyways.
> I believe that it is more work to keep track of every module in the root pom
> than it is to specify the additonal elements (mostly just
> ${pom.version}) in child poms. There is no additional
> maintenance, as the new elements never need to be changed.
> Net effect if this change is less configuration to maintain and thus a less
> brittle build that can adapt to change easier.
> Specifically these should be removed:
> {code:xml}
>
> org.apache.geronimo.modules
> ge-activemq-rar
> ${geronimoVersion}
> rar
>
>
> org.apache.geronimo.modules
> geronimo-activation
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-client-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-common
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-connector-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-converter
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-core
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-config
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-jsr88
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deploy-tool
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-deployment
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-derby
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-directory
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-javamail-transport
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-j2ee-schema
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-kernel
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jetty-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-jmx-remoting
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-mail
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-management
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-naming-builder
> ${geronimoVersion}
>
>
> org.apache.geronimo.modules
> geronimo-security
>
