[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728558#action_12728558 ] Shiny Cheng commented on GERONIMO-4027: --- When I tried to verify the problem on trunk (rev 791414, 2.2-SNAPSHOT), I found the problem still existed. Icons of Classloader tree, JNDI tree, Dependency tree still can't been seen in the high contrast mode while those of JMX and LDAP work correctly. > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Forrest Xia >Assignee: Lin Sun >Priority: Minor > Attachments: GERONIMO-4027-2.patch, GERONIMO-4027.patch > > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602419#action_12602419 ] Lin Sun commented on GERONIMO-4027: --- Cool - sorry I was looking at your first patch (didn't notice that you loaded a new one). Thanks. > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > Attachments: GERONIMO-4027-2.patch, GERONIMO-4027.patch > > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602406#action_12602406 ] Joseph Leong commented on GERONIMO-4027: Quick additional comment. Additionally the background image is being grabbed from the templateCssString rather than any reference to the TreeIcon CSS file itself. The templateCssString is defined in each respective view files. The reason templateCssString was used instead of having an overriding CSS Template file is because in dojo 0.4.x this particular widget (among others) has a glitch that causes that attribute to not function at all. -Joseph Leong > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > Attachments: GERONIMO-4027-2.patch, GERONIMO-4027.patch > > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602402#action_12602402 ] Joseph Leong commented on GERONIMO-4027: Hi Lin, Thanks for looking it over. I see why you would say that, but not to worry - I specifically commented that portion out. The hard-coded address in the TreeIcon CSS file was just there for me to use while debugging. Good spot though, i almost didn't catch it myself the first time. -Joseph Leong > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > Attachments: GERONIMO-4027-2.patch, GERONIMO-4027.patch > > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602369#action_12602369 ] Lin Sun commented on GERONIMO-4027: --- Joseph, just a quick review of your patch, what if the default http port is not 8080? This would result in the failure of getting the background image. > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > Attachments: GERONIMO-4027-2.patch, GERONIMO-4027.patch > > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602290#action_12602290 ] Joseph Leong commented on GERONIMO-4027: LDAP Viewer icons verified. Posted patch includes all necessary changes for this Jira! -Joseph Leong > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > Attachments: GERONIMO-4027.patch > > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602053#action_12602053 ] Joseph Leong commented on GERONIMO-4027: It turns out in some widgets of Dojo 0.4.x , TreeIconExtension being one, there is a bug where the templateCssPath parameter is ignored. As such, a templateCssString will be passed through defining the custom CSS as well as skipping the step of resolving file reference. -Joseph Leong > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601993#action_12601993 ] Joseph Leong commented on GERONIMO-4027: The icons are currently looking at a predefined templated css that is packaged with Dojo 0.4.3 and that css specifies to icon paths that do not exist. Rather than uploading additional icons to the package, i'll modify the TreeDocIcon.css at the root of debug-views and have that take precedence as the CSS to define those icon. This css will have attributes to point to the high contrast icon which already exist at debug-views/ Joseph Leong > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601119#action_12601119 ] Donald Woods commented on GERONIMO-4027: Since this fix is going into the Dojo 0.4.3 files, I doubt we'll ever upgrade the legacy support, so its probably safe to include the fix. Either way, please attach the solution to this JIRA, so others can choose to integrate the fix into their Geronimo based solutions if they want > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600881#action_12600881 ] Joseph Leong commented on GERONIMO-4027: I guess i wouldn't modify the 3rd party lib, the problem might come back when upgrading the lib and possibly more overhead for maintaining a private build. Thoughts? So it looks like the css linking to the icon just appears to be broken. Modifying that piece and testing to make sure that was the only issue. -Joseph Leong > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600785#action_12600785 ] Joseph Leong commented on GERONIMO-4027: Hi Rex, I'll take a look at your lead and see what else i can do. Thanks! -Joseph Leong > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Assignee: Joseph Leong >Priority: Minor > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4027) Accessibility issue: Tree icons in high contrast mode cannot be seen
[ https://issues.apache.org/jira/browse/GERONIMO-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600716#action_12600716 ] Rex Wang commented on GERONIMO-4027: Well, I found that the images are in the archive repository\org\dojotoolkit\dojolegacy\0.4.3\dojolegacy-0.4.3.tgz Should we change the 3rd part lib in repository? > Accessibility issue: Tree icons in high contrast mode cannot be seen > > > Key: GERONIMO-4027 > URL: https://issues.apache.org/jira/browse/GERONIMO-4027 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1.1 > Environment: Windows XP SP2, IE 6.0 >Reporter: Xia Ming >Priority: Minor > > To enable low-vision people to use admin console, the tree icons in these > pages shall be improved: > Classloader tree > JNDI tree > Dependency tree > Note that, after tested, only MBeans tree's icon could be seen in the high > contrast mode. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
