[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-09-25 Thread Donald Woods (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Woods updated GERONIMO-2964:
---

Fix Version/s: (was: 2.0.x)

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Assignee: Vamsavardhana Reddy
>Priority: Minor
> Fix For: 2.0.2, 2.1
>
> Attachments: g2964.war, GERONIMO-2964-2.0-w-cons-change.patch, 
> GERONIMO-2964-2.0.patch, GERONIMO-2964-combined-new.patch, 
> GERONIMO-2964-combined.patch, GERONIMO-2964-trunk.patch, GERONIMO-2964.patch, 
> suid.patch, tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-09-17 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Attachment: suid.patch

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Assignee: Vamsavardhana Reddy
>Priority: Minor
> Fix For: 2.0.2, 2.0.x, 2.1
>
> Attachments: g2964.war, GERONIMO-2964-2.0-w-cons-change.patch, 
> GERONIMO-2964-2.0.patch, GERONIMO-2964-combined-new.patch, 
> GERONIMO-2964-combined.patch, GERONIMO-2964-trunk.patch, GERONIMO-2964.patch, 
> suid.patch, tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-09-17 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Attachment: GERONIMO-2964-trunk.patch

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Assignee: Vamsavardhana Reddy
>Priority: Minor
> Fix For: 2.0.2, 2.0.x, 2.1
>
> Attachments: g2964.war, GERONIMO-2964-2.0-w-cons-change.patch, 
> GERONIMO-2964-2.0.patch, GERONIMO-2964-combined-new.patch, 
> GERONIMO-2964-combined.patch, GERONIMO-2964-trunk.patch, GERONIMO-2964.patch, 
> tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-09-17 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Attachment: GERONIMO-2964-2.0.patch

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Assignee: Vamsavardhana Reddy
>Priority: Minor
> Fix For: 2.0.2, 2.0.x, 2.1
>
> Attachments: g2964.war, GERONIMO-2964-2.0.patch, 
> GERONIMO-2964-combined-new.patch, GERONIMO-2964-combined.patch, 
> GERONIMO-2964.patch, tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-09-17 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Attachment: GERONIMO-2964-2.0-w-cons-change.patch

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Assignee: Vamsavardhana Reddy
>Priority: Minor
> Fix For: 2.0.2, 2.0.x, 2.1
>
> Attachments: g2964.war, GERONIMO-2964-2.0-w-cons-change.patch, 
> GERONIMO-2964-2.0.patch, GERONIMO-2964-combined-new.patch, 
> GERONIMO-2964-combined.patch, GERONIMO-2964.patch, 
> tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-09-15 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Fix Version/s: (was: 1.2)
   2.0.x
   2.0.2
 Assignee: Vamsavardhana Reddy

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Assignee: Vamsavardhana Reddy
>Priority: Minor
> Fix For: 2.0.2, 2.0.x, 2.1
>
> Attachments: g2964.war, GERONIMO-2964-combined-new.patch, 
> GERONIMO-2964-combined.patch, GERONIMO-2964.patch, 
> tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-09-12 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Attachment: GERONIMO-2964-combined-new.patch

GERONIMO-2964-combined-new.patch:

Now that plugin backward compatibility is not an issue, I guess this fix can go 
into 2.0.2 as well.  Here is a patch to allow a "work-dir" tag in web.xml.  For 
G/Jetty, the work-dir is created under var/jetty and for G/Tomcat, the work-dir 
is created under var/catalina with the specified name.  Once again, the patch 
does not address renaming the schema's to new versions which is to be addressed 
before committing the patch.  I have verified that the patch works on 
branches\2.0 without any test failures.  And the distributiions built address 
the issue at hand.

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Priority: Minor
> Fix For: 1.2, 2.1
>
> Attachments: g2964.war, GERONIMO-2964-combined-new.patch, 
> GERONIMO-2964-combined.patch, GERONIMO-2964.patch, 
> tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-08-27 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Attachment: GERONIMO-2964-combined.patch

GERONIMO-2964-combined.patch: This patch features a work-dir setting for both 
tomcat and jetty.  Once again the schema files need to be renamed (which is not 
done by this patch).

I was chatting with David Jencks on IRC channel and he suggested that 
irrespective of not changing the constructors, we might be breaking 
compatibility as we have added new GBean attributes :o(

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Priority: Minor
> Fix For: 1.2, 2.1
>
> Attachments: g2964.war, GERONIMO-2964-combined.patch, 
> GERONIMO-2964.patch, tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-08-27 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Attachment: g2964.war

Verified that GERONIMO-2964.patch solves the problem.  Deploy g2964.war which 
uses a workDir "g2964" under var/catalina.  Access http://localhost:8080/g2964 
once the app is deployed.

Caution: GERONIMO-2964.patch can not be committed as we will need to change the 
versions of the two schema files and this requires (a lot of) other changes.

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Priority: Minor
> Fix For: 1.2, 2.1
>
> Attachments: g2964.war, GERONIMO-2964.patch, 
> tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-08-27 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Attachment: GERONIMO-2964.patch

Aman, can you check if GERONIMO-2964.patch addresses this issue?  Patch to be 
used on branches\2.0 or tags\2.0.1.

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Priority: Minor
> Fix For: 1.2, 2.1
>
> Attachments: GERONIMO-2964.patch, tomcat-config-workdir.patch, 
> tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-08-23 Thread Vamsavardhana Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vamsavardhana Reddy updated GERONIMO-2964:
--

Fix Version/s: 2.1

Though there was a patch waiting on the JIRA, it fell off of 2.0 radar as the 
"Fix Version" did not have 2.0.  Can this the considered for 2.0.x?  Remember 
that it requires a schema change.

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Priority: Minor
> Fix For: 1.2, 2.1
>
> Attachments: tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-04-13 Thread Donald Woods (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Woods updated GERONIMO-2964:
---

Affects Version/s: 2.0-M5

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2, 2.0-M5
>Reporter: Aman Nanner
>Priority: Minor
> Fix For: 1.2
>
> Attachments: tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-03-14 Thread Aman Nanner (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Nanner updated GERONIMO-2964:
--

Attachment: tomcat-config-workdir.patch

Here's an additional patch for the config XSD.

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2
>Reporter: Aman Nanner
>Priority: Minor
> Fix For: 1.2
>
> Attachments: tomcat-config-workdir.patch, tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2964) Cannot specify the Tomcat work directory for a web application

2007-03-14 Thread Aman Nanner (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aman Nanner updated GERONIMO-2964:
--

Attachment: tomcat-workdir.patch

Here is the patch that addresses this improvement.  If there's still time left, 
it would be cool if this made it into Geronimo 1.2.  I understand if it does 
not though, since it involves a schema modification.

> Cannot specify the Tomcat work directory for a web application
> --
>
> Key: GERONIMO-2964
> URL: https://issues.apache.org/jira/browse/GERONIMO-2964
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: Tomcat
>Affects Versions: 1.2
>Reporter: Aman Nanner
>Priority: Minor
> Fix For: 1.2
>
> Attachments: tomcat-workdir.patch
>
>
> In Tomcat, a work directory can be specified for a web application in a 
> WEB-INF/context.xml file.  The GeronimoStandardContext does not permit the 
> user to specify a work directory, and so the work directory defaults to 
> var/catalina/work/.
> I've submitted a patch file that modifies the geronimo-tomcat-1.2 schema to 
> permit the user to optionally specify a work directory.  This work directory 
> is then propagated into the TomcatContext.  I've tested this and it seems to 
> work well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.