Re: Can't close a PR on geronimo-config

[Jean-Louis MONTEIRO]

Thanks Jon. I did not know about this detail.
Good to know even if we are moving to Gitbox


Le lun. 4 juin 2018 à 15:23, John D. Ament  a écrit :

> The commit message doesn't include "this closes " so nothing was triggered
> to close.  Once this moves to gitbox we should be good.
>
> John
>
> On Mon, Jun 4, 2018, 8:07 AM Jean-Louis MONTEIRO 
> wrote:
>
>> Hi,
>>
>> I have applied the PR/2 from Daniel Soro to SVN, but I can't close it.
>> Usually when Github is the mirror and we merge a PR manually, gitbot sees
>> it and closes the PR for us.
>>
>> Did I miss something?
>>
>> Jean-Louis
>>
>

Re: Can't close a PR on geronimo-config

[John D. Ament]

The commit message doesn't include "this closes " so nothing was triggered
to close.  Once this moves to gitbox we should be good.

John

On Mon, Jun 4, 2018, 8:07 AM Jean-Louis MONTEIRO  wrote:

> Hi,
>
> I have applied the PR/2 from Daniel Soro to SVN, but I can't close it.
> Usually when Github is the mirror and we merge a PR manually, gitbot sees
> it and closes the PR for us.
>
> Did I miss something?
>
> Jean-Louis
>

Re: Can't close a PR on geronimo-config

[Romain Manni-Bucau]

Same here

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 4 juin 2018 à 14:07, Jean-Louis MONTEIRO  a
écrit :

> Hi,
>
> I have applied the PR/2 from Daniel Soro to SVN, but I can't close it.
> Usually when Github is the mirror and we merge a PR manually, gitbot sees
> it and closes the PR for us.
>
> Did I miss something?
>
> Jean-Louis
>

Can't close a PR on geronimo-config

[Jean-Louis MONTEIRO]

Hi,

I have applied the PR/2 from Daniel Soro to SVN, but I can't close it.
Usually when Github is the mirror and we merge a PR manually, gitbot sees
it and closes the PR for us.

Did I miss something?

Jean-Louis