Re: [RTC] Merge m2migration (functional m2 build) to trunk
Comments below... get ready to take your grain of salt...
On Jul 25, 2006, at 6:50 AM, anita kulshreshtha wrote:
Jason,
you aksed me on to make a patch for the branch on July 10th. I
looked at the code and saw that you made the following changes to the
packaging plugin:
1. Renamed the plugin
2. Changed the package structure
Yes I merged the 2 plugins into one so they can share the same
codebase. These plugins work with CAR files... and there is
absolutely no reason whatsoever that they should or need to be
separated. There are however good reasons to merge them.
3. Changed the directory layout to standard M2 layout, even though the
rest of the project and the geronimo-deployment _plugin_ still use the
old layout!
There are several modules in the project that use the new standard M2
layout. I moved all modules that were not used by the m1 build to
use the new layout and others will follow shortly.
I don't really see how this matters though. It should be easy enough
for the author of the patch to simply copy and paste the correct bits
in the right place. The code has not changed so much that the
original logic was removed.
4. Used non geronimo coding style.
In the past subjective changes like this were discussed on the
list
so people can provide their input.
Please don't tell me about coding style... the classes in these
plugins were a mix of styles, a mix indentation, grossly abused
System.out.* and did not properly handle exceptions. I normalized them.
I also make may plexus-style changes, which better use the plexus
component container's ability to configure the mojos, that and to
take more advantage of existing plexus bits like utils to delete
directories instead of your custom version.
5. Removed plexus component.xml (you have reverted this change now)
At no point did I remove plexus/components.xml. I am very well aware
of the purpose of this file.
If you are going to publicly list reasons you don't like what I have
done, please do not invent reasons that do not exist, or substantiate
them.
I quickly realized that it was going to require lot more effort to
create the patch. If I had the time, I would have created the patch
for
you. July is not the most productive time for me. The schools are off
and I must attend to other children's activities. IMO, the fastest way
to get this working will be for you to add the code from the
m2-plugins.patch to your code. If you need the java files, I will be
happy to upload them.
I have been reviewing that patch and have started to incorporate the
parts which I believe are relevant. I saw you added comments about
the use-case to a JIRA which I will also review.
Once again I will request you to use ${j2eeJettyServer} etc for
deploymentConfig. If it was up to me I would choose ease of use over
Maven's preferred ways. This plugin is used by many users who
really do
not care to know about the deployers let alone their ordering. As far
as they are concerned they want to specify which custom server they
are
packaging for. As we provide more custom servers we will be adding new
properties.
If it was up to me, I'd remove the need for these plugins altogether
and deploy xml directly to the server and hide all of this the CAR
non-sense from our users.
Anyways, I disagree that in the previous ${...} state that users
don't have to worry about the ordering... since they need to get that
property from somewhere. In either case, something is going to get
copy-pasted. If it really turns out to be a huge user burden then I
would rather investigate a cleaner way to handle this configuration
which hides more of the complexity from users.
--jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
This is just how m2 works... I agree it kinda blows... but bring it up with the Maven guys, nothing we can do about it at the moment. The release plugin takes the pain out of having to update every pom's parent version number... er well it makes it less painful really, but its manageable pain. Else any decent search-replace'ing editor can do the bulk of the dirty work. But I'd use the release plugin when you can. --jason On Jul 25, 2006, at 10:50 AM, Aaron Mulder wrote: One comment for later (post-merge)... It would be great if we could avoid putting the Geronimo version number in every POM in every directory throughout the project (in the element). I gather there's a chicken-and-egg problem here (how do you find the parent using the version if the parent defines the version), but if there was any workaround (trust the relativePath over the group/artifact/version?), it would be really helpful for the process of updating a particular location (trunk/branch/tag) to a new version number. Thanks, Aaron On 7/23/06, Jason Dillon <[EMAIL PROTECTED]> wrote: Please see this issue for details: http://issues.apache.org/jira/browse/GERONIMO-2219 * * * I hope to be able to merge this work to trunk in a week or so, so please, please, please take some time to review the branch and vote (PMC or not). --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
One comment for later (post-merge)... It would be great if we could avoid putting the Geronimo version number in every POM in every directory throughout the project (in the element). I gather there's a chicken-and-egg problem here (how do you find the parent using the version if the parent defines the version), but if there was any workaround (trust the relativePath over the group/artifact/version?), it would be really helpful for the process of updating a particular location (trunk/branch/tag) to a new version number. Thanks, Aaron On 7/23/06, Jason Dillon <[EMAIL PROTECTED]> wrote: Please see this issue for details: http://issues.apache.org/jira/browse/GERONIMO-2219 * * * I hope to be able to merge this work to trunk in a week or so, so please, please, please take some time to review the branch and vote (PMC or not). --jason
Re: Re: [RTC] Merge m2migration (functional m2 build) to trunk
--- Jason Dillon <[EMAIL PROTECTED]> wrote:
> Can you please give me a patch that fixes the problems (without
> System.out.*) based on the m2migration branch? I've asked you a few
> times... so for I get a lot of mail like this one... but no patches.
Jason,
you aksed me on to make a patch for the branch on July 10th. I
looked at the code and saw that you made the following changes to the
packaging plugin:
1. Renamed the plugin
2. Changed the package structure
3. Changed the directory layout to standard M2 layout, even though the
rest of the project and the geronimo-deployment _plugin_ still use the
old layout!
4. Used non geronimo coding style.
In the past subjective changes like this were discussed on the list
so people can provide their input.
5. Removed plexus component.xml (you have reverted this change now)
I quickly realized that it was going to require lot more effort to
create the patch. If I had the time, I would have created the patch for
you. July is not the most productive time for me. The schools are off
and I must attend to other children's activities. IMO, the fastest way
to get this working will be for you to add the code from the
m2-plugins.patch to your code. If you need the java files, I will be
happy to upload them.
Once again I will request you to use ${j2eeJettyServer} etc for
deploymentConfig. If it was up to me I would choose ease of use over
Maven's preferred ways. This plugin is used by many users who really do
not care to know about the deployers let alone their ordering. As far
as they are concerned they want to specify which custom server they are
packaging for. As we provide more custom servers we will be adding new
properties.
Thanks
Anita
>
>
> > Jason,
> > All this functionality and more was available in the packaging
> > plugin on the trunk.
> --jason
>
__
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Here is my 2c. I tested the build out tonight and was able to get a runnable server. IMHO this change is way too complicated for a patch and is taking far too long (no offense to anyone working on the conversion but more of a comment on our current process). I'm inclined to +1 the work Jason has done and move this to trunk. Then we all work through the issues. Jason and others have been very diligent in working on this conversion (which is in several months now I think). Based on the responsiveness of Jason, Prasad and Anita I don't see a tremendopus amount of harm in doing the merge and getting this done in trunk. Its not ideal but one doesn't rework the entire build system every release. I propose we +1 it...suck it up...and work with Jason to get this done. It will be painful for everyone but I think right now Jason, Prasad and Anita are suffering way too much. This isn't a server feature...this is a build system. Its bigger than a bread box. We all know what we're doing and its time to get this done. Matt Jason Dillon wrote: Please see this issue for details: http://issues.apache.org/jira/browse/GERONIMO-2219 * * * I hope to be able to merge this work to trunk in a week or so, so please, please, please take some time to review the branch and vote (PMC or not). --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Jason Dillon wrote: > > But, I don't feel that it is wise to simply drop in a note for the last > word, or to leave a comment that could be misinterpreted go > unchallenged, as those situations tend to bread common (mis)conceptions > of a situation which is not necessarily the accurate reality. > > I believe we all need to work more on own communication skills... > including myself. > I appreciate your response and thanks for acknowledging that we all need a little tweak on the communication skillset. Thanks, Jeff > --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Jason Dillon wrote: If things start to frustrate you...chat about them or walk away from the terminal after typing up a nasty message...hitting delete before send. I have yet to send any message that I believe to have been nasty in nature. Jason, that was a tip for when you feel like saying something nasty. I am not, nor have I said anything you type up is nasty. Lets not beat a dead horse here and turn this into something its not. I understand; I was just being clear that I had not been nasty... which one could derive from your response, not that you mean that I was. Jason, I can probably come up with a minimum of 10 emails from you within the last week or so that are either caustic, sarcastic, or expressing very opinionated views that are somewhat a waste of space on these lists. Ic... so you respond to my caustic or opinionated view with your caustic or opinionated view... don't see how that helps. Expressing your extreme disdain for Windows or responding to someone who is trying to communicate with you with "whatever" is not a way to build and forge good feelings among friends on these lists. How would you respond to someone who is berating you over and over with the same statements and not actively trying to resolve the issue as suggested by working a patch out? Seems like my constructive requests for patches or more specifics are going unanswered... so "whatever..." I give up on trying. I would bet that if you changed your tune on how you interact with people, you may find that your frustrations will dissipate. My tune has only recently been starting to change because of the failed efforts of my previous tune which was to try and be patient and constructive and direct... granted I might not have been the most effective at it, but I am and will keep trying to do that... up to a point. You chimed commenting about several emails after I had reached that threshold. I am not convinced that there is one set, desired and effective way to communicate here. If you feel that my last email was not attempting to help in an amicable way, then my apologies...I need to work on my communication skills. I will not waste my time or yours further on this issue. I suggest we let this go at this time as its going nowhere fast :( I do (and did) understand that was the point of your email... and my response was only to clarify to instigate, but based on your response I see that you might have misinterpreted what I said. This is in fact the krux of our problems with emails... it is entirely to easy to misinterpret, misunderstand or misjudge based solely on textual representations. But, I don't feel that it is wise to simply drop in a note for the last word, or to leave a comment that could be misinterpreted go unchallenged, as those situations tend to bread common (mis) conceptions of a situation which is not necessarily the accurate reality. I believe we all need to work more on own communication skills... including myself. --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Jason Dillon wrote: >> If things start to frustrate you...chat about them or walk away from the >> terminal after typing up a nasty message...hitting delete before send. > > I have yet to send any message that I believe to have been nasty in nature. > Jason, that was a tip for when you feel like saying something nasty. I am not, nor have I said anything you type up is nasty. Lets not beat a dead horse here and turn this into something its not. > >> You would be surprised how different what pours out of your fingers >> changes after the heat has subsided. But please, try not to get >> sarcastic...it is something that gets grating after a while. It's a lot >> easier to be direct in what you are asking as you will get a lot better >> response. > > Oddly enough that is what the email you commented upon did... was direct. > Jason, I can probably come up with a minimum of 10 emails from you within the last week or so that are either caustic, sarcastic, or expressing very opinionated views that are somewhat a waste of space on these lists. Expressing your extreme disdain for Windows or responding to someone who is trying to communicate with you with "whatever" is not a way to build and forge good feelings among friends on these lists. I would bet that if you changed your tune on how you interact with people, you may find that your frustrations will dissipate. If you feel that my last email was not attempting to help in an amicable way, then my apologies...I need to work on my communication skills. I will not waste my time or yours further on this issue. I suggest we let this go at this time as its going nowhere fast :( > --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
If things start to frustrate you...chat about them or walk away from the terminal after typing up a nasty message...hitting delete before send. I have yet to send any message that I believe to have been nasty in nature. You would be surprised how different what pours out of your fingers changes after the heat has subsided. But please, try not to get sarcastic...it is something that gets grating after a while. It's a lot easier to be direct in what you are asking as you will get a lot better response. Oddly enough that is what the email you commented upon did... was direct. --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
I was also wondering the same. I saw a lot of issues created for the configs that were working in the trunk! Because Jason decided to rearrange and reorganize the packagin plugin code, things started failing. It is a good thing to experiment, but I think creating issues was unnecessary. Whatever --jason
Re: Re: [RTC] Merge m2migration (functional m2 build) to trunk
Can you please give me a patch that fixes the problems (without System.out.*) based on the m2migration branch? I've asked you a few times... so for I get a lot of mail like this one... but no patches. Jason, All this functionality and more was available in the packaging plugin on the trunk. But you decided to pick bits and pieces of it. I Lets be clear... I did not pick bits and pieces. I merged the two plugins, reduced code duplication, fixed exception handling, used logging for output and fixed up several other problems with the Mojo impls. I did not pick bits and pieces... If something is missing, then please provide a patch to m2migration. have looked at the past mails and it appears that you have been redoing all the work! I have been applying patches to m2migration. What other "redoing" of the work are you referring to? All you needed to do was add explicit-version properties enhancement and the fix for classPath bug. Anita, there were many changes that I made which were done to reduce code, improve debugging and make better use the the Mojo plugin system. I suggest you study the code and try to understand some of the reasons why I made changes. If you have *specific questions* to code blocks that changed I'd be more than happy to answer them. I would prefer that packaging plugin not have o.a.g.genesis.config:project-config as its parent. Any *specific* reason why you have this preference? The plugins do not have o.a.g.genesis.config:project-config as their parent anyways. Yes the parent of the plugins parent's parent has that for a parent (ie. our root pom has that for a parent). o.a.g.genesis.config:project-config defines common build elements that are shared across most/all Geronimo projects. Do you have any *specific* concerns or objections? Please iterate them and we can discus. --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Jason, I understand you are frustrated. First, let's make clear that we have people who develop from multiple countries with multiple languages, and sometimes we need to do what we can to communicate with each other...and it's not always as smooth as we hope. Even for us who all have the same native language, we misunderstand each other all the time...especially as of late. Email can be a frustrating conduit for communication, so I think its extra important that we talk to one and another with a bit more concern for how things come off. Clearly I am a huge violator in this department ;-) If things start to frustrate you...chat about them or walk away from the terminal after typing up a nasty message...hitting delete before send. You would be surprised how different what pours out of your fingers changes after the heat has subsided. But please, try not to get sarcastic...it is something that gets grating after a while. It's a lot easier to be direct in what you are asking as you will get a lot better response. Thanks, Jeff Jason Dillon wrote: > I have tried to be constructive... but I can only go so far until I > start to shutdown... > > So far I've responded to Jacek several times about creating an issue. > The first was a response to a question if he should create an issue, > and I said yes. So after several more emails still talking about no > issue and me responding with affirmation to create one... I really > don't have much more patience nor do I really know to best and > constructively respond to a situation like that. > > And I really, really don't see how else I could have possibly > responded to his statement in any other constructive manner, about not > understanding my query after I had though that I really, clearly > stated exactly what I was asking. > > --jason > > > On 7/24/06, Jeff Genender <[EMAIL PROTECTED]> wrote: >> Jason, >> >> Do you think you could answer your peers a little bit more >> constructively? Your answers to people are a bit caustic and it is not >> helping promote a healthy environment. Is there something that we can >> help with to aid in a more amicable interaction with your peers? >> >> Jeff >> >> Jason Dillon wrote: >> >> I don't understand why it hasn't been reported in JIRA? An issue is >> >> not known unless it's reported in JIRA where people (like me) can >> >> notice it. I don't think the community follows each and every thread >> >> that's in dev@, so how could they know about it? >> > >> > So, for the 3rd time... file an issue. >> > >> > >> >>> Really don't understand why we have to bounce back and forth for >> >>> several days to get something done. For example, I asked you for the >> >>> "length path" you ran under... and instead of actually giving me the >> >>> path which I asked for you, you give some explanation of why you were >> >>> in the lengthy past which I did not even ask for. >> >> >> >> I'm sounding as repeating myself, but as I didn't get the point I >> >> didn't respond as you requested. I believe the answer above is >> >> sufficient. As you wished ;-) >> > >> > How else would one answer the question "What is the lengthy path you >> ran >> > under?" except with the exact *lengthy path*? >> > >> > --jason >>
Re: Re: [RTC] Merge m2migration (functional m2 build) to trunk
--- Jacek Laskowski <[EMAIL PROTECTED]> wrote: > On 7/25/06, Jason Dillon <[EMAIL PROTECTED]> wrote: > > > > And honestly I still don't know what I should include in the jira > issue. Sorry. I'm trying to grasp it, but...hey it's not an issue! > ;-) > It's in the m2migration branch, so how could I report an issue when > it's a forked development area? It's under development and it needs > to > be fixed with no official statements. If I were to report each and > every issue in a branch, jira would quickly get out of sync with > reality. Am I correct? I was also wondering the same. I saw a lot of issues created for the configs that were working in the trunk! Because Jason decided to rearrange and reorganize the packagin plugin code, things started failing. It is a good thing to experiment, but I think creating issues was unnecessary. Thanks Anita > > Jacek > > -- > Jacek Laskowski > http://www.laskowski.net.pl > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: Re: Re: [RTC] Merge m2migration (functional m2 build) to trunk
And honestly I still don't know what I should include in the jira issue. Sorry. I'm trying to grasp it, but...hey it's not an issue! ;-) Kay... well I did not mean to imply that it was a known JIRA issue... just that (at the very least) Prasad and I are aware of the problem and need to figure out how to fix it. It's in the m2migration branch, so how could I report an issue when it's a forked development area? It's under development and it needs to be fixed with no official statements. If I were to report each and every issue in a branch, jira would quickly get out of sync with reality. Am I correct? Well, now we are back into a semantic argument... And based on your comment, then we would not make a JIRA for it until the merge was done to trunk... but you are commenting on the problem in a RTC to do that merge (which is fine) and then asking where the JIRA is... I feel dizzy. It was my recommendation (as well as others) to just do this work on trunk as it would have eased the entire process and we'd be done already. But the PMC did not bless that recommendation, so we are stuck on a branch... and well, until the PMC gets things together it will stay there. IMO JIRA should be used to track issues... regardless of what branch it is on. But, Jacek, you gotta keep in mind that the m2migration branch is not a typical development branch, but a work around due to the lack of PMC support to apply these changes directly to the trunk as recommended. --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Aaron Mulder wrote: > On 7/24/06, Jeff Genender <[EMAIL PROTECTED]> wrote: >> Do you think you could answer your peers a little bit more >> constructively? Your answers to people are a bit caustic and it is not >> helping promote a healthy environment. Is there something that we can >> help with to aid in a more amicable interaction with your peers? > > Give me a break! I find talking down to someone like this far more > offensive than Jason's messages on this thread. > > It's clear Jason is frustrated. That's OK, it happens to the best of > us every now and then. I think your response is totally > inappropriate. If anything, perhaps, take a break and let's take this > up again tomorrow. Or yell at me for baiting him if you like. But > don't talk down to him -- after all, "he's your peer". :) > It would appear you have read tone or something communicative that was not in my intended message to Jason. Talking down was certainly not my intention. It was truly an offer of help or at least to gage what we can do to communicate better with each other. I am sorry you read this differently than its intention. However, I think that the way you are addressing your concern can probably use a bit of work too, Aaron. ;-) > Thanks, > Aaron > >> Jason Dillon wrote: >> >> I don't understand why it hasn't been reported in JIRA? An issue is >> >> not known unless it's reported in JIRA where people (like me) can >> >> notice it. I don't think the community follows each and every thread >> >> that's in dev@, so how could they know about it? >> > >> > So, for the 3rd time... file an issue. >> > >> > >> >>> Really don't understand why we have to bounce back and forth for >> >>> several days to get something done. For example, I asked you for the >> >>> "length path" you ran under... and instead of actually giving me the >> >>> path which I asked for you, you give some explanation of why you were >> >>> in the lengthy past which I did not even ask for. >> >> >> >> I'm sounding as repeating myself, but as I didn't get the point I >> >> didn't respond as you requested. I believe the answer above is >> >> sufficient. As you wished ;-) >> > >> > How else would one answer the question "What is the lengthy path you >> ran >> > under?" except with the exact *lengthy path*? >> > >> > --jason >>
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Jason, All this functionality and more was available in the packaging plugin on the trunk. But you decided to pick bits and pieces of it. I have looked at the past mails and it appears that you have been redoing all the work! All you needed to do was add explicit-version properties enhancement and the fix for classPath bug. I would prefer that packaging plugin not have o.a.g.genesis.config:project-config as its parent. Thanks Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: > Easy enough to fix. > > This is why I want to make this "the preferred build" so that > everyone uses it and find theses issues. > > In this case "src/conf/geronimo-plugin.xml" just needs to get > included as "META-INF/geronimo-plugin.xml" in the CAR? > > --jason > > > On Jul 24, 2006, at 2:39 PM, Aaron Mulder wrote: > > > -1 to making this "the preferred build" -- we've lost the > > functionality to build plugins as part of the build. > > > > For example, see configs/welcome-jetty/src/conf/geronimo-plugin.xml > > > > Then look at configs/welcome-jetty/target/welcome-jetty-1.2- > > SNAPSHOT.car > > and note that it doesn't have an entry for > > META-INF/geronimo-plugin.xml (whereas > > ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car does have > it). > > > > I was tipped off by Prasad's comment on another thread that the > > geronimoPlugin option to the Maven car plugin is ignored. > > > > In the M1 packaging plugin, we attached a pre or post hook to copy > the > > plugin metadata file into the exploded CAR directory before zipping > it > > into the Maven repository. I suspect that's not the appropriate > > approach for Maven 2, but we need something. > > > > Thanks, > >Aaron > > > > On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: > >> FYI, I just created a new RTC for Genesis: > >> > >> http://issues.apache.org/jira/browse/GERONIMO-2223 > >> > >> --jason > >> > >> > >> On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: > >> > >> > Hi Jason, > >> > My family was visiting. I have been busy and in and out of > >> town. I > >> > am catching up on my mail and apologize for not responding to > >> all the > >> > mail promptly. > >> > > >> > I looked at the code and saw this in the top level pom : > >> > > >> > org.apache.geronimo.genesis.config > >> > project-config > >> > 1.0.0-SNAPSHOT > >> > > >> > Since this project is not in the code being reviewed, I > >> commented it > >> > out and ran one 'simple mvn install' from the top directory! And > > >> you > >> > know what happened... > >> > > >> > If I am a windows user who does not care to install cygwin, I > >> had to > >> > type the following : > >> > mvn -Dstage=bootstrap > >> > cd openejb2 > >> > mvn -Dmaven.test.skip=true install > >> > cd .. > >> > mvn -Dstage=assemble > >> > This looked very familiar.. > >> > > >> > I tried to see where o.a.g.genesis.config was being built. I > found > >> > that > >> > the genesis branch has been built and published to a repo. The > code > >> > under review will not work without building the code in genesis. > > >> Could > >> > you please tell us which repo the artifacts built by genesis > >> have been > >> > published to? > >> >I am still going through the code and will provide more > >> feedback, > >> > even though it does not carry any weight. > >> > > >> > Cheers > >> > Anita > >> > > >> > --- Jason Dillon <[EMAIL PROTECTED]> wrote: > >> > > >> >> Please see this issue for details: > >> >> > >> >> http://issues.apache.org/jira/browse/GERONIMO-2219 > >> >> > >> >> * * * > >> >> > >> >> I hope to be able to merge this work to trunk in a week or so, > so > >> >> please, please, please take some time to review the branch and > > >> vote > >> >> (PMC or not). > >> >> > >> >> --jason > >> >> > >> > > >> > > >> > __ > >> > Do You Yahoo!? > >> > Tired of spam? Yahoo! Mail has the best spam protection around > >> > http://mail.yahoo.com > >> > >> > > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/25/06, Jason Dillon <[EMAIL PROTECTED]> wrote: So far I've responded to Jacek several times about creating an issue. The first was a response to a question if he should create an issue, and I said yes. So after several more emails still talking about no issue and me responding with affirmation to create one... I really don't have much more patience nor do I really know to best and constructively respond to a situation like that. And I really, really don't see how else I could have possibly responded to his statement in any other constructive manner, about not understanding my query after I had though that I really, clearly stated exactly what I was asking. And honestly I still don't know what I should include in the jira issue. Sorry. I'm trying to grasp it, but...hey it's not an issue! ;-) It's in the m2migration branch, so how could I report an issue when it's a forked development area? It's under development and it needs to be fixed with no official statements. If I were to report each and every issue in a branch, jira would quickly get out of sync with reality. Am I correct? Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: Re: [RTC] Merge m2migration (functional m2 build) to trunk
I have tried to be constructive... but I can only go so far until I start to shutdown... So far I've responded to Jacek several times about creating an issue. The first was a response to a question if he should create an issue, and I said yes. So after several more emails still talking about no issue and me responding with affirmation to create one... I really don't have much more patience nor do I really know to best and constructively respond to a situation like that. And I really, really don't see how else I could have possibly responded to his statement in any other constructive manner, about not understanding my query after I had though that I really, clearly stated exactly what I was asking. --jason On 7/24/06, Jeff Genender <[EMAIL PROTECTED]> wrote: Jason, Do you think you could answer your peers a little bit more constructively? Your answers to people are a bit caustic and it is not helping promote a healthy environment. Is there something that we can help with to aid in a more amicable interaction with your peers? Jeff Jason Dillon wrote: >> I don't understand why it hasn't been reported in JIRA? An issue is >> not known unless it's reported in JIRA where people (like me) can >> notice it. I don't think the community follows each and every thread >> that's in dev@, so how could they know about it? > > So, for the 3rd time... file an issue. > > >>> Really don't understand why we have to bounce back and forth for >>> several days to get something done. For example, I asked you for the >>> "length path" you ran under... and instead of actually giving me the >>> path which I asked for you, you give some explanation of why you were >>> in the lengthy past which I did not even ask for. >> >> I'm sounding as repeating myself, but as I didn't get the point I >> didn't respond as you requested. I believe the answer above is >> sufficient. As you wished ;-) > > How else would one answer the question "What is the lengthy path you ran > under?" except with the exact *lengthy path*? > > --jason
Re: Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jeff Genender <[EMAIL PROTECTED]> wrote: Do you think you could answer your peers a little bit more constructively? Your answers to people are a bit caustic and it is not helping promote a healthy environment. Is there something that we can help with to aid in a more amicable interaction with your peers? Give me a break! I find talking down to someone like this far more offensive than Jason's messages on this thread. It's clear Jason is frustrated. That's OK, it happens to the best of us every now and then. I think your response is totally inappropriate. If anything, perhaps, take a break and let's take this up again tomorrow. Or yell at me for baiting him if you like. But don't talk down to him -- after all, "he's your peer". :) Thanks, Aaron Jason Dillon wrote: >> I don't understand why it hasn't been reported in JIRA? An issue is >> not known unless it's reported in JIRA where people (like me) can >> notice it. I don't think the community follows each and every thread >> that's in dev@, so how could they know about it? > > So, for the 3rd time... file an issue. > > >>> Really don't understand why we have to bounce back and forth for >>> several days to get something done. For example, I asked you for the >>> "length path" you ran under... and instead of actually giving me the >>> path which I asked for you, you give some explanation of why you were >>> in the lengthy past which I did not even ask for. >> >> I'm sounding as repeating myself, but as I didn't get the point I >> didn't respond as you requested. I believe the answer above is >> sufficient. As you wished ;-) > > How else would one answer the question "What is the lengthy path you ran > under?" except with the exact *lengthy path*? > > --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Jason, Do you think you could answer your peers a little bit more constructively? Your answers to people are a bit caustic and it is not helping promote a healthy environment. Is there something that we can help with to aid in a more amicable interaction with your peers? Jeff Jason Dillon wrote: >> I don't understand why it hasn't been reported in JIRA? An issue is >> not known unless it's reported in JIRA where people (like me) can >> notice it. I don't think the community follows each and every thread >> that's in dev@, so how could they know about it? > > So, for the 3rd time... file an issue. > > >>> Really don't understand why we have to bounce back and forth for >>> several days to get something done. For example, I asked you for the >>> "length path" you ran under... and instead of actually giving me the >>> path which I asked for you, you give some explanation of why you were >>> in the lengthy past which I did not even ask for. >> >> I'm sounding as repeating myself, but as I didn't get the point I >> didn't respond as you requested. I believe the answer above is >> sufficient. As you wished ;-) > > How else would one answer the question "What is the lengthy path you ran > under?" except with the exact *lengthy path*? > > --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
I don't understand why it hasn't been reported in JIRA? An issue is not known unless it's reported in JIRA where people (like me) can notice it. I don't think the community follows each and every thread that's in dev@, so how could they know about it? So, for the 3rd time... file an issue. Really don't understand why we have to bounce back and forth for several days to get something done. For example, I asked you for the "length path" you ran under... and instead of actually giving me the path which I asked for you, you give some explanation of why you were in the lengthy past which I did not even ask for. I'm sounding as repeating myself, but as I didn't get the point I didn't respond as you requested. I believe the answer above is sufficient. As you wished ;-) How else would one answer the question "What is the lengthy path you ran under?" except with the exact *lengthy path*? --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Hey... well... why don't you go any comment out the import statements in the java sources and try to compile and then send mail to the list asking for why it doesn't work after you commented them out? This is the exact same situation, except not with java files but maven 2 files. If you knew java you would know that you need the imports. Same is true here, that you need to include the parent. I do expect that people who are working on the buildsystem to understand how the underlying tools, this case maven2, work. --jason On Jul 24, 2006, at 3:16 PM, Jacek Laskowski wrote: On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: Do not comment that out. PERIOD. I appreciate your efforts in m2 conversion, but don't expect that the above very short and cryptic answer will suit our needs. Could you please elaborate more why it must not be commented out? (I think 'must' conveys the true meaning of the above sentence not 'should', right?) Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: Do not comment that out. PERIOD. I appreciate your efforts in m2 conversion, but don't expect that the above very short and cryptic answer will suit our needs. Could you please elaborate more why it must not be commented out? (I think 'must' conveys the true meaning of the above sentence not 'should', right?) Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: That is fine... but what was the path? Specifically, please post the exact pathname you ran under for reference. /cygdrive/c/oss/m2migration/m2-assemblies/geronimo-jetty-j2ee/target/geronimo-jetty-j2ee $^%&! Its a known issue with the m2 assemblies. I've sent mail to the dev@ list a few times about this and ping'd folks on IRC on it too. We are aware of the issue, thus it is known. Just no one cares enough to respond to half the emails on the dev@ list so it has gone no where. I don't understand why it hasn't been reported in JIRA? An issue is not known unless it's reported in JIRA where people (like me) can notice it. I don't think the community follows each and every thread that's in dev@, so how could they know about it? I already said please create an issue for this... Not sure why you had to go waste time verifying it on m1, as I am sure it works there and I am sure that it is a problem with the m2 build. Well, it's because I couldn't get the point. It's likely me, but the time has not been wasted. Now, we can talk about it and call it a known issue ;-) Really don't understand why we have to bounce back and forth for several days to get something done. For example, I asked you for the "length path" you ran under... and instead of actually giving me the path which I asked for you, you give some explanation of why you were in the lengthy past which I did not even ask for. I'm sounding as repeating myself, but as I didn't get the point I didn't respond as you requested. I believe the answer above is sufficient. As you wished ;-) Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: Fine... you know I don't really care what you guys want to think of as preferred or not. I just want to get this committed to trunk... and arguing over semantics of preferred or not is just going to slow down the already incredibly painful process that we have set ourselves up to sleep in. But Jason, you just haven't seen the light! This is not slow and painful, this is how we share our knowledge and really get the community involved with the project! No more threats! No more surprises! I think of it as... "newcode". Thanks, Aaron On Jul 24, 2006, at 2:45 PM, Jeff Genender wrote: > I am going to agree with Aaron here. > > Jeff > > Aaron Mulder wrote: >> -1 to making this "the preferred build" -- we've lost the >> functionality to build plugins as part of the build. >> >> For example, see configs/welcome-jetty/src/conf/geronimo-plugin.xml >> >> Then look at configs/welcome-jetty/target/welcome-jetty-1.2- >> SNAPSHOT.car >> and note that it doesn't have an entry for >> META-INF/geronimo-plugin.xml (whereas >> ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car does have >> it). >> >> I was tipped off by Prasad's comment on another thread that the >> geronimoPlugin option to the Maven car plugin is ignored. >> >> In the M1 packaging plugin, we attached a pre or post hook to copy >> the >> plugin metadata file into the exploded CAR directory before >> zipping it >> into the Maven repository. I suspect that's not the appropriate >> approach for Maven 2, but we need something. >> >> Thanks, >>Aaron >> >> On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: >>> FYI, I just created a new RTC for Genesis: >>> >>> http://issues.apache.org/jira/browse/GERONIMO-2223 >>> >>> --jason >>> >>> >>> On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: >>> Hi Jason, My family was visiting. I have been busy and in and out of town. I am catching up on my mail and apologize for not responding to all the mail promptly. I looked at the code and saw this in the top level pom : org.apache.geronimo.genesis.config project-config 1.0.0-SNAPSHOT Since this project is not in the code being reviewed, I commented it out and ran one 'simple mvn install' from the top directory! And you know what happened... If I am a windows user who does not care to install cygwin, I had to type the following : mvn -Dstage=bootstrap cd openejb2 mvn -Dmaven.test.skip=true install cd .. mvn -Dstage=assemble This looked very familiar.. I tried to see where o.a.g.genesis.config was being built. I found that the genesis branch has been built and published to a repo. The code under review will not work without building the code in genesis. Could you please tell us which repo the artifacts built by genesis have been published to? I am still going through the code and will provide more feedback, even though it does not carry any weight. Cheers Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: > Please see this issue for details: > > http://issues.apache.org/jira/browse/GERONIMO-2219 > > * * * > > I hope to be able to merge this work to trunk in a week or so, so > please, please, please take some time to review the branch and > vote > (PMC or not). > > --jason > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com >>> >>>
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Fine... you know I don't really care what you guys want to think of as preferred or not. I just want to get this committed to trunk... and arguing over semantics of preferred or not is just going to slow down the already incredibly painful process that we have set ourselves up to sleep in. --jason On Jul 24, 2006, at 2:45 PM, Jeff Genender wrote: I am going to agree with Aaron here. Jeff Aaron Mulder wrote: -1 to making this "the preferred build" -- we've lost the functionality to build plugins as part of the build. For example, see configs/welcome-jetty/src/conf/geronimo-plugin.xml Then look at configs/welcome-jetty/target/welcome-jetty-1.2- SNAPSHOT.car and note that it doesn't have an entry for META-INF/geronimo-plugin.xml (whereas ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car does have it). I was tipped off by Prasad's comment on another thread that the geronimoPlugin option to the Maven car plugin is ignored. In the M1 packaging plugin, we attached a pre or post hook to copy the plugin metadata file into the exploded CAR directory before zipping it into the Maven repository. I suspect that's not the appropriate approach for Maven 2, but we need something. Thanks, Aaron On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: FYI, I just created a new RTC for Genesis: http://issues.apache.org/jira/browse/GERONIMO-2223 --jason On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: Hi Jason, My family was visiting. I have been busy and in and out of town. I am catching up on my mail and apologize for not responding to all the mail promptly. I looked at the code and saw this in the top level pom : org.apache.geronimo.genesis.config project-config 1.0.0-SNAPSHOT Since this project is not in the code being reviewed, I commented it out and ran one 'simple mvn install' from the top directory! And you know what happened... If I am a windows user who does not care to install cygwin, I had to type the following : mvn -Dstage=bootstrap cd openejb2 mvn -Dmaven.test.skip=true install cd .. mvn -Dstage=assemble This looked very familiar.. I tried to see where o.a.g.genesis.config was being built. I found that the genesis branch has been built and published to a repo. The code under review will not work without building the code in genesis. Could you please tell us which repo the artifacts built by genesis have been published to? I am still going through the code and will provide more feedback, even though it does not carry any weight. Cheers Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: Please see this issue for details: http://issues.apache.org/jira/browse/GERONIMO-2219 * * * I hope to be able to merge this work to trunk in a week or so, so please, please, please take some time to review the branch and vote (PMC or not). --jason __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: This is why I want to make this "the preferred build" so that everyone uses it and find theses issues. Oh, I thought that's why you wanted everyone to test it before it becomes the preferred build. :) In this case "src/conf/geronimo-plugin.xml" just needs to get included as "META-INF/geronimo-plugin.xml" in the CAR? Yes, and it needs variable substitution for the current module's group/artifact/version/type. If it turns out to be hard to get this file in as part of the CAR-building process, we can slam it in the CAR after it's built if necessary -- it just has to get in there somehow. (I'm also not wedded to src/conf as the preferred location, but whatever.) Thanks, Aaron On Jul 24, 2006, at 2:39 PM, Aaron Mulder wrote: > -1 to making this "the preferred build" -- we've lost the > functionality to build plugins as part of the build. > > For example, see configs/welcome-jetty/src/conf/geronimo-plugin.xml > > Then look at configs/welcome-jetty/target/welcome-jetty-1.2- > SNAPSHOT.car > and note that it doesn't have an entry for > META-INF/geronimo-plugin.xml (whereas > ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car does have it). > > I was tipped off by Prasad's comment on another thread that the > geronimoPlugin option to the Maven car plugin is ignored. > > In the M1 packaging plugin, we attached a pre or post hook to copy the > plugin metadata file into the exploded CAR directory before zipping it > into the Maven repository. I suspect that's not the appropriate > approach for Maven 2, but we need something. > > Thanks, >Aaron > > On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: >> FYI, I just created a new RTC for Genesis: >> >> http://issues.apache.org/jira/browse/GERONIMO-2223 >> >> --jason >> >> >> On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: >> >> > Hi Jason, >> > My family was visiting. I have been busy and in and out of >> town. I >> > am catching up on my mail and apologize for not responding to >> all the >> > mail promptly. >> > >> > I looked at the code and saw this in the top level pom : >> > >> > org.apache.geronimo.genesis.config >> > project-config >> > 1.0.0-SNAPSHOT >> > >> > Since this project is not in the code being reviewed, I >> commented it >> > out and ran one 'simple mvn install' from the top directory! And >> you >> > know what happened... >> > >> > If I am a windows user who does not care to install cygwin, I >> had to >> > type the following : >> > mvn -Dstage=bootstrap >> > cd openejb2 >> > mvn -Dmaven.test.skip=true install >> > cd .. >> > mvn -Dstage=assemble >> > This looked very familiar.. >> > >> > I tried to see where o.a.g.genesis.config was being built. I found >> > that >> > the genesis branch has been built and published to a repo. The code >> > under review will not work without building the code in genesis. >> Could >> > you please tell us which repo the artifacts built by genesis >> have been >> > published to? >> >I am still going through the code and will provide more >> feedback, >> > even though it does not carry any weight. >> > >> > Cheers >> > Anita >> > >> > --- Jason Dillon <[EMAIL PROTECTED]> wrote: >> > >> >> Please see this issue for details: >> >> >> >> http://issues.apache.org/jira/browse/GERONIMO-2219 >> >> >> >> * * * >> >> >> >> I hope to be able to merge this work to trunk in a week or so, so >> >> please, please, please take some time to review the branch and >> vote >> >> (PMC or not). >> >> >> >> --jason >> >> >> > >> > >> > __ >> > Do You Yahoo!? >> > Tired of spam? Yahoo! Mail has the best spam protection around >> > http://mail.yahoo.com >> >>
Re: [RTC] Merge m2migration (functional m2 build) to trunk
I am going to agree with Aaron here. Jeff Aaron Mulder wrote: > -1 to making this "the preferred build" -- we've lost the > functionality to build plugins as part of the build. > > For example, see configs/welcome-jetty/src/conf/geronimo-plugin.xml > > Then look at configs/welcome-jetty/target/welcome-jetty-1.2-SNAPSHOT.car > and note that it doesn't have an entry for > META-INF/geronimo-plugin.xml (whereas > ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car does have it). > > I was tipped off by Prasad's comment on another thread that the > geronimoPlugin option to the Maven car plugin is ignored. > > In the M1 packaging plugin, we attached a pre or post hook to copy the > plugin metadata file into the exploded CAR directory before zipping it > into the Maven repository. I suspect that's not the appropriate > approach for Maven 2, but we need something. > > Thanks, >Aaron > > On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: >> FYI, I just created a new RTC for Genesis: >> >> http://issues.apache.org/jira/browse/GERONIMO-2223 >> >> --jason >> >> >> On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: >> >> > Hi Jason, >> > My family was visiting. I have been busy and in and out of town. I >> > am catching up on my mail and apologize for not responding to all the >> > mail promptly. >> > >> > I looked at the code and saw this in the top level pom : >> > >> > org.apache.geronimo.genesis.config >> > project-config >> > 1.0.0-SNAPSHOT >> > >> > Since this project is not in the code being reviewed, I commented it >> > out and ran one 'simple mvn install' from the top directory! And you >> > know what happened... >> > >> > If I am a windows user who does not care to install cygwin, I had to >> > type the following : >> > mvn -Dstage=bootstrap >> > cd openejb2 >> > mvn -Dmaven.test.skip=true install >> > cd .. >> > mvn -Dstage=assemble >> > This looked very familiar.. >> > >> > I tried to see where o.a.g.genesis.config was being built. I found >> > that >> > the genesis branch has been built and published to a repo. The code >> > under review will not work without building the code in genesis. Could >> > you please tell us which repo the artifacts built by genesis have been >> > published to? >> >I am still going through the code and will provide more feedback, >> > even though it does not carry any weight. >> > >> > Cheers >> > Anita >> > >> > --- Jason Dillon <[EMAIL PROTECTED]> wrote: >> > >> >> Please see this issue for details: >> >> >> >> http://issues.apache.org/jira/browse/GERONIMO-2219 >> >> >> >> * * * >> >> >> >> I hope to be able to merge this work to trunk in a week or so, so >> >> please, please, please take some time to review the branch and vote >> >> (PMC or not). >> >> >> >> --jason >> >> >> > >> > >> > __ >> > Do You Yahoo!? >> > Tired of spam? Yahoo! Mail has the best spam protection around >> > http://mail.yahoo.com >> >>
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Easy enough to fix. This is why I want to make this "the preferred build" so that everyone uses it and find theses issues. In this case "src/conf/geronimo-plugin.xml" just needs to get included as "META-INF/geronimo-plugin.xml" in the CAR? --jason On Jul 24, 2006, at 2:39 PM, Aaron Mulder wrote: -1 to making this "the preferred build" -- we've lost the functionality to build plugins as part of the build. For example, see configs/welcome-jetty/src/conf/geronimo-plugin.xml Then look at configs/welcome-jetty/target/welcome-jetty-1.2- SNAPSHOT.car and note that it doesn't have an entry for META-INF/geronimo-plugin.xml (whereas ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car does have it). I was tipped off by Prasad's comment on another thread that the geronimoPlugin option to the Maven car plugin is ignored. In the M1 packaging plugin, we attached a pre or post hook to copy the plugin metadata file into the exploded CAR directory before zipping it into the Maven repository. I suspect that's not the appropriate approach for Maven 2, but we need something. Thanks, Aaron On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: FYI, I just created a new RTC for Genesis: http://issues.apache.org/jira/browse/GERONIMO-2223 --jason On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: > Hi Jason, > My family was visiting. I have been busy and in and out of town. I > am catching up on my mail and apologize for not responding to all the > mail promptly. > > I looked at the code and saw this in the top level pom : > > org.apache.geronimo.genesis.config > project-config > 1.0.0-SNAPSHOT > > Since this project is not in the code being reviewed, I commented it > out and ran one 'simple mvn install' from the top directory! And you > know what happened... > > If I am a windows user who does not care to install cygwin, I had to > type the following : > mvn -Dstage=bootstrap > cd openejb2 > mvn -Dmaven.test.skip=true install > cd .. > mvn -Dstage=assemble > This looked very familiar.. > > I tried to see where o.a.g.genesis.config was being built. I found > that > the genesis branch has been built and published to a repo. The code > under review will not work without building the code in genesis. Could > you please tell us which repo the artifacts built by genesis have been > published to? >I am still going through the code and will provide more feedback, > even though it does not carry any weight. > > Cheers > Anita > > --- Jason Dillon <[EMAIL PROTECTED]> wrote: > >> Please see this issue for details: >> >> http://issues.apache.org/jira/browse/GERONIMO-2219 >> >> * * * >> >> I hope to be able to merge this work to trunk in a week or so, so >> please, please, please take some time to review the branch and vote >> (PMC or not). >> >> --jason >> > > > __ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com
Re: [RTC] Merge m2migration (functional m2 build) to trunk
-1 to making this "the preferred build" -- we've lost the functionality to build plugins as part of the build. For example, see configs/welcome-jetty/src/conf/geronimo-plugin.xml Then look at configs/welcome-jetty/target/welcome-jetty-1.2-SNAPSHOT.car and note that it doesn't have an entry for META-INF/geronimo-plugin.xml (whereas ~/.maven/repository/geronimo/cars/welcome-jetty-1.1.car does have it). I was tipped off by Prasad's comment on another thread that the geronimoPlugin option to the Maven car plugin is ignored. In the M1 packaging plugin, we attached a pre or post hook to copy the plugin metadata file into the exploded CAR directory before zipping it into the Maven repository. I suspect that's not the appropriate approach for Maven 2, but we need something. Thanks, Aaron On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: FYI, I just created a new RTC for Genesis: http://issues.apache.org/jira/browse/GERONIMO-2223 --jason On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: > Hi Jason, > My family was visiting. I have been busy and in and out of town. I > am catching up on my mail and apologize for not responding to all the > mail promptly. > > I looked at the code and saw this in the top level pom : > > org.apache.geronimo.genesis.config > project-config > 1.0.0-SNAPSHOT > > Since this project is not in the code being reviewed, I commented it > out and ran one 'simple mvn install' from the top directory! And you > know what happened... > > If I am a windows user who does not care to install cygwin, I had to > type the following : > mvn -Dstage=bootstrap > cd openejb2 > mvn -Dmaven.test.skip=true install > cd .. > mvn -Dstage=assemble > This looked very familiar.. > > I tried to see where o.a.g.genesis.config was being built. I found > that > the genesis branch has been built and published to a repo. The code > under review will not work without building the code in genesis. Could > you please tell us which repo the artifacts built by genesis have been > published to? >I am still going through the code and will provide more feedback, > even though it does not carry any weight. > > Cheers > Anita > > --- Jason Dillon <[EMAIL PROTECTED]> wrote: > >> Please see this issue for details: >> >> http://issues.apache.org/jira/browse/GERONIMO-2219 >> >> * * * >> >> I hope to be able to merge this work to trunk in a week or so, so >> please, please, please take some time to review the branch and vote >> (PMC or not). >> >> --jason >> > > > __ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com
Re: [RTC] Merge m2migration (functional m2 build) to trunk
FYI, I just created a new RTC for Genesis: http://issues.apache.org/jira/browse/GERONIMO-2223 --jason On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: Hi Jason, My family was visiting. I have been busy and in and out of town. I am catching up on my mail and apologize for not responding to all the mail promptly. I looked at the code and saw this in the top level pom : org.apache.geronimo.genesis.config project-config 1.0.0-SNAPSHOT Since this project is not in the code being reviewed, I commented it out and ran one 'simple mvn install' from the top directory! And you know what happened... If I am a windows user who does not care to install cygwin, I had to type the following : mvn -Dstage=bootstrap cd openejb2 mvn -Dmaven.test.skip=true install cd .. mvn -Dstage=assemble This looked very familiar.. I tried to see where o.a.g.genesis.config was being built. I found that the genesis branch has been built and published to a repo. The code under review will not work without building the code in genesis. Could you please tell us which repo the artifacts built by genesis have been published to? I am still going through the code and will provide more feedback, even though it does not carry any weight. Cheers Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: Please see this issue for details: http://issues.apache.org/jira/browse/GERONIMO-2219 * * * I hope to be able to merge this work to trunk in a week or so, so please, please, please take some time to review the branch and vote (PMC or not). --jason __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Do not comment that out. PERIOD. --jason On Jul 24, 2006, at 5:40 AM, anita kulshreshtha wrote: Hi Jason, My family was visiting. I have been busy and in and out of town. I am catching up on my mail and apologize for not responding to all the mail promptly. I looked at the code and saw this in the top level pom : org.apache.geronimo.genesis.config project-config 1.0.0-SNAPSHOT Since this project is not in the code being reviewed, I commented it out and ran one 'simple mvn install' from the top directory! And you know what happened... If I am a windows user who does not care to install cygwin, I had to type the following : mvn -Dstage=bootstrap cd openejb2 mvn -Dmaven.test.skip=true install cd .. mvn -Dstage=assemble This looked very familiar.. I tried to see where o.a.g.genesis.config was being built. I found that the genesis branch has been built and published to a repo. The code under review will not work without building the code in genesis. Could you please tell us which repo the artifacts built by genesis have been published to? I am still going through the code and will provide more feedback, even though it does not carry any weight. Cheers Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: Please see this issue for details: http://issues.apache.org/jira/browse/GERONIMO-2219 * * * I hope to be able to merge this work to trunk in a week or so, so please, please, please take some time to review the branch and vote (PMC or not). --jason __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: > I run across the following issue when starting from a path-lenghty > directory: What is the lengthy path you ran under? Your description of the test steps suggested that a tester might unpack a server distro from within the directory where the Geronimo sources have been downloaded to. I did so and ended up with the lenghty path error. That is fine... but what was the path? Specifically, please post the exact pathname you ran under for reference. This is a known issue. I requested details about how low logging was expected to be configured before on the list which went unanswered. I do not believe there is an issue for this yet though. If you'd like to create one that would be helpful. I don't think it's a known issue as it doesn't occur in M1-built Geronimo 1.2-SNAPSHOT (Jetty and Tomcat). I've just verified it. Therefore, I'm leaning towards calling it a bug in M2-built Geronimo as opposed to pointing out to the known issue in Geronimo itself. $^%&! Its a known issue with the m2 assemblies. I've sent mail to the dev@ list a few times about this and ping'd folks on IRC on it too. We are aware of the issue, thus it is known. Just no one cares enough to respond to half the emails on the dev@ list so it has gone no where. I already said please create an issue for this... Not sure why you had to go waste time verifying it on m1, as I am sure it works there and I am sure that it is a problem with the m2 build. Really don't understand why we have to bounce back and forth for several days to get something done. For example, I asked you for the "length path" you ran under... and instead of actually giving me the path which I asked for you, you give some explanation of why you were in the lengthy past which I did not even ask for. --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Hi Jason, My family was visiting. I have been busy and in and out of town. I am catching up on my mail and apologize for not responding to all the mail promptly. I looked at the code and saw this in the top level pom : org.apache.geronimo.genesis.config project-config 1.0.0-SNAPSHOT Since this project is not in the code being reviewed, I commented it out and ran one 'simple mvn install' from the top directory! And you know what happened... If I am a windows user who does not care to install cygwin, I had to type the following : mvn -Dstage=bootstrap cd openejb2 mvn -Dmaven.test.skip=true install cd .. mvn -Dstage=assemble This looked very familiar.. I tried to see where o.a.g.genesis.config was being built. I found that the genesis branch has been built and published to a repo. The code under review will not work without building the code in genesis. Could you please tell us which repo the artifacts built by genesis have been published to? I am still going through the code and will provide more feedback, even though it does not carry any weight. Cheers Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: > Please see this issue for details: > > http://issues.apache.org/jira/browse/GERONIMO-2219 > > * * * > > I hope to be able to merge this work to trunk in a week or so, so > please, please, please take some time to review the branch and vote > (PMC or not). > > --jason > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: > I run across the following issue when starting from a path-lenghty > directory: What is the lengthy path you ran under? Your description of the test steps suggested that a tester might unpack a server distro from within the directory where the Geronimo sources have been downloaded to. I did so and ended up with the lenghty path error. This is a known issue. I requested details about how low logging was expected to be configured before on the list which went unanswered. I do not believe there is an issue for this yet though. If you'd like to create one that would be helpful. I don't think it's a known issue as it doesn't occur in M1-built Geronimo 1.2-SNAPSHOT (Jetty and Tomcat). I've just verified it. Therefore, I'm leaning towards calling it a bug in M2-built Geronimo as opposed to pointing out to the known issue in Geronimo itself. Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [RTC] Merge m2migration (functional m2 build) to trunk
I run across the following issue when starting from a path-lenghty directory: What is the lengthy path you ran under? I think we need to resolve why we need to have CAR archives unpacked in the repository, as unpacked wars really blows out the filename length limit. Though... this is a more general problem and should probably not be tied into this RTC. whereas when I moved the directory - geronimo-jetty-j2ee-1.2-SNAPSHOT and renamed to c:/temp/g, it booted up fine. Yup, that is why I mentioned to review from the fs root ;-) There's however an issue no matter how long the Geronimo home path is. log4j:WARN No appenders could be found for logger (org.apache.geronimo.system.main.Daemon). log4j:WARN Please initialize the log4j system properly. Has it already been reported? Shall I create a jira issue? This is a known issue. I requested details about how low logging was expected to be configured before on the list which went unanswered. I do not believe there is an issue for this yet though. If you'd like to create one that would be helpful. --jason
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: Yikes... Time to buy a Mac ;-) Sure. Or install Linux. Yesterday, I saw a mac and that beautiful window manager that swapped windows when you moved a mouse cursor to the upper-left screen corner. I couldn't believe what I could see. It was awesome! On to the m2migration testing... I run across the following issue when starting from a path-lenghty directory: Module 18/19 org.apache.geronimo.configs/webconsole-jetty/1.2-SNAPSHOT/car Server Startup failed org.apache.geronimo.kernel.config.LifecycleException: start of org.apache.geronimo.configs/webconsole-jetty/1.2-SNAPSHOT/car failed at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:529) at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:493) at org.apache.geronimo.kernel.config.SimpleConfigurationManager$$FastClassByCGLIB$$ce77a924.invoke() at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53) at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38) at org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:122) at org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:817) at org.apache.geronimo.gbean.runtime.RawInvoker.invoke(RawInvoker.java:57) at org.apache.geronimo.kernel.basic.RawOperationInvoker.invoke(RawOperationInvoker.java:35) at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96) at org.apache.geronimo.kernel.config.EditableConfigurationManager$$EnhancerByCGLIB$$ec54497.startConfiguration() at org.apache.geronimo.system.main.Daemon.doStartup(Daemon.java:297) at org.apache.geronimo.system.main.Daemon.(Daemon.java:74) at org.apache.geronimo.system.main.Daemon.main(Daemon.java:377) Caused by: org.apache.geronimo.kernel.config.InvalidConfigException: Unknown start exception at org.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:440) at org.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:411) at org.apache.geronimo.kernel.config.KernelConfigurationManager.start(KernelConfigurationManager.java:187) at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:512) ... 13 more Caused by: org.apache.geronimo.gbean.InvalidConfigurationException: Configuration org.apache.geronimo.configs/webconsole-jetty_framework.war/1.2-SNAPSHOT/car failed to start due to the following reasons: whereas when I moved the directory - geronimo-jetty-j2ee-1.2-SNAPSHOT and renamed to c:/temp/g, it booted up fine. There's however an issue no matter how long the Geronimo home path is. log4j:WARN No appenders could be found for logger (org.apache.geronimo.system.main.Daemon). log4j:WARN Please initialize the log4j system properly. Has it already been reported? Shall I create a jira issue? Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [RTC] Merge m2migration (functional m2 build) to trunk
Yikes... Time to buy a Mac ;-) --jason On Jul 24, 2006, at 1:02 AM, Jacek Laskowski wrote: On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: What was the SVN error specifically? Subversion Permission denied moving .svn/tmp/entries to .svn/entries @see http://svn.haxx.se/users/archive-2005-08/1408.shtml I'm experiencing it all the time (not only with the m2migration branch). tortoisesvn doesn't report it and seems to be more reliable than svn on the command line. Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/24/06, Jason Dillon <[EMAIL PROTECTED]> wrote: What was the SVN error specifically? Subversion Permission denied moving .svn/tmp/entries to .svn/entries @see http://svn.haxx.se/users/archive-2005-08/1408.shtml I'm experiencing it all the time (not only with the m2migration branch). tortoisesvn doesn't report it and seems to be more reliable than svn on the command line. Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [RTC] Merge m2migration (functional m2 build) to trunk
What was the SVN error specifically? --jason On Jul 24, 2006, at 12:30 AM, Jacek Laskowski wrote: On 7/23/06, Jason Dillon <[EMAIL PROTECTED]> wrote: Please see this issue for details: http://issues.apache.org/jira/browse/GERONIMO-2219 * * * I hope to be able to merge this work to trunk in a week or so, so please, please, please take some time to review the branch and vote (PMC or not). The very first check has passed - the boostrap finished successfully! I had an intermittent problem with checking out OpenEJB sources and svn that blew up with 'Permission denied', but gave it another try and didn't see it again. Tested on Cygwin. [EMAIL PROTECTED] /cygdrive/c/oss/m2migration $ uname -a CYGWIN_NT-5.1 dev 1.5.20(0.156/4/2) 2006-07-01 02:22 i686 Cygwin [EMAIL PROTECTED] /cygdrive/c/oss/m2migration $ java -version java version "1.4.2_11" Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_11-b06) Java HotSpot(TM) Client VM (build 1.4.2_11-b06, mixed mode) $ bootstrap ... [INFO] BUILD SUCCESSFUL [INFO] -- -- [INFO] Total time: 15 minutes 4 seconds [INFO] Finished at: Mon Jul 24 09:19:50 CEST 2006 [INFO] Final Memory: 63M/254M [INFO] -- -- bootstrap: Completed (08:49:35 CEDT 2006 to 09:20:16 CEDT 2006) Jacek -- Jacek Laskowski http://www.laskowski.net.pl
Re: [RTC] Merge m2migration (functional m2 build) to trunk
On 7/23/06, Jason Dillon <[EMAIL PROTECTED]> wrote: Please see this issue for details: http://issues.apache.org/jira/browse/GERONIMO-2219 * * * I hope to be able to merge this work to trunk in a week or so, so please, please, please take some time to review the branch and vote (PMC or not). The very first check has passed - the boostrap finished successfully! I had an intermittent problem with checking out OpenEJB sources and svn that blew up with 'Permission denied', but gave it another try and didn't see it again. Tested on Cygwin. [EMAIL PROTECTED] /cygdrive/c/oss/m2migration $ uname -a CYGWIN_NT-5.1 dev 1.5.20(0.156/4/2) 2006-07-01 02:22 i686 Cygwin [EMAIL PROTECTED] /cygdrive/c/oss/m2migration $ java -version java version "1.4.2_11" Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_11-b06) Java HotSpot(TM) Client VM (build 1.4.2_11-b06, mixed mode) $ bootstrap ... [INFO] BUILD SUCCESSFUL [INFO] [INFO] Total time: 15 minutes 4 seconds [INFO] Finished at: Mon Jul 24 09:19:50 CEST 2006 [INFO] Final Memory: 63M/254M [INFO] bootstrap: Completed (08:49:35 CEDT 2006 to 09:20:16 CEDT 2006) Jacek -- Jacek Laskowski http://www.laskowski.net.pl
