Re: [m2 build] Update about custom assembly usage
On Jul 17, 2006, at 5:12 PM, David Jencks wrote: After I wrote the tests I made many changes to make them pass on more machines than just mine. I'd love to know how to make them independent of machine load/speed. Do you have any concrete suggestions on how to do this? At the moment no... but I can look at them more after the m2 work is done. We should be able to devise a test that ensures the functionality and also works in any environment. --jason
Re: [m2 build] Update about custom assembly usage
On Jul 15, 2006, at 12:28 PM, Jason Dillon wrote: m1, m2 or ant... the timer tests are not written in such a way that they will always pass. They are heavily dependent on running on a healthy/speedy box or they will start to fail with random errors. These tests run fine for me, but fail for Prasad. The failures are all due to Thread.sleep() returning before the expected number of timer invocations have been executed. They need to be augmented to remove the window for random failures. After I wrote the tests I made many changes to make them pass on more machines than just mine. I'd love to know how to make them independent of machine load/speed. Do you have any concrete suggestions on how to do this? thanks david jencks --jason On Jul 15, 2006, at 3:59 AM, anita kulshreshtha wrote: IIRC these tests have been running successfully (in M1) for more than a year on all kinds of machines. Thanks Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: I did not turn them off... I just added a Jira to remind us that these tests need to be fixed. --jason On Jul 14, 2006, at 8:43 PM, Prasad Kashyap wrote: The timer tests failed. Jason, I thought you pulled them out late last night after our discussion. Cheers Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: The bootstrap on linux first failed a test in the security module. I ran the build inside the security module. It passed successfully. Then I ran bootstrap again. It failed while transferring an artifact. Now I'm running mvn from top level. This is running. Keeping my fingers crossed Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: I tried the latest changes on Windows and it builds the assembly fine. I even ran the jetty binary successfully. Jason, I also tried commenting out a few builders from the dependencies list and it still worked fine. So I guess we can prune the deps list to remove the redudant ones. A full extract and bootstrap on Linux is running. Cheers Prasad On 7/14/06, Jason Dillon <[EMAIL PROTECTED]> wrote: It looks like the Maven 2 peeps are not going to be able to take in our patches to apply to the assembly plugin, which provides mappers and some includes/excludes to unpack and a permission related fix to files/file element processing. I believe that those changes will eventually make it in, but for now to get around the need Prasad and I talked about using the dependency plugin and the antrun plugin to perform the needed "flattening" of the schema files for the /schema/* in the assembly. I've implemented this already for the geronimo-jetty-j2ee assembly in the svkmerge/m2migration branch. It appears to function as expected. I've disabled the remaining assemblies which have not yet been converted. Once they have been converted they will be re-enabled. Note, we are still using car:installConfigs... but we no longer need to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- SNAPSHOT version of the maven-assembly-plugin to build out assemblies. The full conversation is here if anyone is interested: http://uwyn.com/drone/log/bevinbot/geronimo/20060714 Starts with '19:53 any thoughts on using dependency + antrun to setup the right bits and then use the 2.1 assembly plugin?' --jason __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [m2 build] Update about custom assembly usage
Prasad, could you peek at the patches and help sort out what needs to get applied to m2migration? Thanks, --jason On Jul 15, 2006, at 4:24 AM, anita kulshreshtha wrote: Hi Prasad, I wish I could be of more help and investigate why the config are not building. These patches used to work until rev 418907 on the trunk. I have been unable to build the trunk using 'mvn' after RTC-2161. I have not had time to investigate it. IIRC this error comes when the openejb-deployer config is bad. I will have limited email access for the next 2 weeks. Cheers Anita --- Prasad Kashyap <[EMAIL PROTECTED]> wrote: Hi Anita, I applied the pending patch (geronimo-remote-deploy/pom.xml). That was when I got that error. Are there are more patches to be applied along with that ? Cheers Prasad On 7/14/06, anita kulshreshtha <[EMAIL PROTECTED]> wrote: Would it not be simpler to use the patched version of m-a-p and just rename it to geronimo-assembly2-plugin and add it to our code base? This plugin is more elegant than the ant solution. we can remove this code as soon as maven-assembly-plugin is updated. Are there any problems with using code like this? BTW, I saw your comments about remote-deploy-* configs. These are the pending patches at - http://issues.apache.org/jira/browse/GERONIMO-2067#action_12415761 I will be offline for next 2 weeks due to preplanned summer engagements. Cheers Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: It looks like the Maven 2 peeps are not going to be able to take in our patches to apply to the assembly plugin, which provides mappers and some includes/excludes to unpack and a permission related fix to files/file element processing. I believe that those changes will eventually make it in, but for now to get around the need Prasad and I talked about using the dependency plugin and the antrun plugin to perform the needed "flattening" of the schema files for the /schema/* in the assembly. I've implemented this already for the geronimo-jetty-j2ee assembly in the svkmerge/m2migration branch. It appears to function as expected. I've disabled the remaining assemblies which have not yet been converted. Once they have been converted they will be re-enabled. Note, we are still using car:installConfigs... but we no longer need to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- SNAPSHOT version of the maven-assembly-plugin to build out assemblies. The full conversation is here if anyone is interested: http://uwyn.com/drone/log/bevinbot/geronimo/20060714 Starts with '19:53 any thoughts on using dependency + antrun to setup the right bits and then use the 2.1 assembly plugin?' --jason __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [m2 build] Update about custom assembly usage
m1, m2 or ant... the timer tests are not written in such a way that they will always pass. They are heavily dependent on running on a healthy/speedy box or they will start to fail with random errors. These tests run fine for me, but fail for Prasad. The failures are all due to Thread.sleep() returning before the expected number of timer invocations have been executed. They need to be augmented to remove the window for random failures. --jason On Jul 15, 2006, at 3:59 AM, anita kulshreshtha wrote: IIRC these tests have been running successfully (in M1) for more than a year on all kinds of machines. Thanks Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: I did not turn them off... I just added a Jira to remind us that these tests need to be fixed. --jason On Jul 14, 2006, at 8:43 PM, Prasad Kashyap wrote: The timer tests failed. Jason, I thought you pulled them out late last night after our discussion. Cheers Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: The bootstrap on linux first failed a test in the security module. I ran the build inside the security module. It passed successfully. Then I ran bootstrap again. It failed while transferring an artifact. Now I'm running mvn from top level. This is running. Keeping my fingers crossed Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: I tried the latest changes on Windows and it builds the assembly fine. I even ran the jetty binary successfully. Jason, I also tried commenting out a few builders from the dependencies list and it still worked fine. So I guess we can prune the deps list to remove the redudant ones. A full extract and bootstrap on Linux is running. Cheers Prasad On 7/14/06, Jason Dillon <[EMAIL PROTECTED]> wrote: It looks like the Maven 2 peeps are not going to be able to take in our patches to apply to the assembly plugin, which provides mappers and some includes/excludes to unpack and a permission related fix to files/file element processing. I believe that those changes will eventually make it in, but for now to get around the need Prasad and I talked about using the dependency plugin and the antrun plugin to perform the needed "flattening" of the schema files for the /schema/* in the assembly. I've implemented this already for the geronimo-jetty-j2ee assembly in the svkmerge/m2migration branch. It appears to function as expected. I've disabled the remaining assemblies which have not yet been converted. Once they have been converted they will be re-enabled. Note, we are still using car:installConfigs... but we no longer need to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- SNAPSHOT version of the maven-assembly-plugin to build out assemblies. The full conversation is here if anyone is interested: http://uwyn.com/drone/log/bevinbot/geronimo/20060714 Starts with '19:53 any thoughts on using dependency + antrun to setup the right bits and then use the 2.1 assembly plugin?' --jason __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [m2 build] Update about custom assembly usage
Hi Prasad, I wish I could be of more help and investigate why the config are not building. These patches used to work until rev 418907 on the trunk. I have been unable to build the trunk using 'mvn' after RTC-2161. I have not had time to investigate it. IIRC this error comes when the openejb-deployer config is bad. I will have limited email access for the next 2 weeks. Cheers Anita --- Prasad Kashyap <[EMAIL PROTECTED]> wrote: > Hi Anita, > > I applied the pending patch (geronimo-remote-deploy/pom.xml). That > was when I got that error. Are there are more patches to be applied > along with that ? > > Cheers > Prasad > > On 7/14/06, anita kulshreshtha <[EMAIL PROTECTED]> wrote: > >Would it not be simpler to use the patched version of m-a-p and > just > > rename it to geronimo-assembly2-plugin and add it to our code base? > > This plugin is more elegant than the ant solution. we can remove > this > > code as soon as maven-assembly-plugin is updated. Are there any > > problems with using code like this? > > BTW, I saw your comments about remote-deploy-* configs. These > are > > the pending patches at - > > http://issues.apache.org/jira/browse/GERONIMO-2067#action_12415761 > > I will be offline for next 2 weeks due to preplanned summer > > engagements. > > > > Cheers > > Anita > > > > --- Jason Dillon <[EMAIL PROTECTED]> wrote: > > > > > It looks like the Maven 2 peeps are not going to be able to take > in > > > our patches to apply to the assembly plugin, which provides > mappers > > > and some includes/excludes to unpack and a permission related fix > to > > > > > > files/file element processing. > > > > > > I believe that those changes will eventually make it in, but for > now > > > > > > to get around the need Prasad and I talked about using the > dependency > > > > > > plugin and the antrun plugin to perform the needed "flattening" > of > > > the schema files for the /schema/* in the assembly. > > > > > > I've implemented this already for the geronimo-jetty-j2ee > assembly in > > > > > > the svkmerge/m2migration branch. > > > > > > It appears to function as expected. I've disabled the remaining > > > assemblies which have not yet been converted. Once they have > been > > > converted they will be re-enabled. > > > > > > Note, we are still using car:installConfigs... but we no longer > need > > > > > > to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- > > > SNAPSHOT version of the maven-assembly-plugin to build out > > > assemblies. > > > > > > The full conversation is here if anyone is interested: > > > > > > http://uwyn.com/drone/log/bevinbot/geronimo/20060714 > > > > > > Starts with '19:53 any thoughts on using dependency + > > > antrun to setup the right bits and then use the 2.1 assembly > plugin?' > > > --jason > > > > > > > > > __ > > Do You Yahoo!? > > Tired of spam? Yahoo! Mail has the best spam protection around > > http://mail.yahoo.com > > > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [m2 build] Update about custom assembly usage
IIRC these tests have been running successfully (in M1) for more than a year on all kinds of machines. Thanks Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: > I did not turn them off... I just added a Jira to remind us that > these tests need to be fixed. > > --jason > > > On Jul 14, 2006, at 8:43 PM, Prasad Kashyap wrote: > > > The timer tests failed. Jason, I thought you pulled them out late > last > > night after our discussion. > > > > Cheers > > Prasad > > > > On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: > >> The bootstrap on linux first failed a test in the security module. > I > >> ran the build inside the security module. It passed successfully. > >> > >> Then I ran bootstrap again. It failed while transferring an > artifact. > >> > >> Now I'm running mvn from top level. This is running. > >> > >> > >> Keeping my fingers crossed > >> Prasad > >> > >> On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: > >> > I tried the latest changes on Windows and it builds the assembly > > >> fine. > >> > I even ran the jetty binary successfully. > >> > > >> > Jason, I also tried commenting out a few builders from the > >> > dependencies list and it still worked fine. So I guess we can > prune > >> > the deps list to remove the redudant ones. > >> > > >> > A full extract and bootstrap on Linux is running. > >> > > >> > Cheers > >> > Prasad > >> > > >> > On 7/14/06, Jason Dillon <[EMAIL PROTECTED]> wrote: > >> > > It looks like the Maven 2 peeps are not going to be able to > >> take in > >> > > our patches to apply to the assembly plugin, which provides > >> mappers > >> > > and some includes/excludes to unpack and a permission related > > >> fix to > >> > > files/file element processing. > >> > > > >> > > I believe that those changes will eventually make it in, but > >> for now > >> > > to get around the need Prasad and I talked about using the > >> dependency > >> > > plugin and the antrun plugin to perform the needed > >> "flattening" of > >> > > the schema files for the /schema/* in the assembly. > >> > > > >> > > I've implemented this already for the geronimo-jetty-j2ee > >> assembly in > >> > > the svkmerge/m2migration branch. > >> > > > >> > > It appears to function as expected. I've disabled the > remaining > >> > > assemblies which have not yet been converted. Once they have > > >> been > >> > > converted they will be re-enabled. > >> > > > >> > > Note, we are still using car:installConfigs... but we no > >> longer need > >> > > to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- > >> > > SNAPSHOT version of the maven-assembly-plugin to build out > >> assemblies. > >> > > > >> > > The full conversation is here if anyone is interested: > >> > > > >> > > http://uwyn.com/drone/log/bevinbot/geronimo/20060714 > >> > > > >> > > Starts with '19:53 any thoughts on using dependency > + > >> > > antrun to setup the right bits and then use the 2.1 assembly > >> plugin?' > >> > > --jason > >> > > > >> > > >> > > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [m2 build] Update about custom assembly usage
I did not turn them off... I just added a Jira to remind us that these tests need to be fixed. --jason On Jul 14, 2006, at 8:43 PM, Prasad Kashyap wrote: The timer tests failed. Jason, I thought you pulled them out late last night after our discussion. Cheers Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: The bootstrap on linux first failed a test in the security module. I ran the build inside the security module. It passed successfully. Then I ran bootstrap again. It failed while transferring an artifact. Now I'm running mvn from top level. This is running. Keeping my fingers crossed Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: > I tried the latest changes on Windows and it builds the assembly fine. > I even ran the jetty binary successfully. > > Jason, I also tried commenting out a few builders from the > dependencies list and it still worked fine. So I guess we can prune > the deps list to remove the redudant ones. > > A full extract and bootstrap on Linux is running. > > Cheers > Prasad > > On 7/14/06, Jason Dillon <[EMAIL PROTECTED]> wrote: > > It looks like the Maven 2 peeps are not going to be able to take in > > our patches to apply to the assembly plugin, which provides mappers > > and some includes/excludes to unpack and a permission related fix to > > files/file element processing. > > > > I believe that those changes will eventually make it in, but for now > > to get around the need Prasad and I talked about using the dependency > > plugin and the antrun plugin to perform the needed "flattening" of > > the schema files for the /schema/* in the assembly. > > > > I've implemented this already for the geronimo-jetty-j2ee assembly in > > the svkmerge/m2migration branch. > > > > It appears to function as expected. I've disabled the remaining > > assemblies which have not yet been converted. Once they have been > > converted they will be re-enabled. > > > > Note, we are still using car:installConfigs... but we no longer need > > to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- > > SNAPSHOT version of the maven-assembly-plugin to build out assemblies. > > > > The full conversation is here if anyone is interested: > > > > http://uwyn.com/drone/log/bevinbot/geronimo/20060714 > > > > Starts with '19:53 any thoughts on using dependency + > > antrun to setup the right bits and then use the 2.1 assembly plugin?' > > --jason > > >
Re: [m2 build] Update about custom assembly usage
The timer tests failed. Jason, I thought you pulled them out late last night after our discussion. Cheers Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: The bootstrap on linux first failed a test in the security module. I ran the build inside the security module. It passed successfully. Then I ran bootstrap again. It failed while transferring an artifact. Now I'm running mvn from top level. This is running. Keeping my fingers crossed Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: > I tried the latest changes on Windows and it builds the assembly fine. > I even ran the jetty binary successfully. > > Jason, I also tried commenting out a few builders from the > dependencies list and it still worked fine. So I guess we can prune > the deps list to remove the redudant ones. > > A full extract and bootstrap on Linux is running. > > Cheers > Prasad > > On 7/14/06, Jason Dillon <[EMAIL PROTECTED]> wrote: > > It looks like the Maven 2 peeps are not going to be able to take in > > our patches to apply to the assembly plugin, which provides mappers > > and some includes/excludes to unpack and a permission related fix to > > files/file element processing. > > > > I believe that those changes will eventually make it in, but for now > > to get around the need Prasad and I talked about using the dependency > > plugin and the antrun plugin to perform the needed "flattening" of > > the schema files for the /schema/* in the assembly. > > > > I've implemented this already for the geronimo-jetty-j2ee assembly in > > the svkmerge/m2migration branch. > > > > It appears to function as expected. I've disabled the remaining > > assemblies which have not yet been converted. Once they have been > > converted they will be re-enabled. > > > > Note, we are still using car:installConfigs... but we no longer need > > to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- > > SNAPSHOT version of the maven-assembly-plugin to build out assemblies. > > > > The full conversation is here if anyone is interested: > > > > http://uwyn.com/drone/log/bevinbot/geronimo/20060714 > > > > Starts with '19:53 any thoughts on using dependency + > > antrun to setup the right bits and then use the 2.1 assembly plugin?' > > --jason > > >
Re: [m2 build] Update about custom assembly usage
The bootstrap on linux first failed a test in the security module. I ran the build inside the security module. It passed successfully. Then I ran bootstrap again. It failed while transferring an artifact. Now I'm running mvn from top level. This is running. Keeping my fingers crossed Prasad On 7/14/06, Prasad Kashyap <[EMAIL PROTECTED]> wrote: I tried the latest changes on Windows and it builds the assembly fine. I even ran the jetty binary successfully. Jason, I also tried commenting out a few builders from the dependencies list and it still worked fine. So I guess we can prune the deps list to remove the redudant ones. A full extract and bootstrap on Linux is running. Cheers Prasad On 7/14/06, Jason Dillon <[EMAIL PROTECTED]> wrote: > It looks like the Maven 2 peeps are not going to be able to take in > our patches to apply to the assembly plugin, which provides mappers > and some includes/excludes to unpack and a permission related fix to > files/file element processing. > > I believe that those changes will eventually make it in, but for now > to get around the need Prasad and I talked about using the dependency > plugin and the antrun plugin to perform the needed "flattening" of > the schema files for the /schema/* in the assembly. > > I've implemented this already for the geronimo-jetty-j2ee assembly in > the svkmerge/m2migration branch. > > It appears to function as expected. I've disabled the remaining > assemblies which have not yet been converted. Once they have been > converted they will be re-enabled. > > Note, we are still using car:installConfigs... but we no longer need > to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- > SNAPSHOT version of the maven-assembly-plugin to build out assemblies. > > The full conversation is here if anyone is interested: > > http://uwyn.com/drone/log/bevinbot/geronimo/20060714 > > Starts with '19:53 any thoughts on using dependency + > antrun to setup the right bits and then use the 2.1 assembly plugin?' > --jason >
Re: [m2 build] Update about custom assembly usage
I tried the latest changes on Windows and it builds the assembly fine. I even ran the jetty binary successfully. Jason, I also tried commenting out a few builders from the dependencies list and it still worked fine. So I guess we can prune the deps list to remove the redudant ones. A full extract and bootstrap on Linux is running. Cheers Prasad On 7/14/06, Jason Dillon <[EMAIL PROTECTED]> wrote: It looks like the Maven 2 peeps are not going to be able to take in our patches to apply to the assembly plugin, which provides mappers and some includes/excludes to unpack and a permission related fix to files/file element processing. I believe that those changes will eventually make it in, but for now to get around the need Prasad and I talked about using the dependency plugin and the antrun plugin to perform the needed "flattening" of the schema files for the /schema/* in the assembly. I've implemented this already for the geronimo-jetty-j2ee assembly in the svkmerge/m2migration branch. It appears to function as expected. I've disabled the remaining assemblies which have not yet been converted. Once they have been converted they will be re-enabled. Note, we are still using car:installConfigs... but we no longer need to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- SNAPSHOT version of the maven-assembly-plugin to build out assemblies. The full conversation is here if anyone is interested: http://uwyn.com/drone/log/bevinbot/geronimo/20060714 Starts with '19:53 any thoughts on using dependency + antrun to setup the right bits and then use the 2.1 assembly plugin?' --jason
Re: [m2 build] Update about custom assembly usage
Hi Anita, I applied the pending patch (geronimo-remote-deploy/pom.xml). That was when I got that error. Are there are more patches to be applied along with that ? Cheers Prasad On 7/14/06, anita kulshreshtha <[EMAIL PROTECTED]> wrote: Would it not be simpler to use the patched version of m-a-p and just rename it to geronimo-assembly2-plugin and add it to our code base? This plugin is more elegant than the ant solution. we can remove this code as soon as maven-assembly-plugin is updated. Are there any problems with using code like this? BTW, I saw your comments about remote-deploy-* configs. These are the pending patches at - http://issues.apache.org/jira/browse/GERONIMO-2067#action_12415761 I will be offline for next 2 weeks due to preplanned summer engagements. Cheers Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: > It looks like the Maven 2 peeps are not going to be able to take in > our patches to apply to the assembly plugin, which provides mappers > and some includes/excludes to unpack and a permission related fix to > > files/file element processing. > > I believe that those changes will eventually make it in, but for now > > to get around the need Prasad and I talked about using the dependency > > plugin and the antrun plugin to perform the needed "flattening" of > the schema files for the /schema/* in the assembly. > > I've implemented this already for the geronimo-jetty-j2ee assembly in > > the svkmerge/m2migration branch. > > It appears to function as expected. I've disabled the remaining > assemblies which have not yet been converted. Once they have been > converted they will be re-enabled. > > Note, we are still using car:installConfigs... but we no longer need > > to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- > SNAPSHOT version of the maven-assembly-plugin to build out > assemblies. > > The full conversation is here if anyone is interested: > > http://uwyn.com/drone/log/bevinbot/geronimo/20060714 > > Starts with '19:53 any thoughts on using dependency + > antrun to setup the right bits and then use the 2.1 assembly plugin?' > --jason > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Re: [m2 build] Update about custom assembly usage
On Jul 14, 2006, at 4:30 PM, anita kulshreshtha wrote: Would it not be simpler to use the patched version of m-a-p and just rename it to geronimo-assembly2-plugin and add it to our code base? I do not believe so. The use of the dependency + antrun plugins are relatively limited. Both solutions are hacks IMO... and IMO the lesser of the two is to use the released version of the assembly plugin + dependency and antrun. We are also not certain that the patches to the assembly plugin will be committed... and if they will be we are not sure when. I'd be happy to change this up once the new assembly plugin with support can do this for us. Short of that I believe the solution applied to the geronimo-jetty-j2ee assembly is the most optimal given the situation. This plugin is more elegant than the ant solution. we can remove this code as soon as maven-assembly-plugin is updated. Are there any problems with using code like this? There are no other problems that I am aware of. BTW, I saw your comments about remote-deploy-* configs. These are the pending patches at - http://issues.apache.org/jira/browse/GERONIMO-2067#action_12415761 I believe that was Prasad, not I who commented on this... but we will take a look. Thanks :-) I will be offline for next 2 weeks due to preplanned summer engagements. Enjoy. --jason
Re: [m2 build] Update about custom assembly usage
Would it not be simpler to use the patched version of m-a-p and just rename it to geronimo-assembly2-plugin and add it to our code base? This plugin is more elegant than the ant solution. we can remove this code as soon as maven-assembly-plugin is updated. Are there any problems with using code like this? BTW, I saw your comments about remote-deploy-* configs. These are the pending patches at - http://issues.apache.org/jira/browse/GERONIMO-2067#action_12415761 I will be offline for next 2 weeks due to preplanned summer engagements. Cheers Anita --- Jason Dillon <[EMAIL PROTECTED]> wrote: > It looks like the Maven 2 peeps are not going to be able to take in > our patches to apply to the assembly plugin, which provides mappers > and some includes/excludes to unpack and a permission related fix to > > files/file element processing. > > I believe that those changes will eventually make it in, but for now > > to get around the need Prasad and I talked about using the dependency > > plugin and the antrun plugin to perform the needed "flattening" of > the schema files for the /schema/* in the assembly. > > I've implemented this already for the geronimo-jetty-j2ee assembly in > > the svkmerge/m2migration branch. > > It appears to function as expected. I've disabled the remaining > assemblies which have not yet been converted. Once they have been > converted they will be re-enabled. > > Note, we are still using car:installConfigs... but we no longer need > > to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2- > SNAPSHOT version of the maven-assembly-plugin to build out > assemblies. > > The full conversation is here if anyone is interested: > > http://uwyn.com/drone/log/bevinbot/geronimo/20060714 > > Starts with '19:53 any thoughts on using dependency + > antrun to setup the right bits and then use the 2.1 assembly plugin?' > --jason > __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
