Re: Deployment broken on minimal assemblies

2008-01-30 Thread David Jencks

I have an idea that I'd like to try...

I think perhaps the ResourceRefBuilder can get an additional  
CorbaEnvironment that it can merge in only if there is a resource-ref  
to an ORB.  Then web apps that don't use the orb should be ok.


Any ideas how to test this?

thanks
david jencks

On Jan 30, 2008, at 7:52 AM, Joe Bohn wrote:


Jarek Gawor wrote:

In 2.0, it looks like the connector-deployer gbeans were configured
differently between minimal and full assemblies:
minimal's config.xml:


javaee's config.xml:



name="eeNamespaces">http://java.sun.com/xml/ns/j2ee,http:// 
java.sun.com/xml/ns/javaee


http://geronimo.apache.org/xml/ns/deployment-1.2";>


org.apache.geronimo.configsgroupId>

j2ee-corba-yoko
car





..
In trunk the connector-deployer/car gets configured in the same way
(with the yoko dependency) for both assemblies.
Jarek


Excellent observation Jarek.

I modified the config.xml to remove the gbean configurations and I  
was able to deploy without error.


Since the config.xml is now being generated from the module poms I  
wonder if there is a way to influence the outcome for the different  
assemblies.


Joe



On Jan 28, 2008 5:07 PM, Joe Bohn <[EMAIL PROTECTED]> wrote:

I discovered last Friday that deployment is broken on the Minimal
Assemblies.  (see https://issues.apache.org/jira/browse/ 
GERONIMO-3787)


Attempting to deploy a simple web app that contains just a jsp  
(with or

without a deployment plan) we hit an error that there is a missing
dependency:

Missing dependency:
org.apache.geronimo.configs/j2ee-corba-yoko//car


Does this mean that we have a DefaultEnvironment setting or  
something

similar someplace that is attempting to add j2ee-corba-yoko as a
dependency to every web app being deployed?

Aside from the specs, I don't believe that we should include  
anything

from yoko in the minimal assemblies.

Looking at the config.xml for the server it appears this is getting
included via the connector-deployer config and its  
ResourceRefBuilder
GBean's EnvironmentBuilder.  Looking at the connector-deployer  
pom it

appears this defaultEnvironment has been for a long time, so I don't
know why it should start to cause a problem now.  The only  
relatively
recent change I see http://svn.apache.org/viewvc? 
rev=603109&view=rev .
Is it possible this had an impact on the minimal deployments such  
that

they now require a require this car to be available whereas it was
optional before?  Any pointers?

Joe







Re: Deployment broken on minimal assemblies

2008-01-30 Thread Joe Bohn

Jarek Gawor wrote:

In 2.0, it looks like the connector-deployer gbeans were configured
differently between minimal and full assemblies:

minimal's config.xml:



javaee's config.xml:



http://java.sun.com/xml/ns/j2ee,http://java.sun.com/xml/ns/javaee

http://geronimo.apache.org/xml/ns/deployment-1.2";>


org.apache.geronimo.configs
j2ee-corba-yoko
car





..

In trunk the connector-deployer/car gets configured in the same way
(with the yoko dependency) for both assemblies.

Jarek


Excellent observation Jarek.

I modified the config.xml to remove the gbean configurations and I was 
able to deploy without error.


Since the config.xml is now being generated from the module poms I 
wonder if there is a way to influence the outcome for the different 
assemblies.


Joe




On Jan 28, 2008 5:07 PM, Joe Bohn <[EMAIL PROTECTED]> wrote:

I discovered last Friday that deployment is broken on the Minimal
Assemblies.  (see https://issues.apache.org/jira/browse/GERONIMO-3787)

Attempting to deploy a simple web app that contains just a jsp (with or
without a deployment plan) we hit an error that there is a missing
dependency:

Missing dependency:
org.apache.geronimo.configs/j2ee-corba-yoko//car


Does this mean that we have a DefaultEnvironment setting or something
similar someplace that is attempting to add j2ee-corba-yoko as a
dependency to every web app being deployed?

Aside from the specs, I don't believe that we should include anything
from yoko in the minimal assemblies.

Looking at the config.xml for the server it appears this is getting
included via the connector-deployer config and its ResourceRefBuilder
GBean's EnvironmentBuilder.  Looking at the connector-deployer pom it
appears this defaultEnvironment has been for a long time, so I don't
know why it should start to cause a problem now.  The only relatively
recent change I see http://svn.apache.org/viewvc?rev=603109&view=rev .
Is it possible this had an impact on the minimal deployments such that
they now require a require this car to be available whereas it was
optional before?  Any pointers?

Joe







Re: Deployment broken on minimal assemblies

2008-01-30 Thread Jarek Gawor
In 2.0, it looks like the connector-deployer gbeans were configured
differently between minimal and full assemblies:

minimal's config.xml:



javaee's config.xml:



http://java.sun.com/xml/ns/j2ee,http://java.sun.com/xml/ns/javaee

http://geronimo.apache.org/xml/ns/deployment-1.2";>


org.apache.geronimo.configs
j2ee-corba-yoko
car





..

In trunk the connector-deployer/car gets configured in the same way
(with the yoko dependency) for both assemblies.

Jarek

On Jan 28, 2008 5:07 PM, Joe Bohn <[EMAIL PROTECTED]> wrote:
> I discovered last Friday that deployment is broken on the Minimal
> Assemblies.  (see https://issues.apache.org/jira/browse/GERONIMO-3787)
>
> Attempting to deploy a simple web app that contains just a jsp (with or
> without a deployment plan) we hit an error that there is a missing
> dependency:
>
> Missing dependency:
> org.apache.geronimo.configs/j2ee-corba-yoko//car
>
>
> Does this mean that we have a DefaultEnvironment setting or something
> similar someplace that is attempting to add j2ee-corba-yoko as a
> dependency to every web app being deployed?
>
> Aside from the specs, I don't believe that we should include anything
> from yoko in the minimal assemblies.
>
> Looking at the config.xml for the server it appears this is getting
> included via the connector-deployer config and its ResourceRefBuilder
> GBean's EnvironmentBuilder.  Looking at the connector-deployer pom it
> appears this defaultEnvironment has been for a long time, so I don't
> know why it should start to cause a problem now.  The only relatively
> recent change I see http://svn.apache.org/viewvc?rev=603109&view=rev .
> Is it possible this had an impact on the minimal deployments such that
> they now require a require this car to be available whereas it was
> optional before?  Any pointers?
>
> Joe
>