[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip getPartition() call to Hive Metastore when a partition already e…
autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip
getPartition() call to Hive Metastore when a partition already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716#discussion_r314566577
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreRegisterWithoutComputingPartitionDiff.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.hive.metastore;
+
+import com.google.common.base.Optional;
+import java.io.IOException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.gobblin.configuration.State;
+import org.apache.gobblin.hive.HivePartition;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.AlreadyExistsException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.thrift.TException;
+
+
+@Slf4j
+public class HiveMetaStoreRegisterWithoutComputingPartitionDiff extends
HiveMetaStoreBasedRegister {
+ public HiveMetaStoreRegisterWithoutComputingPartitionDiff(State state,
Optional metastoreURI) throws IOException {
+super(state, metastoreURI);
+ }
+
+ @Override
+ protected void OnPartitionExist(IMetaStoreClient client, Table table,
HivePartition partition,
+ Partition nativePartition, TException e) throws TException {
+if(e instanceof AlreadyExistsException) {
Review comment:
nit-pick: pay attention to blank between character and bracket
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip getPartition() call to Hive Metastore when a partition already e…
autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip
getPartition() call to Hive Metastore when a partition already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716#discussion_r314567012
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##
@@ -501,8 +482,30 @@ private void addOrAlterPartition(IMetaStoreClient client,
Table table, HiveParti
}
}
}
+ protected void OnPartitionExist(IMetaStoreClient client, Table table,
HivePartition partition, Partition nativePartition, TException e) throws
TException {
Review comment:
Why not make `addOrAlterPartition` protected and overwrite that ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip getPartition() call to Hive Metastore when a partition already e…
autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip
getPartition() call to Hive Metastore when a partition already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716#discussion_r314566770
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreRegisterWithoutComputingPartitionDiff.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.hive.metastore;
+
+import com.google.common.base.Optional;
+import java.io.IOException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.gobblin.configuration.State;
+import org.apache.gobblin.hive.HivePartition;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.AlreadyExistsException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.thrift.TException;
+
+
+@Slf4j
+public class HiveMetaStoreRegisterWithoutComputingPartitionDiff extends
HiveMetaStoreBasedRegister {
Review comment:
add a javadoc for usage of this
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip getPartition() call to Hive Metastore when a partition already e…
autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip
getPartition() call to Hive Metastore when a partition already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716#discussion_r314566652
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreRegisterWithoutComputingPartitionDiff.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.hive.metastore;
+
+import com.google.common.base.Optional;
+import java.io.IOException;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.gobblin.configuration.State;
+import org.apache.gobblin.hive.HivePartition;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+import org.apache.hadoop.hive.metastore.api.AlreadyExistsException;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.thrift.TException;
+
+
+@Slf4j
+public class HiveMetaStoreRegisterWithoutComputingPartitionDiff extends
HiveMetaStoreBasedRegister {
+ public HiveMetaStoreRegisterWithoutComputingPartitionDiff(State state,
Optional metastoreURI) throws IOException {
+super(state, metastoreURI);
+ }
+
+ @Override
+ protected void OnPartitionExist(IMetaStoreClient client, Table table,
HivePartition partition,
+ Partition nativePartition, TException e) throws TException {
+if(e instanceof AlreadyExistsException) {
+ log.info(String.format("Partition %s in table %s with location %s
already exists and no need to update",
Review comment:
this will end up flooding the log, suggest to use debug instead of info
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip getPartition() call to Hive Metastore when a partition already e…
autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip
getPartition() call to Hive Metastore when a partition already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716#discussion_r314565883
##
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
##
@@ -119,7 +119,7 @@
* when the first time a table/database is loaded into the cache, whether
they existed on the remote hiveMetaStore side.
*/
CacheLoader cacheLoader = new CacheLoader() {
- @Override
+@Override
Review comment:
Additional blank
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
