[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster …
codecov-io edited a comment on issue #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster … URL: https://github.com/apache/incubator-gobblin/pull/2863#issuecomment-572836083 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=h1) Report > Merging [#2863](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr=desc) will **decrease** coverage by `41.61%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #2863 +/- ## - Coverage 45.72%4.1% -41.62% + Complexity 9085 747 -8338 Files 19131917+4 Lines 72021 72188 +167 Branches 79437968 +25 - Hits 329292961-29968 - Misses36074 68908+32834 + Partials 3018 319 -2699 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/gobblin/cluster/GobblinHelixMultiManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TXVsdGlNYW5hZ2VyLmphdmE=) | `0% <ø> (-54.17%)` | `0 <0> (-19)` | | | [...e/gobblin/yarn/AbstractYarnAppSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vQWJzdHJhY3RZYXJuQXBwU2VjdXJpdHlNYW5hZ2VyLmphdmE=) | `0% <0%> (-46.16%)` | `0 <0> (-3)` | | | [.../gobblin/cluster/GobblinHelixMessagingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TWVzc2FnaW5nU2VydmljZS5qYXZh) | `0% <0%> (-65.17%)` | `0 <0> (-4)` | | | [...obblin/yarn/YarnAppSecurityManagerWithKeytabs.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkFwcFNlY3VyaXR5TWFuYWdlcldpdGhLZXl0YWJzLmphdmE=) | `0% <0%> (-20.59%)` | `0 <0> (-2)` | | | [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `0% <0%> (-19.95%)` | `0 <0> (-7)` | | | [...n/converter/AvroStringFieldDecryptorConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY3J5cHRvLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9BdnJvU3RyaW5nRmllbGREZWNyeXB0b3JDb252ZXJ0ZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | | | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-5%)` | | | [...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL2F2cm8vQXZyb0tleUNvbXBhY3Rvck91dHB1dEZvcm1hdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-3%)` | | | [...apache/gobblin/fork/CopyNotSupportedException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZm9yay9Db3B5Tm90U3VwcG9ydGVkRXhjZXB0aW9uLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | | | [.../gobblin/kafka/writer/KafkaWriterCommonConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbW1vbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-7%)` | | | ... and [1117 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=continue). > **Legend** - [Click here to
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster …
codecov-io edited a comment on issue #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster … URL: https://github.com/apache/incubator-gobblin/pull/2863#issuecomment-572836083 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=h1) Report > Merging [#2863](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr=desc) will **decrease** coverage by `41.61%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #2863 +/- ## - Coverage 45.72%4.1% -41.62% + Complexity 9085 747 -8338 Files 19131917+4 Lines 72021 72147 +126 Branches 79437963 +20 - Hits 329292961-29968 - Misses36074 68867+32793 + Partials 3018 319 -2699 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/gobblin/cluster/GobblinHelixMultiManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TXVsdGlNYW5hZ2VyLmphdmE=) | `0% <ø> (-54.17%)` | `0 <0> (-19)` | | | [...e/gobblin/yarn/AbstractYarnAppSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vQWJzdHJhY3RZYXJuQXBwU2VjdXJpdHlNYW5hZ2VyLmphdmE=) | `0% <0%> (-46.16%)` | `0 <0> (-3)` | | | [.../gobblin/cluster/GobblinHelixMessagingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TWVzc2FnaW5nU2VydmljZS5qYXZh) | `0% <0%> (-65.17%)` | `0 <0> (-4)` | | | [...obblin/yarn/YarnAppSecurityManagerWithKeytabs.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkFwcFNlY3VyaXR5TWFuYWdlcldpdGhLZXl0YWJzLmphdmE=) | `0% <0%> (-20.59%)` | `0 <0> (-2)` | | | [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `0% <0%> (-19.95%)` | `0 <0> (-7)` | | | [...n/converter/AvroStringFieldDecryptorConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY3J5cHRvLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9BdnJvU3RyaW5nRmllbGREZWNyeXB0b3JDb252ZXJ0ZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | | | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-5%)` | | | [...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL2F2cm8vQXZyb0tleUNvbXBhY3Rvck91dHB1dEZvcm1hdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-3%)` | | | [...apache/gobblin/fork/CopyNotSupportedException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZm9yay9Db3B5Tm90U3VwcG9ydGVkRXhjZXB0aW9uLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | | | [.../gobblin/kafka/writer/KafkaWriterCommonConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbW1vbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-7%)` | | | ... and [1117 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=continue). > **Legend** - [Click here to
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster …
codecov-io edited a comment on issue #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster … URL: https://github.com/apache/incubator-gobblin/pull/2863#issuecomment-572836083 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=h1) Report > Merging [#2863](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `57.14%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2863 +/- ## + Coverage 45.72% 45.77% +0.05% - Complexity 9085 9109 +24 Files 1913 1917 +4 Lines 7202172147 +126 Branches 7943 7963 +20 + Hits 3292933024 +95 - Misses3607436098 +24 - Partials 3018 3025 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/gobblin/cluster/GobblinHelixMultiManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TXVsdGlNYW5hZ2VyLmphdmE=) | `54.16% <ø> (ø)` | `19 <0> (ø)` | :arrow_down: | | [.../gobblin/cluster/GobblinHelixMessagingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TWVzc2FnaW5nU2VydmljZS5qYXZh) | `63.04% <0%> (-2.13%)` | `4 <0> (ø)` | | | [...e/gobblin/yarn/AbstractYarnAppSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vQWJzdHJhY3RZYXJuQXBwU2VjdXJpdHlNYW5hZ2VyLmphdmE=) | `48.75% <100%> (+2.59%)` | `6 <1> (+3)` | :arrow_up: | | [...obblin/yarn/YarnAppSecurityManagerWithKeytabs.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkFwcFNlY3VyaXR5TWFuYWdlcldpdGhLZXl0YWJzLmphdmE=) | `25.64% <33.33%> (+5.05%)` | `2 <0> (ø)` | :arrow_down: | | [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `21.39% <90.9%> (+1.44%)` | `8 <0> (+1)` | :arrow_up: | | [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0%> (-7.15%)` | `3% <0%> (-1%)` | | | [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | | | [...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==) | `77.04% <0%> (ø)` | `11% <0%> (?)` | | | [...ion/suite/CompactionWithWatermarkSuiteFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvbldpdGhXYXRlcm1hcmtTdWl0ZUZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (?)` | | | ... and [9 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr=continue). > **Legend** - [Click here to learn
