[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
codecov-io edited a comment on issue #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation URL: https://github.com/apache/incubator-gobblin/pull/2867#issuecomment-574426534 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=h1) Report > Merging [#2867](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/357d1db84c4601b3e50f7d26a05d8ce282c5159d?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `69.38%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #2867 +/- ## === + Coverage 45.75% 45.8% +0.05% - Complexity 91039109 +6 === Files 19171915 -2 Lines 72131 72262 +131 Branches 79567971 +15 === + Hits 33003 33103 +100 - Misses36102 36137 +35 + Partials 30263022 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/gobblin/util/HiveAvroTypeConstants.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGl2ZUF2cm9UeXBlQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=) | `57.72% <0%> (-0.53%)` | `81 <0> (ø)` | | | [...bblin/converter/filter/AvroSchemaFieldRemover.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9BdnJvU2NoZW1hRmllbGRSZW1vdmVyLmphdmE=) | `94.64% <100%> (-0.19%)` | `26 <0> (-1)` | | | [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `65.21% <75%> (+0.7%)` | `92 <3> (+7)` | :arrow_up: | | [.../gobblin/cluster/GobblinHelixMessagingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TWVzc2FnaW5nU2VydmljZS5qYXZh) | `63.04% <0%> (-2.13%)` | `4% <0%> (ø)` | | | [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | | | [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldEhkZnNEYXRhV3JpdGVyLmphdmE=) | | | | | [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXRIZGZzRGF0YVdyaXRlci5qYXZh) | | | | | [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9UZXN0UmVjb3JkLmphdmE=) | | | | | ... and [14 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
codecov-io edited a comment on issue #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation URL: https://github.com/apache/incubator-gobblin/pull/2867#issuecomment-574426534 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=h1) Report > Merging [#2867](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/357d1db84c4601b3e50f7d26a05d8ce282c5159d?src=pr=desc) will **increase** coverage by `0.05%`. > The diff coverage is `64.51%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #2867 +/- ## === + Coverage 45.75% 45.8% +0.05% - Complexity 91039108 +5 === Files 19171917 Lines 72131 72197 +66 Branches 79567963 +7 === + Hits 33003 33070 +67 + Misses36102 36098 -4 - Partials 30263029 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/gobblin/util/HiveAvroTypeConstants.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGl2ZUF2cm9UeXBlQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=) | `57.72% <0%> (-0.53%)` | `81 <0> (ø)` | | | [...bblin/converter/filter/AvroSchemaFieldRemover.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9BdnJvU2NoZW1hRmllbGRSZW1vdmVyLmphdmE=) | `94.64% <100%> (-0.19%)` | `26 <0> (-1)` | | | [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `64.75% <73.07%> (+0.23%)` | `88 <0> (+3)` | :arrow_up: | | [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `78.12% <0%> (-1.57%)` | `15% <0%> (-1%)` | | | [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | | | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `64.81% <0%> (-0.47%)` | `28% <0%> (ø)` | | | [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: | | [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: | | [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: | | ... and [3
