[jira] [Work logged] (GOBBLIN-720) delete the state store whenever a flow is deleted

2019-04-04 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-720?focusedWorklogId=223232=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223232
 ]

ASF GitHub Bot logged work on GOBBLIN-720:
--

Author: ASF GitHub Bot
Created on: 04/Apr/19 20:24
Start Date: 04/Apr/19 20:24
Worklog Time Spent: 10m 
  Work Description: asfgit commented on pull request #2587: [GOBBLIN-720 
Always delete state store
URL: https://github.com/apache/incubator-gobblin/pull/2587
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 223232)
Time Spent: 50m  (was: 40m)

> delete the state store whenever a flow is deleted
> -
>
> Key: GOBBLIN-720
> URL: https://issues.apache.org/jira/browse/GOBBLIN-720
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Arjun Singh Bora
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (GOBBLIN-720) delete the state store whenever a flow is deleted

2019-04-01 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-720?focusedWorklogId=221409=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221409
 ]

ASF GitHub Bot logged work on GOBBLIN-720:
--

Author: ASF GitHub Bot
Created on: 01/Apr/19 18:44
Start Date: 01/Apr/19 18:44
Worklog Time Spent: 10m 
  Work Description: sv2000 commented on pull request #2587: [GOBBLIN-720 
Always delete state store
URL: https://github.com/apache/incubator-gobblin/pull/2587#discussion_r271001196
 
 

 ##
 File path: 
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/job_monitor/KafkaJobMonitor.java
 ##
 @@ -115,4 +118,17 @@ protected void processMessage(MessageAndMetadata message) {
 }
   }
 
+  private void deleteStateStore(URI jobSpecUri) throws IOException {
+String[] uriTokens = jobSpecUri.getPath().split("/");
+if (null == this.datasetStateStore) {
+  log.warn("Job state store deletion failed as datasetstore is not 
initialized.");
+  return;
+} if (uriTokens.length != 3) {
+  log.error("Invalid URI {}.", jobSpecUri);
+  return;
+}
+String jobName = uriTokens[2];
 
 Review comment:
   Maybe, String jobName = uriTokens[uriTokens.length - 1]?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 221409)
Time Spent: 0.5h  (was: 20m)

> delete the state store whenever a flow is deleted
> -
>
> Key: GOBBLIN-720
> URL: https://issues.apache.org/jira/browse/GOBBLIN-720
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Arjun Singh Bora
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (GOBBLIN-720) delete the state store whenever a flow is deleted

2019-04-01 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-720?focusedWorklogId=221411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221411
 ]

ASF GitHub Bot logged work on GOBBLIN-720:
--

Author: ASF GitHub Bot
Created on: 01/Apr/19 18:44
Start Date: 01/Apr/19 18:44
Worklog Time Spent: 10m 
  Work Description: sv2000 commented on pull request #2587: [GOBBLIN-720 
Always delete state store
URL: https://github.com/apache/incubator-gobblin/pull/2587#discussion_r271001383
 
 

 ##
 File path: 
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/job_monitor/KafkaJobMonitor.java
 ##
 @@ -115,4 +118,17 @@ protected void processMessage(MessageAndMetadata message) {
 }
   }
 
+  private void deleteStateStore(URI jobSpecUri) throws IOException {
+String[] uriTokens = jobSpecUri.getPath().split("/");
+if (null == this.datasetStateStore) {
+  log.warn("Job state store deletion failed as datasetstore is not 
initialized.");
+  return;
+} if (uriTokens.length != 3) {
 
 Review comment:
   Perhaps define a constant EXPECTED_NUM_URI_TOKENS = 3 ?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 221411)
Time Spent: 40m  (was: 0.5h)

> delete the state store whenever a flow is deleted
> -
>
> Key: GOBBLIN-720
> URL: https://issues.apache.org/jira/browse/GOBBLIN-720
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Arjun Singh Bora
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (GOBBLIN-720) delete the state store whenever a flow is deleted

2019-04-01 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-720?focusedWorklogId=221407=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221407
 ]

ASF GitHub Bot logged work on GOBBLIN-720:
--

Author: ASF GitHub Bot
Created on: 01/Apr/19 18:42
Start Date: 01/Apr/19 18:42
Worklog Time Spent: 10m 
  Work Description: sv2000 commented on pull request #2587: [GOBBLIN-720 
Always delete state store
URL: https://github.com/apache/incubator-gobblin/pull/2587#discussion_r271000502
 
 

 ##
 File path: 
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/job_monitor/KafkaJobMonitor.java
 ##
 @@ -115,4 +118,17 @@ protected void processMessage(MessageAndMetadata message) {
 }
   }
 
+  private void deleteStateStore(URI jobSpecUri) throws IOException {
 
 Review comment:
   Can you add Javadoc to explain the behavior of deleteStateStore? Also, 
provide an example of what jobSpecUri should look like? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 221407)
Time Spent: 20m  (was: 10m)

> delete the state store whenever a flow is deleted
> -
>
> Key: GOBBLIN-720
> URL: https://issues.apache.org/jira/browse/GOBBLIN-720
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Arjun Singh Bora
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work logged] (GOBBLIN-720) delete the state store whenever a flow is deleted

2019-04-01 Thread ASF GitHub Bot (JIRA) 


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-720?focusedWorklogId=221353=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221353
 ]

ASF GitHub Bot logged work on GOBBLIN-720:
--

Author: ASF GitHub Bot
Created on: 01/Apr/19 16:54
Start Date: 01/Apr/19 16:54
Worklog Time Spent: 10m 
  Work Description: arjun4084346 commented on pull request #2587: 
[GOBBLIN-720 Always delete state store
URL: https://github.com/apache/incubator-gobblin/pull/2587
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below! @sv2000 please review
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   it is a partial rollback of 
https://github.com/apache/incubator-gobblin/commit/ccd7ba769308e720db33ea800d964df43df4e878.
   this pr will clean the state store whenever delete flow request is received 
by cluster manager
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   tests already in place
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 221353)
Time Spent: 10m
Remaining Estimate: 0h

> delete the state store whenever a flow is deleted
> -
>
> Key: GOBBLIN-720
> URL: https://issues.apache.org/jira/browse/GOBBLIN-720
> Project: Apache Gobblin
>  Issue Type: Improvement
>Reporter: Arjun Singh Bora
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)