[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=249699=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249699 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 28/May/19 23:09 Start Date: 28/May/19 23:09 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2652: Revert "[GOBBLIN-766] Emit Workunits Created event" URL: https://github.com/apache/incubator-gobblin/pull/2652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 249699) Time Spent: 2h 10m (was: 2h) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Fix For: 0.15.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=249698=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249698 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 28/May/19 23:08 Start Date: 28/May/19 23:08 Worklog Time Spent: 10m Work Description: htran1 commented on pull request #2652: Revert "[GOBBLIN-766] Emit Workunits Created event" URL: https://github.com/apache/incubator-gobblin/pull/2652 This reverts commit 7e5e0ff9eadc10206bacb90e4015ab834a7df2b4. Revert GOBBLIN-766 since materialization of workunits may be costly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 249698) Time Spent: 2h (was: 1h 50m) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Fix For: 0.15.0 > > Time Spent: 2h > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=246231=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246231 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 21/May/19 17:19 Start Date: 21/May/19 17:19 Worklog Time Spent: 10m Work Description: yukuai518 commented on issue #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#issuecomment-494481074 +1 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 246231) Time Spent: 1.5h (was: 1h 20m) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Time Spent: 1.5h > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[
https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=243809=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243809
]
ASF GitHub Bot logged work on GOBBLIN-766:
--
Author: ASF GitHub Bot
Created on: 17/May/19 03:32
Start Date: 17/May/19 03:32
Worklog Time Spent: 10m
Work Description: krishh85 commented on pull request #2636: [GOBBLIN-766]
Emit Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284967941
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##
@@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext
jobContext)
jobState.setState(JobState.RunningState.COMMITTED);
isWorkUnitsEmpty = true;
return;
+} else {
Review comment:
This depends on the consumer of the event. In our case we consume these
events in time-series and the workUnitsCreated event is set to 0 every minute
irrespective of this event emitted or otherwise and hence workUnitsEmpty helps
to distinguish in this scenario.
We could potentially emit both by removing the "else" clause.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 243809)
Time Spent: 1h 20m (was: 1h 10m)
> Emit Workunits created event in Apache gobblin
> -
>
> Key: GOBBLIN-766
> URL: https://issues.apache.org/jira/browse/GOBBLIN-766
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: kraman
>Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Emit a new workunits created metric to be captured for monitoring/Alerting
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=243806=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243806 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 17/May/19 03:29 Start Date: 17/May/19 03:29 Worklog Time Spent: 10m Work Description: krishh85 commented on pull request #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284967512 ## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/JobEvent.java ## @@ -31,6 +31,7 @@ public static final String LOCK_IN_USE = "LockInUse"; public static final String WORK_UNITS_MISSING = "WorkUnitsMissing"; public static final String WORK_UNITS_EMPTY = "WorkUnitsEmpty"; + public static final String WORK_UNITS_CREATED = "WorkUnitsCreated"; Review comment: EventName enum seems to be defined specifically for Job Timers. I am not sure if this is by design or it just happened to be that way.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 243806) Time Spent: 1h 10m (was: 1h) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Time Spent: 1h 10m > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242952=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242952 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 15/May/19 23:13 Start Date: 15/May/19 23:13 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284486925 ## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/JobEvent.java ## @@ -31,6 +31,7 @@ public static final String LOCK_IN_USE = "LockInUse"; public static final String WORK_UNITS_MISSING = "WorkUnitsMissing"; public static final String WORK_UNITS_EMPTY = "WorkUnitsEmpty"; + public static final String WORK_UNITS_CREATED = "WorkUnitsCreated"; Review comment: seems like these event name constants are scattered between `JobEvents` class and `EventNames` enum. should we combine them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 242952) Time Spent: 0.5h (was: 20m) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242955=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242955 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 15/May/19 23:18 Start Date: 15/May/19 23:18 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284486925 ## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/JobEvent.java ## @@ -31,6 +31,7 @@ public static final String LOCK_IN_USE = "LockInUse"; public static final String WORK_UNITS_MISSING = "WorkUnitsMissing"; public static final String WORK_UNITS_EMPTY = "WorkUnitsEmpty"; + public static final String WORK_UNITS_CREATED = "WorkUnitsCreated"; Review comment: optional: seems like these event name constants are scattered between `JobEvents` class and `EventNames` enum. should we combine them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 242955) Time Spent: 1h (was: 50m) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[
https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242954=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242954
]
ASF GitHub Bot logged work on GOBBLIN-766:
--
Author: ASF GitHub Bot
Created on: 15/May/19 23:18
Start Date: 15/May/19 23:18
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2636:
[GOBBLIN-766] Emit Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284487478
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##
@@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext
jobContext)
jobState.setState(JobState.RunningState.COMMITTED);
isWorkUnitsEmpty = true;
return;
+} else {
Review comment:
optional: how about reporting `workUnitsCreated=0` when there is no
workUnits instead of reporting `WorkUnitsEmpty` event?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 242954)
Time Spent: 50m (was: 40m)
> Emit Workunits created event in Apache gobblin
> -
>
> Key: GOBBLIN-766
> URL: https://issues.apache.org/jira/browse/GOBBLIN-766
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: kraman
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Emit a new workunits created metric to be captured for monitoring/Alerting
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[
https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242953=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242953
]
ASF GitHub Bot logged work on GOBBLIN-766:
--
Author: ASF GitHub Bot
Created on: 15/May/19 23:15
Start Date: 15/May/19 23:15
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2636:
[GOBBLIN-766] Emit Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284487478
##
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##
@@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext
jobContext)
jobState.setState(JobState.RunningState.COMMITTED);
isWorkUnitsEmpty = true;
return;
+} else {
Review comment:
how about reporting `workUnitsCreated=0` when there is no workUnits instead
of reporting `WorkUnitsEmpty` event?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 242953)
Time Spent: 40m (was: 0.5h)
> Emit Workunits created event in Apache gobblin
> -
>
> Key: GOBBLIN-766
> URL: https://issues.apache.org/jira/browse/GOBBLIN-766
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: kraman
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Emit a new workunits created metric to be captured for monitoring/Alerting
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[ https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242943=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242943 ] ASF GitHub Bot logged work on GOBBLIN-766: -- Author: ASF GitHub Bot Created on: 15/May/19 23:06 Start Date: 15/May/19 23:06 Worklog Time Spent: 10m Work Description: krishh85 commented on issue #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#issuecomment-492856313 @htran1 @yukuai518 Can you please review this PL. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 242943) Time Spent: 20m (was: 10m) > Emit Workunits created event in Apache gobblin > - > > Key: GOBBLIN-766 > URL: https://issues.apache.org/jira/browse/GOBBLIN-766 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: kraman >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Emit a new workunits created metric to be captured for monitoring/Alerting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GOBBLIN-766) Emit Workunits created event in Apache gobblin
[
https://issues.apache.org/jira/browse/GOBBLIN-766?focusedWorklogId=242642=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-242642
]
ASF GitHub Bot logged work on GOBBLIN-766:
--
Author: ASF GitHub Bot
Created on: 15/May/19 16:32
Start Date: 15/May/19 16:32
Worklog Time Spent: 10m
Work Description: krishraman commented on pull request #2636:
[GOBBLIN-766] Emit Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit test cases added.
tested new created event log messages in Yugioh cluster.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 242642)
Time Spent: 10m
Remaining Estimate: 0h
> Emit Workunits created event in Apache gobblin
> -
>
> Key: GOBBLIN-766
> URL: https://issues.apache.org/jira/browse/GOBBLIN-766
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: kraman
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Emit a new workunits created metric to be captured for monitoring/Alerting
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
