[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-08-15 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=295689=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295689
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 15/Aug/19 19:03
Start Date: 15/Aug/19 19:03
Worklog Time Spent: 10m 
  Work Description: codecov-io commented on issue #2704: [GOBBLIN-835] Date 
Converter
URL: 
https://github.com/apache/incubator-gobblin/pull/2704#issuecomment-521758283
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2704?src=pr=h1)
 Report
   > Merging 
[#2704](https://codecov.io/gh/apache/incubator-gobblin/pull/2704?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/8903ebf3807af3369839069e2082afa70c7fe77e?src=pr=desc)
 will **increase** coverage by `0.2%`.
   > The diff coverage is `80.95%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/graphs/tree.svg?width=650=4MgURJ0bGc=150=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2704?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ## master   #2704 +/-   ##
   ==
   + Coverage  44.9%   45.1%   +0.2% 
   - Complexity 87138746 +33 
   ==
 Files  18791880  +1 
 Lines 70079   70204+125 
 Branches   77037709  +6 
   ==
   + Hits  31466   31666+200 
   + Misses35702   35615 -87 
   - Partials   29112923 +12
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2704?src=pr=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...g/apache/gobblin/converter/date/DateConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9kYXRlL0RhdGVDb252ZXJ0ZXIuamF2YQ==)
 | `80.95% <80.95%> (ø)` | `5 <5> (?)` | |
   | 
[...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh)
 | `70% <0%> (-30%)` | `3% <0%> (-2%)` | |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `35.51% <0%> (-6.33%)` | `12% <0%> (-2%)` | |
   | 
[.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh)
 | `60.41% <0%> (-3.48%)` | `9% <0%> (ø)` | |
   | 
[...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==)
 | `81.53% <0%> (-1.8%)` | `26% <0%> (-2%)` | |
   | 
[...ache/gobblin/cluster/GobblinHelixJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iU2NoZWR1bGVyLmphdmE=)
 | `39.21% <0%> (-1.31%)` | `6% <0%> (ø)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `64.78% <0%> (-0.94%)` | `29% <0%> (ø)` | |
   | 
[...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh)
 | `54.58% <0%> (-0.46%)` | `25% <0%> (ø)` | |
   | 
[...g/apache/gobblin/writer/PartitionedDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9QYXJ0aXRpb25lZERhdGFXcml0ZXIuamF2YQ==)
 | `58.89% <0%> (-0.23%)` | `28% <0%> (+1%)` | |
   | 
[.../org/apache/gobblin/metrics/event/TimingEvent.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2704/diff?src=pr=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9UaW1pbmdFdmVudC5qYXZh)
 | `70% <0%> (ø)` | `15% <0%> (ø)` | 

[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=292385=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292385
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 10/Aug/19 01:22
Start Date: 10/Aug/19 01:22
Worklog Time Spent: 10m 
  Work Description: jhsenjaliya commented on pull request #2704: 
[GOBBLIN-835] Date Converter
URL: https://github.com/apache/incubator-gobblin/pull/2704#discussion_r312684855
 
 

 ##
 File path: 
gobblin-core/src/main/java/org/apache/gobblin/converter/date/DateConverter.java
 ##
 @@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.converter.date;
+
+import com.google.common.base.Preconditions;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.Converter;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.converter.SchemaConversionException;
+import org.apache.gobblin.converter.SingleRecordIterable;
+import org.apache.gobblin.util.EmptyIterable;
+
+import java.lang.reflect.Method;
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
+import java.util.Calendar;
+import java.util.Date;
+import java.util.TimeZone;
+
+public class DateConverter extends Converter {
+
+private String inputTimezone;
+private String inputTimeformat;
+private String outputTimezone;
+private String outputTimeformat;
+
+private String date;
+
+public String getDate() {
+return date;
+}
+
+public void setDate(String date) {
+this.date = date;
+}
+
+@Override
+public Converter init(WorkUnitState workUnit) {
+Calendar cal = Calendar.getInstance();
+TimeZone tz = cal.getTimeZone();
+
+
Preconditions.checkArgument(workUnit.contains(ConfigurationKeys.CONVERTER_INPUT_TIMEZONE),
 "Cannot use "
++ this.getClass().getName() + " without specifying " + 
ConfigurationKeys.CONVERTER_INPUT_TIMEZONE);
+
Preconditions.checkArgument(workUnit.contains(ConfigurationKeys.CONVERTER_INPUT_TIMEFORMAT),
 "Cannot use "
++ this.getClass().getName() + " without specifying " + 
ConfigurationKeys.CONVERTER_INPUT_TIMEFORMAT);
+
+this.inputTimezone = 
workUnit.getProp(ConfigurationKeys.CONVERTER_INPUT_TIMEZONE);
+this.inputTimeformat = 
workUnit.getProp(ConfigurationKeys.CONVERTER_INPUT_TIMEFORMAT);
+this.outputTimezone = 
workUnit.contains(ConfigurationKeys.CONVERTER_OUTPUT_TIMEZONE) ? 
workUnit.getProp(ConfigurationKeys.CONVERTER_OUTPUT_TIMEZONE) : 
tz.toZoneId().toString();
+this.outputTimeformat = 
workUnit.contains(ConfigurationKeys.CONVERTER_OUTPUT_TIMEFORMAT) ? 
workUnit.getProp(ConfigurationKeys.CONVERTER_OUTPUT_TIMEFORMAT) : "MM-dd- 
HH:mm:ss z";
+
+return this;
+}
+
+@Override
+public SO convertSchema(SI inputSchema, WorkUnitState workUnit) throws 
SchemaConversionException {
+return (SO)inputSchema;
+}
+
+@Override
+public Iterable convertRecord(SO outputSchema, DI iR, WorkUnitState 
workUnit)
+throws DataConversionException {
+String inputRecord = "";
+try{
+Class inputRecordClass = iR.getClass();
+Method inputRecordClassGetDate = 
inputRecordClass.getMethod("getDate", null);
+inputRecord = (String)inputRecordClassGetDate.invoke(iR, null);
 
 Review comment:
   inputField than inputRecord
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292385)
Time Spent: 1h 20m  (was: 1h 10m)

> add date transformation converter
> -
>
> Key: GOBBLIN-835
>   

[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=292386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292386
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 10/Aug/19 01:22
Start Date: 10/Aug/19 01:22
Worklog Time Spent: 10m 
  Work Description: jhsenjaliya commented on pull request #2704: 
[GOBBLIN-835] Date Converter
URL: https://github.com/apache/incubator-gobblin/pull/2704#discussion_r312684887
 
 

 ##
 File path: 
gobblin-core/src/main/java/org/apache/gobblin/converter/date/DateConverter.java
 ##
 @@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.converter.date;
+
+import com.google.common.base.Preconditions;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.Converter;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.converter.SchemaConversionException;
+import org.apache.gobblin.converter.SingleRecordIterable;
+import org.apache.gobblin.util.EmptyIterable;
+
+import java.lang.reflect.Method;
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
+import java.util.Calendar;
+import java.util.Date;
+import java.util.TimeZone;
+
+public class DateConverter extends Converter {
+
+private String inputTimezone;
+private String inputTimeformat;
+private String outputTimezone;
+private String outputTimeformat;
+
+private String date;
+
+public String getDate() {
+return date;
+}
+
+public void setDate(String date) {
+this.date = date;
+}
+
+@Override
+public Converter init(WorkUnitState workUnit) {
+Calendar cal = Calendar.getInstance();
+TimeZone tz = cal.getTimeZone();
+
+
Preconditions.checkArgument(workUnit.contains(ConfigurationKeys.CONVERTER_INPUT_TIMEZONE),
 "Cannot use "
++ this.getClass().getName() + " without specifying " + 
ConfigurationKeys.CONVERTER_INPUT_TIMEZONE);
+
Preconditions.checkArgument(workUnit.contains(ConfigurationKeys.CONVERTER_INPUT_TIMEFORMAT),
 "Cannot use "
++ this.getClass().getName() + " without specifying " + 
ConfigurationKeys.CONVERTER_INPUT_TIMEFORMAT);
+
+this.inputTimezone = 
workUnit.getProp(ConfigurationKeys.CONVERTER_INPUT_TIMEZONE);
+this.inputTimeformat = 
workUnit.getProp(ConfigurationKeys.CONVERTER_INPUT_TIMEFORMAT);
+this.outputTimezone = 
workUnit.contains(ConfigurationKeys.CONVERTER_OUTPUT_TIMEZONE) ? 
workUnit.getProp(ConfigurationKeys.CONVERTER_OUTPUT_TIMEZONE) : 
tz.toZoneId().toString();
+this.outputTimeformat = 
workUnit.contains(ConfigurationKeys.CONVERTER_OUTPUT_TIMEFORMAT) ? 
workUnit.getProp(ConfigurationKeys.CONVERTER_OUTPUT_TIMEFORMAT) : "MM-dd- 
HH:mm:ss z";
+
+return this;
+}
+
+@Override
+public SO convertSchema(SI inputSchema, WorkUnitState workUnit) throws 
SchemaConversionException {
+return (SO)inputSchema;
+}
+
+@Override
+public Iterable convertRecord(SO outputSchema, DI iR, WorkUnitState 
workUnit)
+throws DataConversionException {
+String inputRecord = "";
+try{
+Class inputRecordClass = iR.getClass();
+Method inputRecordClassGetDate = 
inputRecordClass.getMethod("getDate", null);
 
 Review comment:
   getDateMethod
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292386)
Time Spent: 1.5h  (was: 1h 20m)

> add date transformation converter
> -
>
> Key: GOBBLIN-835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-835
> Project: 

[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=292383=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292383
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 10/Aug/19 01:14
Start Date: 10/Aug/19 01:14
Worklog Time Spent: 10m 
  Work Description: jhsenjaliya commented on pull request #2704: 
[GOBBLIN-835] Date Converter
URL: https://github.com/apache/incubator-gobblin/pull/2704#discussion_r312684575
 
 

 ##
 File path: 
gobblin-core/src/main/java/org/apache/gobblin/converter/date/DateConverter.java
 ##
 @@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.converter.date;
+
+import com.google.common.base.Preconditions;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.WorkUnitState;
+import org.apache.gobblin.converter.Converter;
+import org.apache.gobblin.converter.DataConversionException;
+import org.apache.gobblin.converter.SchemaConversionException;
+import org.apache.gobblin.converter.SingleRecordIterable;
+import org.apache.gobblin.util.EmptyIterable;
+
+import java.lang.reflect.Method;
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
+import java.util.Calendar;
+import java.util.Date;
+import java.util.TimeZone;
+
+public class DateConverter extends Converter {
 
 Review comment:
   pls add some class comment
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292383)
Time Spent: 1h 10m  (was: 1h)

> add date transformation converter
> -
>
> Key: GOBBLIN-835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-835
> Project: Apache Gobblin
>  Issue Type: New Feature
>Affects Versions: 0.14.0
>Reporter: Jay Sen
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> create new convertor for date format 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=292382=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292382
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 10/Aug/19 01:11
Start Date: 10/Aug/19 01:11
Worklog Time Spent: 10m 
  Work Description: jhsenjaliya commented on pull request #2704: 
[GOBBLIN-835] Date Converter
URL: https://github.com/apache/incubator-gobblin/pull/2704#discussion_r312684417
 
 

 ##
 File path: 
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
 ##
 @@ -327,6 +327,10 @@
   public static final String CONVERTER_SKIP_FAILED_RECORD = 
"converter.skipFailedRecord";
   public static final String CONVERTER_AVRO_SCHEMA_KEY = 
"converter.avroSchema";
   public static final String CONVERTER_IGNORE_FIELDS = 
"converter.ignoreFields";
+  public static final String CONVERTER_INPUT_TIMEZONE = 
"converter.input.timezone";
 
 Review comment:
   This should be part of the converter class since its specific to that date 
converter
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292382)
Time Spent: 1h  (was: 50m)

> add date transformation converter
> -
>
> Key: GOBBLIN-835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-835
> Project: Apache Gobblin
>  Issue Type: New Feature
>Affects Versions: 0.14.0
>Reporter: Jay Sen
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> create new convertor for date format 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=292192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292192
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 09/Aug/19 18:00
Start Date: 09/Aug/19 18:00
Worklog Time Spent: 10m 
  Work Description: ssnarvekar01 commented on pull request #2704: 
[GOBBLIN-835] Date Converter
URL: https://github.com/apache/incubator-gobblin/pull/2704
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292192)
Time Spent: 50m  (was: 40m)

> add date transformation converter
> -
>
> Key: GOBBLIN-835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-835
> Project: Apache Gobblin
>  Issue Type: New Feature
>Affects Versions: 0.14.0
>Reporter: Jay Sen
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> create new convertor for date format 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-08-09 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=292183=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292183
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 09/Aug/19 17:43
Start Date: 09/Aug/19 17:43
Worklog Time Spent: 10m 
  Work Description: ssnarvekar01 commented on pull request #2695: 
GOBBLIN-835
URL: https://github.com/apache/incubator-gobblin/pull/2695
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 292183)
Time Spent: 40m  (was: 0.5h)

> add date transformation converter
> -
>
> Key: GOBBLIN-835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-835
> Project: Apache Gobblin
>  Issue Type: New Feature
>Affects Versions: 0.14.0
>Reporter: Jay Sen
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> create new convertor for date format 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-08-07 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=290789=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290789
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 07/Aug/19 21:35
Start Date: 07/Aug/19 21:35
Worklog Time Spent: 10m 
  Work Description: ssnarvekar01 commented on issue #2695: GOBBLIN-835
URL: 
https://github.com/apache/incubator-gobblin/pull/2695#issuecomment-519277833
 
 
   @jhsenjaliya can you please review this?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 290789)
Time Spent: 0.5h  (was: 20m)

> add date transformation converter
> -
>
> Key: GOBBLIN-835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-835
> Project: Apache Gobblin
>  Issue Type: New Feature
>Affects Versions: 0.14.0
>Reporter: Jay Sen
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> create new convertor for date format 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-07-29 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=284605=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284605
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 29/Jul/19 23:11
Start Date: 29/Jul/19 23:11
Worklog Time Spent: 10m 
  Work Description: codecov-io commented on issue #2695: GOBBLIN-835
URL: 
https://github.com/apache/incubator-gobblin/pull/2695#issuecomment-516196381
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2695?src=pr=h1)
 Report
   > Merging 
[#2695](https://codecov.io/gh/apache/incubator-gobblin/pull/2695?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/07dcf2bcf57bb835290be925c5ab47bfbe0cddd0?src=pr=desc)
 will **decrease** coverage by `0.05%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/graphs/tree.svg?width=650=4MgURJ0bGc=150=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2695?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#2695  +/-   ##
   
   - Coverage 44.82%   44.76%   -0.06% 
   + Complexity 8692 8687   -5 
   
 Files  1878 1879   +1 
 Lines 7005870107  +49 
 Branches   7701 7704   +3 
   
   - Hits  3140431385  -19 
   - Misses3574935816  +67 
   - Partials   2905 2906   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2695?src=pr=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...g/apache/gobblin/converter/date/DateConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9kYXRlL0RhdGVDb252ZXJ0ZXIuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh)
 | `70% <0%> (-30%)` | `3% <0%> (-2%)` | |
   | 
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
 | `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | |
   | 
[.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh)
 | `60.41% <0%> (-3.48%)` | `9% <0%> (ø)` | |
   | 
[...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==)
 | `81.25% <0%> (-2.09%)` | `26% <0%> (-2%)` | |
   | 
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
 | `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `64.31% <0%> (-1.41%)` | `29% <0%> (ø)` | |
   | 
[...ache/gobblin/cluster/GobblinHelixJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iU2NoZWR1bGVyLmphdmE=)
 | `39.21% <0%> (-1.31%)` | `6% <0%> (ø)` | |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2695/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `41.83% <0%> (ø)` | `13% <0%> 

[jira] [Work logged] (GOBBLIN-835) add date transformation converter

2019-07-27 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GOBBLIN-835?focusedWorklogId=283858=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283858
 ]

ASF GitHub Bot logged work on GOBBLIN-835:
--

Author: ASF GitHub Bot
Created on: 28/Jul/19 00:25
Start Date: 28/Jul/19 00:25
Worklog Time Spent: 10m 
  Work Description: ssnarvekar01 commented on pull request #2695: 
GOBBLIN-835
URL: https://github.com/apache/incubator-gobblin/pull/2695
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
   - https://issues.apache.org/jira/browse/GOBBLIN-835
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
   1. Subject is separated from body by a blank line
   2. Subject is limited to 50 characters
   3. Subject does not end with a period
   4. Subject uses the imperative mood ("add", not "adding")
   5. Body wraps at 72 characters
   6. Body explains "what" and "why", not "how"
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 283858)
Time Spent: 10m
Remaining Estimate: 0h

> add date transformation converter
> -
>
> Key: GOBBLIN-835
> URL: https://issues.apache.org/jira/browse/GOBBLIN-835
> Project: Apache Gobblin
>  Issue Type: New Feature
>Affects Versions: 0.14.0
>Reporter: Jay Sen
>Priority: Major
> Fix For: 0.15.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> create new convertor for date format 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)