[jira] [Work logged] (GOBBLIN-849) Connection to Oracle using service name and update metadata query for OracleExtractor
[
https://issues.apache.org/jira/browse/GOBBLIN-849?focusedWorklogId=300742=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300742
]
ASF GitHub Bot logged work on GOBBLIN-849:
--
Author: ASF GitHub Bot
Created on: 24/Aug/19 18:57
Start Date: 24/Aug/19 18:57
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2705: [GOBBLIN-849]
Connect to Oracle using service name, update metadata query
URL: https://github.com/apache/incubator-gobblin/pull/2705#discussion_r317371335
##
File path:
gobblin-modules/gobblin-sql/src/main/java/org/apache/gobblin/source/jdbc/OracleExtractor.java
##
@@ -253,8 +253,14 @@ public String constructSampleClause() {
public String getConnectionUrl() {
String host =
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_HOST_NAME);
String port =
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_PORT);
-String sid =
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SID).trim();
-String url = "jdbc:oracle:thin:@" + host.trim() +
(StringUtils.isEmpty(port) ? "" : ":" + port) + ":" + sid;
+String sid =
this.workUnitState.contains(ConfigurationKeys.SOURCE_CONN_SID) ?
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SID).trim() : "";
+String serviceName =
this.workUnitState.contains(ConfigurationKeys.SOURCE_CONN_SERVICE_NAME) ?
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SERVICE_NAME).trim() :
"";
+String conn;
+if(sid != null && sid.length() > 0)
Review comment:
Replace with if (!Strings.isNullOrEmpty(sid)) ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 300742)
Time Spent: 40m (was: 0.5h)
> Connection to Oracle using service name and update metadata query for
> OracleExtractor
> -
>
> Key: GOBBLIN-849
> URL: https://issues.apache.org/jira/browse/GOBBLIN-849
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Siddhesh Sudesh Narvekar
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This issue has an improvement and solves a bug.
> Improvement: Enable OracleExtractor to connect to Oracle using service name.
> Bug: METADATA_SCHEMA_PSTMT_FORMAT query updated to consider owner and table
> name in upper case.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (GOBBLIN-849) Connection to Oracle using service name and update metadata query for OracleExtractor
[
https://issues.apache.org/jira/browse/GOBBLIN-849?focusedWorklogId=300741=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300741
]
ASF GitHub Bot logged work on GOBBLIN-849:
--
Author: ASF GitHub Bot
Created on: 24/Aug/19 18:57
Start Date: 24/Aug/19 18:57
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2705: [GOBBLIN-849]
Connect to Oracle using service name, update metadata query
URL: https://github.com/apache/incubator-gobblin/pull/2705#discussion_r317371445
##
File path:
gobblin-modules/gobblin-sql/src/main/java/org/apache/gobblin/source/jdbc/OracleExtractor.java
##
@@ -253,8 +253,14 @@ public String constructSampleClause() {
public String getConnectionUrl() {
String host =
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_HOST_NAME);
String port =
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_PORT);
-String sid =
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SID).trim();
-String url = "jdbc:oracle:thin:@" + host.trim() +
(StringUtils.isEmpty(port) ? "" : ":" + port) + ":" + sid;
+String sid =
this.workUnitState.contains(ConfigurationKeys.SOURCE_CONN_SID) ?
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SID).trim() : "";
+String serviceName =
this.workUnitState.contains(ConfigurationKeys.SOURCE_CONN_SERVICE_NAME) ?
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_SERVICE_NAME).trim() :
"";
+String conn;
+if(sid != null && sid.length() > 0)
+ conn = ":" + sid;
Review comment:
Replace "conn" with "serviceString" or something more meaningful?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 300741)
Time Spent: 40m (was: 0.5h)
> Connection to Oracle using service name and update metadata query for
> OracleExtractor
> -
>
> Key: GOBBLIN-849
> URL: https://issues.apache.org/jira/browse/GOBBLIN-849
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Siddhesh Sudesh Narvekar
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This issue has an improvement and solves a bug.
> Improvement: Enable OracleExtractor to connect to Oracle using service name.
> Bug: METADATA_SCHEMA_PSTMT_FORMAT query updated to consider owner and table
> name in upper case.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (GOBBLIN-849) Connection to Oracle using service name and update metadata query for OracleExtractor
[ https://issues.apache.org/jira/browse/GOBBLIN-849?focusedWorklogId=292387=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292387 ] ASF GitHub Bot logged work on GOBBLIN-849: -- Author: ASF GitHub Bot Created on: 10/Aug/19 01:37 Start Date: 10/Aug/19 01:37 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on issue #2705: [GOBBLIN-849] Connection to Oracle using service name and update meta… URL: https://github.com/apache/incubator-gobblin/pull/2705#issuecomment-520107507 +1, LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 292387) Time Spent: 0.5h (was: 20m) > Connection to Oracle using service name and update metadata query for > OracleExtractor > - > > Key: GOBBLIN-849 > URL: https://issues.apache.org/jira/browse/GOBBLIN-849 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: Siddhesh Sudesh Narvekar >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > This issue has an improvement and solves a bug. > Improvement: Enable OracleExtractor to connect to Oracle using service name. > Bug: METADATA_SCHEMA_PSTMT_FORMAT query updated to consider owner and table > name in upper case. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (GOBBLIN-849) Connection to Oracle using service name and update metadata query for OracleExtractor
[ https://issues.apache.org/jira/browse/GOBBLIN-849?focusedWorklogId=292309=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292309 ] ASF GitHub Bot logged work on GOBBLIN-849: -- Author: ASF GitHub Bot Created on: 09/Aug/19 22:30 Start Date: 09/Aug/19 22:30 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2705: [GOBBLIN-849] Connection to Oracle using service name and update meta… URL: https://github.com/apache/incubator-gobblin/pull/2705#issuecomment-520084380 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr=h1) Report > Merging [#2705](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/8903ebf3807af3369839069e2082afa70c7fe77e?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2705 +/- ## - Coverage 44.9% 44.88% -0.02% + Complexity 8713 8709 -4 Files 1879 1879 Lines 7007970083 +4 Branches 7703 7706 +3 - Hits 3146631454 -12 - Misses3570235719 +17 + Partials 2911 2910 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2705?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/gobblin/source/jdbc/OracleExtractor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL09yYWNsZUV4dHJhY3Rvci5qYXZh) | `43.83% <0%> (-1.24%)` | `7 <0> (ø)` | | | [...bblin/cluster/GobblinHelixJobLauncherListener.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXJMaXN0ZW5lci5qYXZh) | `70% <0%> (-30%)` | `3% <0%> (-2%)` | | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | | | [.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh) | `60.41% <0%> (-3.48%)` | `9% <0%> (ø)` | | | [...ache/gobblin/couchbase/writer/CouchbaseWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY291Y2hiYXNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvdWNoYmFzZS93cml0ZXIvQ291Y2hiYXNlV3JpdGVyLmphdmE=) | `66.27% <0%> (-2.33%)` | `11% <0%> (ø)` | | | [...pache/gobblin/cluster/GobblinHelixJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iTGF1bmNoZXIuamF2YQ==) | `81.25% <0%> (-2.09%)` | `26% <0%> (-2%)` | | | [...ache/gobblin/cluster/GobblinHelixJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iU2NoZWR1bGVyLmphdmE=) | `39.21% <0%> (-1.31%)` | `6% <0%> (ø)` | | | [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2705/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `41.83% <0%> (ø)` | `13% <0%> (-1%)` | :arrow_down: | |
[jira] [Work logged] (GOBBLIN-849) Connection to Oracle using service name and update metadata query for OracleExtractor
[
https://issues.apache.org/jira/browse/GOBBLIN-849?focusedWorklogId=292272=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292272
]
ASF GitHub Bot logged work on GOBBLIN-849:
--
Author: ASF GitHub Bot
Created on: 09/Aug/19 21:35
Start Date: 09/Aug/19 21:35
Worklog Time Spent: 10m
Work Description: ssnarvekar01 commented on pull request #2705:
[GOBBLIN-849] Connection to Oracle using service name and update meta…
URL: https://github.com/apache/incubator-gobblin/pull/2705
…data query for OracleExtractor
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 292272)
Time Spent: 10m
Remaining Estimate: 0h
> Connection to Oracle using service name and update metadata query for
> OracleExtractor
> -
>
> Key: GOBBLIN-849
> URL: https://issues.apache.org/jira/browse/GOBBLIN-849
> Project: Apache Gobblin
> Issue Type: Improvement
>Reporter: Siddhesh Sudesh Narvekar
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This issue has an improvement and solves a bug.
> Improvement: Enable OracleExtractor to connect to Oracle using service name.
> Bug: METADATA_SCHEMA_PSTMT_FORMAT query updated to consider owner and table
> name in upper case.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
