[jira] [Work logged] (GOBBLIN-907) implement a StateCleanerSource to clean states (not dataset state or dataset)
[ https://issues.apache.org/jira/browse/GOBBLIN-907?focusedWorklogId=440369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440369 ] ASF GitHub Bot logged work on GOBBLIN-907: -- Author: ASF GitHub Bot Created on: 02/Jun/20 18:04 Start Date: 02/Jun/20 18:04 Worklog Time Spent: 10m Work Description: arjun4084346 closed pull request #2761: URL: https://github.com/apache/incubator-gobblin/pull/2761 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 440369) Time Spent: 1h (was: 50m) > implement a StateCleanerSource to clean states (not dataset state or dataset) > - > > Key: GOBBLIN-907 > URL: https://issues.apache.org/jira/browse/GOBBLIN-907 > Project: Apache Gobblin > Issue Type: New Feature >Reporter: Arjun Singh Bora >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-907) implement a StateCleanerSource to clean states (not dataset state or dataset)
[
https://issues.apache.org/jira/browse/GOBBLIN-907?focusedWorklogId=333602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333602
]
ASF GitHub Bot logged work on GOBBLIN-907:
--
Author: ASF GitHub Bot
Created on: 24/Oct/19 17:16
Start Date: 24/Oct/19 17:16
Worklog Time Spent: 10m
Work Description: zxcware commented on pull request #2761: [GOBBLIN-907]
implement StateCleanerSource
URL: https://github.com/apache/incubator-gobblin/pull/2761#discussion_r338693964
##
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/StateCleaner.java
##
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.data.management.retention;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.List;
+import java.util.Properties;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+
+import org.apache.commons.lang.exception.ExceptionUtils;
+import org.apache.hadoop.fs.FileSystem;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.codahale.metrics.Meter;
+import com.google.common.base.Optional;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.Lists;
+import com.google.common.io.Closer;
+import com.google.common.util.concurrent.FutureCallback;
+import com.google.common.util.concurrent.Futures;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.configuration.State;
+import org.apache.gobblin.data.management.retention.dataset.CleanableDataset;
+import
org.apache.gobblin.data.management.retention.dataset.finder.TimeBasedStateStoreDatasetFinder;
+import org.apache.gobblin.instrumented.Instrumentable;
+import org.apache.gobblin.instrumented.Instrumented;
+import org.apache.gobblin.metastore.StateStoreDataset;
+import org.apache.gobblin.metastore.StateStoreDatasetFinder;
+import org.apache.gobblin.metrics.GobblinMetrics;
+import org.apache.gobblin.metrics.MetricContext;
+import org.apache.gobblin.metrics.Tag;
+import org.apache.gobblin.metrics.event.EventSubmitter;
+import org.apache.gobblin.util.AzkabanTags;
+import org.apache.gobblin.util.ExecutorsUtils;
+import org.apache.gobblin.util.RateControlledFileSystem;
+import org.apache.gobblin.util.WriterUtils;
+import org.apache.gobblin.util.executors.ScalingThreadPoolExecutor;
+
+
+/**
+ * Finds existing versions of datasets and cleans old or deprecated versions.
+ */
+public class StateCleaner implements Instrumentable, Closeable {
Review comment:
This state store pr has lots of duplicate logic to dataset store clean,
which implies that we could reuse the existing codes to achieve what we want.
Let's think about it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 333602)
Time Spent: 50m (was: 40m)
> implement a StateCleanerSource to clean states (not dataset state or dataset)
> -
>
> Key: GOBBLIN-907
> URL: https://issues.apache.org/jira/browse/GOBBLIN-907
> Project: Apache Gobblin
> Issue Type: New Feature
>Reporter: Arjun Singh Bora
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (GOBBLIN-907) implement a StateCleanerSource to clean states (not dataset state or dataset)
[ https://issues.apache.org/jira/browse/GOBBLIN-907?focusedWorklogId=330245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330245 ] ASF GitHub Bot logged work on GOBBLIN-907: -- Author: ASF GitHub Bot Created on: 18/Oct/19 03:24 Start Date: 18/Oct/19 03:24 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2761: [GOBBLIN-907] implement StateCleanerSource URL: https://github.com/apache/incubator-gobblin/pull/2761#issuecomment-541276201 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=h1) Report > Merging [#2761](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/bce5cbc3c8bb607b8c1af56dd3b41f75bbb2b92e?src=pr&el=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `25.44%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2761 +/- ## - Coverage 45.3% 45.24% -0.06% - Complexity 8841 8867 +26 Files 1890 1904 +14 Lines 7069870975 +277 Branches 7766 7792 +26 + Hits 3202832113 +85 - Misses3571835905 +187 - Partials 2952 2957 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...t/version/TimestampedDatasetStateStoreVersion.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vVGltZXN0YW1wZWREYXRhc2V0U3RhdGVTdG9yZVZlcnNpb24uamF2YQ==) | `44.44% <ø> (ø)` | `5 <0> (ø)` | :arrow_down: | | [...lin/runtime/retention/StateCleanerTaskFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9yZXRlbnRpb24vU3RhdGVDbGVhbmVyVGFza0ZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...che/gobblin/metastore/StateStoreDatasetFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1N0YXRlU3RvcmVEYXRhc2V0RmluZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...rg/apache/gobblin/metastore/StateStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1N0YXRlU3RvcmVEYXRhc2V0LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...he/gobblin/runtime/retention/StateCleanerTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9yZXRlbnRpb24vU3RhdGVDbGVhbmVyVGFzay5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...obblin/data/management/retention/StateCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9TdGF0ZUNsZWFuZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...he/gobblin/metastore/FsStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZzU3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ava/org/apache/gobblin/metastore/FsStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZzU3RhdGVTdG9yZS5qYXZh) | `33.54% <0%> (-2.32%)` | `14 <0> (ø)` | | | [...nt/retention/state/CleanableStateStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9zdGF0ZS9DbGVhbmFibGVTdGF0ZVN0b3JlRGF0YXNldC5qYXZh) | `100% <100%> (ø)` | `3 <3> (?)` | | | [...taset/finder/TimeBasedStateStoreDatasetFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=
[jira] [Work logged] (GOBBLIN-907) implement a StateCleanerSource to clean states (not dataset state or dataset)
[ https://issues.apache.org/jira/browse/GOBBLIN-907?focusedWorklogId=327192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327192 ] ASF GitHub Bot logged work on GOBBLIN-907: -- Author: ASF GitHub Bot Created on: 12/Oct/19 03:41 Start Date: 12/Oct/19 03:41 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2761: [GOBBLIN-907] implement StateCleanerSource URL: https://github.com/apache/incubator-gobblin/pull/2761#issuecomment-541276201 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=h1) Report > Merging [#2761](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/bce5cbc3c8bb607b8c1af56dd3b41f75bbb2b92e?src=pr&el=desc) will **decrease** coverage by `0.15%`. > The diff coverage is `0.48%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2761 +/- ## - Coverage 45.3% 45.15% -0.16% + Complexity 8841 8838 -3 Files 1890 1901 +11 Lines 7069870905 +207 Branches 7766 7784 +18 - Hits 3202832015 -13 - Misses3571835937 +219 - Partials 2952 2953 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...t/version/TimestampedDatasetStateStoreVersion.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vVGltZXN0YW1wZWREYXRhc2V0U3RhdGVTdG9yZVZlcnNpb24uamF2YQ==) | `44.44% <ø> (ø)` | `5 <0> (ø)` | :arrow_down: | | [...lin/runtime/retention/StateCleanerTaskFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9yZXRlbnRpb24vU3RhdGVDbGVhbmVyVGFza0ZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ion/finder/TimestampedStateStoreVersionFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vZmluZGVyL1RpbWVzdGFtcGVkU3RhdGVTdG9yZVZlcnNpb25GaW5kZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...nt/retention/state/CleanableStateStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9zdGF0ZS9DbGVhbmFibGVTdGF0ZVN0b3JlRGF0YXNldC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...nagement/version/TimestampedStateStoreVersion.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vVGltZXN0YW1wZWRTdGF0ZVN0b3JlVmVyc2lvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...taset/finder/TimeBasedStateStoreDatasetFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L2ZpbmRlci9UaW1lQmFzZWRTdGF0ZVN0b3JlRGF0YXNldEZpbmRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...rg/apache/gobblin/metastore/StateStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1N0YXRlU3RvcmVEYXRhc2V0LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...he/gobblin/runtime/retention/StateCleanerTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9yZXRlbnRpb24vU3RhdGVDbGVhbmVyVGFzay5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...obblin/data/management/retention/StateCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9TdGF0ZUNsZWFuZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0
[jira] [Work logged] (GOBBLIN-907) implement a StateCleanerSource to clean states (not dataset state or dataset)
[ https://issues.apache.org/jira/browse/GOBBLIN-907?focusedWorklogId=327188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327188 ] ASF GitHub Bot logged work on GOBBLIN-907: -- Author: ASF GitHub Bot Created on: 12/Oct/19 02:42 Start Date: 12/Oct/19 02:42 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2761: [GOBBLIN-907] implement StateCleanerSource URL: https://github.com/apache/incubator-gobblin/pull/2761#issuecomment-541276201 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=h1) Report > Merging [#2761](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/bce5cbc3c8bb607b8c1af56dd3b41f75bbb2b92e?src=pr&el=desc) will **decrease** coverage by `0.15%`. > The diff coverage is `0.48%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2761 +/- ## - Coverage 45.3% 45.15% -0.16% + Complexity 8841 8838 -3 Files 1890 1901 +11 Lines 7069870905 +207 Branches 7766 7784 +18 - Hits 3202832015 -13 - Misses3571835937 +219 - Partials 2952 2953 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2761?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...t/version/TimestampedDatasetStateStoreVersion.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vVGltZXN0YW1wZWREYXRhc2V0U3RhdGVTdG9yZVZlcnNpb24uamF2YQ==) | `44.44% <ø> (ø)` | `5 <0> (ø)` | :arrow_down: | | [...lin/runtime/retention/StateCleanerTaskFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9yZXRlbnRpb24vU3RhdGVDbGVhbmVyVGFza0ZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ion/finder/TimestampedStateStoreVersionFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vZmluZGVyL1RpbWVzdGFtcGVkU3RhdGVTdG9yZVZlcnNpb25GaW5kZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...nt/retention/state/CleanableStateStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9zdGF0ZS9DbGVhbmFibGVTdGF0ZVN0b3JlRGF0YXNldC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...nagement/version/TimestampedStateStoreVersion.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vVGltZXN0YW1wZWRTdGF0ZVN0b3JlVmVyc2lvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...taset/finder/TimeBasedStateStoreDatasetFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9kYXRhc2V0L2ZpbmRlci9UaW1lQmFzZWRTdGF0ZVN0b3JlRGF0YXNldEZpbmRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...rg/apache/gobblin/metastore/StateStoreDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL1N0YXRlU3RvcmVEYXRhc2V0LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...he/gobblin/runtime/retention/StateCleanerTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9yZXRlbnRpb24vU3RhdGVDbGVhbmVyVGFzay5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...obblin/data/management/retention/StateCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2761/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9TdGF0ZUNsZWFuZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0
[jira] [Work logged] (GOBBLIN-907) implement a StateCleanerSource to clean states (not dataset state or dataset)
[
https://issues.apache.org/jira/browse/GOBBLIN-907?focusedWorklogId=327180&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327180
]
ASF GitHub Bot logged work on GOBBLIN-907:
--
Author: ASF GitHub Bot
Created on: 12/Oct/19 01:57
Start Date: 12/Oct/19 01:57
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2761:
[GOBBLIN-907] implement StateCleanerSource
URL: https://github.com/apache/incubator-gobblin/pull/2761
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-907
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
implement a StateCleanerSource, that will clean states. so far we had
support to clean only JobState.DatasetState
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 327180)
Remaining Estimate: 0h
Time Spent: 10m
> implement a StateCleanerSource to clean states (not dataset state or dataset)
> -
>
> Key: GOBBLIN-907
> URL: https://issues.apache.org/jira/browse/GOBBLIN-907
> Project: Apache Gobblin
> Issue Type: New Feature
>Reporter: Arjun Singh Bora
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
