Re: Add datastore for Elasticsearch. Outreachy Week 6 Report

2021-01-10 Thread John Mora
Hi. Thanks for the update. Some comments: Please define a parameter for the XSD validation ( gora.xsd_validation, default: false ) Example: https://github.com/apache/gora/blob/master/gora-lucene/src/main/java/org/apache/gora/lucene/store/LuceneStore.java#L131 I do not think the Elasticsearch

Re: Add datastore for Elasticsearch. Outreachy Week 6 Report

2021-01-10 Thread Maria Podorvanova
Hi, Thank you for your feedback. I will define the parameter for the XSD validation and fix authentication. I submitted my midpoint feedback last week. Regards, Maria On Mon, 11 Jan 2021 at 11:38, John Mora wrote: > Hi. > > Thanks for the update. > > Some comments: > > Please define a

Re: Outreachy 2020-2021 - Neo4j - Weekly reports.

2021-01-10 Thread John Mora
Hi. Thanks for the update. Some comments: Please use constants instead of literal values here: https://github.com/mgov88/gora/blob/GORA-663/gora-neo4j/src/test/java/org/apache/gora/neo4j/GoraNeo4jTestDriver.java#L37 Add javadocs in these classes: