[GitHub] [gora] lewismc commented on issue #140: GORA-548 Apache Flink support for Gora

2019-03-31 Thread GitBox
lewismc commented on issue #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140#issuecomment-478381991 ``` [ERROR] Failures: [ERROR] TestHBaseStore>DataStoreTestBase.testDelete:341 expected:<9> but was:<8> [ERROR]

[GitHub] [gora] lewismc commented on issue #140: GORA-548 Apache Flink support for Gora

2019-03-31 Thread GitBox
lewismc commented on issue #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140#issuecomment-478382125

[GitHub] [gora] djkevincr opened a new pull request #157: GORA-549: Remove PersistentBase extending java.io.Externalizable

2019-04-02 Thread GitBox
djkevincr opened a new pull request #157: GORA-549: Remove PersistentBase extending java.io.Externalizable URL: https://github.com/apache/gora/pull/157 This is no longer required since SpecificRecordBase extends java.io.Externalizable with AVRO upgrade.

[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-03 Thread GitBox
djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r271661575 ## File path: gora-dynamodb/src/main/java/org/apache/gora/dynamodb/store/DynamoDBStore.java ## @@

[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-03 Thread GitBox
djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r271653309 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java

[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-03 Thread GitBox
djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r271653309 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java

[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-03 Thread GitBox
djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r271626749 ## File path: gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanStore.java ##

[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-03 Thread GitBox
djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r271628751 ## File path: gora-dynamodb/src/main/java/org/apache/gora/dynamodb/store/DynamoDBNativeStore.java ##

[GitHub] [gora] djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-03 Thread GitBox
djkevincr commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r271654155 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/CassandraQueryFactory.java

[GitHub] [gora] jhnmora000 opened a new pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-25 Thread GitBox
jhnmora000 opened a new pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156 Adds a **exists(key)** method to the DataStores. - Custom implementations for all backends. - Two new tests for: operability and benchmark.

[GitHub] [gora] djkevincr merged pull request #154: GORA-560:Fix Java doc comments to stabalize the build

2019-03-24 Thread GitBox
djkevincr merged pull request #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [gora] djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build

2019-03-24 Thread GitBox
djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475975272 +1, mvn javadoc:aggregate build without any issue. This is an

[GitHub] [gora] djkevincr edited a comment on issue #154: GORA-560:Fix Java doc comments to stabalize the build

2019-03-24 Thread GitBox
djkevincr edited a comment on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475975148 ``` [INFO] Reactor Summary: [INFO] [INFO] Apache Gora SUCCESS [ 29.755 s]

[GitHub] [gora] djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build

2019-03-24 Thread GitBox
djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475975148 `[INFO] Reactor Summary: [INFO] [INFO] Apache Gora SUCCESS [ 29.755 s] [INFO]

[GitHub] [gora] madhawa-gunasekara opened a new pull request #155: GORA-545 Fix split size in infinispan store

2019-03-24 Thread GitBox
madhawa-gunasekara opened a new pull request #155: GORA-545 Fix split size in infinispan store URL: https://github.com/apache/gora/pull/155 Hi @djkevincr, Can you review and merge this pull request This is an

[GitHub] [gora] djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build

2019-03-24 Thread GitBox
djkevincr commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475975355 This is great @madhawa-gunasekara , I have merged your PR. Thank you for the contribution.

[GitHub] [gora] madhawa-gunasekara opened a new pull request #154: GORA-560:Fix Java doc comments to stabalize the build

2019-03-24 Thread GitBox
madhawa-gunasekara opened a new pull request #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154 This is an automated message from the Apache Git Service. To respond to

[GitHub] [gora] madhawa-gunasekara commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build

2019-03-24 Thread GitBox
madhawa-gunasekara commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475957714 @djkevincr Can you review and merge this pull request.

[GitHub] [gora] djkevincr merged pull request #155: GORA-545 Fix split size in infinispan store

2019-03-25 Thread GitBox
djkevincr merged pull request #155: GORA-545 Fix split size in infinispan store URL: https://github.com/apache/gora/pull/155 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [gora] djkevincr commented on issue #155: GORA-545 Fix split size in infinispan store

2019-03-25 Thread GitBox
djkevincr commented on issue #155: GORA-545 Fix split size in infinispan store URL: https://github.com/apache/gora/pull/155#issuecomment-476077247 @madhawa-gunasekara Thank you for the contribution. This is an automated

[GitHub] [gora] alfonsonishikawa commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build

2019-03-24 Thread GitBox
alfonsonishikawa commented on issue #154: GORA-560:Fix Java doc comments to stabalize the build URL: https://github.com/apache/gora/pull/154#issuecomment-475987480 @madhawa-gunasekara So sorry for the javadoc bugs :( Thank you very much for fixing it! I will add to my own

[GitHub] [gora] djkevincr commented on issue #153: GORA-554: Upgrade Solr dependency to latest

2019-03-23 Thread GitBox
djkevincr commented on issue #153: GORA-554: Upgrade Solr dependency to latest URL: https://github.com/apache/gora/pull/153#issuecomment-475862398 @madhawa-gunasekara Updated the PR. Can you please have a look and merge the PR.

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480031983 +1 @cuent This look certainly great. @lewismc mentioned you may add Lucene store specific tests. ( in

[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480168630 @cuent you can easily implement individual tests for the module and use the `@Override` convention to implement the

[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480081077 I was trying to add that but it creates two examples, employees and website, which have string keys. How can I extend

[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480299253 Yes, I reviewed the `DataStoreTestBase`, but it creates a `employeeStore` and a `webPageStore` which both have String

[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480384094 So why don't you just create individual tests such as

[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#discussion_r272787031 ## File path: gora-lucene/src/test/java/org/apache/gora/lucene/store/EmployeeInt.java

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480482576 @cuent Thanks for considering my suggestions over the discussion we had on ticket. Noticed you have added changes

[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#discussion_r272787651 ## File path: gora-lucene/src/main/java/org/apache/gora/lucene/store/LuceneStore.java

[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#discussion_r272787885 ## File path: gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneQuery.java

[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#discussion_r272787885 ## File path: gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneQuery.java

[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-05 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480476838 I implemented the test. I also notice that in some places some keys are converted to `String` by default. I solved

[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#discussion_r272787234 ## File path: gora-lucene/src/test/java/org/apache/gora/lucene/store/TestLuceneStore.java

[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#discussion_r272787990 ## File path: gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneQuery.java

[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-06 Thread GitBox
jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r272802075 ## File path: gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java ## @@

[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-06 Thread GitBox
jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r272802277 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/CassandraQueryFactory.java

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480521014 @cuent Thank you for addressing my comments. Were you able add the EmployeeInt.json AVRO schema? This should be added

[GitHub] [gora] djkevincr edited a comment on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr edited a comment on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480521014 @cuent Thank you for addressing my comments. Were you able add the EmployeeInt.json AVRO schema? This should

[GitHub] [gora] djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#discussion_r272802460 ## File path: gora-lucene/src/test/java/org/apache/gora/lucene/store/EmployeeInt.java

[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-06 Thread GitBox
jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r272802625 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java

[GitHub] [gora] cuent commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
cuent commented on a change in pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#discussion_r272804698 ## File path: gora-lucene/src/test/java/org/apache/gora/lucene/store/EmployeeInt.java

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480526888 I have approved the PR, will locally test and merge to the master.

[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480527044 @lewismc Please raise if you do have any concerns. Otherwise will proceed to merge.

[GitHub] [gora] cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-06 Thread GitBox
cuent commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480512928 @djkevincr done! This is an automated message from

[GitHub] [gora] cuent opened a new pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
cuent opened a new pull request #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158 Infer data type for building range queries. First, check if there is a numeric type if so cast to the appropriate type otherwise set to

[GitHub] [gora] lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery

2019-04-04 Thread GitBox
lewismc commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480010966 This looks good @cuent thank you for taking the issue on. Please augment your pull request with Unit tests. Thank you

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284412 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java ## @@

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284458 ## File path: gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java ## @@ -214,6 +214,18

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284519 ## File path: gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java ## @@ -167,6 +168,49

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284492 ## File path: gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java ## @@ -214,6 +214,18

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284368 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/CassandraSerializer.java

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284398 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/NativeSerializer.java

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284149 ## File path: gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikeStore.java ## @@

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284452 ## File path: gora-core/src/main/java/org/apache/gora/store/impl/DataStoreBase.java ## @@ -150,6

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284062 ## File path: gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java ## @@

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284428 ## File path: gora-core/src/main/java/org/apache/gora/memory/store/MemStore.java ## @@ -195,6 +195,12

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284347 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/CassandraQueryFactory.java

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284126 ## File path: gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java ## @@

[GitHub] [gora] lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-28 Thread GitBox
lewismc commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r270284172 ## File path: gora-cassandra/src/main/java/org/apache/gora/cassandra/serializers/AvroSerializer.java ##

[GitHub] [gora] djkevincr commented on issue #140: GORA-548 Apache Flink support for Gora

2019-04-01 Thread GitBox
djkevincr commented on issue #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140#issuecomment-478509012 I will monitor over this @lewismc, I sometime notice this intermittent failures with HBase. I will address that separately.

[GitHub] [gora] djkevincr merged pull request #140: GORA-548 Apache Flink support for Gora

2019-04-01 Thread GitBox
djkevincr merged pull request #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [gora] djkevincr commented on issue #140: GORA-548 Apache Flink support for Gora

2019-03-31 Thread GitBox
djkevincr commented on issue #140: GORA-548 Apache Flink support for Gora URL: https://github.com/apache/gora/pull/140#issuecomment-478415577 Test passes without any issue in my machine locally for HBase, I will have a another look. [INFO]

[GitHub] [gora] djkevincr merged pull request #157: GORA-549: Remove PersistentBase extending java.io.Externalizable

2019-04-08 Thread GitBox
djkevincr merged pull request #157: GORA-549: Remove PersistentBase extending java.io.Externalizable URL: https://github.com/apache/gora/pull/157 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [gora] djkevincr opened a new pull request #160: GORA-611: Fix intermittent test failures with HBase module

2019-04-08 Thread GitBox
djkevincr opened a new pull request #160: GORA-611: Fix intermittent test failures with HBase module URL: https://github.com/apache/gora/pull/160 Fix various issues such as resource closing, auto flush etc. https://issues.apache.org/jira/browse/HBASE-2256 - main concern here is sometime

[GitHub] [gora] djkevincr merged pull request #159: GORA-564: Remove deprecated method usages of HBase module after upgrading to 2

2019-04-08 Thread GitBox
djkevincr merged pull request #159: GORA-564: Remove deprecated method usages of HBase module after upgrading to 2 URL: https://github.com/apache/gora/pull/159 This is an automated message from the Apache Git Service. To

[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-06 Thread GitBox
jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r272807465 ## File path: gora-core/src/main/java/org/apache/gora/store/impl/DataStoreBase.java ## @@ -150,6

[GitHub] [gora] jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface

2019-04-06 Thread GitBox
jhnmora000 commented on a change in pull request #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#discussion_r272807723 ## File path: gora-dynamodb/src/main/java/org/apache/gora/dynamodb/store/DynamoDBNativeStore.java ##

[GitHub] [gora] madhawa-gunasekara commented on issue #153: GORA-554: Upgrade Solr dependency to latest

2019-03-23 Thread GitBox
madhawa-gunasekara commented on issue #153: GORA-554: Upgrade Solr dependency to latest URL: https://github.com/apache/gora/pull/153#issuecomment-475914648 I tested locally, all good. ``` [INFO] [INFO] Results: [INFO] [INFO] Tests run: 82, Failures: 0, Errors: 0, Skipped:

[GitHub] [gora] carlosrmng commented on issue #156: GORA 411 - Add exists(key) to DataStore interface

2019-03-26 Thread GitBox
carlosrmng commented on issue #156: GORA 411 - Add exists(key) to DataStore interface URL: https://github.com/apache/gora/pull/156#issuecomment-476932498 Nice work @jhnmora000 . The implementation for the Ignite Datastore looks good in my opinion. But, I would suggest you to use

[GitHub] [gora] djkevincr merged pull request #153: GORA-554: Upgrade Solr dependency to latest

2019-03-23 Thread GitBox
djkevincr merged pull request #153: GORA-554: Upgrade Solr dependency to latest URL: https://github.com/apache/gora/pull/153 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] djkevincr opened a new pull request #151: Update developer role information

2019-02-25 Thread GitBox
djkevincr opened a new pull request #151: Update developer role information URL: https://github.com/apache/gora/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] djkevincr merged pull request #151: Update developer role information

2019-02-25 Thread GitBox
djkevincr merged pull request #151: Update developer role information URL: https://github.com/apache/gora/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] [gora] djkevincr opened a new pull request #152: GORA-266 Lucene datastore for Gora - lewismc

2019-03-16 Thread GitBox
djkevincr opened a new pull request #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152 This is based on https://github.com/apache/gora/pull/131 resolved conflicts and merged to master. However tests needs to be fixed.

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266249623 ## File path: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java ## @@ -412,7 +484,7 @@ public

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r224998986 ## File path: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ## @@ -180,6 +180,11 @@

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r222506186 ## File path: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ## @@ -180,6 +180,11 @@

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256014 ## File path: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java ## @@ -1,20 +0,0 @@

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256105 ## File path: gora-pig/src/test/examples/example.pig ## @@ -0,0 +1,4 @@ +set job.name 'GoraStorage test' ; +register

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266255944 ## File path: conf/log4j.properties ## @@ -24,7 +24,7 @@ log4j.threshhold=ALL log4j.rootLogger=${gora.root.logger}

[GitHub] [gora] alfonsonishikawa commented on issue #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-473711809 Hi! Finished the changes. You can see all in the [Files Tab](https://github.com/apache/gora/pull/135/files?file-filters%5B%5D=). Thank you!!

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256724 ## File path: gora-pig/src/test/examples/README.md ## @@ -0,0 +1,46 @@ + Review comment: The Gora-Pig example

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256724 ## File path: gora-pig/src/test/examples/README.md ## @@ -0,0 +1,46 @@ + Review comment: The Gora-Pig example

[GitHub] [gora] lewismc commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc

2019-03-17 Thread GitBox
lewismc commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152#issuecomment-473757077 I think this looks good. The only suggestion I have right now is to expand support for other `keyClass` implementations in LuceneQuery. There is

[GitHub] [gora] djkevincr edited a comment on issue #135: Goraexplorer needed changes

2019-03-13 Thread GitBox
djkevincr edited a comment on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or do you need further time on this?

[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes

2019-03-13 Thread GitBox
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or do you need further time on this? Its

[GitHub] [gora] djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora

2019-03-13 Thread GitBox
djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472522958 @lewismc Are you happy with this PR or is there anything else that we should address or Do you need further time on this? Its awesome if we can

[GitHub] [gora] djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora

2019-03-13 Thread GitBox
djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472522958 @lewismc Are you happy with this PR or is there anything else that we should address or do you need further time on this? Its awesome if we can get to

[GitHub] [gora] djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora

2019-03-13 Thread GitBox
djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472522958 @lewismc Are you happy with this PR or Is there anything else that we should address? Its awesome if we can get this to the release coming

[GitHub] [gora] djkevincr edited a comment on issue #135: Goraexplorer needed changes

2019-03-13 Thread GitBox
djkevincr edited a comment on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or Do you need further time on this?

[GitHub] [gora] lewismc commented on issue #131: GORA-266 Lucene datastore for Gora

2019-03-13 Thread GitBox
lewismc commented on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472565167 I don't have time to go back right now and code this implementation. I would suggest the following * upgrade Lucene and fix any deprecated API usage

[GitHub] [gora] djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora

2019-03-13 Thread GitBox
djkevincr edited a comment on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472566647 @lewismc Thanks for the input Lewis, I will have look and take over this :) This

[GitHub] [gora] djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora

2019-03-13 Thread GitBox
djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-472566647 @lewismc Thanks for the input Lewis, I will have look and take over this. This is an

[GitHub] [gora] djkevincr commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc

2019-03-18 Thread GitBox
djkevincr commented on issue #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152#issuecomment-473925982 @lewismc I have created issue [1] on NumericRangeQuery. I think this PR is in good shape to be merged. All major test cases passes without

[GitHub] [gora] djkevincr closed pull request #131: GORA-266 Lucene datastore for Gora

2019-03-18 Thread GitBox
djkevincr closed pull request #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [gora] djkevincr edited a comment on issue #152: GORA-266 Lucene datastore for Gora - lewismc

2019-03-18 Thread GitBox
djkevincr edited a comment on issue #152: GORA-266 Lucene datastore for Gora - lewismc URL: https://github.com/apache/gora/pull/152#issuecomment-473925982 @lewismc I have created issue [1] on NumericRangeQuery. Let s address this separately. I think this PR is in good shape to be merged.

[GitHub] [gora] djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora

2019-03-18 Thread GitBox
djkevincr commented on issue #131: GORA-266 Lucene datastore for Gora URL: https://github.com/apache/gora/pull/131#issuecomment-473918146 Closing this PR after submitting more update version of the same work in https://github.com/apache/gora/pull/152

[GitHub] [gora] djkevincr commented on a change in pull request #135: Goraexplorer needed changes

2019-03-18 Thread GitBox
djkevincr commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266567600 ## File path: gora-pig/src/test/java/org/apache/gora/pig/GoraStorageTest.java-disabled ## @@ -0,0 +1,352 @@ +package

[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes

2019-03-18 Thread GitBox
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474034153 @alfonsonishikawa One concern I do have is, I noticed record.vm velocity template changes, hopefully I think you have regenerated all the AVRO databean

[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes

2019-03-18 Thread GitBox
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474029378 Locally tested the PR, build passes without any test failures. [INFO]

  1   2   3   4   5   6   7   >