[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

2018-05-01 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/132 +1 ---

[GitHub] gora pull request: Memstore problems is fixed

2015-08-27 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/30 Memstore problems is fixed Memstore problems is fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora memstore Alternatively you can

[GitHub] gora pull request: Memstore problems is fixed

2015-08-27 Thread cguzel
Github user cguzel commented on the pull request: https://github.com/apache/gora/pull/30#issuecomment-135560832 Yes I tested on nutch. The Nutch Injector test is run successfully . You can apply the last patch from NUTCH-1741 and run TestInjector.java --- If your project is set up

[GitHub] gora pull request: Memstore problems are fixed GORA-228 GORA-226 N...

2015-08-29 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/31 Memstore problems are fixed GORA-228 GORA-226 NUTCH-1741 Hi. My previous pull request has a problem. Some tests have failed. I had run only nutch tests, not run gora tests. I'm sorr

[GitHub] gora pull request: Fixed javadocs errors

2016-05-21 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/66 Fixed javadocs errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora GORA-445-javadocs Alternatively you can review and apply these

[GitHub] gora pull request: GORA-465 remove deprecated logic

2016-05-22 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/67 GORA-465 remove deprecated logic You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora GORA-465 Alternatively you can review and apply these

[GitHub] gora pull request: GORA-465 remove deprecated logic

2016-05-23 Thread cguzel
Github user cguzel commented on a diff in the pull request: https://github.com/apache/gora/pull/67#discussion_r64287443 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -116,18 +114,8 @@ public void initialize(Class keyClass, Class

[GitHub] gora pull request: GORA-445 spark dependency scope have changed as...

2016-05-26 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/69 GORA-445 spark dependency scope have changed as provided spark dependency scope have changed as provided. Besides javadoc problem is fixed. you can use "mvn javadoc:aggregate" You can

[GitHub] gora pull request #74: GORA-437 implement couchdb datastore

2016-08-13 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/74 GORA-437 implement couchdb datastore This pull request is for GORA-437. I developed couchdb store for gora. I added javadocs and test codes. The tests required couchdb instance. But I wondered how to

[GitHub] gora pull request #74: GORA-437 implement couchdb datastore

2016-08-17 Thread cguzel
Github user cguzel commented on a diff in the pull request: https://github.com/apache/gora/pull/74#discussion_r75223135 --- Diff: gora-couchdb/src/test/java/org/apache/gora/couchdb/store/TestCouchDBStore.java --- @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #74: GORA-437 implement couchdb datastore

2016-08-17 Thread cguzel
Github user cguzel commented on a diff in the pull request: https://github.com/apache/gora/pull/74#discussion_r75223403 --- Diff: gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java --- @@ -690,6 +690,7 @@ else if (effectiveSchema.getType() == Type.MAP

[GitHub] gora pull request #74: GORA-437 implement couchdb datastore

2016-08-17 Thread cguzel
Github user cguzel commented on a diff in the pull request: https://github.com/apache/gora/pull/74#discussion_r75224040 --- Diff: gora-core/src/test/java/org/apache/gora/GoraTestDriver.java --- @@ -94,14 +94,18 @@ public void tearDown() throws Exception

[GitHub] gora pull request #76: GORA-487 Edited AccumuloStore.java duplicate code lin...

2016-08-17 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/76 GORA-487 Edited AccumuloStore.java duplicate code lines The code lines have already been in org.apache.gora.util.IOUtils You can merge this pull request into a Git repository by running: $ git

[GitHub] gora pull request #74: GORA-437 implement couchdb datastore

2016-08-17 Thread cguzel
Github user cguzel commented on a diff in the pull request: https://github.com/apache/gora/pull/74#discussion_r75225014 --- Diff: gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java --- @@ -690,6 +690,7 @@ else if (effectiveSchema.getType() == Type.MAP

[GitHub] gora issue #76: GORA-487 Edited AccumuloStore.java duplicate code lines

2016-08-19 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/76 I have edited AvroUtils.java. I review the other instances, any changes will not do for them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] gora issue #74: GORA-437 implement couchdb datastore

2016-08-20 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/74 @lewismc How to create documentation? I don't know how to edit this page : http://gora.apache.org/current/index.html#gora-modules --- If your project is set up for it, you can reply to this emai

[GitHub] gora issue #74: GORA-437 implement couchdb datastore

2016-08-21 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/74 I added a patch for documentation https://issues.apache.org/jira/browse/GORA-489 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] gora issue #74: GORA-437 implement couchdb datastore

2016-08-21 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/74 I have added maven profile in gora-couchdb pom.xml. So The tests skip by default. If you use java 1.8 and docker, you build and run tests using maven profile as "mvn clean install -P couchdb-with

[GitHub] gora issue #74: GORA-437 implement couchdb datastore

2016-08-21 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/74 I have added new javadocs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] gora pull request #78: Gora 490 Adding package-info.java for gora modules

2016-08-24 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/78 Gora 490 Adding package-info.java for gora modules I added some missing package-info.java and javadocs You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] gora pull request #79: GORA-469 gora build problem is solved under jdk1.8

2016-08-27 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/79 GORA-469 gora build problem is solved under jdk1.8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora-couchdb GORA-469 Alternatively you

[GitHub] gora issue #79: GORA-469 gora build problem is solved under jdk1.8

2016-08-27 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/79 There is no problem in existing code. Only the try catch block is incorrect. JDK 1.7 and JDK 1.8 behave differently for this case. --- If your project is set up for it, you can reply to this email and

[GitHub] gora issue #79: GORA-469 gora-core build problem is solved under jdk1.8

2016-08-27 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/79 The previous error is releated gora-core. I fixed it. This last error log is releated gora-cassandra. This is different problem. If I run "mvn clean install", it fails. If I run as

[GitHub] gora pull request #81: Gora-490 Added mising package-info.java for all gora ...

2016-08-28 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/81 Gora-490 Added mising package-info.java for all gora modules You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora-couchdb GORA-490

[GitHub] gora pull request #83: GORA-469 cassandra javadoc error is fixed

2016-08-28 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/83 GORA-469 cassandra javadoc error is fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora-couchdb GORA-469 Alternatively you can

[GitHub] gora pull request #84: GORA-466 avro version upgrade to 1.8.1

2016-08-29 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/84 GORA-466 avro version upgrade to 1.8.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora GORA-466 Alternatively you can review and apply

[GitHub] gora pull request #85: GORA-492 javadoc:jar build problem fix

2016-08-29 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/85 GORA-492 javadoc:jar build problem fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora GORA-492 Alternatively you can review and apply

[GitHub] gora pull request #87: GORA-488 setProperties method contains no code. Remov...

2016-09-01 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/87 GORA-488 setProperties method contains no code. Removed unused code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora GORA-488

[GitHub] gora issue #87: GORA-488 Removed unused code. Edited the releated test codes...

2016-09-21 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/87 I have added the documents. @lewismc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] gora issue #74: GORA-437 implement couchdb datastore

2017-02-21 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/74 Thanks @bsideup . I will check it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] gora issue #74: GORA-437 implement couchdb datastore

2017-02-21 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/74 Hi, @bsideup . It's OK for me. But I am not PMC for GORA. So, This question should be answered by GORA PMC members. @lewis ? --- If your project is set up for it, you can reply to this emai

[GitHub] gora issue #74: GORA-437 implement couchdb datastore

2017-02-21 Thread cguzel
Github user cguzel commented on the issue: https://github.com/apache/gora/pull/74 Sorry. Yes true. I corrected the mistake. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] gora pull request #98: GORA-505 Testcontainers is moved to test scope

2017-02-23 Thread cguzel
GitHub user cguzel opened a pull request: https://github.com/apache/gora/pull/98 GORA-505 Testcontainers is moved to test scope You can merge this pull request into a Git repository by running: $ git pull https://github.com/cguzel/gora GORA-505 Alternatively you can review