[GitHub] [gora] djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support
djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support URL: https://github.com/apache/gora/pull/175#discussion_r392551036 ## File path: gora-tutorial/src/main/java/org/apache/gora/tutorial/log/LogAnalyticsJet.java ## @@ -0,0 +1,91 @@ +package org.apache.gora.tutorial.log; Review comment: Please add License header. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support
djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support URL: https://github.com/apache/gora/pull/175#discussion_r320844512 ## File path: gora-jet/pom.xml ## @@ -0,0 +1,131 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 + + +org.apache.gora +gora +0.9-SNAPSHOT Review comment: This has to be 1.0-SNAPSHOT, PR fails at building locally due to this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support
djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support URL: https://github.com/apache/gora/pull/175#discussion_r316815627 ## File path: pom.xml ## @@ -840,7 +841,8 @@ 1.0.0 -3.6.4 +3.12.2 Review comment: My mistake.. Thank you for pointing that out. +1 to move resolve this review comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support
djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support URL: https://github.com/apache/gora/pull/175#discussion_r316594560 ## File path: pom.xml ## @@ -792,6 +792,7 @@ gora-ignite gora-tutorial sources-dist +gora-jet Review comment: You need to move gora-jet module before sources-dist module. Otherwise jet module will not be packaged into source distribution. Ideally it should be built even before gora-tutorial, since we have dependency to gora-jet from gora-tutorial. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support
djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support URL: https://github.com/apache/gora/pull/175#discussion_r316593072 ## File path: pom.xml ## @@ -840,7 +841,8 @@ 1.0.0 -3.6.4 +3.12.2 Review comment: It seems you have downgraded the current Hazelcast version. I think we need to avoid this and need to find a better solution around dependency conflicts between Hazelcast Jet /JCache. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
