[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480527044 @lewismc Please raise if you do have any concerns. Otherwise will proceed to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480526888 I have approved the PR, will locally test and merge to the master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480521014 @cuent Thank you for addressing my comments. Were you able add the EmployeeInt.json AVRO schema? This should be added to gora-core/src/examples/avro directory. You will see - employee.json You will have to rename the name and type for ssn. Please make sure you regenerate using the json file. This looks Awesome and ready to be merged :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480482576 @cuent Thanks for considering my suggestions over the discussion we had on ticket. Noticed you have added changes that needed for put method in order use native types opposed to converting to Strings. This is Awesome. Please address my comments, I will go ahead and locally test your PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [gora] djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery
djkevincr commented on issue #158: GORA-555: Improve Lucene query implementation with NumericRangeQuery URL: https://github.com/apache/gora/pull/158#issuecomment-480031983 +1 @cuent This look certainly great. @lewismc mentioned you may add Lucene store specific tests. ( in TestLuceneStore.java. ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
