[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r225001067 --- Diff: pom.xml --- @@ -832,6 +833,12 @@ 1.0.1 2.5 + +0.16.0 +1.11-8 --- End diff --

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r225000854 --- Diff: gora-pig/src/test/examples/example.pig --- @@ -0,0 +1,4 @@ +set job.name 'GoraStorage test' ; +register gora/*.jar ; +webpage =

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r225000361 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/mapreduce/PigGoraOutputFormat.java --- @@ -0,0 +1,86 @@ +package

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r225000105 --- Diff: gora-pig/pom.xml --- @@ -0,0 +1,180 @@ + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; +

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r224999854 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -80,15 +81,20 @@ * DataStore for HBase. Thread safe.

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r224998986 --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm --- @@ -180,6 +180,11 @@ public class

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543455 --- Diff: gora-pig/src/test/examples/README.txt --- @@ -0,0 +1,9 @@ + --- End diff -- Can you make this an .md file? ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542930 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/ResourceFieldSchemaWithIndex.java --- @@ -0,0 +1,31 @@ +package org.apache.gora.pig; --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222540948 --- Diff: gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java --- @@ -86,6 +88,31 @@ public static void compileSchema(File[] srcFiles, File

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541609 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java --- @@ -251,6 +254,70 @@ D getDataStore( Class dataStoreClass, Class keyClass,

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542624 --- Diff: gora-pig/pom.xml --- @@ -0,0 +1,180 @@ + --- End diff -- License header. ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222540708 --- Diff: bin/compile-examples.sh --- @@ -36,8 +36,57 @@ DIR=$GORA_HOME/$MODULE/src/examples/avro/ OUTDIR=$GORA_HOME/$MODULE/src/examples/java

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543677 --- Diff: pom.xml --- @@ -757,9 +758,9 @@ gora-maven-plugin gora-mongodb gora-solr +gora-aerospike --- End diff --

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542669 --- Diff: gora-pig/pom.xml --- @@ -0,0 +1,180 @@ + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; +

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541705 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java --- @@ -412,7 +484,7 @@ public static String getMappingFile(Properties

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541077 --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm --- @@ -180,6 +180,11 @@ public class

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543835 --- Diff: pom.xml --- @@ -1546,6 +1553,40 @@ ${orientqb.version} + + + org.apache.pig +

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543728 --- Diff: pom.xml --- @@ -832,6 +833,12 @@ 1.0.1 2.5 + +0.16.0 +1.11-8 --- End diff -- Is this

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542415 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -734,14 +756,13 @@ private void setField(T persistent, Field field, List

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543239 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/mapreduce/PigGoraOutputFormat.java --- @@ -0,0 +1,86 @@ +package org.apache.gora.pig.mapreduce;

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543267 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/udf/MapMerge.java --- @@ -0,0 +1,33 @@ +package org.apache.gora.pig.udf; --- End diff --

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541967 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreMetadataFactory.java --- @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542504 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseTableMetadata.java --- @@ -0,0 +1,27 @@ +package org.apache.gora.hbase.store; ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541246 --- Diff: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java --- @@ -1,20 +0,0 @@ -/** --- End diff -- Why

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542987 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/StorageConfiguration.java --- @@ -0,0 +1,140 @@ +package org.apache.gora.pig; --- End diff --

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542461 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStoreMetadataAnalyzer.java --- @@ -0,0 +1,75 @@ +package org.apache.gora.hbase.store;

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542089 --- Diff: gora-goraci/src/main/java/org/apache/gora/goraci/generated/package-info.java --- @@ -1,21 +0,0 @@ -/** --- End diff -- Why remove?

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541419 --- Diff: gora-core/src/main/java/org/apache/gora/persistency/Persistent.java --- @@ -113,4 +118,13 @@ * @return a new instance of the object

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543383 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/util/PersistentUtils.java --- @@ -0,0 +1,147 @@ +package org.apache.gora.pig.util; --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543248 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/udf/MapDeleteElements.java --- @@ -0,0 +1,67 @@ +package org.apache.gora.pig.udf; --- End diff --

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542231 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -80,15 +81,20 @@ * DataStore for HBase. Thread safe. *

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543177 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/mapreduce/PigGoraOutputFormat.java --- @@ -0,0 +1,86 @@ +package org.apache.gora.pig.mapreduce;

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543621 --- Diff: gora-pig/src/test/resources/gora.properties --- @@ -0,0 +1,4 @@ +gora.datastore.default=org.apache.gora.hbase.store.HBaseStore --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543479 --- Diff: gora-pig/src/test/examples/example.pig --- @@ -0,0 +1,4 @@ +set job.name 'GoraStorage test' ; --- End diff -- License header if

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543584 --- Diff: gora-pig/src/test/examples/example.pig --- @@ -0,0 +1,4 @@ +set job.name 'GoraStorage test' ; +register gora/*.jar ; +webpage = LOAD '.'

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222510709 --- Diff: gora-pig/src/test/java/org/apache/gora/pig/GoraStorageTest.java-disabled --- @@ -0,0 +1,352 @@ +package org.apache.gora.pig; ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222508755 --- Diff: pom.xml --- @@ -757,9 +758,9 @@ gora-maven-plugin gora-mongodb gora-solr +gora-aerospike --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222508076 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -80,15 +81,20 @@ * DataStore for HBase. Thread safe.

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222507887 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -80,15 +81,20 @@ * DataStore for HBase. Thread safe.

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222506447 --- Diff: gora-core/src/main/java/org/apache/gora/mapreduce/GoraRecordWriter.java --- @@ -76,4 +76,26 @@ public void write(K key, T value) throws

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222506186 --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm --- @@ -180,6 +180,11 @@ public class

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222505739 --- Diff: gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java --- @@ -86,6 +88,31 @@ public static void compileSchema(File[]

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222505121 --- Diff: bin/compile-examples.sh --- @@ -36,8 +36,57 @@ DIR=$GORA_HOME/$MODULE/src/examples/avro/ OUTDIR=$GORA_HOME/$MODULE/src/examples/java

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread alfonsonishikawa
GitHub user alfonsonishikawa opened a pull request: https://github.com/apache/gora/pull/135 Goraexplorer needed changes This set of commits implements the following functionalities: - Compile schemas from Strings and not only from files. - Allow to configure the mapping