[GitHub] gora pull request #88: GORA-495 fix

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/gora/pull/88


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #88: GORA-495 fix

[alfonsonishikawa]

Github user alfonsonishikawa commented on a diff in the pull request:

https://github.com/apache/gora/pull/88#discussion_r79947161
  
--- Diff: 
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
 #if ($schema.getNamespace())
 package $schema.getNamespace();  
 #end
-@SuppressWarnings("all")
--- End diff --

I don't have permissions to accept pull requests :\


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #88: GORA-495 fix

[lewismc]

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/gora/pull/88#discussion_r79938119
  
--- Diff: 
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
 #if ($schema.getNamespace())
 package $schema.getNamespace();  
 #end
-@SuppressWarnings("all")
--- End diff --

i think most of the warnings will be down to type safety. Feel free to 
commit this @alfonsonishikawa thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #88: GORA-495 fix

[alfonsonishikawa]

Github user alfonsonishikawa commented on a diff in the pull request:

https://github.com/apache/gora/pull/88#discussion_r79923310
  
--- Diff: 
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
 #if ($schema.getNamespace())
 package $schema.getNamespace();  
 #end
-@SuppressWarnings("all")
--- End diff --

In https://issues.apache.org/jira/browse/GORA-412 where the consensus was 
to remove the @SuppressWarnings("all") and let the warnings be shown in the IDE.
I guess it will show warnings, but who cares? ;)

I vote +1 to apply the patch :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #88: GORA-495 fix

[lewismc]

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/gora/pull/88#discussion_r79887906
  
--- Diff: 
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ---
@@ -18,7 +18,7 @@
 #if ($schema.getNamespace())
 package $schema.getNamespace();  
 #end
-@SuppressWarnings("all")
--- End diff --

Did this not result in compiler warnings?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #88: GORA-495 fix

[djkevincr]

GitHub user djkevincr opened a pull request:

https://github.com/apache/gora/pull/88

GORA-495 fix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/djkevincr/gora GORA-495

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/gora/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit c103f8951106f037b7e2b075c69610372d65aa4c
Author: Kevin Ratnasekera 
Date:   2016-09-16T19:43:47Z

GORA-495 fix




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---