[jira] [Commented] (GOSSIP-35) Different payloads can be transmitted at different rates
[ https://issues.apache.org/jira/browse/GOSSIP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113821#comment-16113821 ] Juby Victor commented on GOSSIP-35: --- Introducing 5 additional parameters into the class will either need an overloaded constructor or change the existing constructor. IMHO a constructor with 10 parameters is really clumsy, So we have the option of introducing a builder, or stick with a 5 param constructor & 10 param constructor. I'm inclined to option 1 (Builder). Since there are only two places which uses the settings class, I guess we can bite the bullet on this and make the change to use a builder - this should give us some flexibility to introduce other params further down the line too... > Different payloads can be transmitted at different rates > > > Key: GOSSIP-35 > URL: https://issues.apache.org/jira/browse/GOSSIP-35 > Project: Gossip > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Juby Victor > Fix For: 0.1.3 > > > Current we have a a few ScheduledExectuor one that controls active gossip, > one that controls gossip to dead nodes, one that controls gosssip of user > data, etc. Currently they all use the same setting to control how often they > run (10ms currently). It would be better if they each had their own setting. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GOSSIP-35) Different payloads can be transmitted at different rates
[
https://issues.apache.org/jira/browse/GOSSIP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110800#comment-16110800
]
Edward Capriolo commented on GOSSIP-35:
---
Good analysis.
{quote}
Should we support overriding these properties via environment variables ?
{quote}
No, I do not think we support any configuration through environment variables.
There is GossipSettings and optionally the json file support adding a third way
to hydrate variables is too confusing.
{quote}
side effects on gossip-base/SimpleActiveGossipper#init
{quote}
There is a second instance of active Gossiper that is network aware. You should
consider what they does as well and how it would respond to these variables.
> Different payloads can be transmitted at different rates
>
>
> Key: GOSSIP-35
> URL: https://issues.apache.org/jira/browse/GOSSIP-35
> Project: Gossip
> Issue Type: New Feature
>Reporter: Edward Capriolo
>Assignee: Juby Victor
> Fix For: 0.1.3
>
>
> Current we have a a few ScheduledExectuor one that controls active gossip,
> one that controls gossip to dead nodes, one that controls gosssip of user
> data, etc. Currently they all use the same setting to control how often they
> run (10ms currently). It would be better if they each had their own setting.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (GOSSIP-35) Different payloads can be transmitted at different rates
[ https://issues.apache.org/jira/browse/GOSSIP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107435#comment-16107435 ] Edward Capriolo commented on GOSSIP-35: --- I assigned this issue to you [~jubyvictor]. Let me know how I can help if need be,. > Different payloads can be transmitted at different rates > > > Key: GOSSIP-35 > URL: https://issues.apache.org/jira/browse/GOSSIP-35 > Project: Gossip > Issue Type: New Feature >Reporter: Edward Capriolo >Assignee: Juby Victor > Fix For: 0.1.3 > > > Current we have a a few ScheduledExectuor one that controls active gossip, > one that controls gossip to dead nodes, one that controls gosssip of user > data, etc. Currently they all use the same setting to control how often they > run (10ms currently). It would be better if they each had their own setting. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (GOSSIP-35) Different payloads can be transmitted at different rates
[ https://issues.apache.org/jira/browse/GOSSIP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106613#comment-16106613 ] Juby Victor commented on GOSSIP-35: --- Hi Edward I would like to work on this issue. > Different payloads can be transmitted at different rates > > > Key: GOSSIP-35 > URL: https://issues.apache.org/jira/browse/GOSSIP-35 > Project: Gossip > Issue Type: New Feature >Reporter: Edward Capriolo > Fix For: 0.1.3 > > > Current we have a a few ScheduledExectuor one that controls active gossip, > one that controls gossip to dead nodes, one that controls gosssip of user > data, etc. Currently they all use the same setting to control how often they > run (10ms currently). It would be better if they each had their own setting. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
