[GitHub] guoyuepeng commented on issue #18: Add quickstart-cn.html

2019-01-18 Thread GitBox
guoyuepeng commented on issue #18: Add quickstart-cn.html URL: https://github.com/apache/griffin-site/pull/18#issuecomment-455588318 @Viking-Bird Thanks, We will go through at your Chinese tutorial . This is an automated

[GitHub] guoyuepeng commented on issue #18: Add quickstart-cn.html

2019-01-20 Thread GitBox
guoyuepeng commented on issue #18: Add quickstart-cn.html URL: https://github.com/apache/griffin-site/pull/18#issuecomment-455847476 @Viking-Bird could you also update _config.yml in root to enable navigation part? This

[GitHub] bhlx3lyx7 commented on issue #18: Add quickstart-cn.html

2019-01-21 Thread GitBox
bhlx3lyx7 commented on issue #18: Add quickstart-cn.html URL: https://github.com/apache/griffin-site/pull/18#issuecomment-456020958 LGTM This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit merged pull request #18: Add quickstart-cn.html

2019-01-21 Thread GitBox
asfgit merged pull request #18: Add quickstart-cn.html URL: https://github.com/apache/griffin-site/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] asfgit merged pull request #20: Replace images/project.jpg

2019-01-21 Thread GitBox
asfgit merged pull request #20: Replace images/project.jpg URL: https://github.com/apache/griffin-site/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] asfgit merged pull request #19: fix image path

2019-01-21 Thread GitBox
asfgit merged pull request #19: fix image path URL: https://github.com/apache/griffin-site/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] Viking-Bird opened a new pull request #20: Replace images/project.jpg

2019-01-21 Thread GitBox
Viking-Bird opened a new pull request #20: Replace images/project.jpg URL: https://github.com/apache/griffin-site/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] guoyuepeng opened a new pull request #19: fix image path

2019-01-21 Thread GitBox
guoyuepeng opened a new pull request #19: fix image path URL: https://github.com/apache/griffin-site/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] guoyuepeng commented on issue #16: Append contribution stuff

2019-01-11 Thread GitBox
guoyuepeng commented on issue #16: Append contribution stuff URL: https://github.com/apache/griffin-site/pull/16#issuecomment-453724479 LGTM, will merge into master This is an automated message from the Apache Git Service. To

[GitHub] asfgit closed pull request #16: Append contribution stuff

2019-01-11 Thread GitBox
asfgit closed pull request #16: Append contribution stuff URL: https://github.com/apache/griffin-site/pull/16 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] guoyuepeng opened a new pull request #17: fix image path

2019-01-11 Thread GitBox
guoyuepeng opened a new pull request #17: fix image path URL: https://github.com/apache/griffin-site/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] asfgit closed pull request #17: fix image path

2019-01-11 Thread GitBox
asfgit closed pull request #17: fix image path URL: https://github.com/apache/griffin-site/pull/17 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] [griffin] chemikadze commented on issue #491: GRIFFIN-244 Get metrics by instance

2019-04-01 Thread GitBox
chemikadze commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478838049 @RodionGork these merge commits have no practical sense, please rebase ontop of fresh master

[GitHub] [griffin] RodionGork opened a new pull request #492: GRIFFIN-244 get metrics by instance

2019-04-02 Thread GitBox
RodionGork opened a new pull request #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492 This is just a squashed version of #491 This is an automated message from the Apache Git Service.

[GitHub] [griffin] chemikadze edited a comment on issue #491: GRIFFIN-244 Get metrics by instance

2019-04-01 Thread GitBox
chemikadze edited a comment on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478838049 @RodionGork these merge commits have no practical sense, please rebase ontop of fresh master, and get rid of non-merge commits

[GitHub] [griffin] RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance

2019-04-01 Thread GitBox
RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478852679 @chemikadze rebase leads to conflicts resolving... Thus I'd better have all this stuff squashed and pushed as @dershovGD (we probably have no

[GitHub] [griffin] RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance

2019-04-02 Thread GitBox
RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478929334 Now #492 is a new, squashed version of this PR. This is an automated message from

[GitHub] [griffin] dershovGD commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance

2019-03-29 Thread GitBox
dershovGD commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270431694 ## File path: service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java ## @@ -72,7

[GitHub] [griffin] dershovGD commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance

2019-03-29 Thread GitBox
dershovGD commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270432048 ## File path: service/pom.xml ## @@ -110,11 +110,11 @@ under the License. postgresql

[GitHub] [griffin] RodionGork opened a new pull request #494: Griffin 240 trigger returns triggerkey

2019-04-02 Thread GitBox
RodionGork opened a new pull request #494: Griffin 240 trigger returns triggerkey URL: https://github.com/apache/griffin/pull/494 This PR requires updating tests and postman json yet, but I need it to show the proposed API before moving further. Triggering and searching by triggerKey -

[GitHub] [griffin] RodionGork opened a new pull request #493: Griffin 240 trigger

2019-04-02 Thread GitBox
RodionGork opened a new pull request #493: Griffin 240 trigger URL: https://github.com/apache/griffin/pull/493 This PR requires updating tests and postman json yet, but I need it to show the proposed API before moving further. Triggering and searching by triggerKey - both works.

[GitHub] [griffin] RodionGork commented on issue #493: Griffin 240 trigger

2019-04-02 Thread GitBox
RodionGork commented on issue #493: Griffin 240 trigger URL: https://github.com/apache/griffin/pull/493#issuecomment-478998377 Sorry, I shall recreate squashed version of this PR for sanity (see #494) This is an automated

[GitHub] [griffin] RodionGork commented on a change in pull request #492: GRIFFIN-244 get metrics by instance

2019-04-02 Thread GitBox
RodionGork commented on a change in pull request #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#discussion_r271573888 ## File path: service/src/main/java/org/apache/griffin/core/metric/model/MetricValue.java ## @@ -61,4 +72,38

[GitHub] [griffin] RodionGork commented on a change in pull request #492: GRIFFIN-244 get metrics by instance

2019-04-02 Thread GitBox
RodionGork commented on a change in pull request #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#discussion_r271573888 ## File path: service/src/main/java/org/apache/griffin/core/metric/model/MetricValue.java ## @@ -61,4 +72,38

[GitHub] [griffin] chemikadze closed pull request #491: GRIFFIN-244 Get metrics by instance

2019-04-02 Thread GitBox
chemikadze closed pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [griffin] chemikadze commented on a change in pull request #492: GRIFFIN-244 get metrics by instance

2019-04-02 Thread GitBox
chemikadze commented on a change in pull request #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#discussion_r271557391 ## File path: service/src/main/java/org/apache/griffin/core/metric/model/MetricValue.java ## @@ -61,4 +72,38

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-20 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r267623101 ## File path: service/src/main/java/org/apache/griffin/core/job/JobController.java

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-20 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r267624070 ## File path:

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-20 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r267622904 ## File path: griffin-doc/service/api-guide.md ## @@ -549,7 +549,21 @@

[GitHub] [griffin] RodionGork commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-27 Thread GitBox
RodionGork commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r269582900 ## File path: service/src/main/java/org/apache/griffin/core/job/JobController.java

[GitHub] [griffin] dershovGD commented on a change in pull request #492: GRIFFIN-244 get metrics by instance

2019-04-03 Thread GitBox
dershovGD commented on a change in pull request #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#discussion_r271835189 ## File path: service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java ## @@ -211,9 +213,13 @@

[GitHub] [griffin] RodionGork commented on a change in pull request #492: GRIFFIN-244 get metrics by instance

2019-04-03 Thread GitBox
RodionGork commented on a change in pull request #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#discussion_r271838431 ## File path: service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java ## @@ -211,9 +213,13

[GitHub] [griffin] toyboxman opened a new pull request #495: Update version information for new release.

2019-04-03 Thread GitBox
toyboxman opened a new pull request #495: Update version information for new release. URL: https://github.com/apache/griffin/pull/495 change version 0.4.0 --> 0.5.0 This is an automated message from the Apache Git Service.

[GitHub] [griffin] asfgit closed pull request #496: Complement Apache License Declaration for rel-0.5.0

2019-04-03 Thread GitBox
asfgit closed pull request #496: Complement Apache License Declaration for rel-0.5.0 URL: https://github.com/apache/griffin/pull/496 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [griffin] toyboxman opened a new pull request #496: Complement Apache License Declaration for rel-0.5.0

2019-04-03 Thread GitBox
toyboxman opened a new pull request #496: Complement Apache License Declaration for rel-0.5.0 URL: https://github.com/apache/griffin/pull/496 rel-0.5.0 license-checking fails on those three files without license statement

[GitHub] [griffin] asfgit closed pull request #495: Update version information for new release.

2019-04-03 Thread GitBox
asfgit closed pull request #495: Update version information for new release. URL: https://github.com/apache/griffin/pull/495 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [griffin] chemikadze commented on issue #492: GRIFFIN-244 get metrics by instance

2019-04-04 Thread GitBox
chemikadze commented on issue #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#issuecomment-479957657 @RodionGork let update logic in measure attaching applicationId to metrics in new format

[GitHub] [griffin] chemikadze commented on a change in pull request #494: GRIFFIN-240 trigger returns triggerkey

2019-04-04 Thread GitBox
chemikadze commented on a change in pull request #494: GRIFFIN-240 trigger returns triggerkey URL: https://github.com/apache/griffin/pull/494#discussion_r272251722 ## File path: service/src/main/java/org/apache/griffin/core/job/JobController.java ## @@ -120,8 +124,13 @@

[GitHub] [griffin] chemikadze commented on a change in pull request #494: GRIFFIN-240 trigger returns triggerkey

2019-04-04 Thread GitBox
chemikadze commented on a change in pull request #494: GRIFFIN-240 trigger returns triggerkey URL: https://github.com/apache/griffin/pull/494#discussion_r272253398 ## File path: service/src/main/java/org/apache/griffin/core/job/repo/JobInstanceRepo.java ## @@ -53,4 +53,6

[GitHub] [griffin] RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance

2019-03-30 Thread GitBox
RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478223535 @chemikadze please come to see this... This is an automated message from the

[GitHub] [griffin] RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance

2019-03-29 Thread GitBox
RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270409323 ## File path: service/pom.xml ## @@ -110,11 +110,11 @@ under the License. postgresql

[GitHub] [griffin] RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance

2019-03-29 Thread GitBox
RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270405608 ## File path: service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java ## @@ -72,7

[GitHub] [griffin] RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance

2019-04-01 Thread GitBox
RodionGork commented on a change in pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270732965 ## File path: service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java ## @@ -206,4 +208,14

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-04-01 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r270773676 ## File path:

[GitHub] [griffin] RodionGork commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-04-01 Thread GitBox
RodionGork commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r270744266 ## File path:

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-04-01 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r270774300 ## File path:

[GitHub] [griffin] dershovGD opened a new pull request #491: Get metrics by instance

2019-03-29 Thread GitBox
dershovGD opened a new pull request #491: Get metrics by instance URL: https://github.com/apache/griffin/pull/491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [griffin] RodionGork commented on issue #492: GRIFFIN-244 get metrics by instance

2019-04-08 Thread GitBox
RodionGork commented on issue #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#issuecomment-480708435 @chemikadze I've made changes in the measure code according to your hint. I only was not sure if we should change the "external" interface of

[GitHub] [griffin] RodionGork commented on a change in pull request #494: GRIFFIN-240 trigger returns triggerkey

2019-04-08 Thread GitBox
RodionGork commented on a change in pull request #494: GRIFFIN-240 trigger returns triggerkey URL: https://github.com/apache/griffin/pull/494#discussion_r272945748 ## File path: service/src/main/java/org/apache/griffin/core/job/repo/JobInstanceRepo.java ## @@ -53,4 +53,6

[GitHub] dershovGD opened a new pull request #483: Add applicationId to MetricWrapper

2019-02-28 Thread GitBox
dershovGD opened a new pull request #483: Add applicationId to MetricWrapper URL: https://github.com/apache/griffin/pull/483 In order to store more detailed information about certain metric the YARN application id associated with that metric has been added to MetricWrapper's flush method.

[GitHub] chemikadze commented on issue #483: Add applicationId to MetricWrapper

2019-02-28 Thread GitBox
chemikadze commented on issue #483: Add applicationId to MetricWrapper URL: https://github.com/apache/griffin/pull/483#issuecomment-468325491 @dershovGD can you please add Griffin's jira ticket id to the title of PR? This is

[GitHub] chemikadze commented on a change in pull request #480: For task GRIFFIN-229, trigger the job right now

2019-02-28 Thread GitBox
chemikadze commented on a change in pull request #480: For task GRIFFIN-229, trigger the job right now URL: https://github.com/apache/griffin/pull/480#discussion_r261299954 ## File path: service/src/main/java/org/apache/griffin/core/job/JobController.java ## @@ -113,4

[GitHub] chemikadze commented on issue #480: For task GRIFFIN-229, trigger the job right now

2019-02-28 Thread GitBox
chemikadze commented on issue #480: For task GRIFFIN-229, trigger the job right now URL: https://github.com/apache/griffin/pull/480#issuecomment-468359278 @dyingbleed That's quite useful feature, and I think many people would really like to see it in upstream. If you don't have time for

[GitHub] aborgatin opened a new pull request #484: GRIFFIN-232 - add support pluggable predicates

2019-03-01 Thread GitBox
aborgatin opened a new pull request #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484 Classifier "exec" added to spring-boot-maven-plugin for possibility use service as a library. This will allow to create custom predicates without

[GitHub] [griffin] asfgit closed pull request #481: fix GRIFFIN-231

2019-03-03 Thread GitBox
asfgit closed pull request #481: fix GRIFFIN-231 URL: https://github.com/apache/griffin/pull/481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] guoyuepeng commented on issue #483: GRIFFIN-234 Add applicationId to MetricWrapper

2019-03-02 Thread GitBox
guoyuepeng commented on issue #483: GRIFFIN-234 Add applicationId to MetricWrapper URL: https://github.com/apache/griffin/pull/483#issuecomment-468984094 LGTM, applicationId appended. Thanks. This is an automated

[GitHub] [griffin] aborgatin commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates

2019-03-06 Thread GitBox
aborgatin commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#discussion_r262931370 ## File path: service/src/main/java/org/apache/griffin/core/util/MeasureUtil.java ## @@ -54,6 +55,27

[GitHub] [griffin] aborgatin commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates

2019-03-06 Thread GitBox
aborgatin commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#discussion_r262923746 ## File path: service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java ## @@ -185,17

[GitHub] [griffin] aborgatin commented on issue #484: GRIFFIN-232 - add support pluggable predicates

2019-03-06 Thread GitBox
aborgatin commented on issue #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#issuecomment-470103876 > @aborgatin can you please add to documentation (probably deployment.md?) how custom segment predicates can be plugged in? I

[GitHub] [griffin] chemikadze commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates

2019-03-06 Thread GitBox
chemikadze commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#discussion_r263031466 ## File path: service/pom.xml ## @@ -291,8 +291,9 @@ under the License.

[GitHub] [griffin] chemikadze commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates

2019-03-06 Thread GitBox
chemikadze commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#discussion_r263032819 ## File path: service/pom.xml ## @@ -291,8 +291,9 @@ under the License.

[GitHub] chengxvyuanoom opened a new pull request #482: Modification of Griffin Service

2019-02-22 Thread GitBox
chengxvyuanoom opened a new pull request #482: Modification of Griffin Service URL: https://github.com/apache/griffin/pull/482 fix bug: Replacement of Web runtime container Tomcat -> Jetty (Reduce startup time) Merging Swagger Framework Under PROFILING operation´╝îa bug about Single

[GitHub] chengxvyuanoom closed pull request #482: Modification of Griffin Service

2019-02-22 Thread GitBox
chengxvyuanoom closed pull request #482: Modification of Griffin Service URL: https://github.com/apache/griffin/pull/482 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [griffin] chemikadze commented on issue #480: For task GRIFFIN-229, trigger the job right now

2019-03-05 Thread GitBox
chemikadze commented on issue #480: For task GRIFFIN-229, trigger the job right now URL: https://github.com/apache/griffin/pull/480#issuecomment-469788577 @bhlx3lyx7 @guoyuepeng We'd like to see GRIFFIN-229 in upstream faster, but original PR author is not responding. What's the policy in

[GitHub] [griffin] asfgit closed pull request #483: GRIFFIN-234 Add applicationId to MetricWrapper

2019-03-05 Thread GitBox
asfgit closed pull request #483: GRIFFIN-234 Add applicationId to MetricWrapper URL: https://github.com/apache/griffin/pull/483 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [griffin] guoyuepeng commented on issue #480: For task GRIFFIN-229, trigger the job right now

2019-03-05 Thread GitBox
guoyuepeng commented on issue #480: For task GRIFFIN-229, trigger the job right now URL: https://github.com/apache/griffin/pull/480#issuecomment-469913309 @chemikadze @dyingbleed @bhlx3lyx7 For this feature development, I think we can add commits on top of it.

[GitHub] [griffin] chemikadze commented on a change in pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id

2019-03-13 Thread GitBox
chemikadze commented on a change in pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id URL: https://github.com/apache/griffin/pull/486#discussion_r265412902 ## File path: service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java

[GitHub] [griffin] asfgit closed pull request #485: GRIFFIN-229 trigger the job right now with fixing comments

2019-03-14 Thread GitBox
asfgit closed pull request #485: GRIFFIN-229 trigger the job right now with fixing comments URL: https://github.com/apache/griffin/pull/485 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [griffin] asfgit closed pull request #488: Fix deployment doc

2019-03-14 Thread GitBox
asfgit closed pull request #488: Fix deployment doc URL: https://github.com/apache/griffin/pull/488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [griffin] chemikadze closed pull request #480: For task GRIFFIN-229, trigger the job right now

2019-03-14 Thread GitBox
chemikadze closed pull request #480: For task GRIFFIN-229, trigger the job right now URL: https://github.com/apache/griffin/pull/480 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [griffin] chemikadze commented on issue #480: For task GRIFFIN-229, trigger the job right now

2019-03-14 Thread GitBox
chemikadze commented on issue #480: For task GRIFFIN-229, trigger the job right now URL: https://github.com/apache/griffin/pull/480#issuecomment-472928433 Closed by #485 This is an automated message from the Apache Git

[GitHub] [griffin] chemikadze commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates

2019-03-10 Thread GitBox
chemikadze commented on a change in pull request #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#discussion_r264060866 ## File path: service/pom.xml ## @@ -280,6 +280,23 @@ under the License.

[GitHub] [griffin] toyboxman opened a new pull request #487: Bug Fix

2019-03-13 Thread GitBox
toyboxman opened a new pull request #487: Bug Fix URL: https://github.com/apache/griffin/pull/487 scalaj.http only allows HttpURLConnection to call remote web api, but on spark cluster condition, no HttpURLConnection returns instead of class org.apache.hadoop.fs.FsUrlConnection. so

[GitHub] [griffin] toyboxman commented on issue #487: Bug Fix

2019-03-13 Thread GitBox
toyboxman commented on issue #487: Bug Fix URL: https://github.com/apache/griffin/pull/487#issuecomment-472412416 @guoyuepeng, @bhlx3lyx7 , please review and approve this change. because it actually leads ES writing failure.

[GitHub] [griffin] aborgatin opened a new pull request #485: GRIFFIN-229 trigger the job right now with fixing comments

2019-03-07 Thread GitBox
aborgatin opened a new pull request #485: GRIFFIN-229 trigger the job right now with fixing comments URL: https://github.com/apache/griffin/pull/485 [comment](https://github.com/apache/griffin/pull/480#issuecomment-460075951) > @dyingbleed can you please include screenshots for UI

[GitHub] [griffin] chemikadze commented on issue #485: GRIFFIN-229 trigger the job right now with fixing comments

2019-03-07 Thread GitBox
chemikadze commented on issue #485: GRIFFIN-229 trigger the job right now with fixing comments URL: https://github.com/apache/griffin/pull/485#issuecomment-470608381 Looks good! @bhlx3lyx7 @dyingbleed WDYT? This is an

[GitHub] [griffin] chemikadze commented on issue #484: GRIFFIN-232 - add support pluggable predicates

2019-03-07 Thread GitBox
chemikadze commented on issue #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#issuecomment-470609419 @aborgatin let keep semantics of existing jar, and build separate "lib" jar to be used as dependency for plugins

[GitHub] [griffin] aborgatin opened a new pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
aborgatin opened a new pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489 This is an automated message from the Apache Git Service.

[GitHub] [griffin] asfgit closed pull request #487: Bug Fix

2019-03-19 Thread GitBox
asfgit closed pull request #487: Bug Fix URL: https://github.com/apache/griffin/pull/487 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [griffin] jhsb25 commented on issue #486: GRIFFIN-237 Implement service method get JobInstanceBean by id

2019-03-20 Thread GitBox
jhsb25 commented on issue #486: GRIFFIN-237 Implement service method get JobInstanceBean by id URL: https://github.com/apache/griffin/pull/486#issuecomment-475048315 @guoyuepeng can you please approve and/or merge This is an

[GitHub] [griffin] toyboxman commented on issue #490: *IMPROVEMENT BUILD*

2019-03-18 Thread GitBox
toyboxman commented on issue #490: *IMPROVEMENT BUILD* URL: https://github.com/apache/griffin/pull/490#issuecomment-474176116 Close it until coverity app is ready. This is an automated message from the Apache Git Service. To

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266699358 ## File path: service/src/main/java/org/apache/griffin/core/job/JobController.java

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266699321 ## File path: service/src/main/java/org/apache/griffin/core/job/JobController.java

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266699462 ## File path: service/src/main/java/org/apache/griffin/core/job/JobInstance.java

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266699234 ## File path:

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266699489 ## File path:

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266699518 ## File path:

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266699550 ## File path:

[GitHub] [griffin] chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-18 Thread GitBox
chemikadze commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266699167 ## File path: griffin-doc/service/api-guide.md ## @@ -549,7 +549,21 @@

[GitHub] [griffin] toyboxman opened a new pull request #490: *IMPROVEMENT BUILD*

2019-03-18 Thread GitBox
toyboxman opened a new pull request #490: *IMPROVEMENT BUILD* URL: https://github.com/apache/griffin/pull/490 add coverage verification in build flow. This is an automated message from the Apache Git Service. To respond to

[GitHub] [griffin] toyboxman closed pull request #490: *IMPROVEMENT BUILD*

2019-03-18 Thread GitBox
toyboxman closed pull request #490: *IMPROVEMENT BUILD* URL: https://github.com/apache/griffin/pull/490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-19 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266855423 ## File path: griffin-doc/service/api-guide.md ## @@ -549,7 +549,21 @@

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-19 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266864068 ## File path:

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-19 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266859889 ## File path: service/src/main/java/org/apache/griffin/core/job/JobController.java

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-19 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266876882 ## File path:

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-19 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266877049 ## File path: service/src/main/java/org/apache/griffin/core/job/JobInstance.java

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-19 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266855423 ## File path: griffin-doc/service/api-guide.md ## @@ -549,7 +549,21 @@

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-19 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266863242 ## File path: service/src/main/java/org/apache/griffin/core/job/JobController.java

[GitHub] [griffin] aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id

2019-03-19 Thread GitBox
aborgatin commented on a change in pull request #489: GRIFFIN-240 Return JobInstanceBean in response to a call Trigger job by id URL: https://github.com/apache/griffin/pull/489#discussion_r266877547 ## File path:

[GitHub] [griffin] aborgatin commented on a change in pull request #485: GRIFFIN-229 trigger the job right now with fixing comments

2019-03-12 Thread GitBox
aborgatin commented on a change in pull request #485: GRIFFIN-229 trigger the job right now with fixing comments URL: https://github.com/apache/griffin/pull/485#discussion_r264623722 ## File path: service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ##

  1   2   3   4   >