Sounds good to me.
- application.properties would have a property containing list of hook
class names (or probably, spring bean names?), configuring subset and
order
of hook instances enabled at deployment time.
[William] I like a logic name as spring bean name.
- Hook instantiation
[
https://issues.apache.org/jira/browse/GRIFFIN-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Sokolov updated GRIFFIN-200:
Description:
In some environments, users might want to perform certain actions
[
https://issues.apache.org/jira/browse/GRIFFIN-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658634#comment-16658634
]
Nikolay Sokolov commented on GRIFFIN-200:
-
[~Lionel_3L] thank you, expanding scope of hook
I think this is best detail I can give right now without writing any code:
- application.properties would have a property containing list of hook
class names (or probably, spring bean names?), configuring subset and order
of hook instances enabled at deployment time.
- Hook
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r227214831
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,100 @@
+/*
+Licensed
[
https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660037#comment-16660037
]
ASF GitHub Bot commented on GRIFFIN-207:
Github user chemikadze commented on a diff in the pull
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/442#discussion_r227217198
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -81,6 +81,9 @@ Licensed to the Apache Software
I'm fine this hook proposal.
one comment, could we define annotation to take list of hook class names as
well.
From: William Guo
Sent: Monday, October 22, 2018 3:42 PM
To: dev@griffin.incubator.apache.org
Subject: Re: Hooks support in JobService
Sounds good to
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-griffin/pull/440
---
[
https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659533#comment-16659533
]
ASF GitHub Bot commented on GRIFFIN-207:
Github user chemikadze commented on the issue:
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/441
@toyboxman i've updated the code according to your comments, thanks!
---
Nikolay Sokolov created GRIFFIN-208:
---
Summary: Job status is SUCCESS even if some stages have failed
Key: GRIFFIN-208
URL: https://issues.apache.org/jira/browse/GRIFFIN-208
Project: Griffin
Github user whhe commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r227194519
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,100 @@
+/*
+Licensed to the
LGTM, we can start this.
Thanks,
Lionel
On Mon, Oct 22, 2018 at 8:58 PM Eugene Liu wrote:
> I'm fine this hook proposal.
>
> one comment, could we define annotation to take list of hook class names
> as well.
>
>
> From: William Guo
> Sent: Monday, October
[
https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659926#comment-16659926
]
ASF GitHub Bot commented on GRIFFIN-207:
Github user whhe commented on a diff in the pull
15 matches
Mail list logo
