Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230049250
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -168,7 +175,14 @@ public AbstractJob addJob(AbstractJob
+1 Be better.
--
Sheng Wu
Apache SkyWalking
-- Original --
From: "ShaoFeng Shi";
Date: Thu, Nov 1, 2018 04:48 PM
To: "general";
Cc: "dev";
Subject: Re: [VOTE] Graduate Apache Griffin (incubating) as a TLP
+1 (non-binding)
Gook
+1
Alex Lv
From: 吴晟 Sheng Wu
Sent: Thursday, November 1, 2018 16:52
To: general
Cc: dev
Subject: Re: [VOTE] Graduate Apache Griffin (incubating) as a TLP
+1 Be better.
--
Sheng Wu
Apache SkyWalking
-- Original
It's time to graduate now!
totally agree +1
From: jenny li
Sent: Thursday, November 1, 2018 3:53 PM
To: dev@griffin.incubator.apache.org
Cc: gene...@incubator.apache.org
Subject: Re: [VOTE] Graduate Apache Griffin (incubating) as a TLP
+1 Can‘t wait to see this
+1 (non-binding)
Gook luck Griffin!
Eugene Liu 于2018年11月1日周四 下午3:57写道：
> It's time to graduate now!
>
> totally agree +1
>
> From: jenny li
> Sent: Thursday, November 1, 2018 3:53 PM
> To: dev@griffin.incubator.apache.org
> Cc: gene...@incubator.apache.org
>
+dev
-- Forwarded message -
From: William Guo
Date: Thu, Nov 1, 2018 at 11:21 AM
Subject: [VOTE] Graduate Apache Griffin (incubating) as a TLP
To:
Hi all,
Given that we've got positive feedback on the DISCUSS
thread, after we had made some changes based on DISCUSS feedback.
+1 Can‘t wait to see this great project Apache Griffin from the Incubator
to Graduation.
Best regards,
Jenny
On Thu, Nov 1, 2018 at 3:31 PM William Guo wrote:
> +dev
>
> -- Forwarded message -
> From: William Guo
> Date: Thu, Nov 1, 2018 at 11:21 AM
> Subject: [VOTE] Graduate
+1
From: William Guo
Sent: Thursday, November 1, 2018 7:31 AM
To: gene...@incubator.apache.org; dev@griffin.incubator.apache.org
Subject: Fwd: [VOTE] Graduate Apache Griffin (incubating) as a TLP
+dev
-- Forwarded message -
From: William Guo
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-griffin-site/pull/13
---
+1
Thanks，
Kevin Yao
William Guo 于2018年11月1日 周四上午10:24写道：
> Will go to vote after some changes upon DISCUSS feedback.
>
> Thanks,
> William
>
> On Thu, Nov 1, 2018 at 10:04 AM William Guo wrote:
>
> > Thanks all.
> >
> > One following update: Apache Griffin Name Search resolved.
> >
> >
+1 (binding)
Regards
JB
Le 1 nov. 2018 à 14:03, à 14:03, Willem Jiang a écrit:
>+1 binding.
>It's good to see griffin is ready to graduate.
>
>Willem Jiang
>
>Twitter: willemjiang
>Weibo: 姜宁willem
>
>On Thu, Nov 1, 2018 at 3:31 PM William Guo wrote:
>>
>> +dev
>>
>> -- Forwarded
+1 binding.
It's good to see griffin is ready to graduate.
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Thu, Nov 1, 2018 at 3:31 PM William Guo wrote:
>
> +dev
>
> -- Forwarded message -
> From: William Guo
> Date: Thu, Nov 1, 2018 at 11:21 AM
> Subject: [VOTE]
GitHub user icesmartjuan opened a pull request:
https://github.com/apache/incubator-griffin-site/pull/13
Fix layout issue when on mobile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/icesmartjuan/incubator-griffin-site
+1
On Thu, Nov 1, 2018 at 3:31 PM William Guo wrote:
> +dev
>
> -- Forwarded message -
> From: William Guo
> Date: Thu, Nov 1, 2018 at 11:21 AM
> Subject: [VOTE] Graduate Apache Griffin (incubating) as a TLP
> To:
>
>
> Hi all,
>
> Given that we've got positive feedback on the
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230045266
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047076
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230046860
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
+1
On Thu, Nov 1, 2018 at 6:03 PM Jean-Baptiste Onofré wrote:
> +1 (binding)
>
> Regards
> JB
>
> Le 1 nov. 2018 à 14:03, à 14:03, Willem Jiang a
> écrit:
> >+1 binding.
> >It's good to see griffin is ready to graduate.
> >
> >Willem Jiang
> >
> >Twitter: willemjiang
> >Weibo: 姜宁willem
> >
>
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047870
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEvent.java ---
@@ -0,0 +1,44 @@
+/*
+Licensed to the Apache
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230046728
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/JobEventHook.java ---
@@ -0,0 +1,11 @@
+package
Github user toyboxman commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230047399
--- Diff:
service/src/test/java/org/apache/griffin/core/job/EventServiceTest.java ---
@@ -0,0 +1,69 @@
+package
+1 (binding)
Regards,
Dave
Sent from my iPhone
> On Nov 1, 2018, at 12:31 AM, William Guo wrote:
>
> +dev
>
> -- Forwarded message -
> From: William Guo
> Date: Thu, Nov 1, 2018 at 11:21 AM
> Subject: [VOTE] Graduate Apache Griffin (incubating) as a TLP
> To:
>
>
> Hi
22 matches
Mail list logo
