[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user jmuehlner closed the pull request at: https://github.com/apache/incubator-guacamole-client/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65447441 --- Diff: guacamole-docker/README.md --- @@ -129,17 +126,17 @@ Deploying Aoache Guacamole with LDAP authentication -e LDAP_CONFIG_BASE_DN=ou=connections,dc=example,dc=com \ -d -p 8080:8080 glyptodon/guacamole -Linking Guacamole to your LDAP directory will require additional configuration parameters +Using Guacamole with your LDAP directory will require additional configuration parameters specified via environment variables. These variables collectively describe how Guacamole will connect to LDAP: -1. `LDAP_HOSTNAME` - The base of the DN for all Guacamole users. +1. `LDAP_HOSTNAME` - The hostname or IP address of your LDAP server. 2. `LDAP_USER_BASE_DN` - The base of the DN for all Guacamole users. 3. `LDAP_PORT` - The port your LDAP server listens on. (Optional) --- End diff -- If you think that's better, then cool. I'm more of the mind that separate would be easier to read, but I don't think this way is bad in itself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65447767 --- Diff: guacamole-docker/README.md --- @@ -148,6 +145,24 @@ binding as `LDAP_SEARCH_BIND_DN` to authenticate other users. (Optional) username within all Guacamole user objects in the LDAP directory. (Optional) 9. `LDAP_CONFIG_BASE_DN` - The base of the DN for all Guacamole configurations. (Optional) +Deploying Apache Guacamole with LDAP authentication --- End diff -- Seems reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446605 --- Diff: guacamole-docker/README.md --- @@ -148,6 +145,24 @@ binding as `LDAP_SEARCH_BIND_DN` to authenticate other users. (Optional) username within all Guacamole user objects in the LDAP directory. (Optional) 9. `LDAP_CONFIG_BASE_DN` - The base of the DN for all Guacamole configurations. (Optional) +Deploying Apache Guacamole with LDAP authentication --- End diff -- Arg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446703 --- Diff: guacamole-docker/README.md --- @@ -148,6 +145,24 @@ binding as `LDAP_SEARCH_BIND_DN` to authenticate other users. (Optional) username within all Guacamole user objects in the LDAP directory. (Optional) 9. `LDAP_CONFIG_BASE_DN` - The base of the DN for all Guacamole configurations. (Optional) +Deploying Apache Guacamole with LDAP authentication --- End diff -- What do you think about letting the "Using both LDAP and a database" thing be a level 3 heading beneath the general LDAP section? Like what we did with the database initialization parts? Seems related enough that it maybe shouldn't be its own thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446708 --- Diff: guacamole-docker/README.md --- @@ -129,17 +126,17 @@ Deploying Aoache Guacamole with LDAP authentication -e LDAP_CONFIG_BASE_DN=ou=connections,dc=example,dc=com \ -d -p 8080:8080 glyptodon/guacamole -Linking Guacamole to your LDAP directory will require additional configuration parameters +Using Guacamole with your LDAP directory will require additional configuration parameters specified via environment variables. These variables collectively describe how Guacamole will connect to LDAP: -1. `LDAP_HOSTNAME` - The base of the DN for all Guacamole users. +1. `LDAP_HOSTNAME` - The hostname or IP address of your LDAP server. 2. `LDAP_USER_BASE_DN` - The base of the DN for all Guacamole users. 3. `LDAP_PORT` - The port your LDAP server listens on. (Optional) --- End diff -- I could do that ... I was trying to keep things a bit more compact by grouping them together. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446122 --- Diff: guacamole-docker/README.md --- @@ -129,17 +126,17 @@ Deploying Aoache Guacamole with LDAP authentication -e LDAP_CONFIG_BASE_DN=ou=connections,dc=example,dc=com \ -d -p 8080:8080 glyptodon/guacamole -Linking Guacamole to your LDAP directory will require additional configuration parameters +Using Guacamole with your LDAP directory will require additional configuration parameters specified via environment variables. These variables collectively describe how Guacamole will connect to LDAP: -1. `LDAP_HOSTNAME` - The base of the DN for all Guacamole users. +1. `LDAP_HOSTNAME` - The hostname or IP address of your LDAP server. 2. `LDAP_USER_BASE_DN` - The base of the DN for all Guacamole users. 3. `LDAP_PORT` - The port your LDAP server listens on. (Optional) --- End diff -- Hm... What do you think about listing the optional variables in their own list? I think this is how things are organized in the manual. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65445879 --- Diff: guacamole-docker/README.md --- @@ -148,6 +145,24 @@ binding as `LDAP_SEARCH_BIND_DN` to authenticate other users. (Optional) username within all Guacamole user objects in the LDAP directory. (Optional) 9. `LDAP_CONFIG_BASE_DN` - The base of the DN for all Guacamole configurations. (Optional) +Deploying Apache Guacamole with LDAP authentication --- End diff -- But this is LDAP + database --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65446586 --- Diff: guacamole-docker/README.md --- @@ -120,7 +117,7 @@ documented in [the Guacamole manual](http://guacamole.incubator.apache.org/doc/gug/jdbc-auth.html#jdbc-auth-mysql). -Deploying Aoache Guacamole with LDAP authentication +Deploying Apache Guacamole with LDAP and database authentication --- End diff -- Erg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
[GitHub] incubator-guacamole-client pull request #11: GUACAMOLE-41: Add LDAP section ...
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/11#discussion_r65445847 --- Diff: guacamole-docker/README.md --- @@ -120,7 +117,7 @@ documented in [the Guacamole manual](http://guacamole.incubator.apache.org/doc/gug/jdbc-auth.html#jdbc-auth-mysql). -Deploying Aoache Guacamole with LDAP authentication +Deploying Apache Guacamole with LDAP and database authentication --- End diff -- But this is just with LDAP --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
