Re: [DISCUSS] HBASE-14850 C++ client implementation
The new github repo is https://github.com/apache/hbase-native-client. Sean Busbey 于2019年4月11日周四 上午12:55写道： > also please > > * delete the feature branch for HBASE-14850 > * update HBASE-14850 jira with a pointer > > Could you include a summary on the jira for status of nightly/precommit > tests? > > On Wed, Apr 10, 2019 at 11:22 AM Stack wrote: > > > > Point this to the new repo > > https://github.com/apache/hbase/tree/master/hbase-native-client ? > > Thanks, > > S > > > > On Wed, Apr 10, 2019 at 7:07 AM Guanghao Zhang > wrote: > > > > > https://gitbox.apache.org/repos/asf?p=hbase-native-client.git > > > The new hbase-native-client repo created and push the commit from > > > HBASE-14850 to it. > > > > > > Peter Somogyi 于2019年3月20日周三 下午8:08写道： > > > > > > > +1 for hbase-native-client repo. > > > > You can create a new gitbox repository on https://gitbox.apache.org/ > by > > > > filling out a simple form. > > > > > > > > On Wed, Mar 20, 2019 at 8:48 AM Guanghao Zhang > > > wrote: > > > > > > > > > I am +1 to push the hbase-native-client to a new git repo. One more > > > > > question, how to create a new repo in gitbox? Do we have some ref > guide > > > > for > > > > > this? Thanks. > > > > > > > > > > Sean Busbey 于2019年3月14日周四 下午9:58写道： > > > > > > > > > > > I'd also like to see the native client in its own repo. Dealing > with > > > a > > > > > > new build system for C++ will be some overhead, but I suspect > less > > > > > > overhead than if we have to stitch that build to work with maven > in > > > > > > the same repo. > > > > > > > > > > > > Also I think the hbase-connectors repo is overdue for a release > and > > > > > > I'd rather avoid either rushing the C++ client, blocking to wait > for > > > > > > it, or doing the work to pull it aside when doing a release. > > > > > > > > > > > > On Thu, Mar 14, 2019 at 8:28 AM 张铎(Duo Zhang) < > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > > > > For hbase-connectors, it is still a maven project, but the > native > > > > > client > > > > > > is > > > > > > > a C++ project, so maybe we could just give it a separated > repo... > > > > > > > > > > > > > > Stack 于2019年3月14日周四 下午1:54写道： > > > > > > > > > > > > > > > On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang < > > > > [email protected]> > > > > > > > > wrote: > > > > > > > > ... > > > > > > > > > > > > > > > > > As we have hbase-connectors project now and Sean Busbey > > > suggested > > > > > to > > > > > > move > > > > > > > > > the native client to hbase-connector project. Or we can > create > > > a > > > > > new > > > > > > > > > project hbase-native-client for this. But the problem is > the > > > > > > > > compatibility > > > > > > > > > may be break when there are some changes in HBase project. > > > > Looking > > > > > > > > forward > > > > > > > > > to your suggestions. > > > > > > > > > > > > > > > > > > > > > > > > > Would hbase-native-client be in hbase-connectors? I'd imagine > > > this > > > > > > would > > > > > > > > make the development easier. > > > > > > > > > > > > > > > > Once you'd made a release of the new client, could we a step > to > > > the > > > > > > nightly > > > > > > > > build that pulls the new client and runs it through paces > > > > complaining > > > > > > if it > > > > > > > > fails? > > > > > > > > > > > > > > > > (sounds great) > > > > > > > > S > > > > > > > > > > > > > > > > > > > > > > > > > > >
Re: [DISCUSS] HBASE-14850 C++ client implementation
also please * delete the feature branch for HBASE-14850 * update HBASE-14850 jira with a pointer Could you include a summary on the jira for status of nightly/precommit tests? On Wed, Apr 10, 2019 at 11:22 AM Stack wrote: > > Point this to the new repo > https://github.com/apache/hbase/tree/master/hbase-native-client ? > Thanks, > S > > On Wed, Apr 10, 2019 at 7:07 AM Guanghao Zhang wrote: > > > https://gitbox.apache.org/repos/asf?p=hbase-native-client.git > > The new hbase-native-client repo created and push the commit from > > HBASE-14850 to it. > > > > Peter Somogyi 于2019年3月20日周三 下午8:08写道： > > > > > +1 for hbase-native-client repo. > > > You can create a new gitbox repository on https://gitbox.apache.org/ by > > > filling out a simple form. > > > > > > On Wed, Mar 20, 2019 at 8:48 AM Guanghao Zhang > > wrote: > > > > > > > I am +1 to push the hbase-native-client to a new git repo. One more > > > > question, how to create a new repo in gitbox? Do we have some ref guide > > > for > > > > this? Thanks. > > > > > > > > Sean Busbey 于2019年3月14日周四 下午9:58写道： > > > > > > > > > I'd also like to see the native client in its own repo. Dealing with > > a > > > > > new build system for C++ will be some overhead, but I suspect less > > > > > overhead than if we have to stitch that build to work with maven in > > > > > the same repo. > > > > > > > > > > Also I think the hbase-connectors repo is overdue for a release and > > > > > I'd rather avoid either rushing the C++ client, blocking to wait for > > > > > it, or doing the work to pull it aside when doing a release. > > > > > > > > > > On Thu, Mar 14, 2019 at 8:28 AM 张铎(Duo Zhang) > > > > > > > wrote: > > > > > > > > > > > > For hbase-connectors, it is still a maven project, but the native > > > > client > > > > > is > > > > > > a C++ project, so maybe we could just give it a separated repo... > > > > > > > > > > > > Stack 于2019年3月14日周四 下午1:54写道： > > > > > > > > > > > > > On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang < > > > [email protected]> > > > > > > > wrote: > > > > > > > ... > > > > > > > > > > > > > > > As we have hbase-connectors project now and Sean Busbey > > suggested > > > > to > > > > > move > > > > > > > > the native client to hbase-connector project. Or we can create > > a > > > > new > > > > > > > > project hbase-native-client for this. But the problem is the > > > > > > > compatibility > > > > > > > > may be break when there are some changes in HBase project. > > > Looking > > > > > > > forward > > > > > > > > to your suggestions. > > > > > > > > > > > > > > > > > > > > > > Would hbase-native-client be in hbase-connectors? I'd imagine > > this > > > > > would > > > > > > > make the development easier. > > > > > > > > > > > > > > Once you'd made a release of the new client, could we a step to > > the > > > > > nightly > > > > > > > build that pulls the new client and runs it through paces > > > complaining > > > > > if it > > > > > > > fails? > > > > > > > > > > > > > > (sounds great) > > > > > > > S > > > > > > > > > > > > > > > > > > > > >
Re: [DISCUSS] HBASE-14850 C++ client implementation
Point this to the new repo https://github.com/apache/hbase/tree/master/hbase-native-client ? Thanks, S On Wed, Apr 10, 2019 at 7:07 AM Guanghao Zhang wrote: > https://gitbox.apache.org/repos/asf?p=hbase-native-client.git > The new hbase-native-client repo created and push the commit from > HBASE-14850 to it. > > Peter Somogyi 于2019年3月20日周三 下午8:08写道： > > > +1 for hbase-native-client repo. > > You can create a new gitbox repository on https://gitbox.apache.org/ by > > filling out a simple form. > > > > On Wed, Mar 20, 2019 at 8:48 AM Guanghao Zhang > wrote: > > > > > I am +1 to push the hbase-native-client to a new git repo. One more > > > question, how to create a new repo in gitbox? Do we have some ref guide > > for > > > this? Thanks. > > > > > > Sean Busbey 于2019年3月14日周四 下午9:58写道： > > > > > > > I'd also like to see the native client in its own repo. Dealing with > a > > > > new build system for C++ will be some overhead, but I suspect less > > > > overhead than if we have to stitch that build to work with maven in > > > > the same repo. > > > > > > > > Also I think the hbase-connectors repo is overdue for a release and > > > > I'd rather avoid either rushing the C++ client, blocking to wait for > > > > it, or doing the work to pull it aside when doing a release. > > > > > > > > On Thu, Mar 14, 2019 at 8:28 AM 张铎(Duo Zhang) > > > > > wrote: > > > > > > > > > > For hbase-connectors, it is still a maven project, but the native > > > client > > > > is > > > > > a C++ project, so maybe we could just give it a separated repo... > > > > > > > > > > Stack 于2019年3月14日周四 下午1:54写道： > > > > > > > > > > > On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang < > > [email protected]> > > > > > > wrote: > > > > > > ... > > > > > > > > > > > > > As we have hbase-connectors project now and Sean Busbey > suggested > > > to > > > > move > > > > > > > the native client to hbase-connector project. Or we can create > a > > > new > > > > > > > project hbase-native-client for this. But the problem is the > > > > > > compatibility > > > > > > > may be break when there are some changes in HBase project. > > Looking > > > > > > forward > > > > > > > to your suggestions. > > > > > > > > > > > > > > > > > > > Would hbase-native-client be in hbase-connectors? I'd imagine > this > > > > would > > > > > > make the development easier. > > > > > > > > > > > > Once you'd made a release of the new client, could we a step to > the > > > > nightly > > > > > > build that pulls the new client and runs it through paces > > complaining > > > > if it > > > > > > fails? > > > > > > > > > > > > (sounds great) > > > > > > S > > > > > > > > > > > > > > > >
Re: [DISCUSS] HBASE-14850 C++ client implementation
https://gitbox.apache.org/repos/asf?p=hbase-native-client.git The new hbase-native-client repo created and push the commit from HBASE-14850 to it. Peter Somogyi 于2019年3月20日周三 下午8:08写道： > +1 for hbase-native-client repo. > You can create a new gitbox repository on https://gitbox.apache.org/ by > filling out a simple form. > > On Wed, Mar 20, 2019 at 8:48 AM Guanghao Zhang wrote: > > > I am +1 to push the hbase-native-client to a new git repo. One more > > question, how to create a new repo in gitbox? Do we have some ref guide > for > > this? Thanks. > > > > Sean Busbey 于2019年3月14日周四 下午9:58写道： > > > > > I'd also like to see the native client in its own repo. Dealing with a > > > new build system for C++ will be some overhead, but I suspect less > > > overhead than if we have to stitch that build to work with maven in > > > the same repo. > > > > > > Also I think the hbase-connectors repo is overdue for a release and > > > I'd rather avoid either rushing the C++ client, blocking to wait for > > > it, or doing the work to pull it aside when doing a release. > > > > > > On Thu, Mar 14, 2019 at 8:28 AM 张铎(Duo Zhang) > > > wrote: > > > > > > > > For hbase-connectors, it is still a maven project, but the native > > client > > > is > > > > a C++ project, so maybe we could just give it a separated repo... > > > > > > > > Stack 于2019年3月14日周四 下午1:54写道： > > > > > > > > > On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang < > [email protected]> > > > > > wrote: > > > > > ... > > > > > > > > > > > As we have hbase-connectors project now and Sean Busbey suggested > > to > > > move > > > > > > the native client to hbase-connector project. Or we can create a > > new > > > > > > project hbase-native-client for this. But the problem is the > > > > > compatibility > > > > > > may be break when there are some changes in HBase project. > Looking > > > > > forward > > > > > > to your suggestions. > > > > > > > > > > > > > > > > Would hbase-native-client be in hbase-connectors? I'd imagine this > > > would > > > > > make the development easier. > > > > > > > > > > Once you'd made a release of the new client, could we a step to the > > > nightly > > > > > build that pulls the new client and runs it through paces > complaining > > > if it > > > > > fails? > > > > > > > > > > (sounds great) > > > > > S > > > > > > > > > > >
Re: [DISCUSS] HBASE-14850 C++ client implementation
+1 for hbase-native-client repo. You can create a new gitbox repository on https://gitbox.apache.org/ by filling out a simple form. On Wed, Mar 20, 2019 at 8:48 AM Guanghao Zhang wrote: > I am +1 to push the hbase-native-client to a new git repo. One more > question, how to create a new repo in gitbox? Do we have some ref guide for > this? Thanks. > > Sean Busbey 于2019年3月14日周四 下午9:58写道： > > > I'd also like to see the native client in its own repo. Dealing with a > > new build system for C++ will be some overhead, but I suspect less > > overhead than if we have to stitch that build to work with maven in > > the same repo. > > > > Also I think the hbase-connectors repo is overdue for a release and > > I'd rather avoid either rushing the C++ client, blocking to wait for > > it, or doing the work to pull it aside when doing a release. > > > > On Thu, Mar 14, 2019 at 8:28 AM 张铎(Duo Zhang) > > wrote: > > > > > > For hbase-connectors, it is still a maven project, but the native > client > > is > > > a C++ project, so maybe we could just give it a separated repo... > > > > > > Stack 于2019年3月14日周四 下午1:54写道： > > > > > > > On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang > > > > wrote: > > > > ... > > > > > > > > > As we have hbase-connectors project now and Sean Busbey suggested > to > > move > > > > > the native client to hbase-connector project. Or we can create a > new > > > > > project hbase-native-client for this. But the problem is the > > > > compatibility > > > > > may be break when there are some changes in HBase project. Looking > > > > forward > > > > > to your suggestions. > > > > > > > > > > > > > Would hbase-native-client be in hbase-connectors? I'd imagine this > > would > > > > make the development easier. > > > > > > > > Once you'd made a release of the new client, could we a step to the > > nightly > > > > build that pulls the new client and runs it through paces complaining > > if it > > > > fails? > > > > > > > > (sounds great) > > > > S > > > > > > >
Re: [DISCUSS] HBASE-14850 C++ client implementation
I am +1 to push the hbase-native-client to a new git repo. One more question, how to create a new repo in gitbox? Do we have some ref guide for this? Thanks. Sean Busbey 于2019年3月14日周四 下午9:58写道： > I'd also like to see the native client in its own repo. Dealing with a > new build system for C++ will be some overhead, but I suspect less > overhead than if we have to stitch that build to work with maven in > the same repo. > > Also I think the hbase-connectors repo is overdue for a release and > I'd rather avoid either rushing the C++ client, blocking to wait for > it, or doing the work to pull it aside when doing a release. > > On Thu, Mar 14, 2019 at 8:28 AM 张铎(Duo Zhang) > wrote: > > > > For hbase-connectors, it is still a maven project, but the native client > is > > a C++ project, so maybe we could just give it a separated repo... > > > > Stack 于2019年3月14日周四 下午1:54写道： > > > > > On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang > > > wrote: > > > ... > > > > > > > As we have hbase-connectors project now and Sean Busbey suggested to > move > > > > the native client to hbase-connector project. Or we can create a new > > > > project hbase-native-client for this. But the problem is the > > > compatibility > > > > may be break when there are some changes in HBase project. Looking > > > forward > > > > to your suggestions. > > > > > > > > > > Would hbase-native-client be in hbase-connectors? I'd imagine this > would > > > make the development easier. > > > > > > Once you'd made a release of the new client, could we a step to the > nightly > > > build that pulls the new client and runs it through paces complaining > if it > > > fails? > > > > > > (sounds great) > > > S > > > >
Re: [DISCUSS] HBASE-14850 C++ client implementation
I'd also like to see the native client in its own repo. Dealing with a new build system for C++ will be some overhead, but I suspect less overhead than if we have to stitch that build to work with maven in the same repo. Also I think the hbase-connectors repo is overdue for a release and I'd rather avoid either rushing the C++ client, blocking to wait for it, or doing the work to pull it aside when doing a release. On Thu, Mar 14, 2019 at 8:28 AM 张铎(Duo Zhang) wrote: > > For hbase-connectors, it is still a maven project, but the native client is > a C++ project, so maybe we could just give it a separated repo... > > Stack 于2019年3月14日周四 下午1:54写道： > > > On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang > > wrote: > > ... > > > > > As we have hbase-connectors project now and Sean Busbey suggested to move > > > the native client to hbase-connector project. Or we can create a new > > > project hbase-native-client for this. But the problem is the > > compatibility > > > may be break when there are some changes in HBase project. Looking > > forward > > > to your suggestions. > > > > > > > Would hbase-native-client be in hbase-connectors? I'd imagine this would > > make the development easier. > > > > Once you'd made a release of the new client, could we a step to the nightly > > build that pulls the new client and runs it through paces complaining if it > > fails? > > > > (sounds great) > > S > >
Re: [DISCUSS] HBASE-14850 C++ client implementation
For hbase-connectors, it is still a maven project, but the native client is a C++ project, so maybe we could just give it a separated repo... Stack 于2019年3月14日周四 下午1:54写道： > On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang > wrote: > ... > > > As we have hbase-connectors project now and Sean Busbey suggested to move > > the native client to hbase-connector project. Or we can create a new > > project hbase-native-client for this. But the problem is the > compatibility > > may be break when there are some changes in HBase project. Looking > forward > > to your suggestions. > > > > Would hbase-native-client be in hbase-connectors? I'd imagine this would > make the development easier. > > Once you'd made a release of the new client, could we a step to the nightly > build that pulls the new client and runs it through paces complaining if it > fails? > > (sounds great) > S >
Re: [DISCUSS] HBASE-14850 C++ client implementation
On Wed, Mar 13, 2019 at 12:54 AM Guanghao Zhang wrote: ... > As we have hbase-connectors project now and Sean Busbey suggested to move > the native client to hbase-connector project. Or we can create a new > project hbase-native-client for this. But the problem is the compatibility > may be break when there are some changes in HBase project. Looking forward > to your suggestions. > Would hbase-native-client be in hbase-connectors? I'd imagine this would make the development easier. Once you'd made a release of the new client, could we a step to the nightly build that pulls the new client and runs it through paces complaining if it fails? (sounds great) S
Re: [DISCUSS] HBASE-14850 C++ client implementation
+1 On 3/13/19 3:46 AM, Guanghao Zhang wrote: Hi, all, we plan to pick hbase-native-client feature up. And my colleague Junhong Xu is working on this. Now it can build rightly. And create table/get/put/scan/delete works right. We plan to continue development on feature branch HBASE-14850. But we found it didn't has a precommit check for this. We are trying to add a precommit check in HBASE-22046. As we have hbase-connectors project now and Sean Busbey suggested to move the native client to hbase-connector project. Or we can create a new project hbase-native-client for this. But the problem is the compatibility may be break when there are some changes in HBase project. Looking forward to your suggestions. Thanks.
Re: [DISCUSS] HBASE-14850 C++ client implementation
+1 for creating a new hbse-native-client project, about the compatibility, I think we can add an night test ? such as it'll clone the latest HBase repo and use the native client to request the HBase Minicluster. On Wed, Mar 13, 2019 at 3:54 PM Guanghao Zhang wrote: > Hi, all, we plan to pick hbase-native-client feature up. And my colleague > Junhong Xu is working on this. Now it can build rightly. And create > table/get/put/scan/delete works right. We plan to continue development on > feature branch HBASE-14850. But we found it didn't has a precommit check > for this. We are trying to add a precommit check in HBASE-22046. > > As we have hbase-connectors project now and Sean Busbey suggested to move > the native client to hbase-connector project. Or we can create a new > project hbase-native-client for this. But the problem is the compatibility > may be break when there are some changes in HBase project. Looking forward > to your suggestions. Thanks. >
