Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
Oh, there is a typo in the previous email, HBASE-28396 should be HBASE-29386... 张铎(Duo Zhang) 于2025年7月2日周三 21:46写道： > > See the comment here > > https://github.com/apache/hbase/pull/7084#issuecomment-3027898590 > > The problem is introduced by direct memory OOM, which seems not > related to the PR. > > Let me prepare for 2.6.3RC1. > > 张铎(Duo Zhang) 于2025年7月2日周三 11:27写道： > > > > There are some concerns around HBASE-28396, so let's wait for one more > > day to see whether we should revert the change. > > > > Thanks. > > > > 张铎(Duo Zhang) 于2025年7月1日周二 23:33写道： > > > > > > HBASE-28596 and HBASE-29423 both have been merged to branch-2.6. > > > > > > Let me sink this RC and prepare for RC1. > > > > > > Dieter De Paepe 于2025年6月30日周一 17:54写道： > > > > > > > > I had created a PR, but it didn't get picked up by jira. I've added it > > > > in a comment. > > > > > > > > However: > > > > > > > > * > > > > My PR doesn't have a testcase because > > > > org.apache.hadoop.hbase.backup.TestIncrementalBackup doesn't work > > > > (pre-patch) on my system, neither on master or on the 2.6 branch. > > > > * > > > > I just discovered another breaking issue with incremental backups: > > > > https://issues.apache.org/jira/browse/HBASE-29434 > > > > > > > > Both issues were already in 2.6.2. Given that nobody noticed so far, I > > > > guess it's not blocker for 2.6.3? > > > > > > > > From: 张铎(Duo Zhang) > > > > Sent: 29 June 2025 14:58 > > > > To: [email protected] > > > > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 > > > > is available > > > > > > > > Do we have a fix for HBASE-29423 already? > > > > > > > > Dieter De Paepe 于2025年6月28日周六 00:54写道： > > > > > > > > > > If possible, HBASE-29423 would also be very good to include. > > > > > > > > > > > > > > > From: Wellington Chevreuil > > > > > Sent: 27 June 2025 14:05 > > > > > To: [email protected] > > > > > Subject: Re: [VOTE] The first release candidate for Apache HBase > > > > > 2.6.3 is available > > > > > > > > > > Thanks for the feedback Charles. I have rebased the HBASE-28596 PR to > > > > > branch-2.6, we should be able to merge it today. > > > > > > > > > > Em qua., 25 de jun. de 2025 às 22:12, Charles Connell > > > > > escreveu: > > > > > > > > > > > I vote -1 because I feel that HBASE-28596 should be included in > > > > > > 2.6.3. > > > > > > There is an open PR to accomplish this: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887365445%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=X9Eaew8ArTQwE6jVuuU%2FOOpsztLpDpaYWWJVVUxID5Y%3D&reserved=0<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887388348%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=QDY4oOrpBD1Ua0EzTQf7fNzkzNyqCatkXwe53%2BRCNCU%3D&reserved=0><https://github.com/apache/hbase/pull/6508>. > > > > > > This will fix a performance > > > > > > regression that was introduced in 2.6.0 by HBASE-27474. The > > > > > > regression > > > > > > is described in HBASE-29012, but to summarize: logic was added so > > > > > > that > > > > > > we don't cache blocks that exist within a reference or a link. This > > > > > > is > > > > > > a significant issue. At Hubspot we had to apply the patch from the > > > > > > PR > > > > > > to our fork in order to have acceptable performance. > > > > > > > > > > > > Charles > > &g
Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
See the comment here https://github.com/apache/hbase/pull/7084#issuecomment-3027898590 The problem is introduced by direct memory OOM, which seems not related to the PR. Let me prepare for 2.6.3RC1. 张铎(Duo Zhang) 于2025年7月2日周三 11:27写道： > > There are some concerns around HBASE-28396, so let's wait for one more > day to see whether we should revert the change. > > Thanks. > > 张铎(Duo Zhang) 于2025年7月1日周二 23:33写道： > > > > HBASE-28596 and HBASE-29423 both have been merged to branch-2.6. > > > > Let me sink this RC and prepare for RC1. > > > > Dieter De Paepe 于2025年6月30日周一 17:54写道： > > > > > > I had created a PR, but it didn't get picked up by jira. I've added it in > > > a comment. > > > > > > However: > > > > > > * > > > My PR doesn't have a testcase because > > > org.apache.hadoop.hbase.backup.TestIncrementalBackup doesn't work > > > (pre-patch) on my system, neither on master or on the 2.6 branch. > > > * > > > I just discovered another breaking issue with incremental backups: > > > https://issues.apache.org/jira/browse/HBASE-29434 > > > > > > Both issues were already in 2.6.2. Given that nobody noticed so far, I > > > guess it's not blocker for 2.6.3? > > > > > > From: 张铎(Duo Zhang) > > > Sent: 29 June 2025 14:58 > > > To: [email protected] > > > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is > > > available > > > > > > Do we have a fix for HBASE-29423 already? > > > > > > Dieter De Paepe 于2025年6月28日周六 00:54写道： > > > > > > > > If possible, HBASE-29423 would also be very good to include. > > > > > > > > > > > > From: Wellington Chevreuil > > > > Sent: 27 June 2025 14:05 > > > > To: [email protected] > > > > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 > > > > is available > > > > > > > > Thanks for the feedback Charles. I have rebased the HBASE-28596 PR to > > > > branch-2.6, we should be able to merge it today. > > > > > > > > Em qua., 25 de jun. de 2025 às 22:12, Charles Connell > > > > escreveu: > > > > > > > > > I vote -1 because I feel that HBASE-28596 should be included in 2.6.3. > > > > > There is an open PR to accomplish this: > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887365445%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=X9Eaew8ArTQwE6jVuuU%2FOOpsztLpDpaYWWJVVUxID5Y%3D&reserved=0<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887388348%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=QDY4oOrpBD1Ua0EzTQf7fNzkzNyqCatkXwe53%2BRCNCU%3D&reserved=0><https://github.com/apache/hbase/pull/6508>. > > > > > This will fix a performance > > > > > regression that was introduced in 2.6.0 by HBASE-27474. The regression > > > > > is described in HBASE-29012, but to summarize: logic was added so that > > > > > we don't cache blocks that exist within a reference or a link. This is > > > > > a significant issue. At Hubspot we had to apply the patch from the PR > > > > > to our fork in order to have acceptable performance. > > > > > > > > > > Charles > > > > > > > > > > On Sat, Jun 21, 2025 at 9:48 PM Duo Zhang wrote: > > > > > > > > > > > > Please vote on this Apache hbase release candidate, > > > > > > hbase-2.6.3RC0 > > > > > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.3 > > > > > > [ ] -1 Do not release this package because ... > > > > > > > > > > > > The tag to be voted on is 2.6.3RC0: > > &g
Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
There are some concerns around HBASE-28396, so let's wait for one more day to see whether we should revert the change. Thanks. 张铎(Duo Zhang) 于2025年7月1日周二 23:33写道： > > HBASE-28596 and HBASE-29423 both have been merged to branch-2.6. > > Let me sink this RC and prepare for RC1. > > Dieter De Paepe 于2025年6月30日周一 17:54写道： > > > > I had created a PR, but it didn't get picked up by jira. I've added it in a > > comment. > > > > However: > > > > * > > My PR doesn't have a testcase because > > org.apache.hadoop.hbase.backup.TestIncrementalBackup doesn't work > > (pre-patch) on my system, neither on master or on the 2.6 branch. > > * > > I just discovered another breaking issue with incremental backups: > > https://issues.apache.org/jira/browse/HBASE-29434 > > > > Both issues were already in 2.6.2. Given that nobody noticed so far, I > > guess it's not blocker for 2.6.3? > > ________________ > > From: 张铎(Duo Zhang) > > Sent: 29 June 2025 14:58 > > To: [email protected] > > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is > > available > > > > Do we have a fix for HBASE-29423 already? > > > > Dieter De Paepe 于2025年6月28日周六 00:54写道： > > > > > > If possible, HBASE-29423 would also be very good to include. > > > > > > > > > From: Wellington Chevreuil > > > Sent: 27 June 2025 14:05 > > > To: [email protected] > > > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is > > > available > > > > > > Thanks for the feedback Charles. I have rebased the HBASE-28596 PR to > > > branch-2.6, we should be able to merge it today. > > > > > > Em qua., 25 de jun. de 2025 às 22:12, Charles Connell > > > escreveu: > > > > > > > I vote -1 because I feel that HBASE-28596 should be included in 2.6.3. > > > > There is an open PR to accomplish this: > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887365445%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=X9Eaew8ArTQwE6jVuuU%2FOOpsztLpDpaYWWJVVUxID5Y%3D&reserved=0<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887388348%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=QDY4oOrpBD1Ua0EzTQf7fNzkzNyqCatkXwe53%2BRCNCU%3D&reserved=0><https://github.com/apache/hbase/pull/6508>. > > > > This will fix a performance > > > > regression that was introduced in 2.6.0 by HBASE-27474. The regression > > > > is described in HBASE-29012, but to summarize: logic was added so that > > > > we don't cache blocks that exist within a reference or a link. This is > > > > a significant issue. At Hubspot we had to apply the patch from the PR > > > > to our fork in order to have acceptable performance. > > > > > > > > Charles > > > > > > > > On Sat, Jun 21, 2025 at 9:48 PM Duo Zhang wrote: > > > > > > > > > > Please vote on this Apache hbase release candidate, > > > > > hbase-2.6.3RC0 > > > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.3 > > > > > [ ] -1 Do not release this package because ... > > > > > > > > > > The tag to be voted on is 2.6.3RC0: > > > > > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.6.3RC0&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887403134%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=1W0KYxZ%2BfIoCYXR3jSouv2cL2JNVdNCQye9HI1XpdU4%3D&reserved=0<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.6.3RC0&data=05%7C02%7Cd
Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
HBASE-28596 and HBASE-29423 both have been merged to branch-2.6. Let me sink this RC and prepare for RC1. Dieter De Paepe 于2025年6月30日周一 17:54写道： > > I had created a PR, but it didn't get picked up by jira. I've added it in a > comment. > > However: > > * > My PR doesn't have a testcase because > org.apache.hadoop.hbase.backup.TestIncrementalBackup doesn't work (pre-patch) > on my system, neither on master or on the 2.6 branch. > * > I just discovered another breaking issue with incremental backups: > https://issues.apache.org/jira/browse/HBASE-29434 > > Both issues were already in 2.6.2. Given that nobody noticed so far, I guess > it's not blocker for 2.6.3? > > From: 张铎(Duo Zhang) > Sent: 29 June 2025 14:58 > To: [email protected] > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is > available > > Do we have a fix for HBASE-29423 already? > > Dieter De Paepe 于2025年6月28日周六 00:54写道： > > > > If possible, HBASE-29423 would also be very good to include. > > > > ________________ > > From: Wellington Chevreuil > > Sent: 27 June 2025 14:05 > > To: [email protected] > > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is > > available > > > > Thanks for the feedback Charles. I have rebased the HBASE-28596 PR to > > branch-2.6, we should be able to merge it today. > > > > Em qua., 25 de jun. de 2025 às 22:12, Charles Connell > > escreveu: > > > > > I vote -1 because I feel that HBASE-28596 should be included in 2.6.3. > > > There is an open PR to accomplish this: > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887365445%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=X9Eaew8ArTQwE6jVuuU%2FOOpsztLpDpaYWWJVVUxID5Y%3D&reserved=0<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887388348%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=QDY4oOrpBD1Ua0EzTQf7fNzkzNyqCatkXwe53%2BRCNCU%3D&reserved=0><https://github.com/apache/hbase/pull/6508>. > > > This will fix a performance > > > regression that was introduced in 2.6.0 by HBASE-27474. The regression > > > is described in HBASE-29012, but to summarize: logic was added so that > > > we don't cache blocks that exist within a reference or a link. This is > > > a significant issue. At Hubspot we had to apply the patch from the PR > > > to our fork in order to have acceptable performance. > > > > > > Charles > > > > > > On Sat, Jun 21, 2025 at 9:48 PM Duo Zhang wrote: > > > > > > > > Please vote on this Apache hbase release candidate, > > > > hbase-2.6.3RC0 > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > [ ] +1 Release this package as Apache hbase 2.6.3 > > > > [ ] -1 Do not release this package because ... > > > > > > > > The tag to be voted on is 2.6.3RC0: > > > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.6.3RC0&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887403134%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=1W0KYxZ%2BfIoCYXR3jSouv2cL2JNVdNCQye9HI1XpdU4%3D&reserved=0<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.6.3RC0&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887417017%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=szW62yUx4F9oHFjH1JmwFz8mM1%2BOA6ZmF5Jp9hWI%2Brc%3D&reserved=0><https://github.com/apache/hbase/tree/2.6.3RC0> > > > > > > > > This tag currently points to git reference > > > > > > > > bd91bafe4236c0a4dbba38a4c
Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
I had created a PR, but it didn't get picked up by jira. I've added it in a comment. However: * My PR doesn't have a testcase because org.apache.hadoop.hbase.backup.TestIncrementalBackup doesn't work (pre-patch) on my system, neither on master or on the 2.6 branch. * I just discovered another breaking issue with incremental backups: https://issues.apache.org/jira/browse/HBASE-29434 Both issues were already in 2.6.2. Given that nobody noticed so far, I guess it's not blocker for 2.6.3? From: 张铎(Duo Zhang) Sent: 29 June 2025 14:58 To: [email protected] Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available Do we have a fix for HBASE-29423 already? Dieter De Paepe 于2025年6月28日周六 00:54写道： > > If possible, HBASE-29423 would also be very good to include. > > > From: Wellington Chevreuil > Sent: 27 June 2025 14:05 > To: [email protected] > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is > available > > Thanks for the feedback Charles. I have rebased the HBASE-28596 PR to > branch-2.6, we should be able to merge it today. > > Em qua., 25 de jun. de 2025 às 22:12, Charles Connell > escreveu: > > > I vote -1 because I feel that HBASE-28596 should be included in 2.6.3. > > There is an open PR to accomplish this: > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887365445%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=X9Eaew8ArTQwE6jVuuU%2FOOpsztLpDpaYWWJVVUxID5Y%3D&reserved=0<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887388348%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=QDY4oOrpBD1Ua0EzTQf7fNzkzNyqCatkXwe53%2BRCNCU%3D&reserved=0><https://github.com/apache/hbase/pull/6508>. > > This will fix a performance > > regression that was introduced in 2.6.0 by HBASE-27474. The regression > > is described in HBASE-29012, but to summarize: logic was added so that > > we don't cache blocks that exist within a reference or a link. This is > > a significant issue. At Hubspot we had to apply the patch from the PR > > to our fork in order to have acceptable performance. > > > > Charles > > > > On Sat, Jun 21, 2025 at 9:48 PM Duo Zhang wrote: > > > > > > Please vote on this Apache hbase release candidate, > > > hbase-2.6.3RC0 > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > [ ] +1 Release this package as Apache hbase 2.6.3 > > > [ ] -1 Do not release this package because ... > > > > > > The tag to be voted on is 2.6.3RC0: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.6.3RC0&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887403134%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=1W0KYxZ%2BfIoCYXR3jSouv2cL2JNVdNCQye9HI1XpdU4%3D&reserved=0<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.6.3RC0&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887417017%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C8%7C%7C%7C&sdata=szW62yUx4F9oHFjH1JmwFz8mM1%2BOA6ZmF5Jp9hWI%2Brc%3D&reserved=0><https://github.com/apache/hbase/tree/2.6.3RC0> > > > > > > This tag currently points to git reference > > > > > > bd91bafe4236c0a4dbba38a4cc735dfe9db67cd6 > > > > > > The release files, including signatures, digests, as well as CHANGES.md > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fhbase%2F2.6.3RC0%2F&data=05%7C02%7Cdieterdp%40ngdata.com%7C6e8f6942dba24e0a7a4a08ddb70cc65a%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638867987887431672%7CUnknown%
Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
Do we have a fix for HBASE-29423 already? Dieter De Paepe 于2025年6月28日周六 00:54写道： > > If possible, HBASE-29423 would also be very good to include. > > > From: Wellington Chevreuil > Sent: 27 June 2025 14:05 > To: [email protected] > Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is > available > > Thanks for the feedback Charles. I have rebased the HBASE-28596 PR to > branch-2.6, we should be able to merge it today. > > Em qua., 25 de jun. de 2025 às 22:12, Charles Connell > escreveu: > > > I vote -1 because I feel that HBASE-28596 should be included in 2.6.3. > > There is an open PR to accomplish this: > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862735276%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=cIbLv8OWbeBtU5crCA05O36ObsxzDJEOWV1g0T0%2B%2BUw%3D&reserved=0<https://github.com/apache/hbase/pull/6508>. > > This will fix a performance > > regression that was introduced in 2.6.0 by HBASE-27474. The regression > > is described in HBASE-29012, but to summarize: logic was added so that > > we don't cache blocks that exist within a reference or a link. This is > > a significant issue. At Hubspot we had to apply the patch from the PR > > to our fork in order to have acceptable performance. > > > > Charles > > > > On Sat, Jun 21, 2025 at 9:48 PM Duo Zhang wrote: > > > > > > Please vote on this Apache hbase release candidate, > > > hbase-2.6.3RC0 > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > [ ] +1 Release this package as Apache hbase 2.6.3 > > > [ ] -1 Do not release this package because ... > > > > > > The tag to be voted on is 2.6.3RC0: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.6.3RC0&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862760147%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=eLZHy9M%2F1MFJNuXNZ0fncX0sr7Z4IiEo9okLuAwmFis%3D&reserved=0<https://github.com/apache/hbase/tree/2.6.3RC0> > > > > > > This tag currently points to git reference > > > > > > bd91bafe4236c0a4dbba38a4cc735dfe9db67cd6 > > > > > > The release files, including signatures, digests, as well as CHANGES.md > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fhbase%2F2.6.3RC0%2F&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862775386%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Pow9Nd8KB4KjlO5ew24JRXvcqkC02n6beB4SBkahlYY%3D&reserved=0<https://dist.apache.org/repos/dist/dev/hbase/2.6.3RC0/> > > > > > > Maven artifacts are available in a staging repository at: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachehbase-1578%2F&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862789372%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=d4397VUA3%2BbOSpaLTr%2FRU5mK1T4nTT1KT1GU1%2FXV%2FKs%3D&reserved=0<https://repository.apache.org/content/repositories/orgapachehbase-1578/> > > > > > > Maven artifacts for hadoop3 are available in a staging repository at: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachehbase-1579%2F&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862806027%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=gjXEumXGG1pihW9n9kWN4ZirVNOGxtHmSNjf1cFPz70%3D&reserved=0<https://repository.apache.org/content/repositories/orgapachehbase-1579/> > > > > >
Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
If possible, HBASE-29423 would also be very good to include. From: Wellington Chevreuil Sent: 27 June 2025 14:05 To: [email protected] Subject: Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available Thanks for the feedback Charles. I have rebased the HBASE-28596 PR to branch-2.6, we should be able to merge it today. Em qua., 25 de jun. de 2025 às 22:12, Charles Connell escreveu: > I vote -1 because I feel that HBASE-28596 should be included in 2.6.3. > There is an open PR to accomplish this: > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Fpull%2F6508&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862735276%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=cIbLv8OWbeBtU5crCA05O36ObsxzDJEOWV1g0T0%2B%2BUw%3D&reserved=0<https://github.com/apache/hbase/pull/6508>. > This will fix a performance > regression that was introduced in 2.6.0 by HBASE-27474. The regression > is described in HBASE-29012, but to summarize: logic was added so that > we don't cache blocks that exist within a reference or a link. This is > a significant issue. At Hubspot we had to apply the patch from the PR > to our fork in order to have acceptable performance. > > Charles > > On Sat, Jun 21, 2025 at 9:48 PM Duo Zhang wrote: > > > > Please vote on this Apache hbase release candidate, > > hbase-2.6.3RC0 > > > > The VOTE will remain open for at least 72 hours. > > > > [ ] +1 Release this package as Apache hbase 2.6.3 > > [ ] -1 Do not release this package because ... > > > > The tag to be voted on is 2.6.3RC0: > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fhbase%2Ftree%2F2.6.3RC0&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862760147%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=eLZHy9M%2F1MFJNuXNZ0fncX0sr7Z4IiEo9okLuAwmFis%3D&reserved=0<https://github.com/apache/hbase/tree/2.6.3RC0> > > > > This tag currently points to git reference > > > > bd91bafe4236c0a4dbba38a4cc735dfe9db67cd6 > > > > The release files, including signatures, digests, as well as CHANGES.md > > and RELEASENOTES.md included in this RC can be found at: > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fhbase%2F2.6.3RC0%2F&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862775386%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Pow9Nd8KB4KjlO5ew24JRXvcqkC02n6beB4SBkahlYY%3D&reserved=0<https://dist.apache.org/repos/dist/dev/hbase/2.6.3RC0/> > > > > Maven artifacts are available in a staging repository at: > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachehbase-1578%2F&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862789372%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=d4397VUA3%2BbOSpaLTr%2FRU5mK1T4nTT1KT1GU1%2FXV%2FKs%3D&reserved=0<https://repository.apache.org/content/repositories/orgapachehbase-1578/> > > > > Maven artifacts for hadoop3 are available in a staging repository at: > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachehbase-1579%2F&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862806027%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=gjXEumXGG1pihW9n9kWN4ZirVNOGxtHmSNjf1cFPz70%3D&reserved=0<https://repository.apache.org/content/repositories/orgapachehbase-1579/> > > > > Artifacts were signed with the 0x9AD2AE49 key which can be found in: > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownloads.apache.org%2Fhbase%2FKEYS&data=05%7C02%7Cdieterdp%40ngdata.com%7C36205256771e4b6211cf08ddb57342e4%7Cbe7affe0d1e145ca9c69fddf0939a55a%7C0%7C0%7C638866228862820668%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWU
Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
Thanks for the feedback Charles. I have rebased the HBASE-28596 PR to branch-2.6, we should be able to merge it today. Em qua., 25 de jun. de 2025 às 22:12, Charles Connell escreveu: > I vote -1 because I feel that HBASE-28596 should be included in 2.6.3. > There is an open PR to accomplish this: > https://github.com/apache/hbase/pull/6508. This will fix a performance > regression that was introduced in 2.6.0 by HBASE-27474. The regression > is described in HBASE-29012, but to summarize: logic was added so that > we don't cache blocks that exist within a reference or a link. This is > a significant issue. At Hubspot we had to apply the patch from the PR > to our fork in order to have acceptable performance. > > Charles > > On Sat, Jun 21, 2025 at 9:48 PM Duo Zhang wrote: > > > > Please vote on this Apache hbase release candidate, > > hbase-2.6.3RC0 > > > > The VOTE will remain open for at least 72 hours. > > > > [ ] +1 Release this package as Apache hbase 2.6.3 > > [ ] -1 Do not release this package because ... > > > > The tag to be voted on is 2.6.3RC0: > > > > https://github.com/apache/hbase/tree/2.6.3RC0 > > > > This tag currently points to git reference > > > > bd91bafe4236c0a4dbba38a4cc735dfe9db67cd6 > > > > The release files, including signatures, digests, as well as CHANGES.md > > and RELEASENOTES.md included in this RC can be found at: > > > > https://dist.apache.org/repos/dist/dev/hbase/2.6.3RC0/ > > > > Maven artifacts are available in a staging repository at: > > > > https://repository.apache.org/content/repositories/orgapachehbase-1578/ > > > > Maven artifacts for hadoop3 are available in a staging repository at: > > > > https://repository.apache.org/content/repositories/orgapachehbase-1579/ > > > > Artifacts were signed with the 0x9AD2AE49 key which can be found in: > > > > https://downloads.apache.org/hbase/KEYS > > > > To learn more about Apache hbase, please see > > > > http://hbase.apache.org/ > > > > Thanks, > > Your HBase Release Manager > >
Re: [VOTE] The first release candidate for Apache HBase 2.6.3 is available
I vote -1 because I feel that HBASE-28596 should be included in 2.6.3. There is an open PR to accomplish this: https://github.com/apache/hbase/pull/6508. This will fix a performance regression that was introduced in 2.6.0 by HBASE-27474. The regression is described in HBASE-29012, but to summarize: logic was added so that we don't cache blocks that exist within a reference or a link. This is a significant issue. At Hubspot we had to apply the patch from the PR to our fork in order to have acceptable performance. Charles On Sat, Jun 21, 2025 at 9:48 PM Duo Zhang wrote: > > Please vote on this Apache hbase release candidate, > hbase-2.6.3RC0 > > The VOTE will remain open for at least 72 hours. > > [ ] +1 Release this package as Apache hbase 2.6.3 > [ ] -1 Do not release this package because ... > > The tag to be voted on is 2.6.3RC0: > > https://github.com/apache/hbase/tree/2.6.3RC0 > > This tag currently points to git reference > > bd91bafe4236c0a4dbba38a4cc735dfe9db67cd6 > > The release files, including signatures, digests, as well as CHANGES.md > and RELEASENOTES.md included in this RC can be found at: > > https://dist.apache.org/repos/dist/dev/hbase/2.6.3RC0/ > > Maven artifacts are available in a staging repository at: > > https://repository.apache.org/content/repositories/orgapachehbase-1578/ > > Maven artifacts for hadoop3 are available in a staging repository at: > > https://repository.apache.org/content/repositories/orgapachehbase-1579/ > > Artifacts were signed with the 0x9AD2AE49 key which can be found in: > > https://downloads.apache.org/hbase/KEYS > > To learn more about Apache hbase, please see > > http://hbase.apache.org/ > > Thanks, > Your HBase Release Manager
