Re: Recent source incompatible change to Public interfaces AsyncBufferedMutator and AsyncBufferedMutatorBuilder

[Andrew Purtell]

Thanks Duo.

I also don't think this is a blocker for release.



On Thu, Jul 17, 2025 at 6:47 PM 张铎(Duo Zhang)  wrote:

> I think usually it is OK to add methods for interfaces which are not
> designed to be implemented by our users, like AsyncBufferedMutator and
> AsyncBufferedMutatorBuilder. The opposite is ScanResultConsumer, which
> is designed to be implemented by our users.
>
> So for me I do not think this is a blocker for a new patch release,
> but I suggest we add default implementation for these methods if
> possible.
>
> Thanks.
>
> Andrew Purtell  于2025年7月18日周五 01:28写道：
> >
> > I should have said rel/2.6.3, not 2.6.3RC2, sorry about that. It is a cut
> > and paste mistake.
> >
> > On Thu, Jul 17, 2025 at 10:24 AM Andrew Purtell 
> wrote:
> >
> > > A recent source incompatible change was committed affecting
> > > AsyncBufferedMutator and AsyncBufferedMutatorBuilder, both marked as
> Public
> > > interfaces.
> > >
> > > I see this is currently in 2.6.3RC2 and is in the RC for 2.5 I am
> > > considering.
> > >
> > > Does this present a problem? I am seeking the consensus opinion.
> > >
>


-- 
Best regards,
Andrew

Unrest, ignorance distilled, nihilistic imbeciles -
It's what we’ve earned
Welcome, apocalypse, what’s taken you so long?
Bring us the fitting end that we’ve been counting on
   - A23, Welcome, Apocalypse

Re: Recent source incompatible change to Public interfaces AsyncBufferedMutator and AsyncBufferedMutatorBuilder

[Duo Zhang]

I think usually it is OK to add methods for interfaces which are not
designed to be implemented by our users, like AsyncBufferedMutator and
AsyncBufferedMutatorBuilder. The opposite is ScanResultConsumer, which
is designed to be implemented by our users.

So for me I do not think this is a blocker for a new patch release,
but I suggest we add default implementation for these methods if
possible.

Thanks.

Andrew Purtell  于2025年7月18日周五 01:28写道：
>
> I should have said rel/2.6.3, not 2.6.3RC2, sorry about that. It is a cut
> and paste mistake.
>
> On Thu, Jul 17, 2025 at 10:24 AM Andrew Purtell  wrote:
>
> > A recent source incompatible change was committed affecting
> > AsyncBufferedMutator and AsyncBufferedMutatorBuilder, both marked as Public
> > interfaces.
> >
> > I see this is currently in 2.6.3RC2 and is in the RC for 2.5 I am
> > considering.
> >
> > Does this present a problem? I am seeking the consensus opinion.
> >

Re: Recent source incompatible change to Public interfaces AsyncBufferedMutator and AsyncBufferedMutatorBuilder

[Andrew Purtell]

I should have said rel/2.6.3, not 2.6.3RC2, sorry about that. It is a cut
and paste mistake.

On Thu, Jul 17, 2025 at 10:24 AM Andrew Purtell  wrote:

> A recent source incompatible change was committed affecting
> AsyncBufferedMutator and AsyncBufferedMutatorBuilder, both marked as Public
> interfaces.
>
> I see this is currently in 2.6.3RC2 and is in the RC for 2.5 I am
> considering.
>
> Does this present a problem? I am seeking the consensus opinion.
>