Re: Tags class using wrong length?

2017-08-07 Thread Chia-Ping Tsai
Sorry for the typo. I mean that "bytes[offset + TAG_LENGTH_SIZE]" is correct. BTW, the name of "upcoming HBase book" you mentioned is "HBase: The Definitive Guide"? On 2017-08-07 14:13, Lars George wrote: > Gotcha, sorry for the noise. I documented properly in the

Re: Tags class using wrong length?

2017-08-07 Thread Lars George
Gotcha, sorry for the noise. I documented properly in the upcoming HBase book. :) Sent from my iPhone > On 7. Aug 2017, at 07:02, ramkrishna vasudevan > wrote: > > I think the layout of tags is missing now in the javadoc. May be it got > missed or moved to

Re: Tags class using wrong length?

2017-08-06 Thread ramkrishna vasudevan
I think the layout of tags is missing now in the javadoc. May be it got missed or moved to some other place? I remember we had a layout explaining the tag structure then this code is much easier to read this code. As Chia-Ping said is the layout. So from the KeyValue lay out we extract the tag

Re: Tags class using wrong length?

2017-08-06 Thread Ted Yu
The byte following the tag length (a short) is the tag type. The current code is correct. On Sun, Aug 6, 2017 at 5:40 AM, Chia-Ping Tsai wrote: > According to the following code: > public ArrayBackedTag(byte tagType, byte[] tag) { > int tagLength = tag.length +

Re: Tags class using wrong length?

2017-08-06 Thread Lars George
You mean I am right and it should be the other constant being used? Sorry, just wanting to confirm. On Sun, Aug 6, 2017 at 2:40 PM, Chia-Ping Tsai wrote: > According to the following code: > public ArrayBackedTag(byte tagType, byte[] tag) { > int tagLength =

Re: Tags class using wrong length?

2017-08-06 Thread Chia-Ping Tsai
According to the following code: public ArrayBackedTag(byte tagType, byte[] tag) { int tagLength = tag.length + TYPE_LENGTH_SIZE; if (tagLength > MAX_TAG_LENGTH) { throw new IllegalArgumentException( "Invalid tag data being passed. Its length can not exceed " +

Tags class using wrong length?

2017-08-06 Thread Lars George
Hi, I found this reading through tags in 1.3, but checked in trunk as well. There is this code: public ArrayBackedTag(byte[] bytes, int offset, int length) { if (length > MAX_TAG_LENGTH) { throw new IllegalArgumentException( "Invalid tag data being passed. Its length can