Re: [HttpClient] enum for methods?

2018-07-12 Thread Oleg Kalnichevski
On Thu, 2018-07-12 at 09:35 -0600, Gary Gregory wrote: > On Wed, Jul 11, 2018 at 3:18 PM Oleg Kalnichevski > wrote: > > > On Wed, 2018-07-11 at 10:01 -0600, Gary Gregory wrote: > > > On Wed, Jul 11, 2018 at 8:55 AM Oleg Kalnichevski > > rg> > > > wrote: > > > > > > > On Wed, 2018-07-11 at

[jira] [Created] (HTTPCLIENT-1931) Add factory enum org.apache.hc.client5.http.classic.methods.ClassicHttpRequests

2018-07-12 Thread Gary Gregory (JIRA)
Gary Gregory created HTTPCLIENT-1931: Summary: Add factory enum org.apache.hc.client5.http.classic.methods.ClassicHttpRequests Key: HTTPCLIENT-1931 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1931

Re: [HttpClient] enum for methods?

2018-07-12 Thread Gary Gregory
On Thu, Jul 12, 2018 at 2:40 PM Oleg Kalnichevski wrote: > On Thu, 2018-07-12 at 09:35 -0600, Gary Gregory wrote: > > On Wed, Jul 11, 2018 at 3:18 PM Oleg Kalnichevski > > wrote: > > > > > On Wed, 2018-07-11 at 10:01 -0600, Gary Gregory wrote: > > > > On Wed, Jul 11, 2018 at 8:55 AM Oleg

[jira] [Closed] (HTTPCORE-537) org.apache.hc.core5.http.message.BasicHttpResponse.toString() prints its code twice and no protocol version.

2018-07-12 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed HTTPCORE-537. - Resolution: Fixed Assignee: Gary Gregory In git master. >

[GitHub] httpcomponents-core pull request #69: HTTPCORE-535

2018-07-12 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-core/pull/69 HTTPCORE-535 if workerCount is power of two , use &(workerCount -1 ) achieve mod workerCount funciton You can merge this pull request into a Git repository by running: $

[jira] [Commented] (HTTPCORE-535) mod workerCount is power of two can be improved as &(workerCount-1)

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542497#comment-16542497 ] ASF GitHub Bot commented on HTTPCORE-535: - GitHub user xiaohu-zhang opened a pull request:

[jira] [Updated] (HTTPCORE-535) mod workerCount is power of two can be improved as &(workerCount-1)

2018-07-12 Thread JIRA
[ https://issues.apache.org/jira/browse/HTTPCORE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julio A PĂ©rez Duarte updated HTTPCORE-535: -- Attachment: myportfolio-financial-planning-tool1.png > mod workerCount is

[jira] [Resolved] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

2018-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-1928. --- Resolution: Fixed Fix Version/s: 5.0 Beta2 > HttpAsyncClient

[jira] [Commented] (HTTPCORE-535) mod workerCount is power of two can be improved as &(workerCount-1)

2018-07-12 Thread silver9886 (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541317#comment-16541317 ] silver9886 commented on HTTPCORE-535: - of course & is faster than %. > mod workerCount is power of

[jira] [Commented] (HTTPCORE-535) mod workerCount is power of two can be improved as &(workerCount-1)

2018-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541313#comment-16541313 ] Oleg Kalnichevski commented on HTTPCORE-535: What would be the benefits of doing so? Oleg

[jira] [Commented] (HTTPCORE-535) mod workerCount is power of two can be improved as &(workerCount-1)

2018-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541320#comment-16541320 ] Oleg Kalnichevski commented on HTTPCORE-535: Fair enough. Please raise a PR. Oleg > mod

[jira] [Commented] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541306#comment-16541306 ] ASF GitHub Bot commented on HTTPCLIENT-1928: Github user ok2c commented on the issue:

[jira] [Commented] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

2018-07-12 Thread silver9886 (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541323#comment-16541323 ] silver9886 commented on HTTPCLIENT-1928: why delete AbstractMinimalHttpAsyncClientBase.java

[jira] [Commented] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

2018-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541332#comment-16541332 ] Oleg Kalnichevski commented on HTTPCLIENT-1928: --- I think this is wrong to catch and

[jira] [Commented] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

2018-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541305#comment-16541305 ] ASF subversion and git services commented on HTTPCLIENT-1928: - Commit

[GitHub] httpcomponents-client issue #106: HTTPCLIENT-1928

2018-07-12 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-client/pull/106 Committed with some changes as 0c0e9c7b7cd9261e8155beac13446b526df36d6b. Please review and close. --- - To

Re: [HttpCore5] GracefullyCloseable: Not the best method or interface name

2018-07-12 Thread Oleg Kalnichevski
Gary, How about that? https://github.com/ok2c/httpcore/commit/b922161b9776672c89bd8df2ce0757de143a15e4 https://github.com/ok2c/httpcore/commit/fff078122075d5ab6249e247b5b71e23422be768 Oleg On Wed, 2018-07-11 at 23:16 +0200, Oleg Kalnichevski wrote: > On Wed, 2018-07-11 at 09:57 -0600, Gary

[jira] [Updated] (HTTPASYNC-139) CloseableHttpAsyncClient not working when a http/https proxy is provided

2018-07-12 Thread Neha Sharma (JIRA)
[ https://issues.apache.org/jira/browse/HTTPASYNC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Sharma updated HTTPASYNC-139: -- Attachment: AsyncClientCustomSSL.java > CloseableHttpAsyncClient not working when a

[jira] [Resolved] (HTTPASYNC-139) CloseableHttpAsyncClient not working when a http/https proxy is provided

2018-07-12 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPASYNC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPASYNC-139. - Resolution: Not A Problem HttpClient of all versions supports plain tunnel

[jira] [Created] (HTTPASYNC-139) CloseableHttpAsyncClient not working when a http/https proxy is provided

2018-07-12 Thread Neha Sharma (JIRA)
Neha Sharma created HTTPASYNC-139: - Summary: CloseableHttpAsyncClient not working when a http/https proxy is provided Key: HTTPASYNC-139 URL: https://issues.apache.org/jira/browse/HTTPASYNC-139

[GitHub] httpcomponents-core issue #67: HTTPCORE-484 use TimeWheel algorithm to deal ...

2018-07-12 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-core/pull/67 @xiaohu-zhang I have spent more time looking at the proposed change-set. 1. Do I understand it correctly that with this patch all `IOEventHandler#timeout` events will be executed by a

[jira] [Commented] (HTTPCORE-484) check timeout could use TimeWheel algorithm

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541704#comment-16541704 ] ASF GitHub Bot commented on HTTPCORE-484: - Github user ok2c commented on the issue:

[GitHub] httpcomponents-core issue #67: HTTPCORE-484 use TimeWheel algorithm to deal ...

2018-07-12 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/httpcomponents-core/pull/67 It would be great to show a small program that demonstrates the performance difference. Maybe something that can be run before and after the patch is applied. ---

[GitHub] httpcomponents-client pull request #106: HTTPCLIENT-1928

2018-07-12 Thread xiaohu-zhang
Github user xiaohu-zhang closed the pull request at: https://github.com/apache/httpcomponents-client/pull/106 --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail:

[jira] [Commented] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541434#comment-16541434 ] ASF GitHub Bot commented on HTTPCLIENT-1928: Github user xiaohu-zhang closed the pull

[GitHub] httpcomponents-client issue #106: HTTPCLIENT-1928

2018-07-12 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-client/pull/106 thank you --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail:

[jira] [Commented] (HTTPCLIENT-1928) HttpAsyncClient callback should ignore exception throwed by compelete method

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541433#comment-16541433 ] ASF GitHub Bot commented on HTTPCLIENT-1928: Github user xiaohu-zhang commented on the

[jira] [Commented] (HTTPCORE-484) check timeout could use TimeWheel algorithm

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541719#comment-16541719 ] ASF GitHub Bot commented on HTTPCORE-484: - Github user garydgregory commented on the issue:

Re: [HttpCore5] GracefullyCloseable: Not the best method or interface name

2018-07-12 Thread Gary Gregory
On Thu, Jul 12, 2018 at 3:09 AM Oleg Kalnichevski wrote: > Gary, > > How about that? > > > https://github.com/ok2c/httpcore/commit/b922161b9776672c89bd8df2ce0757de143a15e4 > > https://github.com/ok2c/httpcore/commit/fff078122075d5ab6249e247b5b71e23422be768 +1 :-) Much better IMO. Gary > > >

Re: [HttpClient] enum for methods?

2018-07-12 Thread Gary Gregory
On Wed, Jul 11, 2018 at 3:18 PM Oleg Kalnichevski wrote: > On Wed, 2018-07-11 at 10:01 -0600, Gary Gregory wrote: > > On Wed, Jul 11, 2018 at 8:55 AM Oleg Kalnichevski > > wrote: > > > > > On Wed, 2018-07-11 at 08:40 -0600, Gary Gregory wrote: > > > > Hi All, > > > > > > > > In my apps, I

Re: [HttpClient] enum for methods?

2018-07-12 Thread Julian Reschke
On 2018-07-11 16:55, Oleg Kalnichevski wrote: On Wed, 2018-07-11 at 08:40 -0600, Gary Gregory wrote: Hi All, In my apps, I usually have this enum, handy for parameterizing things like tests. There is already one called StandardMethods. Would that be enough? Oleg Methods are an extension

[jira] [Updated] (HTTPCORE-537) org.apache.hc.core5.http.message.BasicHttpResponse.toString() prints its code twice and no protocol version.

2018-07-12 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated HTTPCORE-537: -- Description: org.apache.hc.core5.http.message.BasicHttpResponse.toString() prints its code

[jira] [Commented] (HTTPCORE-537) org.apache.hc.core5.http.message.BasicHttpResponse.toString() prints its code twice and no protocol version.

2018-07-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541895#comment-16541895 ] ASF subversion and git services commented on HTTPCORE-537: -- Commit

[jira] [Created] (HTTPCORE-537) org.apache.hc.core5.http.message.BasicHttpResponse.toString() prints its code twice and no protocol version.

2018-07-12 Thread Gary Gregory (JIRA)
Gary Gregory created HTTPCORE-537: - Summary: org.apache.hc.core5.http.message.BasicHttpResponse.toString() prints its code twice and no protocol version. Key: HTTPCORE-537 URL: