[GitHub] [httpcomponents-core] ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.
ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615873724 @ufolr Cool! Many thanks for contributing the fix! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.
ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615801608 @ufolr I am sorry but this is too much so that "sub noodle could be a noodle". Let's just fix the bug and let the rest stay the same. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.
ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615451584 @ufolr While "sub noodle is a noodle" is conceptually nice, it does cause an unnecessary array allocation and an array copy, which is a very expensive operation. It completely defeats the purpose of having efficient access to a sub sequence of characters contained in the buffer. Could we fix the bug without causing unnecessary buffer allocation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex, endIndex) to return right result.
ok2c commented on issue #195: Fix CharArrayBuffer.subSequence(beganIndex,endIndex) to return right result. URL: https://github.com/apache/httpcomponents-core/pull/195#issuecomment-615394424 > CharArrayBuffer's sub-sequence should return the result as same class of CharArrayBuffer. But' the old implementation use CharBuffer.wrap to make a result which instance of HeapCharBuffer. @ufolr Where is this requirement stated anywhere? I could not find any evidence of such requirement in `CharSequence` javadocs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
