[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517554#comment-17517554 ] Anthony Baldocchi commented on HTTPCLIENT-2080: --- Since a change was made for this, would it make sense to update the Resolution, Fix version, and Components? > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514743#comment-17514743 ] ASF subversion and git services commented on HTTPCLIENT-2080: - Commit 94017237b2046574267f46bf6f441bc560378b58 in httpcomponents-client's branch refs/heads/master from Anthony Baldocchi [ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=9401723 ] HTTPCLIENT-2080: add getRetryInterval to HttpRequestRetryStrategy for use on retriable IOExceptions (#356) > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104703#comment-17104703
]
Michael Osipov commented on HTTPCLIENT-2080:
[~olegk], it could be also a network issue on the client side. Nothing fancy.
[~hw873], do yo want to work out a PR for this? I think we could add this via
{{ExtendedRedirectStrategy}} with a new method where the interface is instantly
marked for removal in the next major version or even maybe with a Java 8
interface default method.
> HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
> --
>
> Key: HTTPCLIENT-2080
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
>Affects Versions: 5.0
>Reporter: Hendra
>Priority: Major
>
> In httpclient5, HttpRequestRetryStrategy has introduced a new feature
> retryInterval which determines the interval between subsequent retries. In
> case there are IOExceptions occur, the retry happens but without any delays.
>
> There might be some bugs in HttpRequestRetryExec.class implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104306#comment-17104306 ] Oleg Kalnichevski commented on HTTPCLIENT-2080: --- [~hw873] What makes you think that just pausing for extra seconds would somehow make the problem go away? The main reason for retrying i/o errors is to redirect the request to another live node in a cluster , in which case pausing the request re-execution makes no sense. If the server is unable to process the request due to excessive load it should respond with 503, not just drop the connection. [~michael-o] It is up to you to decide if you want to add support for a delay interval in case of I/O errors. I would just close this ticket as `not-an-issue`. Oleg > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104305#comment-17104305
]
Michael Osipov commented on HTTPCLIENT-2080:
We we could do is to introduce an extended interface to {{RedirectStrategy}}
which handles this case. The default {{RedirectExec}} will be aware of, custom
ones at ther discretion.
> HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
> --
>
> Key: HTTPCLIENT-2080
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
>Affects Versions: 5.0
>Reporter: Hendra
>Priority: Major
>
> In httpclient5, HttpRequestRetryStrategy has introduced a new feature
> retryInterval which determines the interval between subsequent retries. In
> case there are IOExceptions occur, the retry happens but without any delays.
>
> There might be some bugs in HttpRequestRetryExec.class implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104037#comment-17104037 ] Hendra commented on HTTPCLIENT-2080: [~olegk] If the client calls a service, there can be different reasons on why the service doesn't give a response. It can cause by the network, the service is down etc. We might also get Socket Exception when the remote connection is unexpectedly and forcefully closed due to various reasons like application crash, etc. The client might want to do retry for this request. > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102657#comment-17102657 ] Oleg Kalnichevski commented on HTTPCLIENT-2080: --- > If you look at code inside the execute method, there is a for loop in it. It > catches the IOExceptions and calls retryStrategy.retryRequest(request, ex, > execCount, context) method to check whether the request is eligible for > retry. There are no delays in between the retry. [~hw873] Should there be? Why exactly? Oleg > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102513#comment-17102513 ] Hendra commented on HTTPCLIENT-2080: [~michael-o] I just found out the bug recently. We decided to upgrade to httpclient 5 after we look at the API but we caught the bug while doing testing. > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102509#comment-17102509 ] Michael Osipov commented on HTTPCLIENT-2080: [~hw873], why didn't you come up with that *before* GA? > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102446#comment-17102446 ] Hendra commented on HTTPCLIENT-2080: [~olegk] As I mentioned, if there are IOExceptions occur, there are no delays in the retry. If you look at code inside the execute method, there is a for loop in it. It catches the IOExceptions and calls retryStrategy.retryRequest(request, ex, execCount, context) method to check whether the request is eligible for retry. There are no delays in between the retry. > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102408#comment-17102408 ] Oleg Kalnichevski commented on HTTPCLIENT-2080: --- > There might be some bugs in HttpRequestRetryExec.class implementation. [~hw873] What bugs are you specifically referring to? Oleg > HttpRequestRetryStrategy doesn't delay the retry if IOException occurs > -- > > Key: HTTPCLIENT-2080 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) >Affects Versions: 5.0 >Reporter: Hendra >Priority: Major > > In httpclient5, HttpRequestRetryStrategy has introduced a new feature > retryInterval which determines the interval between subsequent retries. In > case there are IOExceptions occur, the retry happens but without any delays. > > There might be some bugs in HttpRequestRetryExec.class implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
[jira] [Commented] (HTTPCLIENT-2080) HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102394#comment-17102394
]
Michael Osipov commented on HTTPCLIENT-2080:
So you miss:
{code}
@Override
public TimeValue getRetryRequest(
final HttpRequest request,
final IOException exception,
final int execCount,
final HttpContext context);
{code}
> HttpRequestRetryStrategy doesn't delay the retry if IOException occurs
> --
>
> Key: HTTPCLIENT-2080
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2080
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
>Affects Versions: 5.0
>Reporter: Hendra
>Priority: Major
>
> In httpclient5, HttpRequestRetryStrategy has introduced a new feature
> retryInterval which determines the interval between subsequent retries. In
> case there are IOExceptions occur, the retry happens but without any delays.
>
> There might be some bugs in HttpRequestRetryExec.class implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
