[jira] Commented: (HTTPCLIENT-711) bad route computed for redirected requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551814 ] Oleg Kalnichevski commented on HTTPCLIENT-711: -- OK. I think I got it Oleg > bad route computed for redirected requests > -- > > Key: HTTPCLIENT-711 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-711 > Project: HttpComponents HttpClient > Issue Type: Bug >Affects Versions: 4.0 Alpha 2 >Reporter: Oleg Kalnichevski >Priority: Critical > Fix For: 4.0 Alpha 3 > > > BasicRouteDirector appears to miscalculate complex routes. Example to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (HTTPCLIENT-711) bad route computed for redirected requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551812 ] Roland Weber commented on HTTPCLIENT-711: - Hi Oleg, the idea is to have all route computations done in the route planner. If a specific proxy or local address is needed, then the route planner should know about it, not the application. A specific route planner can get proxy and local address data from context (default or request specific), from parameters (default or request specific), as constructor arguments, or from any other place like system properties. I consider the case where the route is computed by the application rather than in the route planner as rare. Usually, applications should be able to encapsulate routing logic into a route planner, either the default one or a custom one. For the rare case that individual requests must be route by the application explicitly, I was planning to extend the default route planner with an additional request property or context attribute, see HTTPCLIENT-716. cheers, Roland > bad route computed for redirected requests > -- > > Key: HTTPCLIENT-711 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-711 > Project: HttpComponents HttpClient > Issue Type: Bug >Affects Versions: 4.0 Alpha 2 >Reporter: Oleg Kalnichevski >Priority: Critical > Fix For: 4.0 Alpha 3 > > > BasicRouteDirector appears to miscalculate complex routes. Example to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (HTTPCLIENT-711) bad route computed for redirected requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551799 ] Oleg Kalnichevski commented on HTTPCLIENT-711: -- Roland, Now I am completely lost. I just noticed you had eliminated #execute method from HttpClient interface that takes HttpRoute as a parameter. I thought you wanted to do away with RoutedRequest, not HttpRoute. What is your plan about passing custom localAddress and proxy host? Oleg > bad route computed for redirected requests > -- > > Key: HTTPCLIENT-711 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-711 > Project: HttpComponents HttpClient > Issue Type: Bug >Affects Versions: 4.0 Alpha 2 >Reporter: Oleg Kalnichevski >Priority: Critical > Fix For: 4.0 Alpha 3 > > > BasicRouteDirector appears to miscalculate complex routes. Example to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (HTTPCLIENT-711) bad route computed for redirected requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551796 ] Roland Weber commented on HTTPCLIENT-711: - Hi Oleg, the context is request specific, and so are the request parameters. Is it really necessary to move this stuff into the interface? I don't mind a DHRP that interprets more context or parameters, but I would rather not have this stuff as method arguments. cheers, Roland > bad route computed for redirected requests > -- > > Key: HTTPCLIENT-711 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-711 > Project: HttpComponents HttpClient > Issue Type: Bug >Affects Versions: 4.0 Alpha 2 >Reporter: Oleg Kalnichevski >Priority: Critical > Fix For: 4.0 Alpha 3 > > > BasicRouteDirector appears to miscalculate complex routes. Example to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (HTTPCLIENT-711) bad route computed for redirected requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551794 ] Oleg Kalnichevski commented on HTTPCLIENT-711: -- The HttpRoutePlanner interface and its default impl in their current form are two restrictive. DefaultHttpRoutePlanner always uses null for localAddress and the default proxy as set in the context. This is no way to pass a different proxy host or a local address. Do you mind my doing some changes to the HttpRoutePlanner interface? Oleg > bad route computed for redirected requests > -- > > Key: HTTPCLIENT-711 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-711 > Project: HttpComponents HttpClient > Issue Type: Bug >Affects Versions: 4.0 Alpha 2 >Reporter: Oleg Kalnichevski >Priority: Critical > Fix For: 4.0 Alpha 3 > > > BasicRouteDirector appears to miscalculate complex routes. Example to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (HTTPCLIENT-711) bad route computed for redirected requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551735 ] Oleg Kalnichevski commented on HTTPCLIENT-711: -- I can take it over from here Oleg > bad route computed for redirected requests > -- > > Key: HTTPCLIENT-711 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-711 > Project: HttpComponents HttpClient > Issue Type: Bug >Affects Versions: 4.0 Alpha 2 >Reporter: Oleg Kalnichevski >Priority: Critical > Fix For: 4.0 Alpha 3 > > > BasicRouteDirector appears to miscalculate complex routes. Example to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (HTTPCLIENT-711) bad route computed for redirected requests
[ https://issues.apache.org/jira/browse/HTTPCLIENT-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551579 ] Roland Weber commented on HTTPCLIENT-711: - Hi Oleg, I haven't fixed the route computation for redirected requests, but I've completed all preliminary steps. Maybe you can take it from here... it's getting late for me. cheers, Roland > bad route computed for redirected requests > -- > > Key: HTTPCLIENT-711 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-711 > Project: HttpComponents HttpClient > Issue Type: Bug >Affects Versions: 4.0 Alpha 2 >Reporter: Oleg Kalnichevski >Priority: Critical > Fix For: 4.0 Alpha 3 > > > BasicRouteDirector appears to miscalculate complex routes. Example to follow. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
