Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]
rschmitt merged PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]
rschmitt commented on code in PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542#discussion_r2260863147 ## httpcore5/src/main/java/org/apache/hc/core5/io/SocketSupport.java: ## @@ -36,8 +36,11 @@ /** * @since 5.3 + * + * @deprecated No longer necessary, due to the backport of all supported ExtendedSocketOptions to Java 8 */ @Internal +@Deprecated Review Comment: What's more, I don't think we've ever released a version of httpclient that depended on this class, so this is the perfect time to delete this class! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]
ok2c commented on code in PR #542:
URL:
https://github.com/apache/httpcomponents-core/pull/542#discussion_r2259386248
##
httpcore5/src/test/java/org/apache/hc/core5/io/TestSocketSupport.java:
##
@@ -38,6 +38,7 @@
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
+@SuppressWarnings("deprecation")
Review Comment:
@rschmitt Same. This test can be dropped now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] Discontinue use of SocketSupport to set extended socket options [httpcomponents-core]
ok2c commented on code in PR #542: URL: https://github.com/apache/httpcomponents-core/pull/542#discussion_r2259384299 ## httpcore5/src/main/java/org/apache/hc/core5/io/SocketSupport.java: ## @@ -36,8 +36,11 @@ /** * @since 5.3 + * + * @deprecated No longer necessary, due to the backport of all supported ExtendedSocketOptions to Java 8 */ @Internal +@Deprecated Review Comment: @rschmitt This class is internal and can just be dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
