Re: [PR] HTTPCLIENT-1482: expect-continue only on reused connections [httpcomponents-client]

2025-07-24 Thread via GitHub


arturobernalg merged PR #683:
URL: https://github.com/apache/httpcomponents-client/pull/683


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] HTTPCLIENT-1482: expect-continue only on reused connections [httpcomponents-client]

2025-07-20 Thread via GitHub


ok2c commented on PR #683:
URL: 
https://github.com/apache/httpcomponents-client/pull/683#issuecomment-3095451233

   @arturobernalg Looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] HTTPCLIENT-1482: expect-continue only on reused connections [httpcomponents-client]

2025-07-20 Thread via GitHub


arturobernalg commented on PR #683:
URL: 
https://github.com/apache/httpcomponents-client/pull/683#issuecomment-3094651610

   > `TestRequestExpectContinue`
   
   @ok2c my bad. I should have added tests  Please take a look 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] HTTPCLIENT-1482: expect-continue only on reused connections [httpcomponents-client]

2025-07-20 Thread via GitHub


ok2c commented on PR #683:
URL: 
https://github.com/apache/httpcomponents-client/pull/683#issuecomment-3094616571

   @arturobernalg It would be good to add tests to `TestRequestExpectContinue` 
for the new config options.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]