Re: [PR] HTTPCORE-770: Add plusAsBlank parameter to URIBuilder for dynamic configuration [httpcomponents-core]
ok2c commented on PR #481: URL: https://github.com/apache/httpcomponents-core/pull/481#issuecomment-3112941677 > Any idea when this will be released? @jeremystucki In August for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HTTPCORE-770: Add plusAsBlank parameter to URIBuilder for dynamic configuration [httpcomponents-core]
jeremystucki commented on PR #481: URL: https://github.com/apache/httpcomponents-core/pull/481#issuecomment-3108113614 Any idea when this will be released? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HTTPCORE-770: Add plusAsBlank parameter to URIBuilder for dynamic configuration [httpcomponents-core]
ok2c merged PR #481: URL: https://github.com/apache/httpcomponents-core/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HTTPCORE-770: Add plusAsBlank parameter to URIBuilder for dynamic configuration [httpcomponents-core]
ok2c commented on PR #481: URL: https://github.com/apache/httpcomponents-core/pull/481#issuecomment-2351464454 > Now, on second thought, it may be incorrect to allow users to change the plusAsBlank value. I'm not sure anymore. @arturobernalg This behavior is non-conformant but it is wide-spread and very common. This is a case where we ought to be lenient. 1. There is no need to have a special constructor for this flag. Just a setter should suffice. 2. Please add `@since 5.4` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HTTPCORE-770: Add plusAsBlank parameter to URIBuilder for dynamic configuration [httpcomponents-core]
arturobernalg commented on PR #481: URL: https://github.com/apache/httpcomponents-core/pull/481#issuecomment-2350914987 > I'm not sure about creating a special case for a single character. Maybe registering a Map would be more flexible. I'm not sure what should be allowed to be mapped though. HI @garydgregory As far as I understand, according to [RFC3986](https://datatracker.ietf.org/doc/html/rfc3986), spaces in URIs should be encoded as %20, and the + character is not treated as a space. Introducing a map would add unnecessary complexity since only + is treated this way in form encoding. Now, on second thought, it may be incorrect to allow users to change the plusAsBlank value. I'm not sure anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HTTPCORE-770: Add plusAsBlank parameter to URIBuilder for dynamic configuration [httpcomponents-core]
garydgregory commented on PR #481: URL: https://github.com/apache/httpcomponents-core/pull/481#issuecomment-2350185491 I'm not sure about creating a special case for a single character. Maybe registering a Map would be more flexible. I'm not sure what should be allowed to be mapped though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
