Re: Log misleading for User-Agent

2012-11-19 Thread Gary Gregory
Hi Oleg and All: I've added in core: org.apache.http.util.VersionInfo.setUserAgent(HttpParams, String, String, Class?) but it is not quite right yet: The code needs adjusting to account for the deprecated types in 4.3 {@link HttpParams} and {@link HttpProtocolParams}. How can this be

Re: Log misleading for User-Agent

2012-11-18 Thread Gary Gregory
On Sat, Nov 17, 2012 at 4:54 PM, Oleg Kalnichevski ol...@apache.org wrote: On Sat, 2012-11-17 at 12:49 -0500, Gary Gregory wrote: On Sat, Nov 17, 2012 at 10:25 AM, Oleg Kalnichevski ol...@apache.org wrote: On Fri, 2012-11-16 at 21:19 -0500, Gary Gregory wrote: As a tangent I want to

Re: Log misleading for User-Agent

2012-11-18 Thread Oleg Kalnichevski
On Sun, 2012-11-18 at 10:35 -0500, Gary Gregory wrote: ... I was just thinking that the client was the right place given the snippet in question clearly had HttpClient specific bits. Anyway, feel free to put that code in a place you deem most appropriate. There is now o.a.h.config

Re: Log misleading for User-Agent

2012-11-18 Thread Gary Gregory
On Nov 18, 2012, at 14:31, Oleg Kalnichevski ol...@apache.org wrote: On Sun, 2012-11-18 at 10:35 -0500, Gary Gregory wrote: ... I was just thinking that the client was the right place given the snippet in question clearly had HttpClient specific bits. Anyway, feel free to put that code

Re: Log misleading for User-Agent

2012-11-17 Thread Oleg Kalnichevski
On Fri, 2012-11-16 at 21:19 -0500, Gary Gregory wrote: As a tangent I want to reduce this code pattern which is duplicated no less than six times: // determine the release version from packaged version info final VersionInfo vi = VersionInfo.loadVersionInfo

Re: Log misleading for User-Agent

2012-11-17 Thread Gary Gregory
On Sat, Nov 17, 2012 at 10:25 AM, Oleg Kalnichevski ol...@apache.orgwrote: On Fri, 2012-11-16 at 21:19 -0500, Gary Gregory wrote: As a tangent I want to reduce this code pattern which is duplicated no less than six times: // determine the release version from packaged version

Re: Log misleading for User-Agent

2012-11-17 Thread Oleg Kalnichevski
On Sat, 2012-11-17 at 12:49 -0500, Gary Gregory wrote: On Sat, Nov 17, 2012 at 10:25 AM, Oleg Kalnichevski ol...@apache.orgwrote: On Fri, 2012-11-16 at 21:19 -0500, Gary Gregory wrote: As a tangent I want to reduce this code pattern which is duplicated no less than six times:

Re: Log misleading for User-Agent

2012-11-16 Thread Jon Moore
Yes, I'd be in favor of either one of these changes (removing or reporting dynamically the right version). I'd probably lean towards removing it if pressed to express an opinion. As I recall (although I don't have the code in front of me), the CachingHttpClient sends a slightly different

Re: Log misleading for User-Agent

2012-11-16 Thread Oleg Kalnichevski
On Fri, 2012-11-16 at 06:38 -0500, Jon Moore wrote: Yes, I'd be in favor of either one of these changes (removing or reporting dynamically the right version). I'd probably lean towards removing it if pressed to express an opinion. As I recall (although I don't have the code in front of me),

Re: Log misleading for User-Agent

2012-11-16 Thread sebb
On 16 November 2012 15:55, Oleg Kalnichevski ol...@apache.org wrote: On Fri, 2012-11-16 at 06:38 -0500, Jon Moore wrote: Yes, I'd be in favor of either one of these changes (removing or reporting dynamically the right version). I'd probably lean towards removing it if pressed to express an

Re: Log misleading for User-Agent

2012-11-16 Thread Oleg Kalnichevski
On Fri, 2012-11-16 at 17:33 +, sebb wrote: On 16 November 2012 15:55, Oleg Kalnichevski ol...@apache.org wrote: On Fri, 2012-11-16 at 06:38 -0500, Jon Moore wrote: Yes, I'd be in favor of either one of these changes (removing or reporting dynamically the right version). I'd probably

Re: Log misleading for User-Agent

2012-11-16 Thread Jon Moore
On Fri, Nov 16, 2012 at 8:42 PM, Gary Gregory garydgreg...@gmail.com wrote: 1) do nothing 2) User-Agent: Apache-HttpClient/4.2.1 (Java 1.5+ min) 3) User-Agent: Apache-HttpClient/4.2.1 (Java/1.6.0_35) 3 is in the spirit of the JRE's HttpURLConnection FWIW. If you're collecting votes, I'd vote

Re: Log misleading for User-Agent

2012-11-16 Thread Gary Gregory
As a tangent I want to reduce this code pattern which is duplicated no less than six times: // determine the release version from packaged version info final VersionInfo vi = VersionInfo.loadVersionInfo (org.apache.http.client,