[GitHub] helix pull request: [HELIX-524] Add a getProgress to the Task inte...

2014-10-02 Thread kanakb
Github user kanakb commented on the pull request: https://github.com/apache/helix/pull/6#issuecomment-57588016 I like this in general, but I have a couple questions/comments: * This is an interface change. Is there a way we can provide this functionality without requiring

[jira] [Commented] (HELIX-524) add getProgress() to Task interface

2014-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156118#comment-14156118 ] ASF GitHub Bot commented on HELIX-524: -- Github user kanakb commented on the pull

[GitHub] helix pull request: [HELIX-524] Add a getProgress to the Task inte...

2014-10-02 Thread brandtg
Github user brandtg commented on the pull request: https://github.com/apache/helix/pull/6#issuecomment-57596146 For persistence story, what about putting a new health report: `/STAND_ALONE/INSTANCES/{instanceName}/HEALTHREPORT/taskStatus`? Another thing to consider is that

[jira] [Commented] (HELIX-524) add getProgress() to Task interface

2014-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156204#comment-14156204 ] ASF GitHub Bot commented on HELIX-524: -- Github user brandtg commented on the pull

[jira] [Commented] (HELIX-524) add getProgress() to Task interface

2014-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156218#comment-14156218 ] ASF GitHub Bot commented on HELIX-524: -- Github user brandtg commented on the pull

Review Request 26272: [HELIX-518] Add integration tests to ensure helix tasks work as expected during master failover

2014-10-02 Thread Zhen Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26272/ --- Review request for helix, Kanak Biscuitwala and Shi Lu. Bugs: 518

Re: Review Request 26272: [HELIX-518] Add integration tests to ensure helix tasks work as expected during master failover

2014-10-02 Thread Shi Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26272/#review55248 --- Ship it! Ship It! - Shi Lu On Oct. 2, 2014, 5:30 p.m., Zhen

[jira] [Commented] (HELIX-524) add getProgress() to Task interface

2014-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157419#comment-14157419 ] ASF GitHub Bot commented on HELIX-524: -- Github user dayzzz commented on the pull

[GitHub] helix pull request: [HELIX-524] Add a getProgress to the Task inte...

2014-10-02 Thread kanakb
Github user kanakb commented on the pull request: https://github.com/apache/helix/pull/6#issuecomment-57730714 Why not have an abstract ProgressReportingTask that implements task and includes all the JMX persistence, and then have tasks extends from that and implement getProgress()?

[jira] [Commented] (HELIX-524) add getProgress() to Task interface

2014-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157483#comment-14157483 ] ASF GitHub Bot commented on HELIX-524: -- Github user kanakb commented on the pull