Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/6#issuecomment-57588016
I like this in general, but I have a couple questions/comments:
* This is an interface change. Is there a way we can provide this
functionality without requiring
[
https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156118#comment-14156118
]
ASF GitHub Bot commented on HELIX-524:
--
Github user kanakb commented on the pull
Github user brandtg commented on the pull request:
https://github.com/apache/helix/pull/6#issuecomment-57596146
For persistence story, what about putting a new health report:
`/STAND_ALONE/INSTANCES/{instanceName}/HEALTHREPORT/taskStatus`?
Another thing to consider is that
[
https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156204#comment-14156204
]
ASF GitHub Bot commented on HELIX-524:
--
Github user brandtg commented on the pull
[
https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156218#comment-14156218
]
ASF GitHub Bot commented on HELIX-524:
--
Github user brandtg commented on the pull
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26272/
---
Review request for helix, Kanak Biscuitwala and Shi Lu.
Bugs: 518
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26272/#review55248
---
Ship it!
Ship It!
- Shi Lu
On Oct. 2, 2014, 5:30 p.m., Zhen
[
https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157419#comment-14157419
]
ASF GitHub Bot commented on HELIX-524:
--
Github user dayzzz commented on the pull
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/6#issuecomment-57730714
Why not have an abstract ProgressReportingTask that implements task and
includes all the JMX persistence, and then have tasks extends from that and
implement getProgress()?
[
https://issues.apache.org/jira/browse/HELIX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157483#comment-14157483
]
ASF GitHub Bot commented on HELIX-524:
--
Github user kanakb commented on the pull
10 matches
Mail list logo