[GitHub] helix pull request: [HELIX-592] addCluster should respect overwrit...

2015-05-11 Thread lei-xia
GitHub user lei-xia opened a pull request: https://github.com/apache/helix/pull/27 [HELIX-592] addCluster should respect overwriteExisitng when adding stateModel Definations. Congrui Ji has sent this fix before, and got some comments. But he is on vacation, and we (LinkedIn) do

[jira] [Commented] (HELIX-592) addCluster should respect overwriteExisitng when adding stateModelDefinations

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538450#comment-14538450 ] ASF GitHub Bot commented on HELIX-592: -- GitHub user lei-xia opened a pull request:

[GitHub] helix pull request: [HELIX-592] addCluster should respect overwrit...

2015-05-11 Thread kanakb
Github user kanakb commented on a diff in the pull request: https://github.com/apache/helix/pull/27#discussion_r30104417 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java --- @@ -715,14 +715,26 @@ public ExternalView getResourceExternalView(String

[GitHub] helix pull request: [HELIX-592] addCluster should respect overwrit...

2015-05-11 Thread kanakb
Github user kanakb commented on a diff in the pull request: https://github.com/apache/helix/pull/27#discussion_r30104425 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java --- @@ -715,14 +715,26 @@ public ExternalView getResourceExternalView(String

[jira] [Commented] (HELIX-592) addCluster should respect overwriteExisitng when adding stateModelDefinations

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539227#comment-14539227 ] ASF GitHub Bot commented on HELIX-592: -- Github user kanakb commented on a diff in the

[jira] [Commented] (HELIX-592) addCluster should respect overwriteExisitng when adding stateModelDefinations

2015-05-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HELIX-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539230#comment-14539230 ] ASF GitHub Bot commented on HELIX-592: -- Github user kanakb commented on a diff in the