[GitHub] helix pull request #138: CallbackHandler to use either java config property ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/helix/pull/138


---

[GitHub] helix pull request #138: CallbackHandler to use either java config property ...

[kishoreg]

Github user kishoreg commented on a diff in the pull request:

https://github.com/apache/helix/pull/138#discussion_r171987248
  
--- Diff: 
helix-core/src/test/java/org/apache/helix/TestListenerCallbackBatchMode.java ---
@@ -122,21 +131,45 @@ public void testNonBatchedListener() throws Exception 
{
 
 final Listener listener = new Listener();
 addListeners(listener);
+updateConfigs();
+verifyNonbatchedListeners(listener);
+removeListeners(listener);
 
+System.out.println("END " + methodName + " at " + new 
Date(System.currentTimeMillis()));
--- End diff --

remove sysout


---

[GitHub] helix pull request #138: CallbackHandler to use either java config property ...

[kishoreg]

Github user kishoreg commented on a diff in the pull request:

https://github.com/apache/helix/pull/138#discussion_r171987319
  
--- Diff: 
helix-core/src/test/java/org/apache/helix/TestListenerCallbackBatchMode.java ---
@@ -122,21 +131,45 @@ public void testNonBatchedListener() throws Exception 
{
 
 final Listener listener = new Listener();
 addListeners(listener);
+updateConfigs();
+verifyNonbatchedListeners(listener);
+removeListeners(listener);
 
+System.out.println("END " + methodName + " at " + new 
Date(System.currentTimeMillis()));
+  }
+
+  @Test (dependsOnMethods = {"testNonBatchedListener", 
"testBatchedListener", "testMixedListener"})
+  public void testEnableBatchedListenerByJavaProperty() throws Exception {
+String methodName = TestHelper.getTestMethodName();
+System.out.println("START " + methodName + " at " + new 
Date(System.currentTimeMillis()));
--- End diff --

avoid using sysout every where


---

[GitHub] helix pull request #138: CallbackHandler to use either java config property ...

[lei-xia]

GitHub user lei-xia opened a pull request:

https://github.com/apache/helix/pull/138

CallbackHandler to use either java config property or class annotation n to 
enable batch callback handling

CallbackHandler to use either java config property or class annotation to 
enable batch callback handling.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lei-xia/helix master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/helix/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #138


commit 2dbd88ffed2eb84697225a58e8831b740ecd5919
Author: Lei Xia 
Date:   2018-03-02T22:20:14Z

CallbackHandler to use either java config property or class annotation to 
enable batch callback handling.




---