[GitHub] helix pull request #147: [Helix 678] Clear controller event queue when it is...

2018-03-14 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/helix/pull/147


---


[GitHub] helix pull request #147: [Helix 678] Clear controller event queue when it is...

2018-03-13 Thread jiajunwang
GitHub user jiajunwang opened a pull request:

https://github.com/apache/helix/pull/147

[Helix 678] Clear controller event queue when it is shutdown or no longer 
the leader

 Clear controller event queue when it is shutdown or no longer the leader

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jiajunwang/helix helix-678

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/helix/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #147


commit 7e011d358b10528dfa79362965e192012ffa4d22
Author: Jiajun Wang 
Date:   2018-02-05T21:29:59Z

[HELIX-678] Clear controller event queue when it is shutdown or no longer 
the leader.

This change can prevent unnecessary event processing.

commit b5c72bc164e8be8155c6108cb8d4567122aafd12
Author: Jiajun Wang 
Date:   2018-02-07T23:28:49Z

[HELIX-678] Don't clear event queues when the controller is no longer 
leader.

Cleaning queues is optional for controller state change. However, it may 
cause potential issue if the controller state read fails for a short while. As 
a result, the event will be lost.
So undo this change for safe.




---