[jira] [Commented] (HELIX-691) Allow users to update InstanceConfig

2018-04-09 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HELIX-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431120#comment-16431120
 ] 

Hudson commented on HELIX-691:
--

FAILURE: Integrated in Jenkins build helix #1436 (See 
[https://builds.apache.org/job/helix/1436/])
[HELIX-691] Allow users to update InstanceConfig (narendly: rev 
72d52484716bf2f90323f141a478893fdd0843f1)
* (edit) helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
* (edit) helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
* (edit) helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
* (edit) 
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstanceAccessor.java
* (edit) 
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAccessor.java
* (edit) 
helix-rest/src/test/java/org/apache/helix/rest/server/TestInstanceAccessor.java


> Allow users to update InstanceConfig
> 
>
> Key: HELIX-691
> URL: https://issues.apache.org/jira/browse/HELIX-691
> Project: Apache Helix
>  Issue Type: Improvement
>Reporter: Hunter L
>Priority: Major
>
> In helix-rest, we provide in InstanceAccessor a method updateInstanceConfig 
> updates the instance's config through a POST call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HELIX-691) Allow users to update InstanceConfig

2018-04-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HELIX-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431104#comment-16431104
 ] 

ASF GitHub Bot commented on HELIX-691:
--

Github user asfgit closed the pull request at:

https://github.com/apache/helix/pull/176


> Allow users to update InstanceConfig
> 
>
> Key: HELIX-691
> URL: https://issues.apache.org/jira/browse/HELIX-691
> Project: Apache Helix
>  Issue Type: Improvement
>Reporter: Hunter L
>Priority: Major
>
> In helix-rest, we provide in InstanceAccessor a method updateInstanceConfig 
> updates the instance's config through a POST call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HELIX-691) Allow users to update InstanceConfig

2018-04-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HELIX-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431069#comment-16431069
 ] 

ASF GitHub Bot commented on HELIX-691:
--

GitHub user narendly opened a pull request:

https://github.com/apache/helix/pull/176

[HELIX-691] Allow users to update InstanceConfig

In helix-rest, we provide a method in InstanceAccessor, 
updateInstanceConfig, that updates the instance's config through a POST call.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/narendly/helix instConfig2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/helix/pull/176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #176


commit 72d52484716bf2f90323f141a478893fdd0843f1
Author: narendly 
Date:   2018-04-09T19:04:26Z

[HELIX-691] Allow users to update InstanceConfig

In helix-rest, we provide a method in InstanceAccessor, 
updateInstanceConfig, that updates the instance's config through a POST call.




> Allow users to update InstanceConfig
> 
>
> Key: HELIX-691
> URL: https://issues.apache.org/jira/browse/HELIX-691
> Project: Apache Helix
>  Issue Type: Improvement
>Reporter: Hunter L
>Priority: Major
>
> In helix-rest, we provide in InstanceAccessor a method updateInstanceConfig 
> updates the instance's config through a POST call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HELIX-691) Allow users to update InstanceConfig

2018-04-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HELIX-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431061#comment-16431061
 ] 

ASF GitHub Bot commented on HELIX-691:
--

Github user narendly closed the pull request at:

https://github.com/apache/helix/pull/174


> Allow users to update InstanceConfig
> 
>
> Key: HELIX-691
> URL: https://issues.apache.org/jira/browse/HELIX-691
> Project: Apache Helix
>  Issue Type: Improvement
>Reporter: Hunter L
>Priority: Major
>
> In helix-rest, we provide in InstanceAccessor a method updateInstanceConfig 
> updates the instance's config through a POST call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HELIX-691) Allow users to update InstanceConfig

2018-04-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HELIX-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430970#comment-16430970
 ] 

ASF GitHub Bot commented on HELIX-691:
--

Github user zhan849 commented on a diff in the pull request:

https://github.com/apache/helix/pull/174#discussion_r180178181
  
--- Diff: 
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstanceAccessor.java
 ---
@@ -315,26 +316,27 @@ public Response 
getInstanceConfig(@PathParam("clusterId") String clusterId,
 return notFound();
   }
 
-  @PUT
+  @POST
--- End diff --

PUT is for "set" and POST is for "patch", I'd suggest we keep both. 
@dasahcc thoughts?


> Allow users to update InstanceConfig
> 
>
> Key: HELIX-691
> URL: https://issues.apache.org/jira/browse/HELIX-691
> Project: Apache Helix
>  Issue Type: Improvement
>Reporter: Hunter L
>Priority: Major
>
> In helix-rest, we provide in InstanceAccessor a method updateInstanceConfig 
> updates the instance's config through a POST call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HELIX-691) Allow users to update InstanceConfig

2018-04-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HELIX-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430969#comment-16430969
 ] 

ASF GitHub Bot commented on HELIX-691:
--

Github user zhan849 commented on a diff in the pull request:

https://github.com/apache/helix/pull/174#discussion_r180174778
  
--- Diff: 
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ResourceAccessor.java
 ---
@@ -84,10 +96,66 @@ public Response getResources(@PathParam("clusterId") 
String clusterId) {
 return JSONRepresentation(root);
   }
 
+  /**
--- End diff --

Partition health related changes are not part of this PR (allow user to 
change instance config), can we file different issues?


> Allow users to update InstanceConfig
> 
>
> Key: HELIX-691
> URL: https://issues.apache.org/jira/browse/HELIX-691
> Project: Apache Helix
>  Issue Type: Improvement
>Reporter: Hunter L
>Priority: Major
>
> In helix-rest, we provide in InstanceAccessor a method updateInstanceConfig 
> updates the instance's config through a POST call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HELIX-691) Allow users to update InstanceConfig

2018-04-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/HELIX-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427722#comment-16427722
 ] 

ASF GitHub Bot commented on HELIX-691:
--

GitHub user narendly opened a pull request:

https://github.com/apache/helix/pull/174

[HELIX-691] Allow users to update InstanceConfig

In helix-rest, we provide a method in InstanceAccessor, 
updateInstanceConfig, that updates the instance's config through a POST call.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/narendly/helix instConfig

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/helix/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #174


commit 1ebdc45194dddecb675362e812aa795c876c9f6a
Author: narendly 
Date:   2018-04-05T23:00:52Z

[HELIX-691] Allow users to update InstanceConfig

In helix-rest, we provide a method in InstanceAccessor, 
updateInstanceConfig, that updates the instance's config through a POST call.




> Allow users to update InstanceConfig
> 
>
> Key: HELIX-691
> URL: https://issues.apache.org/jira/browse/HELIX-691
> Project: Apache Helix
>  Issue Type: Improvement
>Reporter: Hunter L
>Priority: Major
>
> In helix-rest, we provide in InstanceAccessor a method updateInstanceConfig 
> updates the instance's config through a POST call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)