Review Request 27318: HIVE-8625: Some union queries result in plans with many unions with CBO on

2014-10-28 Thread Jesús Camacho Rodríguez
--- Thanks, Jesús Camacho Rodríguez

Re: Review Request 27318: HIVE-8625: Some union queries result in plans with many unions with CBO on

2014-10-28 Thread Jesús Camacho Rodríguez
operator. With the fix in the patch attached, the method will merge the two unions if (1) one is the child of the other one, or (2) if one is a descendant of the other one and there is an identity select operator between them. Thanks, Jesús Camacho Rodríguez

Re: Review Request 27318: HIVE-8625: Some union queries result in plans with many unions with CBO on

2014-10-28 Thread Jesús Camacho Rodríguez
, the method will merge the two unions if (1) one is the child of the other one, or (2) if one is a descendant of the other one and there is an identity select operator between them. Thanks, Jesús Camacho Rodríguez

Re: Review Request 27318: HIVE-8625: Some union queries result in plans with many unions with CBO on

2014-10-28 Thread Jesús Camacho Rodríguez
/results/clientpositive/union_remove_11.q.out 82d91a9d036b5c1a61debfe9258b84e8ae2b8f8e Diff: https://reviews.apache.org/r/27318/diff/ Testing (updated) --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 27699: HIVE-8435: Add identity project remover optimization

2014-11-06 Thread Jesús Camacho Rodríguez
/windowing_navfn.q.out 4256640dbd4d613418dc2fd2e309bcb733413d56 Diff: https://reviews.apache.org/r/27699/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 27699: HIVE-8435: Add identity project remover optimization

2014-11-08 Thread Jesús Camacho Rodríguez
/windowing_navfn.q.out 531ab6b6b2389f1784e6c6ac2977f83619f5260c ql/src/test/results/compiler/plan/groupby1.q.xml 3b7e69b3350f1be3dbc5e619975b1a37d5df3f94 Diff: https://reviews.apache.org/r/27699/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Review Request 28067: HIVE-8869

2014-11-14 Thread Jesús Camacho Rodríguez
, Jesús Camacho Rodríguez

Re: Review Request 28067: HIVE-8869

2014-11-16 Thread Jesús Camacho Rodríguez
--- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28067: HIVE-8869

2014-11-16 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/28067/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28067: HIVE-8869

2014-11-17 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/28067/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28067: HIVE-8869

2014-11-17 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/28067/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 27699: HIVE-8435

2014-11-18 Thread Jesús Camacho Rodríguez
Camacho Rodríguez

Re: Review Request 27699: HIVE-8435

2014-11-18 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/27699/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 27699: HIVE-8435

2014-11-19 Thread Jesús Camacho Rodríguez
--- Thanks, Jesús Camacho Rodríguez

Review Request 28285: HIVE-8435

2014-11-20 Thread Jesús Camacho Rodríguez
/results/clientpositive/multiMapJoin1.q.out 26eca26f17bfccb242c79c54732dfe3fe726aada Diff: https://reviews.apache.org/r/28285/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28285: HIVE-8926

2014-11-20 Thread Jesús Camacho Rodríguez
/hadoop/hive/ql/exec/SelectOperator.java dabe2a8d1cdf6a3b57a3fb34a9791a824e6b22e7 ql/src/test/results/clientpositive/multiMapJoin1.q.out 26eca26f17bfccb242c79c54732dfe3fe726aada Diff: https://reviews.apache.org/r/28285/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28285: HIVE-8926

2014-11-20 Thread Jesús Camacho Rodríguez
dabe2a8d1cdf6a3b57a3fb34a9791a824e6b22e7 ql/src/test/results/clientpositive/multiMapJoin1.q.out 26eca26f17bfccb242c79c54732dfe3fe726aada Diff: https://reviews.apache.org/r/28285/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28285: HIVE-8435

2014-11-21 Thread Jesús Camacho Rodríguez
/union_remove_19.q.out 92b376f61f77b23ef9735356e300f9586c65deef ql/src/test/results/clientpositive/windowing.q.out 965438f63a4750f4abe2e06071ec39e65e53aaca Diff: https://reviews.apache.org/r/28285/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28285: HIVE-8926

2014-11-21 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/28285/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Review Request 28510: HIVE-8974

2014-11-27 Thread Jesús Camacho Rodríguez
95c6d00453d5d5b7dac3ef35b85a1c8a0f59f725 Diff: https://reviews.apache.org/r/28510/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28510: HIVE-8974

2014-11-27 Thread Jesús Camacho Rodríguez
68f3be7948df6974fb9412b99742527971207362 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 95c6d00453d5d5b7dac3ef35b85a1c8a0f59f725 Diff: https://reviews.apache.org/r/28510/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28510: HIVE-8974

2014-12-02 Thread Jesús Camacho Rodríguez
/#review63461 --- On Nov. 27, 2014, 2:37 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510

Re: Review Request 28510: HIVE-8974

2014-12-02 Thread Jesús Camacho Rodríguez
/SemanticAnalyzer.java 95c6d00453d5d5b7dac3ef35b85a1c8a0f59f725 Diff: https://reviews.apache.org/r/28510/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28510: HIVE-8974

2014-12-05 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28510/#review64052 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Dec. 3, 2014, 12

Review Request 28941: HIVE-8988

2014-12-11 Thread Jesús Camacho Rodríguez
, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2014-12-11 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/28941/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2014-12-12 Thread Jesús Camacho Rodríguez
7b5d70ae8ffce47a4b351ed9dfedcd15ab1e139c Diff: https://reviews.apache.org/r/28941/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2014-12-13 Thread Jesús Camacho Rodríguez
c12720b27059075050fc92d9f31420c081303699 ql/src/test/results/clientpositive/groupby_cube1.q.out 7b5d70ae8ffce47a4b351ed9dfedcd15ab1e139c Diff: https://reviews.apache.org/r/28941/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2014-12-17 Thread Jesús Camacho Rodríguez
29be69182667dbe2070bd092bf75b4bb97101554 ql/src/test/queries/clientpositive/groupby_cube1.q c12720b27059075050fc92d9f31420c081303699 ql/src/test/results/clientpositive/groupby_cube1.q.out 7b5d70ae8ffce47a4b351ed9dfedcd15ab1e139c Diff: https://reviews.apache.org/r/28941/diff/ Testing --- Thanks, Jesús Camacho

Re: Review Request 28941: HIVE-8988

2014-12-18 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/28941/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2014-12-23 Thread Jesús Camacho Rodríguez
--- On Dec. 18, 2014, 11:07 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28941

Re: Review Request 28941: HIVE-8988

2014-12-23 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/28941/#review65810 --- On Dec. 18, 2014, 11:07 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 28941: HIVE-8988

2014-12-23 Thread Jesús Camacho Rodríguez
need to change the GB output schema to accomodate this, right? Jesús Camacho Rodríguez wrote: 1) The grouping function column is not added by the Aggregate operator in Calcite, but by a Project operator that is introduced just above (lines 13715-13762). Thus, the schema of the Aggregate

Re: Review Request 28941: HIVE-8988

2014-12-23 Thread Jesús Camacho Rodríguez
. - Jesús --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28941/#review65962 --- On Dec. 18, 2014, 11:07 p.m., Jesús Camacho Rodríguez wrote

Review Request 29375: HIVE-9200

2014-12-23 Thread Jesús Camacho Rodríguez
/hadoop/hive/ql/plan/JoinDesc.java c144d8c05c73025ba33b300229125e74930e Diff: https://reviews.apache.org/r/29375/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2014-12-24 Thread Jesús Camacho Rodríguez
, 2014, 11:07 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28941/ --- (Updated Dec. 18, 2014, 11

Re: Review Request 30254: HIVE-9444

2015-02-04 Thread Jesús Camacho Rodríguez
/hive/ql/plan/ReduceSinkDesc.java 43f8321107304c38ecd9f603cd3f8ce43e8496c8 Diff: https://reviews.apache.org/r/30254/diff/ Testing --- Existing tests (global_limit.q). Thanks, Jesús Camacho Rodríguez

Review Request 30638: HIVE-9432

2015-02-04 Thread Jesús Camacho Rodríguez
66d4d4ac02618f8adaa51e2a620005004dceca84 ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 0e85990f5abc4aa3072ed53f8397e858f5b4062d Diff: https://reviews.apache.org/r/30638/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-02-02 Thread Jesús Camacho Rodríguez
/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 30456: HIVE-9512

2015-02-02 Thread Jesús Camacho Rodríguez
--- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
43f8321107304c38ecd9f603cd3f8ce43e8496c8 Diff: https://reviews.apache.org/r/30254/diff/ Testing --- Existing tests (global_limit.q). Thanks, Jesús Camacho Rodríguez

Re: Review Request 30638: HIVE-9432

2015-02-06 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/30638/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
/r/30254/#review70820 --- On Feb. 3, 2015, 7:51 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
/#review70819 --- On Feb. 3, 2015, 7:51 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
/GlobalLimitOptimizer.java c9848dacd1a02db321583c2b91eb6d7317c295ff Diff: https://reviews.apache.org/r/30254/diff/ Testing (updated) --- Existing tests (global_limit.q). Thanks, Jesús Camacho Rodríguez

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
/optimizer/GlobalLimitOptimizer.java c9848dacd1a02db321583c2b91eb6d7317c295ff Diff: https://reviews.apache.org/r/30254/diff/ Testing --- Existing tests (global_limit.q). Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-02-03 Thread Jesús Camacho Rodríguez
/hive/ql/parse/TaskCompiler.java e4ed51e9a40a926ce074a3e33119535b4e08a122 Diff: https://reviews.apache.org/r/29763/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 30254: HIVE-9444

2015-02-02 Thread Jesús Camacho Rodríguez
/optimizer/GlobalLimitOptimizer.java c9848dacd1a02db321583c2b91eb6d7317c295ff Diff: https://reviews.apache.org/r/30254/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Review Request 30086: HIVE-9327

2015-01-20 Thread Jesús Camacho Rodríguez
fe59c132f1e343028205386700a746d72f3fed05 Diff: https://reviews.apache.org/r/30086/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Review Request 30125: HIVE-9431

2015-01-21 Thread Jesús Camacho Rodríguez
/SemanticAnalyzer.java 4364f2830d35b89266bf79948263dd64998fe5cc ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java f2eb4d27fca6472a9d4b777a54fcce8a729b3cd6 Diff: https://reviews.apache.org/r/30125/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Review Request 30160: HIVE-9431

2015-01-22 Thread Jesús Camacho Rodríguez
/SemanticAnalyzer.java 4364f2830d35b89266bf79948263dd64998fe5cc ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java f2eb4d27fca6472a9d4b777a54fcce8a729b3cd6 Diff: https://reviews.apache.org/r/30160/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 30086: HIVE-9327

2015-01-21 Thread Jesús Camacho Rodríguez
d1f2305c5215841dfce5dd5c4fa67b53bbd9 ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out 7a8955276a53343b253c61b0939027baf965ac43 Diff: https://reviews.apache.org/r/30086/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Review Request 31209: HIVE-9727

2015-02-19 Thread Jesús Camacho Rodríguez
/hive/ql/optimizer/calcite/translator/ASTConverter.java ea5918110fa1255f105c646c08e7d307afb3f94b Diff: https://reviews.apache.org/r/31209/diff/ Testing --- Existing tests (groupby*.q) Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-28 Thread Jesús Camacho Rodríguez
/TaskCompiler.java 0116c85979f02ea0f88bbf8085a7590694eb2dfb Diff: https://reviews.apache.org/r/29763/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 30254: HIVE-9444

2015-01-29 Thread Jesús Camacho Rodríguez
c9848dacd1a02db321583c2b91eb6d7317c295ff Diff: https://reviews.apache.org/r/30254/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Review Request 30456: HIVE-9512

2015-01-30 Thread Jesús Camacho Rodríguez
/apache/hadoop/hive/ql/stats/StatsUtils.java 30f63a27cb22cdd0152d5ea305c728d766a091d3 ql/src/test/results/clientpositive/annotate_stats_select.q.out 8984d02c4a724ce07574d1c45740d9e1e63106f0 Diff: https://reviews.apache.org/r/30456/diff/ Testing --- Existing tests. Thanks, Jesús Camacho

Review Request 30254: HIVE-9444

2015-01-25 Thread Jesús Camacho Rodríguez
--- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-28 Thread Jesús Camacho Rodríguez
Camacho Rodríguez

Review Request 29625: HIVE-9200

2015-01-06 Thread Jesús Camacho Rodríguez
8215c26f48f1611d3c64f6df5bcfac02069e3a67 ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java c144d8c05c73025ba33b300229125e74930e Diff: https://reviews.apache.org/r/29625/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2015-01-05 Thread Jesús Camacho Rodríguez
/infer_bucket_sort_grouping_operators.q.out 044946f4242599a3db3b7a7b5a2538d647370052 Diff: https://reviews.apache.org/r/28941/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2015-01-05 Thread Jesús Camacho Rodríguez
/clientpositive/infer_bucket_sort_grouping_operators.q.out 044946f4242599a3db3b7a7b5a2538d647370052 Diff: https://reviews.apache.org/r/28941/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-12 Thread Jesús Camacho Rodríguez
., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29625/ --- (Updated Jan. 12, 2015, 11:32 a.m

Re: Review Request 29625: HIVE-9200

2015-01-12 Thread Jesús Camacho Rodríguez
/plan/JoinDesc.java c144d8c05c73025ba33b300229125e74930e ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 9f8c0918179d9226e36cecc3bd955946d6b5fe98 Diff: https://reviews.apache.org/r/29625/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-12 Thread Jesús Camacho Rodríguez
c144d8c05c73025ba33b300229125e74930e ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 9f8c0918179d9226e36cecc3bd955946d6b5fe98 Diff: https://reviews.apache.org/r/29625/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-12 Thread Jesús Camacho Rodríguez
/TaskCompiler.java 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 Diff: https://reviews.apache.org/r/29763/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29761: HIVE-9315

2015-01-12 Thread Jesús Camacho Rodríguez
Diff: https://reviews.apache.org/r/29761/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29761: HIVE-9315

2015-01-13 Thread Jesús Camacho Rodríguez
8b25c2b6b9f6cfb087ba3c1beaf0c2164ab70de0 Diff: https://reviews.apache.org/r/29761/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-13 Thread Jesús Camacho Rodríguez
c144d8c05c73025ba33b300229125e74930e ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 9f8c0918179d9226e36cecc3bd955946d6b5fe98 Diff: https://reviews.apache.org/r/29625/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-14 Thread Jesús Camacho Rodríguez
/ql/plan/JoinDesc.java c144d8c05c73025ba33b300229125e74930e ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 9f8c0918179d9226e36cecc3bd955946d6b5fe98 Diff: https://reviews.apache.org/r/29625/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-13 Thread Jesús Camacho Rodríguez
tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-13 Thread Jesús Camacho Rodríguez
/hive/ql/plan/JoinDesc.java c144d8c05c73025ba33b300229125e74930e ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 9f8c0918179d9226e36cecc3bd955946d6b5fe98 Diff: https://reviews.apache.org/r/29625/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Review Request 29761: HIVE-9315

2015-01-09 Thread Jesús Camacho Rodríguez
--- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-09 Thread Jesús Camacho Rodríguez
/plan/MapWork.java 9f8c0918179d9226e36cecc3bd955946d6b5fe98 Diff: https://reviews.apache.org/r/29625/diff/ Testing (updated) --- Existing tests. Thanks, Jesús Camacho Rodríguez

Review Request 29763: HIVE-9292

2015-01-09 Thread Jesús Camacho Rodríguez
/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 Diff: https://reviews.apache.org/r/29763/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-09 Thread Jesús Camacho Rodríguez
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 7a0b0da5de5c1c7dc8dd099167e9d06e6b27eea2 Diff: https://reviews.apache.org/r/29763/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-09 Thread Jesús Camacho Rodríguez
/plan/MapWork.java 9f8c0918179d9226e36cecc3bd955946d6b5fe98 Diff: https://reviews.apache.org/r/29625/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-14 Thread Jesús Camacho Rodríguez
/parse/TaskCompiler.java 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 Diff: https://reviews.apache.org/r/29763/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 29763: HIVE-9292

2015-01-14 Thread Jesús Camacho Rodríguez
by RewriteQueryUsingAggregateIndexCtx. Couldn't we get rid of groupToInputTables from parse context by changing RewriteQueryUsingAggregateIndexCtx? Jesús Camacho Rodríguez wrote: The method replaceGroupByOperatorProcess 1) creates a query in String format, 2) uses RewriteParseContextGenerator to create an operator tree

Re: Review Request 30638: HIVE-9432

2015-02-10 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/30638/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 30638: HIVE-9432

2015-02-09 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/30638/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 28941: HIVE-8988

2015-01-05 Thread Jesús Camacho Rodríguez
ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out 044946f4242599a3db3b7a7b5a2538d647370052 Diff: https://reviews.apache.org/r/28941/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Review Request 32370: HIVE-10040

2015-03-21 Thread Jesús Camacho Rodríguez
/HiveRelMdUniqueKeys.java 95515b23e409d73d5c61e107931727add3f992a6 Diff: https://reviews.apache.org/r/32370/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Review Request 32314: [HIVE-9825] CBO (Calcite Return Path): Translate PTFs and Windowing to Hive Op [CBO branch]

2015-03-20 Thread Jesús Camacho Rodríguez
1ab0da6f489376bc97e456a2ead6dbcaa225db62 Diff: https://reviews.apache.org/r/32314/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 31209: HIVE-9727

2015-03-06 Thread Jesús Camacho Rodríguez
/diff/ Testing --- Existing tests (groupby*.q) Thanks, Jesús Camacho Rodríguez

Re: Review Request 32370: HIVE-10040

2015-03-31 Thread Jesús Camacho Rodríguez
, the cost coming from that method for NONE and any other algorithm e.g. COMMON should not be even comparable, right? - Jesús Camacho Rodríguez On March 27, 2015, 4:15 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated

Re: Review Request 30638: HIVE-9432

2015-02-27 Thread Jesús Camacho Rodríguez
0e85990f5abc4aa3072ed53f8397e858f5b4062d Diff: https://reviews.apache.org/r/30638/diff/ Testing --- Existing tests. Thanks, Jesús Camacho Rodríguez

Re: Review Request 31209: HIVE-9727

2015-02-20 Thread Jesús Camacho Rodríguez
/diff/ Testing --- Existing tests (groupby*.q) Thanks, Jesús Camacho Rodríguez

Re: Review Request 32370: HIVE-10040

2015-03-27 Thread Jesús Camacho Rodríguez
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java 95515b23e409d73d5c61e107931727add3f992a6 Diff: https://reviews.apache.org/r/32370/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 32370: HIVE-10040

2015-03-27 Thread Jesús Camacho Rodríguez
dabbe280278dc80f00f0240a0c615fe6c7b8533a ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java 95515b23e409d73d5c61e107931727add3f992a6 Diff: https://reviews.apache.org/r/32370/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 32370: HIVE-10040

2015-03-27 Thread Jesús Camacho Rodríguez
--- On March 21, 2015, 5:49 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370

Re: Review Request 29763: HIVE-9292

2015-01-13 Thread Jesús Camacho Rodríguez
--- On Jan. 13, 2015, 9:17 a.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29763/ --- (Updated Jan

Re: Review Request 32370: HIVE-10040

2015-04-06 Thread Jesús Camacho Rodríguez
--- Thanks, Jesús Camacho Rodríguez

Re: Review Request 32370: HIVE-10040

2015-04-06 Thread Jesús Camacho Rodríguez
://reviews.apache.org/r/32370/#review78284 --- On March 27, 2015, 4:15 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 32370: HIVE-10040

2015-04-07 Thread Jesús Camacho Rodríguez
/stats/HiveRelMdRowCount.java dabbe280278dc80f00f0240a0c615fe6c7b8533a ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java 95515b23e409d73d5c61e107931727add3f992a6 Diff: https://reviews.apache.org/r/32370/diff/ Testing --- Thanks, Jesús Camacho

Re: Review Request 32370: HIVE-10040

2015-04-07 Thread Jesús Camacho Rodríguez
, Jesús Camacho Rodríguez

Review Request 32991: HIVE-10243

2015-04-08 Thread Jesús Camacho Rodríguez
/hadoop/hive/ql/parse/CalcitePlanner.java f67a92f022cdddaebae32f721187692d49341284 Diff: https://reviews.apache.org/r/32991/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 34726: HIVE-10533

2015-06-08 Thread Jesús Camacho Rodríguez
Diff: https://reviews.apache.org/r/34726/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 35618: HiveOnTez: make explain user level = true as default

2015-06-19 Thread Jesús Camacho Rodríguez
is not part of the key for the GroupBy operator ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_1.q.out (line 523) https://reviews.apache.org/r/35618/#comment141115 Is this condition printed correctly? Or you wanted to print 0 to 1 before the colon? - Jesús Camacho Rodríguez

Re: Review Request 34726: HIVE-10533

2015-06-19 Thread Jesús Camacho Rodríguez
/cbo_rp_join1.q.out PRE-CREATION Diff: https://reviews.apache.org/r/34726/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

Re: Review Request 34726: HIVE-10533

2015-06-24 Thread Jesús Camacho Rodríguez
/cbo_rp_join1.q.out PRE-CREATION Diff: https://reviews.apache.org/r/34726/diff/ Testing --- Thanks, Jesús Camacho Rodríguez

  1   2   3   4   5   6   >