Review Request 49215: HIVE-14085 : Allow type widening primitive conversion on hive/parquet tables

2016-06-24 Thread Vihang Karajgaonkar
ql/src/test/results/clientpositive/parquet_columnar.q.out fd28f5ce241d0661a10c18430522ccbb6f0fc88f ql/src/test/results/clientpositive/parquet_type_promotion.q.out 91c3fff57de418db975af18b779bc46e95a15501 Diff: https://reviews.apache.org/r/49215/diff/ Testing --- Thanks, Vihang

Becoming a contributor

2016-05-18 Thread Vihang Karajgaonkar
Hello Everyone, I would like to start working on issues reported on Hive in JIRA. I followed the steps mentioned in https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-BecomingaContributor

Re: Becoming a contributor

2016-05-18 Thread Vihang Karajgaonkar
u probably can’t assign JIRAs to yourself yet, but if you reply to this > email with your JIRA id I’ll make it so you can. > > Alan. > >> On May 18, 2016, at 11:42, Vihang Karajgaonkar <vih...@cloudera.com> wrote: >> >> Hello Everyone, >> >> I would

Re: Becoming a contributor

2016-05-19 Thread Vihang Karajgaonkar
Thanks Alan. On Wed, May 18, 2016 at 5:07 PM, Alan Gates <alanfga...@gmail.com> wrote: > You’ve been added, so you should now be able to assign JIRAs to yourself. > > Alan. > > > On May 18, 2016, at 13:38, Vihang Karajgaonkar <vih...@cloudera.com> > wrote

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Vihang Karajgaonkar
://reviews.apache.org/r/49919/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

2016-07-27 Thread Vihang Karajgaonkar
veConf while the Reflector is looking for setConf. Did you try renaming the method from setHiveConf to setConf? - Vihang Karajgaonkar On July 27, 2016, 4:26 p.m., Peter Vary wrote: > > --- > This is an automatically generated e

Re: Review Request 50982: HIVE-14345:Beeline result table has erroneous characters

2016-08-12 Thread Vihang Karajgaonkar
is test might fail. I think it will be more robust to determine this string programatically using the values in mockResultData and value of maxColumnWidth. - Vihang Karajgaonkar On Aug. 12, 2016, 3:16 p.m., Miklos Csanady wrote: > > --- >

Re: [ANNOUNCE] New PMC Member : Jesus

2016-07-18 Thread Vihang Karajgaonkar
Congratulations Jesus! > On Jul 18, 2016, at 8:30 AM, Sergio Pena wrote: > > Congrats Jesus !!! > > On Mon, Jul 18, 2016 at 7:28 AM, Peter Vary wrote: > >> Congratulations Jesus! >> >>> On Jul 18, 2016, at 6:55 AM, Wei Zheng

Re: [ANNOUNCE] New PMC Member : Pengcheng

2016-07-18 Thread Vihang Karajgaonkar
Congratulations! > On Jul 18, 2016, at 5:28 AM, Peter Vary wrote: > > Congratulations Pengcheng! > > >> On Jul 18, 2016, at 6:55 AM, Wei Zheng wrote: >> >> Congrats Pengcheng! >> >> Thanks, >> >> Wei >> >> >> >> >> >> >> On 7/17/16, 16:01,

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-18 Thread Vihang Karajgaonkar
the previous two tests to be executed before it? If yes, it might make sense to make it self-contained since I believe the order in which tests are executed is not deterministic. - Vihang Karajgaonkar On July 18, 2016, 12:37 p.m.

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-15 Thread Vihang Karajgaonkar
> On July 1, 2016, 9:58 p.m., Vihang Karajgaonkar wrote: > > Thanks for the changes. Can you please test your code by setting > > USE_DEPRECATED_CLI=false. > > Peter Vary wrote: > Ok. Maybe something is not yet clear for me :) > Could you please explain? &g

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-15 Thread Vihang Karajgaonkar
hive/beeline/ClientCommandHookFactory.java (line 64) <https://reviews.apache.org/r/49498/#comment207964> I agree that in case of go command you would probably need to query the db, but I think in the common case of use and connect commands it would be still beneficial to save that extra query call. - Vihang Kara

Re: Review Request 49782: HIVE-14170: Beeline IncrementalRows should buffer rows and incrementally re-calculate width if TableOutputFormat is used

2016-07-15 Thread Vihang Karajgaonkar
o max column width - Vihang Karajgaonkar On July 11, 2016, 5:29 p.m., Sahil Takiar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-14 Thread Vihang Karajgaonkar
it now in the loop. btw, If we have to add it in the loop it should be Math.min(Math.max(max[j], row.sizes[j] + 1), maxColumnWidth); Did you mean the same? - Vihang Karajgaonkar On July 12, 2016, 5:51 p.m., Vihang Karajgaonkar

Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-11 Thread Vihang Karajgaonkar
5aaa38527734d46de037352ff51e54e0ae1cede0 beeline/src/java/org/apache/hive/beeline/BufferedRows.java 962c5319bb7e6e448979e1cef80a086cadd2ecc6 beeline/src/test/org/apache/hive/beeline/TestBufferedRows.java PRE-CREATION Diff: https://reviews.apache.org/r/49919/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 49919: HIVE-14135 : beeline output not formatted correctly for large column widths

2016-07-12 Thread Vihang Karajgaonkar
://reviews.apache.org/r/49919/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 49498: HIVE-14123: Add beeline configuration option to show database in the prompt

2016-07-01 Thread Vihang Karajgaonkar
eeline/BeeLineOpts.java (line 69) <https://reviews.apache.org/r/49498/#comment205783> nit, add a space after = - Vihang Karajgaonkar On July 1, 2016, 3:08 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-

Re: [Announce] New Hive Committer - Mohit Sabharwal

2016-07-01 Thread Vihang Karajgaonkar
Congratulations Mohit! > On Jul 1, 2016, at 10:05 AM, Chao Sun wrote: > > Congratulations Mohit! Good job! > > Best, > Chao > > On Fri, Jul 1, 2016 at 9:57 AM, Szehon Ho > wrote: > On behalf of the Apache Hive PMC,

Re: Review Request 56095: HIVE-15754 exchange partition is not generating notifications

2017-02-08 Thread Vihang Karajgaonkar
clause when success is true. Is there a reason this is different? - Vihang Karajgaonkar On Feb. 7, 2017, 9:32 p.m., Nachiket Vaidya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: [ANNOUNCE] New committer: Zoltan Haindrich

2017-02-21 Thread Vihang Karajgaonkar
Congrats Zoltan! On Tue, Feb 21, 2017 at 4:16 PM, Vaibhav Gumashta wrote: > Congrats Zoltan! > > On 2/21/17, 4:16 PM, "Jimmy Xiang" wrote: > > >Congrats, Zoltan!! > > > >On Tue, Feb 21, 2017 at 4:15 PM, Sushanth Sowmyan >

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

2017-02-21 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/#review166274 --- LGTM. Thanks for the patch Sergio! - Vihang Karajgaonkar

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-18 Thread Vihang Karajgaonkar
vailable in the run time (I think miniHS2 instantiates on a available port at the run time) - Vihang Karajgaonkar On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-20 Thread Vihang Karajgaonkar
> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, > > line 116 > > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line116> > > > >

Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

2017-02-23 Thread Vihang Karajgaonkar
7c94c95f00492467ba27dedc9ce513e13c85ea61 ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java 35f52cd522e0e48a333e30966245bec65cc2ec9c Diff: https://reviews.apache.org/r/56995/diff/ Testing --- Tested using existing and newly added test cases Thanks, Vihang Karajgaonkar

Re: Review Request 56687: Intern strings in various critical places to reduce memory consumption.

2017-02-23 Thread Vihang Karajgaonkar
148) <https://reviews.apache.org/r/56687/#comment238558> Do you think we should intern the keys as well? In case of a table with 1000s of partitions, they partition keys for all the partionSpecs will be the same. So interning them probably makes sense as well. - Vihang Karajgaonkar

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

2017-02-24 Thread Vihang Karajgaonkar
35f52cd522e0e48a333e30966245bec65cc2ec9c Diff: https://reviews.apache.org/r/56995/diff/ Testing --- Tested using existing and newly added test cases Thanks, Vihang Karajgaonkar

Re: Review Request 56118: DROP TABLE in hive doesn't Throw Error

2017-02-10 Thread Vihang Karajgaonkar
stale data unusable anyways without the metadata. If we want to notify such cases to the client, I think it should be a warning at best and not an error. - Vihang Karajgaonkar On Feb. 3, 2017, 2:22 p.m., Adam Szita

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

2017-02-27 Thread Vihang Karajgaonkar
existing and newly added test cases Thanks, Vihang Karajgaonkar

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

2017-02-27 Thread Vihang Karajgaonkar
clartion be `Queue`, same for the other > > declarations below. > > Vihang Karajgaonkar wrote: > We can declare it as a Queue, but the implementation of the queue needs > to be thread-safe since multiple threads are going to operate on the queue at > the same tim

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

2017-02-27 Thread Vihang Karajgaonkar
/ql/metadata/HiveMetaStoreChecker.java (line 546) <https://reviews.apache.org/r/56995/#comment238990> I just replicated what the previous code was throwing. Agreed, better to throw new HiveException(e). Changed. - Vihang Karajgaonkar On Feb. 24, 2017, 7:20 p.m., Vihang

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

2017-02-27 Thread Vihang Karajgaonkar
existing and newly added test cases Thanks, Vihang Karajgaonkar

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

2017-02-27 Thread Vihang Karajgaonkar
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56995/#review166898 --- On Feb. 27, 2017, 6:44 p.m., Vihang Karajgaonkar wrote: > > ---

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

2017-02-27 Thread Vihang Karajgaonkar
tests - Vihang Karajgaonkar On Feb. 24, 2017, 12:21 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
--- Thanks, Vihang Karajgaonkar

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
#review147678 --- On Sept. 6, 2016, 11:53 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.o

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
It this is public, do we need the VisibleForTesting annotation? fixed - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review147700

Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-02 Thread Vihang Karajgaonkar
itests/hive-unit/src/test/java/org/apache/hive/beeline/hs2connectionfile/TestBeelineWithUserHs2ConnectionFile.java PRE-CREATION Diff: https://reviews.apache.org/r/51593/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script

2016-09-12 Thread Vihang Karajgaonkar
see debug messages in the output file. - Vihang Karajgaonkar On Sept. 13, 2016, 2:36 a.m., Jianguo Tian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-05 Thread Vihang Karajgaonkar
, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-05 Thread Vihang Karajgaonkar
-mail. To reply, visit: https://reviews.apache.org/r/52283/#review151382 ------- On Oct. 5, 2016, 9:58 p.m., Vihang Karajgaonkar wrote: > > --- > This is an auto

Re: Error when running the test TestBeeLineWithArgs

2016-09-07 Thread Vihang Karajgaonkar
Yes, you are right. I have created a JIRA for the same. https://issues.apache.org/jira/browse/HIVE-14717 > On Sep 6, 2016, at 7:02 AM, Marta Kuczora wrote: > > Hi, > > I have noticed recently that I cannot run the

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-07 Thread Vihang Karajgaonkar
------ This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review148007 --- On Sept. 7, 2016, 6:22 p.m., Vihang Karajgaonkar wrote: > > -

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-07 Thread Vihang Karajgaonkar
--- Thanks, Vihang Karajgaonkar

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

2016-08-25 Thread Vihang Karajgaonkar
> On July 28, 2016, 4:37 a.m., Vihang Karajgaonkar wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java, line 627 > > <https://reviews.apache.org/r/50510/diff/1/?file=1455259#file1455259line627> > > > > Adding @Ignore may not be the ri

Re: Review Request 50510: HIVE-14360 Starting BeeLine after using !save, there is an error logged: "Error setting configuration: conf"

2016-08-25 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50510/#review146862 --- Ship it! LGTM. Thanks for the change. - Vihang Karajgaonkar

Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-09-27 Thread Vihang Karajgaonkar
in a credential provider Thanks, Vihang Karajgaonkar

Review Request 52493: HIVE-13589 : beeline - support prompt for password with '-u' option

2016-10-03 Thread Vihang Karajgaonkar
a83f925df25be5801f885f4570fb8aaf5ab18c88 beeline/src/test/resources/hive-site.xml 5f310d68245275ac9dc24df45579784019eea332 itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION Diff: https://reviews.apache.org/r/52493/diff/ Testing --- Thanks, Vihang

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-09-30 Thread Vihang Karajgaonkar
in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-30 Thread Vihang Karajgaonkar
/java/org/apache/hive/beeline/hs2connection/TestBeelineWithUserHs2ConnectionFile.java PRE-CREATION Diff: https://reviews.apache.org/r/51593/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-09-29 Thread Vihang Karajgaonkar
: https://reviews.apache.org/r/52283/diff/ Testing --- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-12 Thread Vihang Karajgaonkar
/52283/diff/ Testing --- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52493: HIVE-13589 : beeline support prompt for password with '-p' option

2016-10-20 Thread Vihang Karajgaonkar
0a2c6c37688ab511710bd43517908996f158 > beeline/src/java/org/apache/hive/beeline/Commands.java > 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330 > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52493/diff/ > > > Testing > --- > > > Thanks, > > Vihang Karajgaonkar > >

Re: Review Request 52493: HIVE-13589 : beeline support prompt for password with '-p' option

2016-10-20 Thread Vihang Karajgaonkar
6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330 itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java PRE-CREATION Diff: https://reviews.apache.org/r/52493/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 52493: HIVE-13589 : beeline support prompt for password with '-p' option

2016-10-21 Thread Vihang Karajgaonkar
y generated e-mail. To reply, visit: https://reviews.apache.org/r/52493/#review153482 ------- On Oct. 21, 2016, 5:31 p.m., Vihang Karajgaonkar wrote: > > --- > Th

Re: Review Request 52493: HIVE-13589 : beeline support prompt for password with '-p' option

2016-10-21 Thread Vihang Karajgaonkar
/52493/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-12 Thread Vihang Karajgaonkar
ing environment variables so it is safe to revert back to original implementation of this method. > On Oct. 6, 2016, 8:56 p.m., Mohit Sabharwal wrote: > > ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java, > > line 103 > > <https://r

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-12 Thread Vihang Karajgaonkar
936fdafdb37c461a7a5deb97cba72d4db54a49e1 Diff: https://reviews.apache.org/r/52283/diff/ Testing --- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-14 Thread Vihang Karajgaonkar
936fdafdb37c461a7a5deb97cba72d4db54a49e1 Diff: https://reviews.apache.org/r/52283/diff/ Testing --- Testing running multiple queries on S3 with keys stored in a credential provider Thanks, Vihang Karajgaonkar

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

2016-10-14 Thread Vihang Karajgaonkar
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review152521 --- On Oct. 14, 2016, 6:32 p.m., Vihang Karajgaonkar wrote: > > ---

Re: [ANNOUNCE] New Hive Committer - Rajesh Balamohan

2016-12-14 Thread Vihang Karajgaonkar
Congrats Rajesh! On Wed, Dec 14, 2016 at 1:54 AM, Jesus Camacho Rodriguez < jcamachorodrig...@hortonworks.com> wrote: > Congrats Rajesh, well deserved! :) > > -- > Jesús > > > > > On 12/14/16, 8:41 AM, "Lefty Leverenz" wrote: > > >Congratulations Rajesh! > > > >-- Lefty

Re: Naveen Gangam has become a Hive Committer

2016-12-19 Thread Vihang Karajgaonkar
Congratulations Naveen! On Sat, Dec 17, 2016 at 11:36 PM, Sharath Babu Basavaraja < sharathfe...@gmail.com> wrote: > Congrats Naveen! > > --Sharath > > On Sat, Dec 17, 2016 at 11:16 PM Lefty Leverenz > wrote: > >> Congratulations Naveen! >> >> -- Lefty >> >> >> >> >> On

Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

2016-12-22 Thread Vihang Karajgaonkar
/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java PRE-CREATION hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java PRE-CREATION Diff: https://reviews.apache.org/r/54997/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

2016-12-22 Thread Vihang Karajgaonkar
, everything looks good. I agree. I will remove it and post it again. - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54997/#review160014 -------

Re: Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

2016-12-22 Thread Vihang Karajgaonkar
/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java PRE-CREATION hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java PRE-CREATION Diff: https://reviews.apache.org/r/54997/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 57599: HIVE-16152 TestBeeLineDriver logging improvements

2017-03-21 Thread Vihang Karajgaonkar
gt; Isn't the command which errored out (lastSucessfulCommand + 1)? - Vihang Karajgaonkar On March 14, 2017, 2:14 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail.

Re: INSERT OVERWRITE TABLE with IF NOT EXISTS

2017-03-27 Thread Vihang Karajgaonkar
I am not a 100% sure but looks like it means that do not overwrite the table/partition if it exists which is kinda of weird since we already provide "OVERWRITE" in the query. On Mon, Mar 27, 2017 at 8:40 AM, Eugene Koifman wrote: > Hi, > According to

Re: Review Request 58085: HIVE-16061: Some of console output is not printed to the beeline console

2017-03-30 Thread Vihang Karajgaonkar
<https://reviews.apache.org/r/58085/#comment243523> isnt this already done at line 107? - Vihang Karajgaonkar On March 30, 2017, 9:01 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar
ws.apache.org/r/57632/#comment242375> Can you add additional testcases to verify that older config gets used when the newer one is not set? - Vihang Karajgaonkar On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote: > > --- &

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar
> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java > > Line 392 (original), 381 (patched) > > <https://reviews.apache.org/r/57632/diff/4/?file=1670926#file1670926line395>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar
/CodahaleMetrics.java Lines 394 (patched) <https://reviews.apache.org/r/57632/#comment242436> Nit, please use the Hive coding conventions. We prefer using the curly braces. There is IDE formatter available in dev-support/ if you want to use that. - Vihang Karajgaonkar On March 21, 2

Re: Review Request 58091: HIVE-16299 : MSCK REPAIR TABLE should enforce partition key order when adding unknown partitions

2017-03-30 Thread Vihang Karajgaonkar
ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58091/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Review Request 58091: HIVE-16299 : MSCK REPAIR TABLE should enforce partition key order when adding unknown partitions

2017-03-30 Thread Vihang Karajgaonkar
/TestHiveMetaStoreChecker.java 21bc8eed06c8fcd99d1e4eee3b5e5f8a4fb812be ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58091/diff/1/ Testing --- Thanks, Vihang

Re: Green unit test results

2017-03-14 Thread Vihang Karajgaonkar
One thing which could be done by each author of a patch is to do a search on the HiveQA test failures. If there are flaky tests which fail on the HiveQA run may be should create a JIRA for each of them and link it to the JIRA. The JIRA could have useful information like stacktraces or attaching

Re: [ANNOUNCE] New PMC Member : Eugene Koifman

2017-03-15 Thread Vihang Karajgaonkar
Congratulations Eugene! On Wed, Mar 15, 2017 at 9:23 AM, Wei Zheng wrote: > Congrats! > > Thanks, > Wei > > On 3/15/17, 08:58, "Chaoyu Tang" wrote: > > Congratulations Eugene! > > On Wed, Mar 15, 2017 at 11:52 AM, Jimmy Xiang

Re: Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

2017-03-21 Thread Vihang Karajgaonkar
comments so that it is easier to understand? Is it because BOUNDING_CHAR is both at the starting and the ending of the message? ql/src/java/org/apache/hadoop/hive/ql/hooks/PrinterHook.java Lines 31 (patched) <https://reviews.apache.org/r/57693/#comment242161> Does this need to

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-31 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/#review170787 --- Ship it! Thanks for the changes. LGTM - Vihang Karajgaonkar

Re: Review Request 58091: HIVE-16299 : MSCK REPAIR TABLE should enforce partition key order when adding unknown partitions

2017-03-30 Thread Vihang Karajgaonkar
/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58091/diff/2/ Changes: https://reviews.apache.org/r/58091/diff/1-2/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

2017-04-05 Thread Vihang Karajgaonkar
> On April 5, 2017, 4:11 p.m., Sahil Takiar wrote: > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestHiveLockObject.java > > Lines 57 (patched) > > > > > > Would be nice to have a test case where the query is

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

2017-04-05 Thread Vihang Karajgaonkar
looks good. Couple of suggestions below common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 1774 (patched) <https://reviews.apache.org/r/58086/#comment244025> Do you think we should use a large value for the default instead of -1? - Vihang Karajgaonkar On March 30, 2017, 6:

Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

2017-04-20 Thread Vihang Karajgaonkar
://reviews.apache.org/r/58516/diff/2/ Changes: https://reviews.apache.org/r/58516/diff/1-2/ Testing --- Thanks, Vihang Karajgaonkar

Re: ptest is taking 8h

2017-04-21 Thread Vihang Karajgaonkar
Looks like PtestServer is not responding. org.apache.hive.ptest.api.client.PTestClient --command testStart --outputDir /home/jenkins/jenkins-slave/workspace/PreCommit-HIVE-Build/hive/build/hive/testutils/ptest2/target --password '[***]' --testHandle PreCommit-HIVE-Build-4795 --endpoint

Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

2017-04-21 Thread Vihang Karajgaonkar
e.org/r/58516/#review172590 --- On April 20, 2017, 10:01 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

2017-04-21 Thread Vihang Karajgaonkar
: https://reviews.apache.org/r/58516/diff/2-3/ Testing --- Thanks, Vihang Karajgaonkar

Re: ptest is taking 8h

2017-04-21 Thread Vihang Karajgaonkar
gio Pena <sergio.p...@cloudera.com> > wrote: > > > I'm taking a look at this now. There is something wrong on the server. > > > > On Fri, Apr 21, 2017 at 10:27 AM, Vihang Karajgaonkar < > vih...@cloudera.com > > > wrote: > > > >> Looks like PtestSe

Pre-commit job failing - No disk space

2017-03-03 Thread Vihang Karajgaonkar
Hi Sergio, Looks like the pre-commit jobs are failing due to disk space issues. Can you please help or let me know how can I fix it? Thanks, Vihang

Re: Pre-commit job failing - No disk space

2017-03-03 Thread Vihang Karajgaonkar
G PreCommit-HIVE-Build-3878 >> 212KPreCommit-HIVE-Build-3889 >> 212K PreCommit-HIVE-Build-3880 >> 188KPreCommit-HIVE-Build-3901 >> 156KPreCommit-HIVE-Build-3885 >> 148KPreCommit-HIVE-Build-3884 >> 96K PreCommit-HIVE-Build-3882 >> 88K

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

2017-03-10 Thread Vihang Karajgaonkar
.org/r/57503/ > --- > > (Updated March 10, 2017, 10:36 a.m.) > > > Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang > Karajgaonkar. > > > Repository: hive-git > > > Description > --- > > HIVE-16024: MSCK Repair Requires nonstr

Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver

2017-03-07 Thread Vihang Karajgaonkar
eviews.apache.org/r/57343/#comment240317> Not sure I understand this file.. - Vihang Karajgaonkar On March 7, 2017, 3:14 p.m., Peter Vary wrote: > > --- > This is an automatically gene

Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

2017-04-18 Thread Vihang Karajgaonkar
6b217516bc74c612348b8edeca077dfbdbdb1a40 Diff: https://reviews.apache.org/r/58516/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Re: ptest not running?

2017-04-24 Thread Vihang Karajgaonkar
I see that builds are getting picked up at https://builds.apache.org/ job/PreCommit-HIVE-Build/ The PTest server was restarted a couple of days back. If you had a patch in the queue around that time, may be it was lost due to restart. You may have to re-attach the patch on the upstream JIRA if

Re: [ANNOUNCE] New PMC Member : Matt McCline

2017-07-07 Thread Vihang Karajgaonkar
Congratulations Matt! On Fri, Jul 7, 2017 at 9:27 AM, Xuefu Zhang wrote: > Congratulations! > > On Fri, Jul 7, 2017 at 8:27 AM, Eugene Koifman > wrote: > > > Congratulations! > > > > On 7/7/17, 1:04 AM, "Zoltan Haindrich" >

Re: how to use vectorizedparquetrecordreader

2017-07-17 Thread Vihang Karajgaonkar
Parquet vectorization support was added in 2.2.0. In order to enable it you should set hive.vectorized.execution.enabled=true. Following other configs are also relevant for vectorization and you should have them enabled as well. hive.vectorized.use.vector.serde.deserialize=true;

Re: Review Request 60445: HIVE-16935: Hive should strip comments from input before choosing which CommandProcessor to run.

2017-07-06 Thread Vihang Karajgaonkar
src/test/org/apache/hive/common/util/TestHiveStringUtils.java Lines 112 (patched) <https://reviews.apache.org/r/60445/#comment254672> nit, spellcheck comments - Vihang Karajgaonkar On July 5, 2017, 6:09 p.m., Andrew Sherman wrote: > > --

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-06 Thread Vihang Karajgaonkar
I can understand the concerns from Edward and Xuefu and I think they are valid as well. I think having a regular cadence of release will help alleviate the concerns related to features making into releases to a certain extent. Having quarterly or semi-annual releases would be a good thing in

Re: [Announce] New committer: Vihang Karajgaonkar

2017-07-08 Thread Vihang Karajgaonkar
ations Vihang! > > > > > > > > > > > > On 7/7/17, 10:47 AM, "Vineet Garg" <vg...@hortonworks.com> > wrote: > > > > > > > > > > > > >Congratulations Vihang! > > > > > > &g

Re: Review Request 61041: HIVE-17150: CREATE INDEX execute HMS out-of-transaction listener calls inside a transaction

2017-07-24 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61041/#review181268 --- Ship it! Ship It! - Vihang Karajgaonkar On July 21, 2017, 5

Re: [DISCUSS] Separating out the metastore as its own TLP

2017-07-24 Thread Vihang Karajgaonkar
Before we see a flood of name suggestions :) Why not just keep it Metastore? Its already well-known in the community and easy to relate to. On Mon, Jul 24, 2017 at 2:13 PM, Alan Gates wrote: > In the same vein Carter and Gunther suggested Omegastore. Pick your > alphabet

Re: Review Request 60589: HIVE-17001: Insert overwrite table doesn't clean partition directory on HDFS if partition is missing from HMS

2017-07-05 Thread Vihang Karajgaonkar
o fail on a external table. The behavior of external table is inconsistent in my opinion. We allow it to be overwritten but not truncated. When the table is a managed table, the test works as expected since Hive cleans up the directory after drop partition command. - Vihang Karajg

Re: ptest not running?

2017-04-25 Thread Vihang Karajgaonkar
I see some builds queued up on the pre-commit job. Were these submitted manually? On Tue, Apr 25, 2017 at 2:00 PM, Thejas Nair <thejas.n...@gmail.com> wrote: > Thanks for the update Vihang! > > > On Tue, Apr 25, 2017 at 12:54 PM, Vihang Karajgaonkar <vih...@clo

Re: ptest not running?

2017-04-26 Thread Vihang Karajgaonkar
m. Either submitting patch in > JIRA or manual build could not trigger the tests. > > On Tue, Apr 25, 2017 at 11:31 PM, Eugene Koifman <ekoif...@hortonworks.com > > > wrote: > > > I see HIVE-16445 in it – it was picked up automatically > > > > On 4/25/17, 5:44 PM

  1   2   3   4   5   6   >