Review Request 51006: CBO: Return path - Fix for converting GroupBy operator with no map side group by

2016-08-11 Thread Vineet Garg
ql/src/test/results/clientpositive/spark/groupby_ppr_multi_distinct.q.out 5251241 ql/src/test/results/clientpositive/tez/count.q.out 9fc2c75 Diff: https://reviews.apache.org/r/51006/diff/ Testing --- Added new tests and Pre-commit testing Thanks, Vineet Garg

Re: Review Request 51006: CBO: Return path - Fix for converting GroupBy operator with no map side group by

2016-08-12 Thread Vineet Garg
Thanks, Vineet Garg

Re: [ANNOUNCE] New PMC Member : Pengcheng

2016-07-18 Thread Vineet Garg
Congrats Pengcheng ! On 7/18/16, 5:39 PM, "Chaoyu Tang" wrote: >Congratulations, Pengcheng! > >On Mon, Jul 18, 2016 at 2:39 PM, Pengcheng Xiong wrote: > >> Thanks for everyone. I feel really excited. Wish to contribute more and >> more to the

Re: [ANNOUNCE] New PMC Member : Jesus

2016-07-18 Thread Vineet Garg
Congrats Jesus ! On 7/18/16, 10:27 AM, "Jesus Camacho Rodriguez" wrote: >Thanks everybody! Looking forward to continue contributing to the project! > >-- >Jesús > > > > >On 7/18/16, 6:21 PM, "Prasanth Jayachandran" >wrote:

Review Request 50904: CBO: Return path - Fix for wrong group by plan when map side group by is turned off

2016-08-08 Thread Vineet Garg
Diff: https://reviews.apache.org/r/50904/diff/ Testing --- Added new tests and ran existing tests Thanks, Vineet Garg

Review Request 55952: HIVE-15721 Allow IN/NOT IN correlated subquery with aggregates

2017-01-25 Thread Vineet Garg
--- * Added positive and negative tests. * Pre-commit testing Thanks, Vineet Garg

Re: Review Request 55952: HIVE-15721 Allow IN/NOT IN correlated subquery with aggregates

2017-01-25 Thread Vineet Garg
/clientpositive/spark/subquery_in.q.out 37a6617 Diff: https://reviews.apache.org/r/55952/diff/ Testing --- * Added positive and negative tests. * Pre-commit testing Thanks, Vineet Garg

Review Request 56686: HIVE-15905: Inefficient plan for correlated subqueries

2017-02-14 Thread Vineet Garg
/diff/ Testing --- * Updated existing tests * Pre-commit testing Thanks, Vineet Garg

Re: Review Request 55553: HIVE-15544 Support for scalar subqueries in filter (WHERE/HAVING)

2017-01-18 Thread Vineet Garg
/subquery_in_having.q.out 125187a ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 6e1cc1a Diff: https://reviews.apache.org/r/3/diff/ Testing --- Added q tests Thanks, Vineet Garg

Re: Review Request 55553: HIVE-15544 Support for scalar subqueries in filter (WHERE/HAVING)

2017-01-19 Thread Vineet Garg
> add gby ? this was remove because of same reason as above - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3/#review162239 -

Re: Review Request 55553: HIVE-15544 Support for scalar subqueries in filter (WHERE/HAVING)

2017-01-19 Thread Vineet Garg
/subquery_unqualcolumnrefs.q.out 1eb1b93 Diff: https://reviews.apache.org/r/3/diff/ Testing --- Added q tests Thanks, Vineet Garg

Review Request 51226: HIVE-14522: Remove support for hive.outerjoin.supports.filter

2016-08-18 Thread Vineet Garg
-commit testing Thanks, Vineet Garg

Review Request 51582: HIVE-12806: Use fully qualified name for table alias

2016-09-01 Thread Vineet Garg
735e4f4 ql/src/test/results/clientpositive/vector_auto_smb_mapjoin_14.q.out 9837b26 Diff: https://reviews.apache.org/r/51582/diff/ Testing --- Added test Pre-commit testing Thanks, Vineet Garg

Review Request 51355: Bypass CBO return path for hive.test.mode

2016-08-23 Thread Vineet Garg
/queries/clientpositive/input30.q 7859bbc ql/src/test/results/clientpositive/input30.q.out e728f04 Diff: https://reviews.apache.org/r/51355/diff/ Testing --- * Updated texisting test to add a new test * Pre-commit testing Thanks, Vineet Garg

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-04 Thread Vineet Garg
/groupby_rollup1.q.out 15d6c23 ql/src/test/results/clientpositive/vector_grouping_sets.q.out 4207c19 Diff: https://reviews.apache.org/r/53328/diff/ Testing --- Updated exsting tests to use new ROLLUP and CUBE syntax in addition to non-standard syntax. Thanks, Vineet Garg

Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests

2016-10-18 Thread Vineet Garg
/alter_merge_orc.q.out b5a6d04 ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd ql/src/test/results/clientpositive/vectorization_0.q.out ac33721 Diff: https://reviews.apache.org/r/52708/diff/ Testing --- Pre-commit testing Thanks, Vineet Garg

Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests

2016-10-18 Thread Vineet Garg
------ On Oct. 18, 2016, 5:46 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52708/ > ---

Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests

2016-10-18 Thread Vineet Garg
ile1530006line240> > > > > Repeated tests. Thanks for catching these - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52708/#review153119 -----

Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests

2016-10-18 Thread Vineet Garg
/vectorization_0.q.out ac33721 Diff: https://reviews.apache.org/r/52708/diff/ Testing --- Pre-commit testing Thanks, Vineet Garg

Re: Hive compile and run information

2016-10-21 Thread Vineet Garg
Accidentally hit sent before completing message. Also I find hiveconf datanucleus.schema.autoCreateTables=true useful while starting server to automatically setup metastore schema. Vineet On 10/21/16, 1:38 PM, "Vineet Garg" <vg...@hortonworks.com> wrote: >Hi Arun, >

Re: Hive compile and run information

2016-10-21 Thread Vineet Garg
Hi Arun, Getting Started wiki page has some info on how to do that https://cwiki.apache.org/confluence/display/Hive/GettingStarted#GettingStarted-RunningHive Try starting hiveserver using hiveconf hive.root.logger=DEBUG,console to dump debug logs on console. Also I find Vineet On

Review Request 53328: Support for standard ROLLUP syntax

2016-10-31 Thread Vineet Garg
/vector_grouping_sets.q.out 8e55ce3 ql/src/test/results/clientpositive/vector_grouping_sets.q.out 4207c19 Diff: https://reviews.apache.org/r/53328/diff/ Testing --- Updated exsting tests to use new ROLLUP syntax in addition to non-standard syntax. Thanks, Vineet Garg

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-03 Thread Vineet Garg
be a better approach but I am unable to figure out how to write new rule in such a way. - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53328/#review154349 --

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-03 Thread Vineet Garg
/vector_grouping_sets.q.out 4207c19 Diff: https://reviews.apache.org/r/53328/diff/ Testing (updated) --- Updated exsting tests to use new ROLLUP and CUBE syntax in addition to non-standard syntax. Thanks, Vineet Garg

Re: Review Request 53328: Support for standard ROLLUP syntax

2016-11-03 Thread Vineet Garg
ROLLUP and CUBE syntax in addition to non-standard syntax. Thanks, Vineet Garg

Review Request 52708: HIVE-14913 Moved system tests to unit tests

2016-10-10 Thread Vineet Garg
/spark/alter_merge_orc.q.out b5a6d04 ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd ql/src/test/results/clientpositive/vectorization_0.q.out ac33721 Diff: https://reviews.apache.org/r/52708/diff/ Testing --- Pre-commit testing Thanks, Vineet Garg

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-10 Thread Vineet Garg
/clientpositive/vector_groupby_mapjoin.q.out 3468657 ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out 160b088 Diff: https://reviews.apache.org/r/54517/diff/ Testing --- * Added new tests. * Pre-commit testing on-going Thanks, Vineet Garg

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-15 Thread Vineet Garg
line 82 > > <https://reviews.apache.org/r/54517/diff/3/?file=1582083#file1582083line82> > > > > Each HiveFilter will be visited by RelShuttle. Why do we need to > > traverse the tree here? > > Vineet Garg wrote: > RelShuttle is used by decorrelation logic b

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-15 Thread Vineet Garg
/clientpositive/vector_groupby_mapjoin.q.out 3468657 ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out 160b088 Diff: https://reviews.apache.org/r/54517/diff/ Testing --- * Added new tests. * Pre-commit testing on-going Thanks, Vineet Garg

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-14 Thread Vineet Garg
es are called after decorrelation. Let me see if these rules are already called from Calcite planner, if so we can get rid of these rules > On Dec. 13, 2016, 1:51 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/Hi

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-12 Thread Vineet Garg
/clientpositive/vector_mapjoin_reduce.q.out 160b088 Diff: https://reviews.apache.org/r/54517/diff/ Testing --- * Added new tests. * Pre-commit testing on-going Thanks, Vineet Garg

Re: Review Request 55148: HIVE-15481: Support for multiple and nested subqueries

2017-01-09 Thread Vineet Garg
nd replace with RelBuilder once calcite 1.11 is released. - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55148/#review160893 ------- On Jan. 6, 2017, 11:54 p.m., Vineet Garg wrote: > > ---

Re: Review Request 53983: HIVE-14582 : Add trunc(numeric) udf

2016-11-30 Thread Vineet Garg
) <https://reviews.apache.org/r/53983/#comment228064> I think it'll be good to add tests with negative numbers as well as no-op (e.g. select trunc (12.34, 100). - Vineet Garg On Nov. 30, 2016, 7:04 p.m., Chinna Rao Lalam

Re: Review Request 55148: HIVE-15481: Support for multiple and nested subqueries

2017-01-06 Thread Vineet Garg
://reviews.apache.org/r/55148/diff/ Testing --- *Added new tests *Verfied result correctness with postgress (manually) *Pre-commit testing Thanks, Vineet Garg

Review Request 55148: HIVE-15481: Support for multiple and nested subqueries

2017-01-03 Thread Vineet Garg
/subquery_notin_having.q.out 9f72cc9 ql/src/test/results/clientpositive/vector_groupby_mapjoin.q.out af42e41 Diff: https://reviews.apache.org/r/55148/diff/ Testing --- *Added new tests *Verfied result correctness with postgress (manually) *Pre-commit testing Thanks, Vineet Garg

Re: Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-07 Thread Vineet Garg
/results/clientpositive/vector_groupby_mapjoin.q.out 3468657 ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out 160b088 Diff: https://reviews.apache.org/r/54517/diff/ Testing --- * Added new tests. * Pre-commit testing on-going Thanks, Vineet Garg

Review Request 54517: HIVE-15192: Subquery support with Calcite

2016-12-07 Thread Vineet Garg
/vector_groupby_mapjoin.q.out 3468657 ql/src/test/results/clientpositive/vector_mapjoin_reduce.q.out 160b088 Diff: https://reviews.apache.org/r/54517/diff/ Testing --- * Added new tests. * Pre-commit testing on-going Thanks, Vineet Garg

Review Request 55553: HIVE-15544 Support for scalar subqueries in filter (WHERE/HAVING)

2017-01-15 Thread Vineet Garg
/src/test/results/clientpositive/perf/query81.q.out PRE-CREATION Diff: https://reviews.apache.org/r/3/diff/ Testing --- Added q tests Thanks, Vineet Garg

Review Request 57862: HIVE-16229 Fix for wrong result

2017-03-22 Thread Vineet Garg
/clientpositive/perf/query30.q.out 3bb4f81 ql/src/test/results/clientpositive/perf/query6.q.out ca17206 ql/src/test/results/clientpositive/perf/query81.q.out 25bd68e Diff: https://reviews.apache.org/r/57862/diff/1/ Testing --- Added negative test Updated existing tests Thanks, Vineet Garg

Review Request 58004: HIVE-16228: Support for subqueries in complex expressions in SELECT

2017-03-28 Thread Vineet Garg
/clientpositive/llap/subquery_select.q.out 6fb253b ql/src/test/results/clientpositive/perf/query9.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58004/diff/1/ Testing --- Added more positive and negative test cases Pre-commit testing Thanks, Vineet Garg

Re: Review Request 57518: HIVE-16091 Support subqueries in select

2017-03-14 Thread Vineet Garg
/subquery_select.q.out PRE-CREATION Diff: https://reviews.apache.org/r/57518/diff/4/ Changes: https://reviews.apache.org/r/57518/diff/3-4/ Testing --- Added new tests Done pre-commit testing Pending: More tests Thanks, Vineet Garg

Re: Review Request 57518: HIVE-16091 Support subqueries in select

2017-03-14 Thread Vineet Garg
ically generated e-mail. To reply, visit: https://reviews.apache.org/r/57518/#review168654 ------- On March 14, 2017, 5:05 a.m., Vineet Garg wrote: > > --- &g

Re: [ANNOUNCE] New PMC Member : Eugene Koifman

2017-03-15 Thread Vineet Garg
Congrats Eugene. > On Mar 14, 2017, at 10:39 PM, Ashutosh Chauhan wrote: > > On behalf of the Hive PMC I am delighted to announce Eugene Koifman is > joining Hive PMC. > Eugene is a long time contributor in Hive and is focusing on ACID support > areas these days. > >

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-04 Thread Vineet Garg
: https://reviews.apache.org/r/58181/diff/1-2/ Testing --- Added new tests Pre-commit testing Thanks, Vineet Garg

Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-04 Thread Vineet Garg
/llap/is_distinct_from.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58181/diff/1/ Testing --- Added new tests Pre-commit testing Thanks, Vineet Garg

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-11 Thread Vineet Garg
https://reviews.apache.org/r/58181/diff/5/ Changes: https://reviews.apache.org/r/58181/diff/4-5/ Testing --- Added new tests Pre-commit testing Thanks, Vineet Garg

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-06 Thread Vineet Garg
utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171246 --- On April 6, 2017, 8:02 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-06 Thread Vineet Garg
good to not add extra tokens in grammar as it increases the > > size of state machine. How about: > > > > > > KW_IS (a=KW_NOT)? KW_DISTINCT KW_FROM > > -> {$a !=null}? ^(EQUAL_NS) > > -> ^(KW_NOT EQUAL_NS) > > Vinee

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-05 Thread Vineet Garg
/clientpositive/show_functions.q.out 68e248a ql/src/test/results/clientpositive/udf_equal.q.out 52bd843 Diff: https://reviews.apache.org/r/58181/diff/4/ Changes: https://reviews.apache.org/r/58181/diff/3-4/ Testing --- Added new tests Pre-commit testing Thanks, Vineet Garg

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-05 Thread Vineet Garg
nerated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171125 ------- On April 4, 2017, 11:05 p.m., Vineet Garg wrote: > > --- > This i

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-12 Thread Vineet Garg
/clientpositive/llap/join_is_not_distinct_from.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58181/diff/6/ Changes: https://reviews.apache.org/r/58181/diff/5-6/ Testing --- Added new tests Pre-commit testing Thanks, Vineet Garg

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-12 Thread Vineet Garg
m not sure why our UDF lookup is based on text. Lookup based on AST token type would be much better. - Vineet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review17176

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-13 Thread Vineet Garg
/clientpositive/llap/join_is_not_distinct_from.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58181/diff/7/ Changes: https://reviews.apache.org/r/58181/diff/6-7/ Testing --- Added new tests Pre-commit testing Thanks, Vineet Garg

Re: Review Request 57518: HIVE-16091 Support subqueries in select

2017-03-12 Thread Vineet Garg
://reviews.apache.org/r/57518/diff/2/ Changes: https://reviews.apache.org/r/57518/diff/1-2/ Testing --- Added new tests Done pre-commit testing Pending: More tests Thanks, Vineet Garg

Review Request 57518: HIVE-16091 Support subqueries in select

2017-03-10 Thread Vineet Garg
Pending: More tests Thanks, Vineet Garg

Re: Review Request 57518: HIVE-16091 Support subqueries in select

2017-03-13 Thread Vineet Garg
://reviews.apache.org/r/57518/diff/3/ Changes: https://reviews.apache.org/r/57518/diff/2-3/ Testing --- Added new tests Done pre-commit testing Pending: More tests Thanks, Vineet Garg

Re: Review Request 58181: HIVE-15986 Support for 'is [NOT] distinct from'

2017-04-05 Thread Vineet Garg
, Vineet Garg

Review Request 61625: HIVE-17308 Improvement in join cardinality estimation

2017-08-14 Thread Vineet Garg
/TestCBORuleFiredOnlyOnce.java 884e034731 Diff: https://reviews.apache.org/r/61625/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 61625: HIVE-17308 Improvement in join cardinality estimation

2017-08-14 Thread Vineet Garg
/clientpositive/spark/join_cond_pushdown_4.q.out 9c3aed8932 Diff: https://reviews.apache.org/r/61625/diff/2/ Changes: https://reviews.apache.org/r/61625/diff/1-2/ Testing --- Thanks, Vineet Garg

Re: [Announce] New committer: Vihang Karajgaonkar

2017-07-07 Thread Vineet Garg
Congratulations Vihang! > On Jul 5, 2017, at 5:51 PM, Ashutosh Chauhan wrote: > > The Project Management Committee (PMC) for Apache Hive has invited Vihang > Karajgaonkar to become a committer and we are pleased to announce that he > has accepted. > > Welcome, Vihang! >

Re: [Announce] New committer: Teddy Choi

2017-07-07 Thread Vineet Garg
Congratulations! > On Jul 7, 2017, at 10:25 AM, Gunther Hagleitner > wrote: > > Congrats Teddy! > > From: Xuefu Zhang > Sent: Friday, July 07, 2017 9:26 AM > To: dev@hive.apache.org > Subject: Re:

Re: [Announce] New committer: Peter Vary

2017-07-07 Thread Vineet Garg
Congrats Peter! > On Jul 7, 2017, at 9:27 AM, Xuefu Zhang wrote: > > Congratulations! > > On Fri, Jul 7, 2017 at 4:17 AM, Adam Szita wrote: > >> Congrats all! >> >> On 7 July 2017 at 10:03, Zoltan Haindrich >> wrote: >> >>>

Re: [ANNOUNCE] New PMC Member : Matt McCline

2017-07-07 Thread Vineet Garg
Congrats Matt! > On Jul 7, 2017, at 9:57 AM, Vihang Karajgaonkar wrote: > > Congratulations Matt! > > On Fri, Jul 7, 2017 at 9:27 AM, Xuefu Zhang wrote: > >> Congratulations! >> >> On Fri, Jul 7, 2017 at 8:27 AM, Eugene Koifman

Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

2017-07-10 Thread Vineet Garg
://reviews.apache.org/r/60757/diff/1/ Testing --- Updated existing tests Thanks, Vineet Garg

Review Request 60885: HIVE-15758 Allow correlated scalar subqueries with aggregates which has non-equi join predicates

2017-07-14 Thread Vineet Garg
, Vineet Garg

Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-07-26 Thread Vineet Garg
://reviews.apache.org/r/61165/diff/1/ Testing --- * Updated existing tests * Added new test Thanks, Vineet Garg

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

2017-07-11 Thread Vineet Garg
/clientpositive/spark/annotate_stats_join.q.out d09bc52155 ql/src/test/results/clientpositive/tez/explainanalyze_4.q.out 14535f63da Diff: https://reviews.apache.org/r/60757/diff/2/ Changes: https://reviews.apache.org/r/60757/diff/1-2/ Testing --- Updated existing tests Thanks, Vineet Garg

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

2017-07-11 Thread Vineet Garg
d09bc52155 ql/src/test/results/clientpositive/tez/explainanalyze_4.q.out 14535f63da Diff: https://reviews.apache.org/r/60757/diff/3/ Changes: https://reviews.apache.org/r/60757/diff/2-3/ Testing --- Updated existing tests Thanks, Vineet Garg

Re: Review Request 60349: Scalar sub-query: sq_count_check not required if gby keys are constant

2017-07-12 Thread Vineet Garg
/ Testing --- -Pre-commit testing - new tests Thanks, Vineet Garg

Re: Review Request 60757: HIVE-17066: Better estimation for number of nulls for outer join

2017-07-11 Thread Vineet Garg
eviews.apache.org/r/60757/#review180251 --- On July 11, 2017, 10:07 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-27 Thread Vineet Garg
eviews.apache.org/r/59984/#review179052 --- On June 26, 2017, 8:41 p.m., Vineet Garg wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-27 Thread Vineet Garg
/results/clientpositive/vector_mapjoin_reduce.q.out 0ff11df8a3 Diff: https://reviews.apache.org/r/59984/diff/3/ Changes: https://reviews.apache.org/r/59984/diff/2-3/ Testing --- * Added new tests * Pre-commit testing Thanks, Vineet Garg

Re: Review Request 61165: HIVE-16811 Estimate statistics in absence of stats

2017-08-08 Thread Vineet Garg
new test Thanks, Vineet Garg

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Vineet Garg
> On May 2, 2017, 6:35 p.m., Vineet Garg wrote: > > ql/src/test/queries/clientpositive/semijoin_hint.q > > Line 38 (original), 38 (patched) > > <https://reviews.apache.org/r/58914/diff/1/?file=1705394#file1705394line38> > > > > Why is returnpath on

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Vineet Garg
14/#comment246546> Why is returnpath on? This feature is not yet fully developed/supported and is off by default. You might want to try the same queries with this feature off. - Vineet Garg On May 2, 2017, 5

Re: [Announce] New committer: Vineet Garg

2017-05-12 Thread Vineet Garg
; >> -- Lefty >> >> >> On Wed, May 10, 2017 at 2:08 PM, Vineet Garg <vg...@hortonworks.com> >> wrote: >> >>> Thanks all! >>> >>>> On May 10, 2017, at 12:47 AM, Rui Li <lirui.fu...@gmail.com> wr

Re: [Announce] New committer: Vineet Garg

2017-05-10 Thread Vineet Garg
uot; < >> jcama...@apache.org<mailto:jcama...@apache.org>> wrote: >> >> >> Congrats Vineet! Well deserved! >> >> -- >> Jesús >> >> >> >> >> >> On 5/10/17, 6:45 AM, "Peter Vary" wrote: >> >>> Con

Re: Review Request 43834: Support view column authorization

2017-05-17 Thread Vineet Garg
Access. Note that we do not even use the plan after RelTrimmer's column pruning. We discard it and only use columnAccessInfo. Your help will be much appreciated. -Vineet - Vineet Garg On Feb. 24, 2016, 7:44 a.m., pengcheng xiong

Re: [Announce] New committer: Vineet Garg

2017-05-09 Thread Vineet Garg
Thanks all! Looking forward to contributing more to Hive. Vineet Garg > On May 9, 2017, at 4:43 PM, Vihang Karajgaonkar <vih...@cloudera.com> wrote: > > Congrats Vineet! > > On Tue, May 9, 2017 at 4:29 PM, Sergey Shelukhin <ser...@hortonworks.com> > wrote: >

Review Request 59117: HIVE-16330 Optimization for scalar aggregates with no group by and no windowing

2017-05-09 Thread Vineet Garg
/subquery_scalar_corr_multi_rows.q.out 3235048f74 ql/src/test/results/clientpositive/llap/subquery_scalar.q.out b2b5458c00 ql/src/test/results/clientpositive/llap/subquery_select.q.out 8eaec9e567 Diff: https://reviews.apache.org/r/59117/diff/1/ Testing --- Thanks, Vineet Garg

Review Request 60349: Scalar sub-query: sq_count_check not required if gby keys are constant

2017-06-21 Thread Vineet Garg
.q.out 03fff79951 Diff: https://reviews.apache.org/r/60349/diff/1/ Testing --- -Pre-commit testing - new tests Thanks, Vineet Garg

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-21 Thread Vineet Garg
> > Seems like this if branch is unnecessary. > > Vineet Garg wrote: > I don't think so, most of the calcite code/ hive rules implement > RelShuttle interface. So accept should reroute accordingly > > Ashutosh Chauhan wrote: > Its unnecessary in sense tha

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-21 Thread Vineet Garg
rn, otherwise it traveses all its children. Changing the intial flag to true will entail negating this logic and will anyway keep all the code/cases. - Vineet --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-26 Thread Vineet Garg
/vector_mapjoin_reduce.q.out 0ff11df8a3 Diff: https://reviews.apache.org/r/59984/diff/2/ Changes: https://reviews.apache.org/r/59984/diff/1-2/ Testing --- * Added new tests * Pre-commit testing Thanks, Vineet Garg

Re: Review Request 60349: Scalar sub-query: sq_count_check not required if gby keys are constant

2017-06-26 Thread Vineet Garg
/clientpositive/perf/query58.q.out 5b37f36386 ql/src/test/results/clientpositive/perf/query6.q.out 03fff79951 Diff: https://reviews.apache.org/r/60349/diff/2/ Changes: https://reviews.apache.org/r/60349/diff/1-2/ Testing --- -Pre-commit testing - new tests Thanks, Vineet Garg

Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-11 Thread Vineet Garg
://reviews.apache.org/r/59984/diff/1/ Testing --- * Added new tests * Pre-commit testing Thanks, Vineet Garg

Re: Welcome Rui Li to Hive PMC

2017-05-25 Thread Vineet Garg
Congrats Rui! > On May 24, 2017, at 9:19 PM, Xuefu Zhang wrote: > > Hi all, > > It's an honer to announce that Apache Hive PMC has recently voted to invite > Rui Li as a new Hive PMC member. Rui is a long time Hive contributor and > committer, and has made significant

Re: Jimmy Xiang now a Hive PMC member

2017-05-25 Thread Vineet Garg
Congrats Jimmy! > On May 24, 2017, at 9:16 PM, Xuefu Zhang wrote: > > Hi all, > > It's an honer to announce that Apache Hive PMC has recently voted to invite > Jimmy Xiang as a new Hive PMC member. Please join me in congratulating him > and looking forward to a bigger role

Review Request 62392: HIVE-17535: Support CBO for queries without source table

2017-09-18 Thread Vineet Garg
/results/clientpositive/udtf_stack.q.out 97dcd3a1cd ql/src/test/results/clientpositive/vector_tablesample_rows.q.out 283762a3eb Diff: https://reviews.apache.org/r/62392/diff/1/ Testing --- Updated existing tests Thanks, Vineet Garg

Review Request 62424: HIVE-17536 StatsUtil::getBasicStatForTable doesn't distinguish b/w absence of statistics or zero stats

2017-09-19 Thread Vineet Garg
/clientpositive/udf_trunc_number.q.out dfc9d700e9 Diff: https://reviews.apache.org/r/62424/diff/1/ Testing --- Updated existing tests. Thanks, Vineet Garg

Re: Review Request 62424: HIVE-17536 StatsUtil::getBasicStatForTable doesn't distinguish b/w absence of statistics or zero stats

2017-09-19 Thread Vineet Garg
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62424/#review185757 ------- On Sept. 19, 2017, 11:46 p.m., Vineet Garg wrote: > > --

Review Request 62525: HIVE-17538 Enhance estimation of stats to estimate even if only one column is missing stats

2017-09-23 Thread Vineet Garg
--- Updated existing q files Thanks, Vineet Garg

Re: Review Request 62309: HIVE-17465 Fix filters cardinality for AND predicates

2017-09-17 Thread Vineet Garg
c0186082df ql/src/test/results/clientpositive/vectorization_7.q.out 218d307915 Diff: https://reviews.apache.org/r/62309/diff/3/ Changes: https://reviews.apache.org/r/62309/diff/2-3/ Testing --- * Added new tests * Updated existing tests Thanks, Vineet Garg

Review Request 62309: HIVE-17465 Fix filters cardinality for AND predicates

2017-09-13 Thread Vineet Garg
/vectorization_7.q.out 218d307915 Diff: https://reviews.apache.org/r/62309/diff/1/ Testing --- * Added new tests * Updated existing tests Thanks, Vineet Garg

Review Request 62310: HIVE-17493 Improve PKFK cardinality estimation in Physical planning

2017-09-13 Thread Vineet Garg
://reviews.apache.org/r/62310/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 62309: HIVE-17465 Fix filters cardinality for AND predicates

2017-09-13 Thread Vineet Garg
--- * Added new tests * Updated existing tests Thanks, Vineet Garg

Re: Review Request 62392: HIVE-17535: Support CBO for queries without source table

2017-09-18 Thread Vineet Garg
://reviews.apache.org/r/62392/diff/1-2/ Testing --- Updated existing tests Thanks, Vineet Garg

Re: Review Request 62309: HIVE-17465 Fix filters cardinality for AND predicates

2017-09-14 Thread Vineet Garg
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62309/#review185348 ------- On Sept. 14, 2017, 12:02 a.m., Vineet Garg wrote: > > --- > This is an automatically gen

Review Request 62827: HIVE-17553 CBO wrongly type cast decimal literal to int

2017-10-07 Thread Vineet Garg
/vectorized_math_funcs.q.out d276921d1e Diff: https://reviews.apache.org/r/62827/diff/1/ Testing --- Thanks, Vineet Garg

Re: Review Request 62728: Fix for Explain plan not working

2017-10-02 Thread Vineet Garg
da76c3ca28 Diff: https://reviews.apache.org/r/62728/diff/2/ Changes: https://reviews.apache.org/r/62728/diff/1-2/ Testing --- Thanks, Vineet Garg

  1   2   3   4   5   >