Review Request 68496: Optimized & cleaned up HBaseQTest runner

2018-08-24 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68496/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-20394

Re: Review Request 68496: Optimized & cleaned up HBaseQTest runner

2018-08-24 Thread denys kuzmenko via Review Board
> On Aug. 24, 2018, 8:17 a.m., Peter Vary wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java > > Line 82 (original), 82 (patched) > > > > > > Since we removed

Re: Review Request 68518: ProxyFileSystem.listStatusIterator function override required once migrated to Hadoop 3.2.0+

2018-08-28 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68518/ --- (Updated Aug. 28, 2018, 11:34 a.m.) Review request for hive, Marta Kuczora and

Re: Review Request 68496: Optimized & cleaned up HBaseQTest runner

2018-08-28 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68496/ --- (Updated Aug. 28, 2018, 11:33 a.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

2018-08-28 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68523/ --- (Updated Aug. 28, 2018, 1:50 p.m.) Review request for hive, Marta Kuczora,

Review Request 68518: ProxyFileSystem.listStatusIterator function override required once migrated to Hadoop 3.2.0+

2018-08-27 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68518/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-20465

Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

2018-08-27 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68523/ --- Review request for hive, Marta Kuczora and Peter Vary. Bugs: HIVE-20466

Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-11 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- Review request for hive, Zoltan Haindrich, Zoltan Haindrich, and Peter Vary.

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-15 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- (Updated Oct. 15, 2018, 7:21 p.m.) Review request for hive, Sahil Takiar and

Review Request 69022: HIVE-20737: LocalHiveSparkClient.close() and SparkSession.open() race condition fix

2018-10-15 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- Review request for hive, Sahil Takiar and Adam Szita. Bugs: HIVE-20737

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-18 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 125 (original), 120 (patched) > > > > > > we might need to re-think how

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > > Line 73 (original), 73 (patched) > > > > > > if we expect multiple sessions to

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- (Updated Oct. 16, 2018, 4:49 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 125 (original), 120 (patched) > > > > > > we might need to re-think how

Re: Review Request 69022: HIVE-20737: SparkContext is shared between user sessions and should be closed only when there is no active one

2018-10-15 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ --- (Updated Oct. 15, 2018, 4:54 p.m.) Review request for hive, Sahil Takiar and

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > > Line 73 (original), 73 (patched) > > > > > > if we expect multiple sessions to

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Lines 112-116 (original) > > > > > > do we have unit tests that cover this? >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Lines 112-116 (original) > > > > > > do we have unit tests that cover this? >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-16 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-26 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210088 --- Ship it! Ship It! - Denys Kuzmenko On Oct. 26, 2018, 10:34

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-25 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210044 ---

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-25 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210045 ---

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-25 Thread Denys Kuzmenko via Review Board
> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > > Lines 1172 (patched) > > > > > >

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-25 Thread Denys Kuzmenko via Review Board
> On Oct. 25, 2018, 10:46 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java > > Lines 1172 (patched) > > > > > >

Re: Review Request 69167: HIVE-20796: jdbc URL can contain sensitive information that should not be logged

2018-10-25 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69167/#review210059 ---

Re: Review Request 69022: HIVE-20737: Local SparkContext is shared between user sessions and should be closed only when there is no active

2018-10-18 Thread denys kuzmenko via Review Board
> On Oct. 16, 2018, 1:47 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > > Line 352 (original) > > > > > > why remove this? > > denys kuzmenko wrote: >

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

2018-11-15 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210568 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

2018-11-15 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210569 ---

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

2018-11-15 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210570 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

2018-11-15 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210571 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Line

Re: Review Request 69341: HIVE-20891: Call alter_partition in batch when dynamically loading partitions

2018-11-15 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210572 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 68895: HadoopVer was ignored in QTestUtil

2018-10-05 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68895/ --- (Updated Oct. 5, 2018, 10 a.m.) Review request for hive, Zoltan Haindrich and

Review Request 68960: Race Condition when Multi-Threading in SessionState.createRootHDFSDir

2018-10-09 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68960/ --- Review request for hive, Jason Dere and Peter Vary. Bugs: HIVE-20711

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-10-01 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Oct. 1, 2018, 11:42 a.m.) Review request for hive, Zoltan Haindrich,

Review Request 68895: HadoopVer was ignored in QTestUtil

2018-10-02 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68895/ --- Review request for hive, Zoltan Haindrich and Peter Vary. Bugs: HIVE-20647

Re: Review Request 68767: HIVE-20551: Create PreparedStatement query dynamically when IN clause is used

2018-09-20 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68767/#review208827 ---

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-26 Thread denys kuzmenko via Review Board
> On Sept. 26, 2018, 11:47 a.m., Antal Sinkovits wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3062 (patched) > > > > > > Why is the default value -1? All the checks seems to go

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-26 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 26, 2018, 1:08 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-25 Thread denys kuzmenko via Review Board
> On Sept. 24, 2018, 11:14 p.m., Peter Vary wrote: > > Hi Denys, > > > > Could you please think a little about separating the Manager/Factory and > > the tryAcquire mess? > > > > Incomplete thoughts, but I had to run > > > > Thanks, and sorry :( > > Peter Please review new patch. Really

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-25 Thread denys kuzmenko via Review Board
> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > I'm not sure but I feel that it would be probably simpler to add something > > which covers some reentrant-s and semaphores. > > It feels like this lock handling is a littlebit scattered around...I think > > it would be better to have

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-25 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 25, 2018, 10:19 a.m.) Review request for hive, Zoltan

Re: Review Request 68474: HIVE-20440: Create better cache eviction policy for SmallTableCache

2018-09-20 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/#review208793 ---

Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

2019-01-21 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69801/ --- Review request for hive, Peter Vary and Vihang Karajgaonkar. Bugs: HIVE-21116

Re: Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

2019-01-21 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69801/ --- (Updated Jan. 21, 2019, 1:13 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69801: HADOOP_CREDSTORE_PASSWORD is not populated under yarn.app.mapreduce.am.admin.user.env

2019-01-21 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69801/ --- (Updated Jan. 21, 2019, 1:34 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-12 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/ --- (Updated Dec. 12, 2018, 3:31 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69560: HIVE-21035: Race condition in SparkUtilities#getSparkSession

2018-12-12 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69560/#review211237 --- Ship it! Ship It! - Denys Kuzmenko On Dec. 12, 2018, 3:13

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Denys Kuzmenko via Review Board
> On Dec. 11, 2018, 4:30 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java > > Lines 217 (patched) > > > > > > Do we need to do redact for the Spark config as well?

Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/ --- Review request for hive, Peter Vary and Vihang Karajgaonkar. Repository:

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/ --- (Updated Dec. 11, 2018, 12:43 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69432: HIVE-20964 Create a test that checks the level of the parallel compilation

2018-11-22 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69432/#review210800 --- Ship it! Ship It! - Denys Kuzmenko On Nov. 22, 2018, 3:19

Re: Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

2018-09-17 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68523/ --- (Updated Sept. 17, 2018, 3:24 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-17 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 17, 2018, 5:55 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-13 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 13, 2018, 8:18 p.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-19 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 19, 2018, 9:37 a.m.) Review request for hive, Zoltan Haindrich,

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-19 Thread denys kuzmenko via Review Board
> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 507 (original), 666 (patched) > > > > > > please don't make this method more visible; use

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-17 Thread denys kuzmenko via Review Board
> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > I'm not sure but I feel that it would be probably simpler to add something > > which covers some reentrant-s and semaphores. > > It feels like this lock handling is a littlebit scattered around...I think > > it would be better to have

Re: Review Request 68683: Add new configuration to set the size of the global compile lock

2018-09-17 Thread denys kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/ --- (Updated Sept. 17, 2018, 12:52 p.m.) Review request for hive, Zoltan