Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

2018-01-11 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 11, 2018, 12:54 p.m.) Review request for hive, Alan Gates, Marta

Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-11 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65075/ --- Review request for hive, Aihua Xu and Andrew Sherman. Bugs: HIVE-18426

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

2018-01-11 Thread Peter Vary via Review Board
> On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 350 (patched) > > > > > > I think we should catch

[jira] [Created] (HIVE-18442) HoS: No FileSystem for scheme: nullscan

2018-01-11 Thread Rui Li (JIRA)
Rui Li created HIVE-18442: - Summary: HoS: No FileSystem for scheme: nullscan Key: HIVE-18442 URL: https://issues.apache.org/jira/browse/HIVE-18442 Project: Hive Issue Type: Bug Components:

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

2018-01-11 Thread Adam Szita via Review Board
> On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 350 (patched) > > > > > > I think we should catch

[jira] [Created] (HIVE-18443) Ensure git gc finished in ptest prep phase before copying repo

2018-01-11 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18443: - Summary: Ensure git gc finished in ptest prep phase before copying repo Key: HIVE-18443 URL: https://issues.apache.org/jira/browse/HIVE-18443 Project: Hive Issue

Re: Review Request 63382: HIVE-17833: Publish split generation counters

2018-01-11 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63382/ --- (Updated Jan. 11, 2018, 10:17 p.m.) Review request for hive and Sergey

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-11 Thread Andrew Sherman via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65075/#review195255 --- common/src/java/org/apache/hadoop/hive/common/LogUtils.java

Re: Review Request 63382: HIVE-17833: Publish split generation counters

2018-01-11 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63382/#review195265 ---

Re: Review Request 63382: HIVE-17833: Publish split generation counters

2018-01-11 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63382/#review195264 ---

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-11 Thread kalyan kumar kalvagadda via Review Board
> On Jan. 11, 2018, 9:51 p.m., Andrew Sherman wrote: > > common/src/java/org/apache/hadoop/hive/common/LogUtils.java > > Lines 259 (patched) > > > > > > Does deleteAppender() call stop() internally? If so then can

[jira] [Created] (HIVE-18444) when creating transactional table make sure location has no data

2018-01-11 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18444: - Summary: when creating transactional table make sure location has no data Key: HIVE-18444 URL: https://issues.apache.org/jira/browse/HIVE-18444 Project: Hive

Re: Review Request 63382: HIVE-17833: Publish split generation counters

2018-01-11 Thread j . prasanth . j
> On Jan. 11, 2018, 10:47 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java > > Lines 306 (patched) > > > > > > In the context of triggers, we are more

Re: Review Request 63382: HIVE-17833: Publish split generation counters

2018-01-11 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63382/ --- (Updated Jan. 12, 2018, 1:08 a.m.) Review request for hive and Sergey

Re: Branch for "Per Table Write ID" implementation

2018-01-11 Thread Sankar Hariappan
Thanks Thejas, Eugene and Gopal for the feedback! Will go ahead and create the branch! Best regards Sankar On 11/01/18, 11:03 AM, "Eugene Koifman" wrote: >+1 > > >On 1/10/18, 8:18 PM, "Thejas Nair" wrote: > >+1 >Makes sense to